53760 2011-02-03 23:30:20 -0800 JSC fails to build with TOT Clang 2011-02-13 03:13:43 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 zwarich zwarich andersca ggaren zwarich oldest_to_newest 345388 0 zwarich 2011-02-03 23:30:20 -0800 Building JSC gives the following error (amongst others): CompileC /Volumes/Data/symroots/JavaScriptCore.build/Debug/JavaScriptCore.build/Objects-normal/x86_64/Arguments.o runtime/Arguments.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2 cd /Volumes/Data/WebKit-OpenSource/Source/JavaScriptCore setenv LANG en_US.US-ASCII /Developer/usr/bin/gcc-4.2 -x c++ -arch x86_64 -fmessage-length=0 -pipe -Wno-trigraphs -fno-exceptions -fno-rtti -fpascal-strings -fasm-blocks -O0 -Werror -Wmissing-prototypes -Wnon-virtual-dtor -Wnewline-eof -DHAVE_DTRACE=1 -DWEBKIT_VERSION_MIN_REQUIRED=WEBKIT_VERSION_LATEST -DHAVE_HEADER_DETECTION_H -fstrict-aliasing -fvisibility-inlines-hidden -fno-threadsafe-statics -mmacosx-version-min=10.6 -gdwarf-2 -I/Volumes/Data/symroots/JavaScriptCore.build/Debug/JavaScriptCore.build/JavaScriptCore.hmap -Wall -Wextra -Wcast-qual -Wchar-subscripts -Wextra-tokens -Wformat=2 -Winit-self -Wmissing-format-attribute -Wmissing-noreturn -Wpacked -Wpointer-arith -Wredundant-decls -Wundef -Wwrite-strings -F/Volumes/Data/symroots/Debug -I/Volumes/Data/symroots/Debug/include -I/Volumes/Data/symroots/Debug/DerivedSources/JavaScriptCore -I. -Iicu -I/Volumes/Data/symroots/JavaScriptCore.build/Debug/JavaScriptCore.build/DerivedSources/x86_64 -I/Volumes/Data/symroots/JavaScriptCore.build/Debug/JavaScriptCore.build/DerivedSources -include /var/folders/1t/1tFPZz2zFG8060hthPyLrk+++TI/-Caches-/com.apple.Xcode.501/SharedPrecompiledHeaders/JavaScriptCorePrefix-auvrpfrvjgzoucgqyebkkitidjdk/JavaScriptCorePrefix.h -c /Volumes/Data/WebKit-OpenSource/Source/JavaScriptCore/runtime/Arguments.cpp -o /Volumes/Data/symroots/JavaScriptCore.build/Debug/JavaScriptCore.build/Objects-normal/x86_64/Arguments.o In file included from /Volumes/Data/WebKit-OpenSource/Source/JavaScriptCore/runtime/Arguments.cpp:26: /Volumes/Data/WebKit-OpenSource/Source/JavaScriptCore/runtime/Arguments.h:110:22: error: 'JSC::Arguments::put' hides overloaded virtual function [-Woverloaded-virtual] virtual void put(ExecState*, unsigned propertyName, JSValue, PutPropertySlot&); ^ In file included from /Volumes/Data/WebKit-OpenSource/Source/JavaScriptCore/runtime/Arguments.cpp:26: In file included from /Volumes/Data/WebKit-OpenSource/Source/JavaScriptCore/runtime/Arguments.h:27: In file included from /Volumes/Data/WebKit-OpenSource/Source/JavaScriptCore/runtime/JSActivation.h:32: In file included from /Volumes/Data/WebKit-OpenSource/Source/JavaScriptCore/bytecode/CodeBlock.h:33: In file included from /Volumes/Data/WebKit-OpenSource/Source/JavaScriptCore/bytecode/EvalCodeCache.h:32: In file included from /Volumes/Data/WebKit-OpenSource/Source/JavaScriptCore/runtime/Executable.h:30: In file included from /Volumes/Data/WebKit-OpenSource/Source/JavaScriptCore/runtime/JSFunction.h:27: In file included from /Volumes/Data/WebKit-OpenSource/Source/JavaScriptCore/runtime/JSObjectWithGlobalObject.h:29: /Volumes/Data/WebKit-OpenSource/Source/JavaScriptCore/runtime/JSObject.h:113:22: note: hidden overloaded virtual function 'JSC::JSObject::put' declared here virtual void put(ExecState*, unsigned propertyName, JSValue value); ^ 1 error generated. We use the idiom of adding new variants of an overloaded virtual function in derived classes throughout JSC, mostly with put() and getOwnProperty() functions. Perhaps we should give the overloaded versions a different name so we can keep the otherwise useful warning enabled? 345390 1 ggaren 2011-02-03 23:42:10 -0800 I thin in most cases we can get rid of the custom overload. For example, in the arguments case, I don't think there's any reason to take a PutPropertySlot argument. 345397 2 zwarich 2011-02-04 00:19:43 -0800 I've got a patch that gets rid of the custom overloads in JSC. I just need to do more testing. 350366 3 82255 zwarich 2011-02-13 02:05:29 -0800 Created attachment 82255 Proposed patch 350374 4 zwarich 2011-02-13 02:24:22 -0800 Landed in r78428. I'm building a new Clang to see if nothing else has been introduced before closing this. 350377 5 zwarich 2011-02-13 03:13:43 -0800 Verified that JSC builds with Clang r125450. 82255 2011-02-13 02:05:29 -0800 2011-02-13 02:08:13 -0800 Proposed patch virtual.patch text/plain 6263 zwarich SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0FyZ3VtZW50cy5oCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0FyZ3VtZW50cy5oCShyZXZpc2lv biA3ODQyNikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0FyZ3VtZW50cy5oCSh3 b3JraW5nIGNvcHkpCkBAIC0xMDcsNyArMTA3LDcgQEAKICAgICAgICAgdmlydHVhbCBib29sIGdl dE93blByb3BlcnR5RGVzY3JpcHRvcihFeGVjU3RhdGUqLCBjb25zdCBJZGVudGlmaWVyJiwgUHJv cGVydHlEZXNjcmlwdG9yJik7CiAgICAgICAgIHZpcnR1YWwgdm9pZCBnZXRPd25Qcm9wZXJ0eU5h bWVzKEV4ZWNTdGF0ZSosIFByb3BlcnR5TmFtZUFycmF5JiwgRW51bWVyYXRpb25Nb2RlIG1vZGUg PSBFeGNsdWRlRG9udEVudW1Qcm9wZXJ0aWVzKTsKICAgICAgICAgdmlydHVhbCB2b2lkIHB1dChF eGVjU3RhdGUqLCBjb25zdCBJZGVudGlmaWVyJiBwcm9wZXJ0eU5hbWUsIEpTVmFsdWUsIFB1dFBy b3BlcnR5U2xvdCYpOwotICAgICAgICB2aXJ0dWFsIHZvaWQgcHV0KEV4ZWNTdGF0ZSosIHVuc2ln bmVkIHByb3BlcnR5TmFtZSwgSlNWYWx1ZSwgUHV0UHJvcGVydHlTbG90Jik7CisgICAgICAgIHZp cnR1YWwgdm9pZCBwdXQoRXhlY1N0YXRlKiwgdW5zaWduZWQgcHJvcGVydHlOYW1lLCBKU1ZhbHVl KTsKICAgICAgICAgdmlydHVhbCBib29sIGRlbGV0ZVByb3BlcnR5KEV4ZWNTdGF0ZSosIGNvbnN0 IElkZW50aWZpZXImIHByb3BlcnR5TmFtZSk7CiAgICAgICAgIHZpcnR1YWwgYm9vbCBkZWxldGVQ cm9wZXJ0eShFeGVjU3RhdGUqLCB1bnNpZ25lZCBwcm9wZXJ0eU5hbWUpOwogICAgICAgICB2b2lk IGNyZWF0ZVN0cmljdE1vZGVDYWxsZXJJZk5lY2Vzc2FyeShFeGVjU3RhdGUqKTsKSW5kZXg6IFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0FyZ3VtZW50cy5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQXJndW1lbnRzLmNwcAkocmV2aXNpb24gNzg0 MjYpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9Bcmd1bWVudHMuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC0yNTMsNyArMjUzLDcgQEAKICAgICBKU09iamVjdDo6Z2V0T3duUHJvcGVy dHlOYW1lcyhleGVjLCBwcm9wZXJ0eU5hbWVzLCBtb2RlKTsKIH0KIAotdm9pZCBBcmd1bWVudHM6 OnB1dChFeGVjU3RhdGUqIGV4ZWMsIHVuc2lnbmVkIGksIEpTVmFsdWUgdmFsdWUsIFB1dFByb3Bl cnR5U2xvdCYgc2xvdCkKK3ZvaWQgQXJndW1lbnRzOjpwdXQoRXhlY1N0YXRlKiBleGVjLCB1bnNp Z25lZCBpLCBKU1ZhbHVlIHZhbHVlKQogewogICAgIGlmIChpIDwgZC0+bnVtQXJndW1lbnRzICYm ICghZC0+ZGVsZXRlZEFyZ3VtZW50cyB8fCAhZC0+ZGVsZXRlZEFyZ3VtZW50c1tpXSkpIHsKICAg ICAgICAgaWYgKGkgPCBkLT5udW1QYXJhbWV0ZXJzKQpAQCAtMjYzLDYgKzI2Myw3IEBACiAgICAg ICAgIHJldHVybjsKICAgICB9CiAKKyAgICBQdXRQcm9wZXJ0eVNsb3Qgc2xvdDsKICAgICBKU09i amVjdDo6cHV0KGV4ZWMsIElkZW50aWZpZXIoZXhlYywgVVN0cmluZzo6bnVtYmVyKGkpKSwgdmFs dWUsIHNsb3QpOwogfQogCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTQ2FsbGJh Y2tPYmplY3RGdW5jdGlvbnMuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUv QVBJL0pTQ2FsbGJhY2tPYmplY3RGdW5jdGlvbnMuaAkocmV2aXNpb24gNzg0MjYpCisrKyBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTQ2FsbGJhY2tPYmplY3RGdW5jdGlvbnMuaAkod29ya2lu ZyBjb3B5KQpAQCAtMTY0LDEyICsxNjQsNiBAQAogfQogCiB0ZW1wbGF0ZSA8Y2xhc3MgQmFzZT4K LWJvb2wgSlNDYWxsYmFja09iamVjdDxCYXNlPjo6Z2V0T3duUHJvcGVydHlTbG90KEV4ZWNTdGF0 ZSogZXhlYywgdW5zaWduZWQgcHJvcGVydHlOYW1lLCBQcm9wZXJ0eVNsb3QmIHNsb3QpCi17Ci0g ICAgcmV0dXJuIGdldE93blByb3BlcnR5U2xvdChleGVjLCBJZGVudGlmaWVyOjpmcm9tKGV4ZWMs IHByb3BlcnR5TmFtZSksIHNsb3QpOwotfQotCi10ZW1wbGF0ZSA8Y2xhc3MgQmFzZT4KIGJvb2wg SlNDYWxsYmFja09iamVjdDxCYXNlPjo6Z2V0T3duUHJvcGVydHlEZXNjcmlwdG9yKEV4ZWNTdGF0 ZSogZXhlYywgY29uc3QgSWRlbnRpZmllciYgcHJvcGVydHlOYW1lLCBQcm9wZXJ0eURlc2NyaXB0 b3ImIGRlc2NyaXB0b3IpCiB7CiAgICAgUHJvcGVydHlTbG90IHNsb3Q7CkluZGV4OiBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQVBJL0pTQ2FsbGJhY2tPYmplY3QuaAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTQ2FsbGJhY2tPYmplY3QuaAkocmV2aXNpb24gNzg0MjYp CisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTQ2FsbGJhY2tPYmplY3QuaAkod29ya2lu ZyBjb3B5KQpAQCAtMTU1LDcgKzE1NSw2IEBACiAgICAgdmlydHVhbCBVU3RyaW5nIGNsYXNzTmFt ZSgpIGNvbnN0OwogCiAgICAgdmlydHVhbCBib29sIGdldE93blByb3BlcnR5U2xvdChFeGVjU3Rh dGUqLCBjb25zdCBJZGVudGlmaWVyJiwgUHJvcGVydHlTbG90Jik7Ci0gICAgdmlydHVhbCBib29s IGdldE93blByb3BlcnR5U2xvdChFeGVjU3RhdGUqLCB1bnNpZ25lZCwgUHJvcGVydHlTbG90Jik7 CiAgICAgdmlydHVhbCBib29sIGdldE93blByb3BlcnR5RGVzY3JpcHRvcihFeGVjU3RhdGUqLCBj b25zdCBJZGVudGlmaWVyJiwgUHJvcGVydHlEZXNjcmlwdG9yJik7CiAgICAgCiAgICAgdmlydHVh bCB2b2lkIHB1dChFeGVjU3RhdGUqLCBjb25zdCBJZGVudGlmaWVyJiwgSlNWYWx1ZSwgUHV0UHJv cGVydHlTbG90Jik7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc4NDI2 KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAt MSwzICsxLDIxIEBACisyMDExLTAyLTEzICBDYW1lcm9uIFp3YXJpY2ggIDx6d2FyaWNoQGFwcGxl LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBC dWcgNTM3NjAgLSBKU0MgZmFpbHMgdG8gYnVpbGQgd2l0aCBUT1QgQ2xhbmcKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUzNzYwCisKKyAgICAgICAgRml4 IC1Xb3ZlcmxvYWRlZC12aXJ0dWFsIHdhcm5pbmdzLiBUaGlzIGlzIGFsc28gYSA2JSBzcGVlZHVw IG9uIHRoZSB2OCByYXl0cmFjZQorICAgICAgICBiZW5jaG1hcms7IGl0IGlzIG5vdGhpbmctdG8t bm9pc2Ugb24gZXZlcnl0aGluZyBlbHNlLgorCisgICAgICAgICogQVBJL0pTQ2FsbGJhY2tPYmpl Y3QuaDogUmVtb3ZlIHBvaW50bGVzc2x5IG92ZXJsb2FkZWQgbWV0aG9kLgorICAgICAgICAqIEFQ SS9KU0NhbGxiYWNrT2JqZWN0RnVuY3Rpb25zLmg6IERpdHRvLgorICAgICAgICAqIHJ1bnRpbWUv QXJndW1lbnRzLmNwcDogCisgICAgICAgIChKU0M6OkFyZ3VtZW50czo6cHV0KTogQ2hhbmdlIHNp Z25hdHVyZSB0byBtYXRjaCB0aGUgYmFzZSBjbGFzcy4gVGhpcyBpbXBsZW1lbnRhdGlvbgorICAg ICAgICB3YXMgbm8gbG9uZ2VyIGJlaW5nIGNhbGxlZCBieSBhbnlvbmUuIFRoaXMgd2Fzbid0IG5v dGljZWQgYmVjYXVzZSBpdCBpcyBtZXJlbHkgYW4KKyAgICAgICAgb3B0aW1pemF0aW9uIG9mIHRo ZSBiYXNlIGNsYXNzJyBpbXBsZW1lbnRhdGlvbi4KKyAgICAgICAgKiBydW50aW1lL0FyZ3VtZW50 cy5oOiBEaXR0by4KKwogMjAxMS0wMi0xMiAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3Jn PgogCiAgICAgICAgIFJldmlld2VkIGJ5IE1hcmsgUm93ZS4KSW5kZXg6IFNvdXJjZS9KYXZhU2Ny aXB0R2x1ZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRHbHVlL0No YW5nZUxvZwkocmV2aXNpb24gNzg0MjYpCisrKyBTb3VyY2UvSmF2YVNjcmlwdEdsdWUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDItMTMgIENhbWVyb24g WndhcmljaCAgPHp3YXJpY2hAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEJ1ZyA1Mzc2MCAtIEpTQyBmYWlscyB0byBidWlsZCB3aXRo IFRPVCBDbGFuZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NTM3NjAKKworICAgICAgICBGaXggLVdvdmVybG9hZGVkLXZpcnR1YWwgd2FybmluZ3MuCisK KyAgICAgICAgKiBVc2VyT2JqZWN0SW1wLmNwcDoKKyAgICAgICAgKFVzZXJPYmplY3RJbXA6OnRv UHJpbWl0aXZlKTogVXNlIFByZWZlcnJlZFByaW1pdGl2ZVR5cGUgaW5zdGVhZCBvZiBKU1R5cGUg dG8KKyAgICAgICAgbWF0Y2ggdGhlIGJhc2UgY2xhc3MuCisgICAgICAgICogVXNlck9iamVjdElt cC5oOiAKKwogMjAxMS0wMi0wNiAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAog ICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0 R2x1ZS9Vc2VyT2JqZWN0SW1wLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdEds dWUvVXNlck9iamVjdEltcC5jcHAJKHJldmlzaW9uIDc4NDI2KQorKysgU291cmNlL0phdmFTY3Jp cHRHbHVlL1VzZXJPYmplY3RJbXAuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNjksNyArMTY5LDcg QEAKICAgICByZXR1cm4gZkpTVXNlck9iamVjdDsKIH0KIAotSlNWYWx1ZSBVc2VyT2JqZWN0SW1w Ojp0b1ByaW1pdGl2ZShFeGVjU3RhdGUgKmV4ZWMsIEpTVHlwZSkgY29uc3QKK0pTVmFsdWUgVXNl ck9iamVjdEltcDo6dG9QcmltaXRpdmUoRXhlY1N0YXRlICpleGVjLCBQcmVmZXJyZWRQcmltaXRp dmVUeXBlKSBjb25zdAogewogICAgIEpTVmFsdWUgcmVzdWx0ID0ganNVbmRlZmluZWQoKTsKICAg ICBKU1VzZXJPYmplY3QqIGpzT2JqUHRyID0gS0pTVmFsdWVUb0pTT2JqZWN0KHRvT2JqZWN0KGV4 ZWMpLCBleGVjKTsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0R2x1ZS9Vc2VyT2JqZWN0SW1wLmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRHbHVlL1VzZXJPYmplY3RJbXAuaAkocmV2 aXNpb24gNzg0MjYpCisrKyBTb3VyY2UvSmF2YVNjcmlwdEdsdWUvVXNlck9iamVjdEltcC5oCSh3 b3JraW5nIGNvcHkpCkBAIC01MCw3ICs1MCw3IEBACiAgICAgdmlydHVhbCBib29sIGdldE93blBy b3BlcnR5U2xvdChFeGVjU3RhdGUgKiwgY29uc3QgSWRlbnRpZmllciYsIFByb3BlcnR5U2xvdCYp OwogICAgIHZpcnR1YWwgdm9pZCBwdXQoRXhlY1N0YXRlICpleGVjLCBjb25zdCBJZGVudGlmaWVy ICZwcm9wZXJ0eU5hbWUsIEpTVmFsdWUgdmFsdWUsIFB1dFByb3BlcnR5U2xvdCYpOwogCi0gICAg SlNWYWx1ZSB0b1ByaW1pdGl2ZShFeGVjU3RhdGUqLCBKU1R5cGUgcHJlZmVycmVkVHlwZSA9IFVu c3BlY2lmaWVkVHlwZSkgY29uc3Q7CisgICAgSlNWYWx1ZSB0b1ByaW1pdGl2ZShFeGVjU3RhdGUq LCBQcmVmZXJyZWRQcmltaXRpdmVUeXBlIHByZWZlcnJlZFR5cGUgPSBOb1ByZWZlcmVuY2UpIGNv bnN0OwogICAgIHZpcnR1YWwgYm9vbCB0b0Jvb2xlYW4oRXhlY1N0YXRlICpleGVjKSBjb25zdDsK ICAgICB2aXJ0dWFsIGRvdWJsZSB0b051bWJlcihFeGVjU3RhdGUgKmV4ZWMpIGNvbnN0OwogICAg IHZpcnR1YWwgVVN0cmluZyB0b1N0cmluZyhFeGVjU3RhdGUgKmV4ZWMpIGNvbnN0Owo=