<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>53759</bug_id>
          
          <creation_ts>2011-02-03 23:18:44 -0800</creation_ts>
          <short_desc>Changed MarkedSpace to delegate grow/shrink decisions to Heap</short_desc>
          <delta_ts>2025-12-02 18:57:35 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Geoffrey Garen">ggaren</reporter>
          <assigned_to name="Geoffrey Garen">ggaren</assigned_to>
          <cc>abarth</cc>
    
    <cc>eric</cc>
    
    <cc>k_monsen</cc>
    
    <cc>loislo</cc>
    
    <cc>webkit.review.bot</cc>
    
    <cc>zimmermann</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>345382</commentid>
    <comment_count>0</comment_count>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2011-02-03 23:18:44 -0800</bug_when>
    <thetext>Changed MarkedSpace to delegate grow/shrink decisions to Heap</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>345384</commentid>
    <comment_count>1</comment_count>
      <attachid>81193</attachid>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2011-02-03 23:27:09 -0800</bug_when>
    <thetext>Created attachment 81193
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>345389</commentid>
    <comment_count>2</comment_count>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2011-02-03 23:41:40 -0800</bug_when>
    <thetext>Committed r77612: &lt;http://trac.webkit.org/changeset/77612&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>345425</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-02-04 02:43:36 -0800</bug_when>
    <thetext>http://trac.webkit.org/changeset/77612 might have broken SnowLeopard Intel Release (Tests)
The following tests are not passing:
accessibility/aria-activedescendant-crash.html
accessibility/aria-checkbox-checked.html
accessibility/aria-checkbox-text.html
accessibility/aria-combobox.html
accessibility/aria-controls-with-tabs.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>345442</commentid>
    <comment_count>4</comment_count>
    <who name="Nikolas Zimmermann">zimmermann</who>
    <bug_when>2011-02-04 04:59:22 -0800</bug_when>
    <thetext>Reopening bug. I see sporadic assertions on both 10.5 and 10.6. An example:

ASSERTION FAILED: m_heap.usedBlocks &gt; neededBlocks
(/Users/nikolaszimmermann/Coding/WebKit/Source/JavaScriptCore/runtime/MarkedSpace.cpp:174 void JSC::MarkedSpace::shrinkBlocks(size_t))
 -&gt; JSC::MarkedSpace::shrinkBlocks(unsigned long)
 -&gt; JSC::MarkedSpace::sweep()
 -&gt; JSC::Heap::reset(JSC::Heap::SweepToggle)
 -&gt; JSC::Heap::collectAllGarbage()
 -&gt; JSC::DefaultGCActivityCallbackPlatformData::trigger(__CFRunLoopTimer*, void*)
 -&gt; __CFRunLoopRun
 -&gt; CFRunLoopRunSpecific
 -&gt; RunCurrentEventLoopInMode
 -&gt; ReceiveNextEventCommon
 -&gt; BlockUntilNextEventMatchingListInMode
 -&gt; _DPSNextEvent
 -&gt; -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:]
 -&gt; 0x1000162f4
 -&gt; -[NSApplication run]
 -&gt; NSApplicationMain
 -&gt; 0x10000a1c0

SL bot crashes all tests as well.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>345443</commentid>
    <comment_count>5</comment_count>
    <who name="Ilya Tikhonovsky">loislo</who>
    <bug_when>2011-02-04 05:04:28 -0800</bug_when>
    <thetext>rolled out 


Committed r77619
	M	Source/JavaScriptCore/runtime/MarkedSpace.cpp
	M	Source/JavaScriptCore/runtime/Heap.cpp
	M	Source/JavaScriptCore/runtime/Heap.h
	M	Source/JavaScriptCore/runtime/MarkedSpace.h
	M	Source/JavaScriptCore/ChangeLog
r77619 = c436d330dbed26b8ba04af3f59c77705e7cf3d42 (refs/remotes/trunk)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>345841</commentid>
    <comment_count>6</comment_count>
      <attachid>81301</attachid>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2011-02-04 15:11:48 -0800</bug_when>
    <thetext>Created attachment 81301
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>345842</commentid>
    <comment_count>7</comment_count>
      <attachid>81301</attachid>
    <who name="Oliver Hunt">oliver</who>
    <bug_when>2011-02-04 15:12:40 -0800</bug_when>
    <thetext>Comment on attachment 81301
Patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>345889</commentid>
    <comment_count>8</comment_count>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2011-02-04 16:20:21 -0800</bug_when>
    <thetext>Committed r77699: &lt;http://trac.webkit.org/changeset/77699&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2162797</commentid>
    <comment_count>9</comment_count>
    <who name="Kristian Monsen">k_monsen</who>
    <bug_when>2025-12-02 18:57:35 -0800</bug_when>
    <thetext>*** Bug 301900 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>81193</attachid>
            <date>2011-02-03 23:27:09 -0800</date>
            <delta_ts>2011-02-04 15:11:45 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-53759-20110203232708.patch</filename>
            <type>text/plain</type>
            <size>5618</size>
            <attacher name="Geoffrey Garen">ggaren</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gNzc2MTApCisrKyBTb3VyY2Uv
SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMzEgQEAK
KzIwMTEtMDItMDMgIEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KKworICAgICAg
ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDaGFuZ2VkIE1hcmtlZFNw
YWNlIHRvIGRlbGVnYXRlIGdyb3cvc2hyaW5rIGRlY2lzaW9ucyB0byBIZWFwCisgICAgICAgIGh0
dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01Mzc1OQorICAgICAgICAKKyAg
ICAgICAgU3VuU3BpZGVyIHJlcG9ydHMgbm8gY2hhbmdlLgorICAgICAgICAKKyAgICAgICAgKiBy
dW50aW1lL0hlYXAuY3BwOgorICAgICAgICAoSlNDOjpIZWFwOjpIZWFwKToKKyAgICAgICAgKEpT
Qzo6SGVhcDo6cmVzZXQpOgorICAgICAgICAqIHJ1bnRpbWUvSGVhcC5oOiBSZW9yZ2FuaXplZCBh
IGZldyBkYXRhIG1lbWJlcnMgZm9yIGJldHRlciBjYWNoZSBsb2NhbGl0eS4KKyAgICAgICAgQWRk
ZWQgYSBncm93IHBvbGljeS4KKyAgICAgICAgCisgICAgICAgICogcnVudGltZS9NYXJrZWRTcGFj
ZS5jcHA6CisgICAgICAgIChKU0M6Ok1hcmtlZFNwYWNlOjphbGxvY2F0ZSk6CisgICAgICAgIChK
U0M6Ok1hcmtlZFNwYWNlOjpzd2VlcCk6CisgICAgICAgIChKU0M6Ok1hcmtlZFNwYWNlOjpyZXNl
dCk6IERvbid0IHNocmluayBhdXRvbWF0aWNhbGx5LiBJbnN0ZWFkLCB3YWl0IGZvcgorICAgICAg
ICB0aGUgaGVhcCB0byBtYWtlIGFuIGV4cGxpY2l0IHN3ZWVwIGNhbGwuCisKKyAgICAgICAgKiBy
dW50aW1lL01hcmtlZFNwYWNlLmg6CisgICAgICAgIChKU0M6Ok1hcmtlZFNwYWNlOjpoaWdoV2F0
ZXJNYXJrKToKKyAgICAgICAgKEpTQzo6TWFya2VkU3BhY2U6OnNldEhpZ2hXYXRlck1hcmspOiBV
c2UgYSB3YXRlcm1hcmsgdG8gZGV0ZXJtaW5lIGhvdworICAgICAgICBtYW55IGJ5dGVzIHRvIGFs
bG9jYXRlIGJlZm9yZSBmYWlsaW5nIGFuZCBnaXZpbmcgdGhlIGhlYXAgYW4gb3Bwb3J0dW5pdHkK
KyAgICAgICAgdG8gY29sbGVjdCBnYXJiYWdlLiBUaGlzIGFsc28gbWVhbnMgdGhhdCB3ZSBhbGxv
Y2F0ZSBibG9ja3Mgb24gZGVtYW5kLAorICAgICAgICBpbnN0ZWFkIG9mIGFoZWFkIG9mIHRpbWUu
CisKIDIwMTEtMDItMDMgIEphbWVzIEtvemlhbnNraSAgPGtvekBjaHJvbWl1bS5vcmc+CiAKICAg
ICAgICAgUmV2aWV3ZWQgYnkgRGltaXRyaSBHbGF6a292LgpJbmRleDogU291cmNlL0phdmFTY3Jp
cHRDb3JlL3J1bnRpbWUvSGVhcC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRD
b3JlL3J1bnRpbWUvSGVhcC5jcHAJKHJldmlzaW9uIDc3NTA5KQorKysgU291cmNlL0phdmFTY3Jp
cHRDb3JlL3J1bnRpbWUvSGVhcC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMyLDE0ICszMiwxOSBA
QAogI2luY2x1ZGUgIkpTTG9jay5oIgogI2luY2x1ZGUgIkpTT05PYmplY3QuaCIKICNpbmNsdWRl
ICJUcmFjaW5nLmgiCisjaW5jbHVkZSA8YWxnb3JpdGhtPgogCiAjZGVmaW5lIENPTExFQ1RfT05f
RVZFUllfQUxMT0NBVElPTiAwCiAKK3VzaW5nIG5hbWVzcGFjZSBzdGQ7CisKIG5hbWVzcGFjZSBK
U0MgewogCitjb25zdCBzaXplX3QgbWluQnl0ZXNQZXJDeWNsZSA9IDUxMiAqIDEwMjQ7CisKIEhl
YXA6OkhlYXAoSlNHbG9iYWxEYXRhKiBnbG9iYWxEYXRhKQotICAgIDogbV9tYXJrZWRTcGFjZShn
bG9iYWxEYXRhKQotICAgICwgbV9vcGVyYXRpb25JblByb2dyZXNzKE5vT3BlcmF0aW9uKQorICAg
IDogbV9vcGVyYXRpb25JblByb2dyZXNzKE5vT3BlcmF0aW9uKQorICAgICwgbV9tYXJrZWRTcGFj
ZShnbG9iYWxEYXRhKQogICAgICwgbV9tYXJrTGlzdFNldCgwKQogICAgICwgbV9hY3Rpdml0eUNh
bGxiYWNrKERlZmF1bHRHQ0FjdGl2aXR5Q2FsbGJhY2s6OmNyZWF0ZSh0aGlzKSkKICAgICAsIG1f
Z2xvYmFsRGF0YShnbG9iYWxEYXRhKQpAQCAtMzgxLDYgKzM4NiwxMCBAQCB2b2lkIEhlYXA6OnJl
c2V0KFN3ZWVwVG9nZ2xlIHN3ZWVwVG9nZ2xlCiAgICAgaWYgKHN3ZWVwVG9nZ2xlID09IERvU3dl
ZXApCiAgICAgICAgIG1fbWFya2VkU3BhY2Uuc3dlZXAoKTsKIAorICAgIHNpemVfdCB1c2VkQ2Vs
bENvdW50ID0gbV9tYXJrZWRTcGFjZS5tYXJrZWRDZWxscygpOworICAgIHNpemVfdCBwcm9wb3J0
aW9uYWxCeXRlcyA9IHVzZWRDZWxsQ291bnQgKiAxLjUgKiBIZWFwQ29uc3RhbnRzOjpjZWxsU2l6
ZTsKKyAgICBtX21hcmtlZFNwYWNlLnNldEhpZ2hXYXRlck1hcmsobWF4KHByb3BvcnRpb25hbEJ5
dGVzLCBtaW5CeXRlc1BlckN5Y2xlKSk7CisKICAgICBKQVZBU0NSSVBUQ09SRV9HQ19FTkQoKTsK
IAogICAgICgqbV9hY3Rpdml0eUNhbGxiYWNrKSgpOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRD
b3JlL3J1bnRpbWUvSGVhcC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9y
dW50aW1lL0hlYXAuaAkocmV2aXNpb24gNzc1MDkpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUv
cnVudGltZS9IZWFwLmgJKHdvcmtpbmcgY29weSkKQEAgLTEyMiw4ICsxMjIsOCBAQCBuYW1lc3Bh
Y2UgSlNDIHsKIAogICAgICAgICBSZWdpc3RlckZpbGUmIHJlZ2lzdGVyRmlsZSgpOwogCi0gICAg
ICAgIE1hcmtlZFNwYWNlIG1fbWFya2VkU3BhY2U7CiAgICAgICAgIE9wZXJhdGlvbkluUHJvZ3Jl
c3MgbV9vcGVyYXRpb25JblByb2dyZXNzOworICAgICAgICBNYXJrZWRTcGFjZSBtX21hcmtlZFNw
YWNlOwogCiAgICAgICAgIFByb3RlY3RDb3VudFNldCBtX3Byb3RlY3RlZFZhbHVlczsKICAgICAg
ICAgVmVjdG9yPFBhZ2VBbGxvY2F0aW9uQWxpZ25lZD4gbV93ZWFrR0NIYW5kbGVQb29sczsKSW5k
ZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL01hcmtlZFNwYWNlLmNwcAo9PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9NYXJrZWRTcGFjZS5jcHAJKHJl
dmlzaW9uIDc3NTU3KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvTWFya2VkU3Bh
Y2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMzgsOCArMTM4LDEyIEBAIHZvaWQqIE1hcmtlZFNw
YWNlOjphbGxvY2F0ZShzaXplX3QgcykKICAgICAgICAgICAgIG1faGVhcC5uZXh0Q2VsbCA9IGJs
b2NrLT5tYXJrZWQubmV4dFBvc3NpYmx5VW5zZXQobV9oZWFwLm5leHRDZWxsKTsKICAgICAgICAg
fSB3aGlsZSAobV9oZWFwLm5leHRDZWxsICE9IEhlYXBDb25zdGFudHM6OmNlbGxzUGVyQmxvY2sp
OwogICAgICAgICBtX2hlYXAubmV4dENlbGwgPSAwOworICAgICAgICBtX2hlYXAud2F0ZXJNYXJr
ICs9IEJMT0NLX1NJWkU7CiAgICAgfSB3aGlsZSAoKyttX2hlYXAubmV4dEJsb2NrICE9IG1faGVh
cC51c2VkQmxvY2tzKTsKLSAgICAKKworICAgIGlmIChtX2hlYXAud2F0ZXJNYXJrIDwgbV9oZWFw
LmhpZ2hXYXRlck1hcmspCisgICAgICAgIHJldHVybiAmYWxsb2NhdGVCbG9jaygpLT5jZWxsc1tt
X2hlYXAubmV4dENlbGwrK107CisKICAgICByZXR1cm4gMDsKIH0KIApAQCAtMjcwLDYgKzI3NCw4
IEBAIHZvaWQgTWFya2VkU3BhY2U6OnN3ZWVwKCkKICAgICAgICAgbmV3IChjZWxsKSBKU0NlbGwo
ZHVtbXlNYXJrYWJsZUNlbGxTdHJ1Y3R1cmUpOwogI2VuZGlmCiAgICAgfQorICAgIAorICAgIHNo
cmlua0Jsb2NrcygwKTsKIH0KIAogc2l6ZV90IE1hcmtlZFNwYWNlOjpvYmplY3RDb3VudCgpIGNv
bnN0CkBAIC0yOTQsMTAgKzMwMCwxMCBAQCB2b2lkIE1hcmtlZFNwYWNlOjpyZXNldCgpCiB7CiAg
ICAgbV9oZWFwLm5leHRDZWxsID0gMDsKICAgICBtX2hlYXAubmV4dEJsb2NrID0gMDsKKyAgICBt
X2hlYXAud2F0ZXJNYXJrID0gMDsKICNpZiBFTkFCTEUoSlNDX1pPTUJJRVMpCiAgICAgc3dlZXAo
KTsKICNlbmRpZgotICAgIHJlc2l6ZUJsb2NrcygpOwogfQogCiBMaXZlT2JqZWN0SXRlcmF0b3Ig
TWFya2VkU3BhY2U6OnByaW1hcnlIZWFwQmVnaW4oKQpJbmRleDogU291cmNlL0phdmFTY3JpcHRD
b3JlL3J1bnRpbWUvTWFya2VkU3BhY2UuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlw
dENvcmUvcnVudGltZS9NYXJrZWRTcGFjZS5oCShyZXZpc2lvbiA3NzUxOSkKKysrIFNvdXJjZS9K
YXZhU2NyaXB0Q29yZS9ydW50aW1lL01hcmtlZFNwYWNlLmgJKHdvcmtpbmcgY29weSkKQEAgLTQ3
LDYgKzQ3LDkgQEAgbmFtZXNwYWNlIEpTQyB7CiAgICAgICAgIAogICAgICAgICBzaXplX3QgbnVt
QmxvY2tzOwogICAgICAgICBzaXplX3QgdXNlZEJsb2NrczsKKyAgICAgICAgCisgICAgICAgIHNp
emVfdCB3YXRlck1hcms7CisgICAgICAgIHNpemVfdCBoaWdoV2F0ZXJNYXJrOwogCiAgICAgICAg
IE1hcmtlZEJsb2NrKiBjb2xsZWN0b3JCbG9jayhzaXplX3QgaW5kZXgpIGNvbnN0CiAgICAgICAg
IHsKQEAgLTY4LDEyICs3MSwxNiBAQCBuYW1lc3BhY2UgSlNDIHsKIAogICAgICAgICBKU0dsb2Jh
bERhdGEqIGdsb2JhbERhdGEoKSB7IHJldHVybiBtX2dsb2JhbERhdGE7IH0KIAorICAgICAgICBz
aXplX3QgaGlnaFdhdGVyTWFyaygpIHsgcmV0dXJuIG1faGVhcC5oaWdoV2F0ZXJNYXJrOyB9Cisg
ICAgICAgIHZvaWQgc2V0SGlnaFdhdGVyTWFyayhzaXplX3QgaGlnaFdhdGVyTWFyaykgeyBtX2hl
YXAuaGlnaFdhdGVyTWFyayA9IGhpZ2hXYXRlck1hcms7IH0KKwogICAgICAgICB2b2lkKiBhbGxv
Y2F0ZShzaXplX3QpOwogCiAgICAgICAgIHZvaWQgY2xlYXJNYXJrQml0cygpOwogICAgICAgICB2
b2lkIG1hcmtSb290cygpOwogICAgICAgICB2b2lkIHJlc2V0KCk7CiAgICAgICAgIHZvaWQgc3dl
ZXAoKTsKKyAgICAgICAgc2l6ZV90IG1hcmtlZENlbGxzKHNpemVfdCBzdGFydEJsb2NrID0gMCwg
c2l6ZV90IHN0YXJ0Q2VsbCA9IDApIGNvbnN0OwogCiAgICAgICAgIHNpemVfdCBzaXplKCkgY29u
c3Q7CiAgICAgICAgIHNpemVfdCBjYXBhY2l0eSgpIGNvbnN0OwpAQCAtOTQsNyArMTAxLDYgQEAg
bmFtZXNwYWNlIEpTQyB7CiAgICAgICAgIHZvaWQgc2hyaW5rQmxvY2tzKHNpemVfdCBuZWVkZWRC
bG9ja3MpOwogCiAgICAgICAgIHZvaWQgY2xlYXJNYXJrQml0cyhNYXJrZWRCbG9jayopOwotICAg
ICAgICBzaXplX3QgbWFya2VkQ2VsbHMoc2l6ZV90IHN0YXJ0QmxvY2sgPSAwLCBzaXplX3Qgc3Rh
cnRDZWxsID0gMCkgY29uc3Q7CiAKICAgICAgICAgQ29sbGVjdG9ySGVhcCBtX2hlYXA7CiAgICAg
ICAgIEpTR2xvYmFsRGF0YSogbV9nbG9iYWxEYXRhOwo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>81301</attachid>
            <date>2011-02-04 15:11:48 -0800</date>
            <delta_ts>2011-02-04 15:12:40 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-53759-20110204151147.patch</filename>
            <type>text/plain</type>
            <size>5434</size>
            <attacher name="Geoffrey Garen">ggaren</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gNzc2ODApCisrKyBTb3VyY2Uv
SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjcgQEAK
KzIwMTEtMDItMDQgIEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KKworICAgICAg
ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSb2xsZWQgYmFjayBpbiBy
Nzc2MTIgd2l0aCBBU1NFUlQvY3Jhc2ggZml4ZWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr
aXQub3JnL3Nob3dfYnVnLmNnaT9pZD01Mzc1OQorICAgICAgICAKKyAgICAgICAgRG9uJ3Qgc2hy
aW5rIHRoZSBoZWFwIHRvIDAgdW5jb25kaXRpb25hbGx5LiBJbnN0ZWFkLCBzaHJpbmsgdG8gMSBp
ZgorICAgICAgICBuZWNlc3NhcnkuIEZvciBub3csIHRoZSBoZWFwIGFzc3VtZXMgdGhhdCBpdCBh
bHdheXMgaGFzIGF0IGxlYXN0IG9uZQorICAgICAgICBibG9jayBsaXZlLgorCisgICAgICAgICog
cnVudGltZS9IZWFwLmNwcDoKKyAgICAgICAgKEpTQzo6SGVhcDo6SGVhcCk6CisgICAgICAgIChK
U0M6OkhlYXA6OnJlc2V0KToKKyAgICAgICAgKiBydW50aW1lL0hlYXAuaDoKKyAgICAgICAgKiBy
dW50aW1lL01hcmtlZFNwYWNlLmNwcDoKKyAgICAgICAgKEpTQzo6TWFya2VkU3BhY2U6OmFsbG9j
YXRlKToKKyAgICAgICAgKEpTQzo6TWFya2VkU3BhY2U6OnNocmlua0Jsb2Nrcyk6CisgICAgICAg
IChKU0M6Ok1hcmtlZFNwYWNlOjpzd2VlcCk6CisgICAgICAgIChKU0M6Ok1hcmtlZFNwYWNlOjpy
ZXNldCk6CisgICAgICAgICogcnVudGltZS9NYXJrZWRTcGFjZS5oOgorICAgICAgICAoSlNDOjpN
YXJrZWRTcGFjZTo6aGlnaFdhdGVyTWFyayk6CisgICAgICAgIChKU0M6Ok1hcmtlZFNwYWNlOjpz
ZXRIaWdoV2F0ZXJNYXJrKToKKwogMjAxMS0wMi0wNCAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJA
YXBwbGUuY29tPgogCiAgICAgICAgIEJVSUxEIEZJWDogUkVBTExZIHJlbW92ZSB0aGUgbGFzdCB2
ZXN0aWdlcyBvZiBKU1ZBTFVFMzIhCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGlt
ZS9IZWFwLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9I
ZWFwLmNwcAkocmV2aXNpb24gNzc2ODApCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGlt
ZS9IZWFwLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzIsMTQgKzMyLDE5IEBACiAjaW5jbHVkZSAi
SlNMb2NrLmgiCiAjaW5jbHVkZSAiSlNPTk9iamVjdC5oIgogI2luY2x1ZGUgIlRyYWNpbmcuaCIK
KyNpbmNsdWRlIDxhbGdvcml0aG0+CiAKICNkZWZpbmUgQ09MTEVDVF9PTl9FVkVSWV9BTExPQ0FU
SU9OIDAKIAordXNpbmcgbmFtZXNwYWNlIHN0ZDsKKwogbmFtZXNwYWNlIEpTQyB7CiAKK2NvbnN0
IHNpemVfdCBtaW5CeXRlc1BlckN5Y2xlID0gNTEyICogMTAyNDsKKwogSGVhcDo6SGVhcChKU0ds
b2JhbERhdGEqIGdsb2JhbERhdGEpCi0gICAgOiBtX21hcmtlZFNwYWNlKGdsb2JhbERhdGEpCi0g
ICAgLCBtX29wZXJhdGlvbkluUHJvZ3Jlc3MoTm9PcGVyYXRpb24pCisgICAgOiBtX29wZXJhdGlv
bkluUHJvZ3Jlc3MoTm9PcGVyYXRpb24pCisgICAgLCBtX21hcmtlZFNwYWNlKGdsb2JhbERhdGEp
CiAgICAgLCBtX21hcmtMaXN0U2V0KDApCiAgICAgLCBtX2FjdGl2aXR5Q2FsbGJhY2soRGVmYXVs
dEdDQWN0aXZpdHlDYWxsYmFjazo6Y3JlYXRlKHRoaXMpKQogICAgICwgbV9nbG9iYWxEYXRhKGds
b2JhbERhdGEpCkBAIC0zODEsNiArMzg2LDEwIEBAIHZvaWQgSGVhcDo6cmVzZXQoU3dlZXBUb2dn
bGUgc3dlZXBUb2dnbGUKICAgICBpZiAoc3dlZXBUb2dnbGUgPT0gRG9Td2VlcCkKICAgICAgICAg
bV9tYXJrZWRTcGFjZS5zd2VlcCgpOwogCisgICAgc2l6ZV90IHVzZWRDZWxsQ291bnQgPSBtX21h
cmtlZFNwYWNlLm1hcmtlZENlbGxzKCk7CisgICAgc2l6ZV90IHByb3BvcnRpb25hbEJ5dGVzID0g
c3RhdGljX2Nhc3Q8c2l6ZV90Pih1c2VkQ2VsbENvdW50ICogMS41ICogSGVhcENvbnN0YW50czo6
Y2VsbFNpemUpOworICAgIG1fbWFya2VkU3BhY2Uuc2V0SGlnaFdhdGVyTWFyayhtYXgocHJvcG9y
dGlvbmFsQnl0ZXMsIG1pbkJ5dGVzUGVyQ3ljbGUpKTsKKwogICAgIEpBVkFTQ1JJUFRDT1JFX0dD
X0VORCgpOwogCiAgICAgKCptX2FjdGl2aXR5Q2FsbGJhY2spKCk7CkluZGV4OiBTb3VyY2UvSmF2
YVNjcmlwdENvcmUvcnVudGltZS9IZWFwLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3Jp
cHRDb3JlL3J1bnRpbWUvSGVhcC5oCShyZXZpc2lvbiA3NzY4MCkKKysrIFNvdXJjZS9KYXZhU2Ny
aXB0Q29yZS9ydW50aW1lL0hlYXAuaAkod29ya2luZyBjb3B5KQpAQCAtMTIyLDggKzEyMiw4IEBA
IG5hbWVzcGFjZSBKU0MgewogCiAgICAgICAgIFJlZ2lzdGVyRmlsZSYgcmVnaXN0ZXJGaWxlKCk7
CiAKLSAgICAgICAgTWFya2VkU3BhY2UgbV9tYXJrZWRTcGFjZTsKICAgICAgICAgT3BlcmF0aW9u
SW5Qcm9ncmVzcyBtX29wZXJhdGlvbkluUHJvZ3Jlc3M7CisgICAgICAgIE1hcmtlZFNwYWNlIG1f
bWFya2VkU3BhY2U7CiAKICAgICAgICAgUHJvdGVjdENvdW50U2V0IG1fcHJvdGVjdGVkVmFsdWVz
OwogICAgICAgICBWZWN0b3I8UGFnZUFsbG9jYXRpb25BbGlnbmVkPiBtX3dlYWtHQ0hhbmRsZVBv
b2xzOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvTWFya2VkU3BhY2UuY3Bw
Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL01hcmtlZFNwYWNl
LmNwcAkocmV2aXNpb24gNzc2ODApCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9N
YXJrZWRTcGFjZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEzOCw4ICsxMzgsMTIgQEAgdm9pZCog
TWFya2VkU3BhY2U6OmFsbG9jYXRlKHNpemVfdCBzKQogICAgICAgICAgICAgbV9oZWFwLm5leHRD
ZWxsID0gYmxvY2stPm1hcmtlZC5uZXh0UG9zc2libHlVbnNldChtX2hlYXAubmV4dENlbGwpOwog
ICAgICAgICB9IHdoaWxlIChtX2hlYXAubmV4dENlbGwgIT0gSGVhcENvbnN0YW50czo6Y2VsbHNQ
ZXJCbG9jayk7CiAgICAgICAgIG1faGVhcC5uZXh0Q2VsbCA9IDA7CisgICAgICAgIG1faGVhcC53
YXRlck1hcmsgKz0gQkxPQ0tfU0laRTsKICAgICB9IHdoaWxlICgrK21faGVhcC5uZXh0QmxvY2sg
IT0gbV9oZWFwLnVzZWRCbG9ja3MpOwotICAgIAorCisgICAgaWYgKG1faGVhcC53YXRlck1hcmsg
PCBtX2hlYXAuaGlnaFdhdGVyTWFyaykKKyAgICAgICAgcmV0dXJuICZhbGxvY2F0ZUJsb2NrKCkt
PmNlbGxzW21faGVhcC5uZXh0Q2VsbCsrXTsKKwogICAgIHJldHVybiAwOwogfQogCkBAIC0yNzAs
NiArMjc0LDkgQEAgdm9pZCBNYXJrZWRTcGFjZTo6c3dlZXAoKQogICAgICAgICBuZXcgKGNlbGwp
IEpTQ2VsbChkdW1teU1hcmthYmxlQ2VsbFN0cnVjdHVyZSk7CiAjZW5kaWYKICAgICB9CisgICAg
CisgICAgaWYgKG1faGVhcC51c2VkQmxvY2tzID4gMSkKKyAgICAgICAgc2hyaW5rQmxvY2tzKDEp
OwogfQogCiBzaXplX3QgTWFya2VkU3BhY2U6Om9iamVjdENvdW50KCkgY29uc3QKQEAgLTI5NCwx
MCArMzAxLDEwIEBAIHZvaWQgTWFya2VkU3BhY2U6OnJlc2V0KCkKIHsKICAgICBtX2hlYXAubmV4
dENlbGwgPSAwOwogICAgIG1faGVhcC5uZXh0QmxvY2sgPSAwOworICAgIG1faGVhcC53YXRlck1h
cmsgPSAwOwogI2lmIEVOQUJMRShKU0NfWk9NQklFUykKICAgICBzd2VlcCgpOwogI2VuZGlmCi0g
ICAgcmVzaXplQmxvY2tzKCk7CiB9CiAKIExpdmVPYmplY3RJdGVyYXRvciBNYXJrZWRTcGFjZTo6
cHJpbWFyeUhlYXBCZWdpbigpCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9N
YXJrZWRTcGFjZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l
L01hcmtlZFNwYWNlLmgJKHJldmlzaW9uIDc3NjgwKQorKysgU291cmNlL0phdmFTY3JpcHRDb3Jl
L3J1bnRpbWUvTWFya2VkU3BhY2UuaAkod29ya2luZyBjb3B5KQpAQCAtNDcsNiArNDcsOSBAQCBu
YW1lc3BhY2UgSlNDIHsKICAgICAgICAgCiAgICAgICAgIHNpemVfdCBudW1CbG9ja3M7CiAgICAg
ICAgIHNpemVfdCB1c2VkQmxvY2tzOworICAgICAgICAKKyAgICAgICAgc2l6ZV90IHdhdGVyTWFy
azsKKyAgICAgICAgc2l6ZV90IGhpZ2hXYXRlck1hcms7CiAKICAgICAgICAgTWFya2VkQmxvY2sq
IGNvbGxlY3RvckJsb2NrKHNpemVfdCBpbmRleCkgY29uc3QKICAgICAgICAgewpAQCAtNjgsMTIg
KzcxLDE2IEBAIG5hbWVzcGFjZSBKU0MgewogCiAgICAgICAgIEpTR2xvYmFsRGF0YSogZ2xvYmFs
RGF0YSgpIHsgcmV0dXJuIG1fZ2xvYmFsRGF0YTsgfQogCisgICAgICAgIHNpemVfdCBoaWdoV2F0
ZXJNYXJrKCkgeyByZXR1cm4gbV9oZWFwLmhpZ2hXYXRlck1hcms7IH0KKyAgICAgICAgdm9pZCBz
ZXRIaWdoV2F0ZXJNYXJrKHNpemVfdCBoaWdoV2F0ZXJNYXJrKSB7IG1faGVhcC5oaWdoV2F0ZXJN
YXJrID0gaGlnaFdhdGVyTWFyazsgfQorCiAgICAgICAgIHZvaWQqIGFsbG9jYXRlKHNpemVfdCk7
CiAKICAgICAgICAgdm9pZCBjbGVhck1hcmtCaXRzKCk7CiAgICAgICAgIHZvaWQgbWFya1Jvb3Rz
KCk7CiAgICAgICAgIHZvaWQgcmVzZXQoKTsKICAgICAgICAgdm9pZCBzd2VlcCgpOworICAgICAg
ICBzaXplX3QgbWFya2VkQ2VsbHMoc2l6ZV90IHN0YXJ0QmxvY2sgPSAwLCBzaXplX3Qgc3RhcnRD
ZWxsID0gMCkgY29uc3Q7CiAKICAgICAgICAgc2l6ZV90IHNpemUoKSBjb25zdDsKICAgICAgICAg
c2l6ZV90IGNhcGFjaXR5KCkgY29uc3Q7CkBAIC05NCw3ICsxMDEsNiBAQCBuYW1lc3BhY2UgSlND
IHsKICAgICAgICAgdm9pZCBzaHJpbmtCbG9ja3Moc2l6ZV90IG5lZWRlZEJsb2Nrcyk7CiAKICAg
ICAgICAgdm9pZCBjbGVhck1hcmtCaXRzKE1hcmtlZEJsb2NrKik7Ci0gICAgICAgIHNpemVfdCBt
YXJrZWRDZWxscyhzaXplX3Qgc3RhcnRCbG9jayA9IDAsIHNpemVfdCBzdGFydENlbGwgPSAwKSBj
b25zdDsKIAogICAgICAgICBDb2xsZWN0b3JIZWFwIG1faGVhcDsKICAgICAgICAgSlNHbG9iYWxE
YXRhKiBtX2dsb2JhbERhdGE7Cg==
</data>
<flag name="review"
          id="72866"
          type_id="1"
          status="+"
          setter="oliver"
    />
          </attachment>
      

    </bug>

</bugzilla>