53757 2011-02-03 21:59:48 -0800 [Chromium] Issue 58536: Fix Layout Test canvas/philip/tests/2d.imageData.put.alpha.html with --accelerated-2d-canvas. 2011-02-10 07:43:00 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 honten honten abarth commit-queue darin eric honten hyatt jamesr kbr krit oliver senorblanco simon.fraser zimmermann oldest_to_newest 345350 0 honten 2011-02-03 21:59:48 -0800 [Chromium] Issue 58536: Fix Layout Test canvas/philip/tests/2d.imageData.put.alpha.html with --accelerated-2d-canvas. 345355 1 81189 honten 2011-02-03 22:12:25 -0800 Created attachment 81189 Patch 345356 2 honten 2011-02-03 22:16:11 -0800 Could you review my patch? 345364 3 abarth 2011-02-03 22:31:24 -0800 This is a bit outside my area of expertise. 345378 4 honten 2011-02-03 23:13:36 -0800 Do you know who is the right person? (In reply to comment #3) > This is a bit outside my area of expertise. 345385 5 abarth 2011-02-03 23:27:39 -0800 You can try running "webkit-patch suggest-reviewers" on your patch to see which reviewers it suggests. 345387 6 abarth 2011-02-03 23:29:59 -0800 abarth@quadzen:~/svn/webkit3$ ./Tools/Scripts/webkit-patch suggest-reviewers Dan Bernstein David Hyatt Dirk Schulze Nikolas Zimmermann Oliver Hunt Simon Fraser James Robinson 345394 7 honten 2011-02-04 00:09:19 -0800 Added a couple of people whom Adam recommended. Could you review my patch? 346157 8 honten 2011-02-05 10:08:05 -0800 Is there anybody who can review my patch? 346769 9 81189 kbr 2011-02-07 13:31:52 -0800 Comment on attachment 81189 Patch I think this fix should go in ImageBufferSkia.cpp rather than in the common code. Conceptually, ImageBuffer::putUnmultipliedImageData is supposed to be unaffected by the CompositeOperator. 346808 10 honten 2011-02-07 14:40:11 -0800 Thanks, Kenneth!! I also uploaded, https://bugs.webkit.org/show_bug.cgi?id=53857 If you have time, could you review it too? (In reply to comment #9) > (From update of attachment 81189 [details]) > I think this fix should go in ImageBufferSkia.cpp rather than in the common code. Conceptually, ImageBuffer::putUnmultipliedImageData is supposed to be unaffected by the CompositeOperator. 347010 11 kbr 2011-02-07 19:03:19 -0800 (In reply to comment #10) > Thanks, Kenneth!! > > I also uploaded, > https://bugs.webkit.org/show_bug.cgi?id=53857 > > If you have time, could you review it too? Reviewed. Looking forward to revised versions of these two patches to be able to r+ them. Please be sure to set the cq bit to cq? if you want these landed via the commit queue. 347060 12 81578 honten 2011-02-07 21:14:18 -0800 Created attachment 81578 Patch 347062 13 81578 honten 2011-02-07 21:14:57 -0800 Comment on attachment 81578 Patch Ok, I move the logic to ImageBufferSkia.cpp. Please review. 347063 14 81578 jamesr 2011-02-07 21:17:26 -0800 Comment on attachment 81578 Patch Why should changing the composite operator have any effect on how putImageData works? If putImageData() is wrong, fix that don't patch putUnmultipliedImageData. 347148 15 honten 2011-02-07 23:20:51 -0800 As I wrote in the change log and the comment, syncing between software and hardware doesn't work well if the composite operator is wrong. As you know, if there is no hardware usage, it looks working fine. But logically putImageData() is wrong because of wrong operator inside. That is my intention for the first patch. What do you think, Kenneth? If my intention is right, as James suggested, should we use the first patch? (In reply to comment #14) > (From update of attachment 81578 [details]) > Why should changing the composite operator have any effect on how putImageData works? If putImageData() is wrong, fix that don't patch putUnmultipliedImageData. 347470 16 honten 2011-02-08 09:54:52 -0800 After thinking again last night, I flip to the second patch. Because putUnmultipliedImageData() shouldn't change the result according to the operation as Kenneth says. As you see, putImageData<Unmultiplied>() always overwrite the whole pixels, so the function purpose is "overwriting the destination", it means setCompositeOperation(CompositeDestinationIn) in putUnmultipliedImageData(). What do you think, James? My and Kenneth's thoughts are wrong? Thanks, (In reply to comment #15) > As I wrote in the change log and the comment, syncing between software and hardware doesn't work well if the composite operator is wrong. > As you know, if there is no hardware usage, it looks working fine. But logically putImageData() is wrong because of wrong operator inside. That is my intention for the first patch. > > What do you think, Kenneth? > > If my intention is right, as James suggested, should we use the first patch? > > (In reply to comment #14) > > (From update of attachment 81578 [details] [details]) > > Why should changing the composite operator have any effect on how putImageData works? If putImageData() is wrong, fix that don't patch putUnmultipliedImageData. 347520 17 kbr 2011-02-08 10:57:04 -0800 Looking at this more, I think the bug is that ImageBuffer::putUnmultipliedImageData() (ImageBufferSkia.cpp) is calling PlatformContextSkia::prepareForSoftwareDraw() where it should be calling syncSoftwareCanvas(). (See copyImage() higher in the file.) putPremultipliedImageData() looks like it has a similar bug. 347558 18 honten 2011-02-08 11:23:42 -0800 Kenneth, You are right, I didn't notice the function, syncSoftwareCanvas();-( Ok, I will replace prepareForSoftwareDraw() to syncSoftwareCanvas() in both putPremultipliedImageda() and putUnmultipliedImageData(). (In reply to comment #17) > Looking at this more, I think the bug is that ImageBuffer::putUnmultipliedImageData() (ImageBufferSkia.cpp) is calling PlatformContextSkia::prepareForSoftwareDraw() where it should be calling syncSoftwareCanvas(). (See copyImage() higher in the file.) putPremultipliedImageData() looks like it has a similar bug. 347898 19 81732 honten 2011-02-08 19:32:21 -0800 Created attachment 81732 Patch 347899 20 81732 honten 2011-02-08 19:32:39 -0800 Comment on attachment 81732 Patch Please review again. 348370 21 81732 kbr 2011-02-09 10:40:22 -0800 Comment on attachment 81732 Patch Looks good to me. 348439 22 81732 commit-queue 2011-02-09 12:06:47 -0800 Comment on attachment 81732 Patch Clearing flags on attachment: 81732 Committed r78103: <http://trac.webkit.org/changeset/78103> 348440 23 commit-queue 2011-02-09 12:06:53 -0800 All reviewed patches have been landed. Closing bug. 349058 24 senorblanco 2011-02-10 07:43:00 -0800 (In reply to comment #23) > All reviewed patches have been landed. Closing bug. Thanks very much for fixing this! 81189 2011-02-03 22:12:25 -0800 2011-02-07 21:14:14 -0800 Patch bug-53757-20110203221224.patch text/plain 2254 honten ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjMWE4OWUxNzQzZTgzMGFiODAyNjEyNGNkNGI1NjEwYTUyZjlmODIxLi45 Njg5NTNiOWRjNWNkZjcxYWVlOTMyM2VlZDJiYTEzMTJiYzQ0ODA4IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTUgQEAKKzIwMTEtMDItMDMgIE5hb2tpIFRha2FubyAgPHRha2Fuby5uYW9raUBnbWFp bC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg W0Nocm9taXVtXSBJc3N1ZSA1ODUzNjogRml4IExheW91dCBUZXN0IGNhbnZhcy9waGlsaXAvdGVz dHMvMmQuaW1hZ2VEYXRhLnB1dC5hbHBoYS5odG1sIHdpdGggLS1hY2NlbGVyYXRlZC0yZC1jYW52 YXMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01Mzc1 NworCisgICAgICAgIFRoaXMgZml4IGlzIGZvciAyZC5pbWFnZURhdGEucHV0LmFscGhhLmh0bWwg d2l0aCAtLWFjY2VsZXJhdGVkLTJkLWNhbnZhcy4gTm8gbmV3IHRlc3RzLgorCisgICAgICAgICog aHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkNhbnZhc1JlbmRlcmluZ0NvbnRleHQyRDo6cHV0SW1hZ2VEYXRhKTogQ2FudmFzOjpwdXRJ bWFnZURhdGEoKSBuZWVkcyBhbGwgcGl4ZWxzIHJlcGxhY2VtZW50LiBJZiB3ZSBkb24ndCBzZXQg Q29tcG9zaXRlRGVzdGluYXRpb25Jbiwgc3luY2luZyBidWZmZXJzIGJldHdlZW4gSGFyZHdhcmUg YW5kIFNvZnR3YXJlIGZhaWxzIGluIFBsYXRmb3JtQ29udGV4dFNraWE6OnByZXBhcmVGb3JTb2Z0 d2FyZURyYXcoKS4gVGhhdCBjYXVzZXMgdGhpcyB0ZXN0IGZhaWx1cmUgd2l0aCAtLWFjY2VsZXJh dGVkLTJkLWNhbnZhcy4KKwogMjAxMS0wMi0wMiAgQmV0aCBEYWtpbiAgPGJkYWtpbkBhcHBsZS5j b20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFyayBSb3dlLgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcCBiL1NvdXJj ZS9XZWJDb3JlL2h0bWwvY2FudmFzL0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyRC5jcHAKaW5kZXgg NDU4YTE2ODlmOTYyODFkNjNmNjM2YTRiODI1MzdkM2MxMzFkN2M2NC4uMzgwOGRiMDExYWMwMzgx OTczMzgzN2VjMDhkYjM4MTZhZjE0YWI2ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRt bC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9odG1sL2NhbnZhcy9DYW52YXNSZW5kZXJpbmdDb250ZXh0MkQuY3BwCkBAIC0xNjM2LDcgKzE2 MzYsMTcgQEAgdm9pZCBDYW52YXNSZW5kZXJpbmdDb250ZXh0MkQ6OnB1dEltYWdlRGF0YShJbWFn ZURhdGEqIGRhdGEsIGZsb2F0IGR4LCBmbG9hdCBkeSwKICAgICBJbnRSZWN0IHNvdXJjZVJlY3Qo ZGVzdFJlY3QpOwogICAgIHNvdXJjZVJlY3QubW92ZSgtZGVzdE9mZnNldCk7CiAKKyAgICBHcmFw aGljc0NvbnRleHQqIGNvbnRleHQgPSBkcmF3aW5nQ29udGV4dCgpOworICAgIGlmICghY29udGV4 dCkKKyAgICAgICAgcmV0dXJuOworCisgICAgLy8gUGl4ZWxzIGluIHRoZSBjYW52YXMgYXJlIHJl cGxhY2VkIHdob2xlc2FsZS4gU28gd2UgaGF2ZSB0byBzZXQKKyAgICAvLyBDb21wb3NpdGVEZXN0 aW5hdGlvbkluLiBBZnRlciB0aGUgcmVwbGFjZW1lbnQsIHdlIHJlc3RvcmUKKyAgICAvLyB8cHJl dmlvdXNPcGVyYXRvcnwuCisgICAgQ29tcG9zaXRlT3BlcmF0b3IgcHJldmlvdXNPcGVyYXRvciA9 IGNvbnRleHQtPmNvbXBvc2l0ZU9wZXJhdGlvbigpOworICAgIGNvbnRleHQtPnNldENvbXBvc2l0 ZU9wZXJhdGlvbihDb21wb3NpdGVEZXN0aW5hdGlvbkluKTsKICAgICBidWZmZXItPnB1dFVubXVs dGlwbGllZEltYWdlRGF0YShkYXRhLT5kYXRhKCktPmRhdGEoKSwgSW50U2l6ZShkYXRhLT53aWR0 aCgpLCBkYXRhLT5oZWlnaHQoKSksIHNvdXJjZVJlY3QsIEludFBvaW50KGRlc3RPZmZzZXQpKTsK KyAgICBjb250ZXh0LT5zZXRDb21wb3NpdGVPcGVyYXRpb24ocHJldmlvdXNPcGVyYXRvcik7CiAg ICAgZGlkRHJhdyhkZXN0UmVjdCwgQ2FudmFzRGlkRHJhd0FwcGx5Tm9uZSk7IC8vIGlnbm9yZSB0 cmFuc2Zvcm0sIHNoYWRvdyBhbmQgY2xpcAogfQogCg== 81578 2011-02-07 21:14:18 -0800 2011-02-08 19:32:18 -0800 Patch bug-53757-20110207211416.patch text/plain 2378 honten ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1ZTcwODNkYzVkZTZiNjA0YjE0MjVhZjBmNDVjN2JhNzhlOGIzZjlkLi44 ZTc3MzQ3YzU0NmNhZWMzNzVmOWRmNjZjZmE1ZGIwZjg1MDhmNmYwIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTUgQEAKKzIwMTEtMDItMDcgIE5hb2tpIFRha2FubyAgPHRha2Fuby5uYW9raUBnbWFp bC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg W0Nocm9taXVtXSBJc3N1ZSA1ODUzNjogRml4IExheW91dCBUZXN0IGNhbnZhcy9waGlsaXAvdGVz dHMvMmQuaW1hZ2VEYXRhLnB1dC5hbHBoYS5odG1sIHdpdGggLS1hY2NlbGVyYXRlZC0yZC1jYW52 YXMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01Mzc1 NworCisgICAgICAgIFRoaXMgZml4IGlzIGZvciAyZC5pbWFnZURhdGEucHV0LmFscGhhLmh0bWwg d2l0aCAtLWFjY2VsZXJhdGVkLTJkLWNhbnZhcy4gTm8gbmV3IHRlc3RzLgorCisgICAgICAgICog cGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9JbWFnZUJ1ZmZlclNraWEuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6SW1hZ2VCdWZmZXI6OnB1dFVubXVsdGlwbGllZEltYWdlRGF0YSk6IG5lZWRzIGFsbCBw aXhlbHMgcmVwbGFjZW1lbnQuIElmIHdlIGRvbid0IHNldCBDb21wb3NpdGVEZXN0aW5hdGlvbklu LCBzeW5jaW5nIGJ1ZmZlcnMgYmV0d2VlbiBIYXJkd2FyZSBhbmQgU29mdHdhcmUgZmFpbHMgaW4g UGxhdGZvcm1Db250ZXh0U2tpYTo6cHJlcGFyZUZvclNvZnR3YXJlRHJhdygpLiBUaGF0IGNhdXNl cyB0aGlzIHRlc3QgZmFpbHVyZSB3aXRoIC0tYWNjZWxlcmF0ZWQtMmQtY2FudmFzLgorCiAyMDEx LTAyLTA0ICBKZXJlbXkgT3Jsb3cgIDxqb3Jsb3dAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJl dmVydCBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTM3OTUKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvSW1hZ2VCdWZmZXJT a2lhLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvSW1hZ2VCdWZm ZXJTa2lhLmNwcAppbmRleCBkYmM1NTRlOWNjOTJlMDNhYjdhZDJmYTllYjhiZjQzYzA4YWNmNzgx Li5iN2EwNzI1MzhlZGJkYWZkNDZmYzNkNTU0YzMyMjdkZTgzNGY3NzFmIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0ltYWdlQnVmZmVyU2tpYS5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9JbWFnZUJ1ZmZlclNr aWEuY3BwCkBAIC0zMTAsOCArMzEwLDE0IEBAIHZvaWQgcHV0SW1hZ2VEYXRhKEJ5dGVBcnJheSom IHNvdXJjZSwgY29uc3QgSW50U2l6ZSYgc291cmNlU2l6ZSwgY29uc3QgSW50UmVjdCYKIAogdm9p ZCBJbWFnZUJ1ZmZlcjo6cHV0VW5tdWx0aXBsaWVkSW1hZ2VEYXRhKEJ5dGVBcnJheSogc291cmNl LCBjb25zdCBJbnRTaXplJiBzb3VyY2VTaXplLCBjb25zdCBJbnRSZWN0JiBzb3VyY2VSZWN0LCBj b25zdCBJbnRQb2ludCYgZGVzdFBvaW50KQogeworICAgIC8vIFBpeGVscyBpbiB0aGUgY2FudmFz IGFyZSByZXBsYWNlZCB3aG9sZXNhbGUuIFNvIHdlIGhhdmUgdG8gc2V0CisgICAgLy8gQ29tcG9z aXRlRGVzdGluYXRpb25Jbi4gQWZ0ZXIgdGhlIHJlcGxhY2VtZW50LCB3ZSByZXN0b3JlCisgICAg Ly8gfHByZXZpb3VzT3BlcmF0b3J8LgorICAgIENvbXBvc2l0ZU9wZXJhdG9yIHByZXZpb3VzT3Bl cmF0b3IgPSBjb250ZXh0KCktPmNvbXBvc2l0ZU9wZXJhdGlvbigpOworICAgIGNvbnRleHQoKS0+ c2V0Q29tcG9zaXRlT3BlcmF0aW9uKENvbXBvc2l0ZURlc3RpbmF0aW9uSW4pOwogICAgIGNvbnRl eHQoKS0+cGxhdGZvcm1Db250ZXh0KCktPnByZXBhcmVGb3JTb2Z0d2FyZURyYXcoKTsKICAgICBw dXRJbWFnZURhdGE8VW5tdWx0aXBsaWVkPihzb3VyY2UsIHNvdXJjZVNpemUsIHNvdXJjZVJlY3Qs IGRlc3RQb2ludCwgKmNvbnRleHQoKS0+cGxhdGZvcm1Db250ZXh0KCktPmJpdG1hcCgpLCBtX3Np emUpOworICAgIGNvbnRleHQoKS0+c2V0Q29tcG9zaXRlT3BlcmF0aW9uKHByZXZpb3VzT3BlcmF0 b3IpOwogfQogCiB2b2lkIEltYWdlQnVmZmVyOjpwdXRQcmVtdWx0aXBsaWVkSW1hZ2VEYXRhKEJ5 dGVBcnJheSogc291cmNlLCBjb25zdCBJbnRTaXplJiBzb3VyY2VTaXplLCBjb25zdCBJbnRSZWN0 JiBzb3VyY2VSZWN0LCBjb25zdCBJbnRQb2ludCYgZGVzdFBvaW50KQo= 81732 2011-02-08 19:32:21 -0800 2011-02-09 12:06:47 -0800 Patch bug-53757-20110208193220.patch text/plain 2247 honten ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1ZTcwODNkYzVkZTZiNjA0YjE0MjVhZjBmNDVjN2JhNzhlOGIzZjlkLi5k YTI0ZTcxNjQ1ZTQ4YzA2MDE3NjE4ZjliYzA0ODNkOGVlMmFlOGEyIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTcgQEAKKzIwMTEtMDItMDggIE5hb2tpIFRha2FubyAgPHRha2Fuby5uYW9raUBnbWFp bC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg W0Nocm9taXVtXSBJc3N1ZSA1ODUzNjogRml4IExheW91dCBUZXN0IGNhbnZhcy9waGlsaXAvdGVz dHMvMmQuaW1hZ2VEYXRhLnB1dC5hbHBoYS5odG1sIHdpdGggLS1hY2NlbGVyYXRlZC0yZC1jYW52 YXMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01Mzc1 NworCisgICAgICAgICAgVGhpcyBmaXggaXMgZm9yIDJkLmltYWdlRGF0YS5wdXQuYWxwaGEuaHRt bCB3aXRoIC0tYWNjZWxlcmF0ZWQtMmQtY2FudmFzLiBObyBuZXcgdGVzdHMuCisKKyAgICAgICAg KiBwbGF0Zm9ybS9ncmFwaGljcy9za2lhL0ltYWdlQnVmZmVyU2tpYS5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpJbWFnZUJ1ZmZlcjo6cHV0VW5tdWx0aXBsaWVkSW1hZ2VEYXRhKTogbmVlZHMgdG8g Y2FsbCBzeW5jU29mdHdhcmVDYW52YXMoKSB0byBzeW5jIGJldHdlZW4gaGFyZHdhcmUgYW5kIHNv ZnR3YXJlLgorICAgICAgICAoV2ViQ29yZTo6SW1hZ2VCdWZmZXI6OnB1dFByZW11bHRpcGxpZWRJ bWFnZURhdGEpOiBuZWVkcyB0byBjYWxsIHN5bmNTb2Z0d2FyZUNhbnZhcygpIHRvIHN5bmMgYmV0 d2VlbiBoYXJkd2FyZSBhbmQgc29mdHdhcmUuCisKKwogMjAxMS0wMi0wNCAgSmVyZW15IE9ybG93 ICA8am9ybG93QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZlcnQgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUzNzk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0ltYWdlQnVmZmVyU2tpYS5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0ltYWdlQnVmZmVyU2tpYS5jcHAKaW5kZXggZGJj NTU0ZTljYzkyZTAzYWI3YWQyZmE5ZWI4YmY0M2MwOGFjZjc4MS4uNGViYjg5NGFiMjViYTNkMTM0 YzIzYzVhOGE1NTczNjgzZTAwNWIwZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3Mvc2tpYS9JbWFnZUJ1ZmZlclNraWEuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvSW1hZ2VCdWZmZXJTa2lhLmNwcApAQCAtMzEwLDEyICsz MTAsMTMgQEAgdm9pZCBwdXRJbWFnZURhdGEoQnl0ZUFycmF5KiYgc291cmNlLCBjb25zdCBJbnRT aXplJiBzb3VyY2VTaXplLCBjb25zdCBJbnRSZWN0JgogCiB2b2lkIEltYWdlQnVmZmVyOjpwdXRV bm11bHRpcGxpZWRJbWFnZURhdGEoQnl0ZUFycmF5KiBzb3VyY2UsIGNvbnN0IEludFNpemUmIHNv dXJjZVNpemUsIGNvbnN0IEludFJlY3QmIHNvdXJjZVJlY3QsIGNvbnN0IEludFBvaW50JiBkZXN0 UG9pbnQpCiB7Ci0gICAgY29udGV4dCgpLT5wbGF0Zm9ybUNvbnRleHQoKS0+cHJlcGFyZUZvclNv ZnR3YXJlRHJhdygpOworICAgIGNvbnRleHQoKS0+cGxhdGZvcm1Db250ZXh0KCktPnN5bmNTb2Z0 d2FyZUNhbnZhcygpOwogICAgIHB1dEltYWdlRGF0YTxVbm11bHRpcGxpZWQ+KHNvdXJjZSwgc291 cmNlU2l6ZSwgc291cmNlUmVjdCwgZGVzdFBvaW50LCAqY29udGV4dCgpLT5wbGF0Zm9ybUNvbnRl eHQoKS0+Yml0bWFwKCksIG1fc2l6ZSk7CiB9CiAKIHZvaWQgSW1hZ2VCdWZmZXI6OnB1dFByZW11 bHRpcGxpZWRJbWFnZURhdGEoQnl0ZUFycmF5KiBzb3VyY2UsIGNvbnN0IEludFNpemUmIHNvdXJj ZVNpemUsIGNvbnN0IEludFJlY3QmIHNvdXJjZVJlY3QsIGNvbnN0IEludFBvaW50JiBkZXN0UG9p bnQpCiB7CisgICAgY29udGV4dCgpLT5wbGF0Zm9ybUNvbnRleHQoKS0+c3luY1NvZnR3YXJlQ2Fu dmFzKCk7CiAgICAgcHV0SW1hZ2VEYXRhPFByZW11bHRpcGxpZWQ+KHNvdXJjZSwgc291cmNlU2l6 ZSwgc291cmNlUmVjdCwgZGVzdFBvaW50LCAqY29udGV4dCgpLT5wbGF0Zm9ybUNvbnRleHQoKS0+ Yml0bWFwKCksIG1fc2l6ZSk7CiB9CiAK