53745 2011-02-03 17:48:37 -0800 Remove unneeded function declarations in comments in EditorClient.h 2011-02-04 11:58:02 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED http://trac.webkit.org/browser/trunk/Source/WebCore/page/EditorClient.h?annotate=blame&rev=75523#L122 P3 Trivial --- 1 leviw webkit-unassigned darin ggaren leviw oldest_to_newest 345224 0 leviw 2011-02-03 17:48:37 -0800 EditorClient.h contains 5 functions that were commented out over 4 years ago, and three of which reference NS_____ objects. Unless anyone objects I'll clean them up. They don't appear to have references in WebKit at all. CC-ing from svn blame. 345544 1 darin 2011-02-04 09:44:44 -0800 It’s fine to remove these functions. It’s not quite right to say they were “commented out 4 years ago”. They have always been commented out! See <http://trac.webkit.org/browser/trunk/WebCore/bridge/EditorClient.h?rev=17179> for the initial version of the file. 345634 2 81252 leviw 2011-02-04 11:26:50 -0800 Created attachment 81252 Patch 345666 3 leviw 2011-02-04 11:58:02 -0800 Committed r77651: <http://trac.webkit.org/changeset/77651> 81252 2011-02-04 11:26:50 -0800 2011-02-04 11:29:41 -0800 Patch bug-53745-20110204112649.patch text/plain 1909 leviw SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc3NjQ2KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDItMDQgIExldmkgV2Vp bnRyYXViICA8bGV2aXdAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSB1bm5lZWRlZCBmdW5jdGlvbiBkZWNsYXJhdGlv bnMgaW4gY29tbWVudHMgaW4gRWRpdG9yQ2xpZW50LmgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUzNzQ1CisKKyAgICAgICAgUmVtb3ZpbmcgdW51c2Vk IGNvbW1lbnRlZCBvdXQgZnVuY3Rpb24gZGVjbGFyYXRpb25zLiBObyB0ZXN0cyBzaW5jZSB0aGlz IGlzIGp1c3QgY2xlYW51cC4KKworICAgICAgICAqIHBhZ2UvRWRpdG9yQ2xpZW50Lmg6CisKIDIw MTEtMDItMDQgIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KIAogICAgICAg ICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BhZ2UvRWRp dG9yQ2xpZW50LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGFnZS9FZGl0b3JDbGll bnQuaAkocmV2aXNpb24gNzc1NDYpCisrKyBTb3VyY2UvV2ViQ29yZS9wYWdlL0VkaXRvckNsaWVu dC5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMTksOCArMTE5LDYgQEAgcHVibGljOgogICAgIHZpcnR1 YWwgYm9vbCBzaG91bGRDaGFuZ2VTZWxlY3RlZFJhbmdlKFJhbmdlKiBmcm9tUmFuZ2UsIFJhbmdl KiB0b1JhbmdlLCBFQWZmaW5pdHksIGJvb2wgc3RpbGxTZWxlY3RpbmcpID0gMDsKICAgICAKICAg ICB2aXJ0dWFsIGJvb2wgc2hvdWxkQXBwbHlTdHlsZShDU1NTdHlsZURlY2xhcmF0aW9uKiwgUmFu Z2UqKSA9IDA7Ci0vLyAgdmlydHVhbCBib29sIHNob3VsZENoYW5nZVR5cGluZ1N0eWxlKENTU1N0 eWxlRGVjbGFyYXRpb24qIGZyb21TdHlsZSwgQ1NTU3R5bGVEZWNsYXJhdGlvbiogdG9TdHlsZSkg PSAwOwotLy8gIHZpcnR1YWwgYm9vbCBkb0NvbW1hbmRCeVNlbGVjdG9yKFNFTCBzZWxlY3Rvcikg PSAwOwogICAgIHZpcnR1YWwgYm9vbCBzaG91bGRNb3ZlUmFuZ2VBZnRlckRlbGV0ZShSYW5nZSos IFJhbmdlKikgPSAwOwogCiAgICAgdmlydHVhbCB2b2lkIGRpZEJlZ2luRWRpdGluZygpID0gMDsK QEAgLTEyOSw5ICsxMjcsNiBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIGRpZEVuZEVkaXRp bmcoKSA9IDA7CiAgICAgdmlydHVhbCB2b2lkIGRpZFdyaXRlU2VsZWN0aW9uVG9QYXN0ZWJvYXJk KCkgPSAwOwogICAgIHZpcnR1YWwgdm9pZCBkaWRTZXRTZWxlY3Rpb25UeXBlc0ZvclBhc3RlYm9h cmQoKSA9IDA7Ci0vLyAgdmlydHVhbCB2b2lkIGRpZENoYW5nZVR5cGluZ1N0eWxlOihOU05vdGlm aWNhdGlvbiAqKW5vdGlmaWNhdGlvbiA9IDA7Ci0vLyAgdmlydHVhbCB2b2lkIGRpZENoYW5nZVNl bGVjdGlvbjooTlNOb3RpZmljYXRpb24gKilub3RpZmljYXRpb24gPSAwOwotLy8gIHZpcnR1YWwg TlNVbmRvTWFuYWdlciogdW5kb01hbmFnZXI6KFdlYlZpZXcgKil3ZWJWaWV3ID0gMDsKICAgICAK ICAgICB2aXJ0dWFsIHZvaWQgcmVnaXN0ZXJDb21tYW5kRm9yVW5kbyhQYXNzUmVmUHRyPEVkaXRD b21tYW5kPikgPSAwOwogICAgIHZpcnR1YWwgdm9pZCByZWdpc3RlckNvbW1hbmRGb3JSZWRvKFBh c3NSZWZQdHI8RWRpdENvbW1hbmQ+KSA9IDA7Cg==