53730 2011-02-03 16:17:36 -0800 SerializedScriptValue should not require v8 to create undefined and null values 2011-02-04 02:40:34 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 jorlow jorlow abarth dglazkov eric hans japhet webkit.review.bot oldest_to_newest 345104 0 jorlow 2011-02-03 16:17:36 -0800 SerializedScriptValue should not require v8 to create undefined and null values 345108 1 81136 jorlow 2011-02-03 16:19:51 -0800 Created attachment 81136 Patch 345109 2 jorlow 2011-02-03 16:20:17 -0800 please review? 345138 3 jorlow 2011-02-03 16:37:29 -0800 Committed r77558: <http://trac.webkit.org/changeset/77558> 345419 4 webkit.review.bot 2011-02-04 02:40:34 -0800 http://trac.webkit.org/changeset/77558 might have broken GTK Linux 32-bit Release and GTK Linux 32-bit Debug The following tests are not passing: fast/events/pagehide-timeout.html 81136 2011-02-03 16:19:51 -0800 2011-02-03 16:32:38 -0800 Patch bug-53730-20110203161950.patch text/plain 5292 jorlow ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzMjk3YTA3ZWQyMGQ0MjVhNDYyYWYyZGVlMzI3NTBkNmRiODgyZDJhLi5l NTU1NjM3OTlkNjY1NDhiNjcyMTFlOWI3ODVmYjU2ZDUxNTA3YzRiIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMjkgQEAKKzIwMTEtMDItMDMgIEplcmVteSBPcmxvdyAgPGpvcmxvd0BjaHJvbWl1bS5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2Vy aWFsaXplZFNjcmlwdFZhbHVlIHNob3VsZCBub3QgcmVxdWlyZSB2OCB0byBjcmVhdGUgdW5kZWZp bmVkIGFuZCBudWxsIHZhbHVlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NTM3MzAKKworICAgICAgICBJbnN0ZWFkIG9mIGNyZWF0aW5nIGEgdjggdHlw ZSBhbmQgcGFzc2luZyB0aGF0IGludG8gdGhlIGNvbnN0cnVjdG9yLCBqdXN0IHVzZQorICAgICAg ICB0aGUgd3JpdGVyIGNsYXNzIGRpcmVjdGx5LiBXaGlsZSBJIHdhcyBhdCBpdCwgSSBjbGVhbmVk IHVwIHRoZSBjb2RlIGEgYml0IHRvbworICAgICAgICBieSBnZXR0aW5nIHJpZCBvZiB0aGUgV2ly ZURhdGEvU3RyaW5nVmFsdWUgZW51bSBhcyBJIGZvdW5kIHRoYXQgcGVyc29uYWxseQorICAgICAg ICBjb25mdXNpbmcuCisKKyAgICAgICAgVGhpcyBpcyBuZWNlc3NhcnkgYmVjYXVzZSB0aGVzZSBt ZXRob2RzIGFyZSBjYWxsZWQgYnkgSW5kZXhlZERCIGluIHRoZSBicm93c2VyCisgICAgICAgIHBy b2Nlc3Mgd2hlcmUgdjggaXMgbm90IHNwdW4gdXAuCisKKyAgICAgICAgTm8gZnVuY3Rpb25hbGl0 eSBjaGFuZ2VkIGFuZCBub3QgcG9zc2libGUgdG8gdGVzdC4KKworICAgICAgICAqIGJpbmRpbmdz L3Y4L1NlcmlhbGl6ZWRTY3JpcHRWYWx1ZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTZXJpYWxp emVkU2NyaXB0VmFsdWU6OmNyZWF0ZUZyb21XaXJlKToKKyAgICAgICAgKFdlYkNvcmU6OlNlcmlh bGl6ZWRTY3JpcHRWYWx1ZTo6Y3JlYXRlKToKKyAgICAgICAgKFdlYkNvcmU6OlNlcmlhbGl6ZWRT Y3JpcHRWYWx1ZTo6bnVsbFZhbHVlKToKKyAgICAgICAgKFdlYkNvcmU6OlNlcmlhbGl6ZWRTY3Jp cHRWYWx1ZTo6dW5kZWZpbmVkVmFsdWUpOgorICAgICAgICAoV2ViQ29yZTo6U2VyaWFsaXplZFNj cmlwdFZhbHVlOjpyZWxlYXNlKToKKyAgICAgICAgKFdlYkNvcmU6OlNlcmlhbGl6ZWRTY3JpcHRW YWx1ZTo6U2VyaWFsaXplZFNjcmlwdFZhbHVlKToKKyAgICAgICAgKiBiaW5kaW5ncy92OC9TZXJp YWxpemVkU2NyaXB0VmFsdWUuaDoKKwogMjAxMS0wMi0wMyAgVmFuZ2VsaXMgS29ra2V2aXMgIDx2 YW5nZWxpc0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSdXNz ZWxsLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2VyaWFsaXplZFNj cmlwdFZhbHVlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1NlcmlhbGl6ZWRTY3Jp cHRWYWx1ZS5jcHAKaW5kZXggNjY2ZTYxOWJiNTI1ZjA5OWZmMDNhYzhmOWY2ZDA0ZDI2ZjlhN2I4 YS4uMWM1ZTRlNzE4NDA1MjEzYTkxZGFiYzE1ZDUzOTRiM2RkNWRmM2EwMCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2VyaWFsaXplZFNjcmlwdFZhbHVlLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9TZXJpYWxpemVkU2NyaXB0VmFsdWUuY3BwCkBA IC0xMTE4LDEyICsxMTE4LDE1IEBAIFBhc3NSZWZQdHI8U2VyaWFsaXplZFNjcmlwdFZhbHVlPiBT ZXJpYWxpemVkU2NyaXB0VmFsdWU6OmNyZWF0ZSh2ODo6SGFuZGxlPHY4OjpWCiAKIFBhc3NSZWZQ dHI8U2VyaWFsaXplZFNjcmlwdFZhbHVlPiBTZXJpYWxpemVkU2NyaXB0VmFsdWU6OmNyZWF0ZUZy b21XaXJlKFN0cmluZyBkYXRhKQogewotICAgIHJldHVybiBhZG9wdFJlZihuZXcgU2VyaWFsaXpl ZFNjcmlwdFZhbHVlKGRhdGEsIFdpcmVEYXRhKSk7CisgICAgcmV0dXJuIGFkb3B0UmVmKG5ldyBT ZXJpYWxpemVkU2NyaXB0VmFsdWUoZGF0YSkpOwogfQogCiBQYXNzUmVmUHRyPFNlcmlhbGl6ZWRT Y3JpcHRWYWx1ZT4gU2VyaWFsaXplZFNjcmlwdFZhbHVlOjpjcmVhdGUoU3RyaW5nIGRhdGEpCiB7 Ci0gICAgcmV0dXJuIGFkb3B0UmVmKG5ldyBTZXJpYWxpemVkU2NyaXB0VmFsdWUoZGF0YSwgU3Ry aW5nVmFsdWUpKTsKKyAgICBXcml0ZXIgd3JpdGVyOworICAgIHdyaXRlci53cml0ZVdlYkNvcmVT dHJpbmcoZGF0YSk7CisgICAgU3RyaW5nIHdpcmVEYXRhID0gU3RyaW5nSW1wbDo6YWRvcHQod3Jp dGVyLmRhdGEoKSk7CisgICAgcmV0dXJuIGFkb3B0UmVmKG5ldyBTZXJpYWxpemVkU2NyaXB0VmFs dWUod2lyZURhdGEpKTsKIH0KIAogUGFzc1JlZlB0cjxTZXJpYWxpemVkU2NyaXB0VmFsdWU+IFNl cmlhbGl6ZWRTY3JpcHRWYWx1ZTo6Y3JlYXRlKCkKQEAgLTExMzMsMTkgKzExMzYsMzEgQEAgUGFz c1JlZlB0cjxTZXJpYWxpemVkU2NyaXB0VmFsdWU+IFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZTo6Y3Jl YXRlKCkKIAogU2VyaWFsaXplZFNjcmlwdFZhbHVlKiBTZXJpYWxpemVkU2NyaXB0VmFsdWU6Om51 bGxWYWx1ZSgpCiB7Ci0gICAgREVGSU5FX1NUQVRJQ19MT0NBTChSZWZQdHI8U2VyaWFsaXplZFNj cmlwdFZhbHVlPiwgbnVsbFZhbHVlLCAoU2VyaWFsaXplZFNjcmlwdFZhbHVlOjpjcmVhdGUoKSkp OworICAgIERFRklORV9TVEFUSUNfTE9DQUwoUmVmUHRyPFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZT4s IG51bGxWYWx1ZSwgKDApKTsKKyAgICBpZiAoIW51bGxWYWx1ZSkgeworICAgICAgICBXcml0ZXIg d3JpdGVyOworICAgICAgICB3cml0ZXIud3JpdGVOdWxsKCk7CisgICAgICAgIFN0cmluZyB3aXJl RGF0YSA9IFN0cmluZ0ltcGw6OmFkb3B0KHdyaXRlci5kYXRhKCkpOworICAgICAgICBudWxsVmFs dWUgPSBhZG9wdFJlZihuZXcgU2VyaWFsaXplZFNjcmlwdFZhbHVlKHdpcmVEYXRhKSk7CisgICAg fQogICAgIHJldHVybiBudWxsVmFsdWUuZ2V0KCk7CiB9CiAKIFNlcmlhbGl6ZWRTY3JpcHRWYWx1 ZSogU2VyaWFsaXplZFNjcmlwdFZhbHVlOjp1bmRlZmluZWRWYWx1ZSgpCiB7Ci0gICAgREVGSU5F X1NUQVRJQ19MT0NBTChSZWZQdHI8U2VyaWFsaXplZFNjcmlwdFZhbHVlPiwgdW5kZWZpbmVkVmFs dWUsIChTZXJpYWxpemVkU2NyaXB0VmFsdWU6OmNyZWF0ZSh2ODo6VW5kZWZpbmVkKCkpKSk7Cisg ICAgREVGSU5FX1NUQVRJQ19MT0NBTChSZWZQdHI8U2VyaWFsaXplZFNjcmlwdFZhbHVlPiwgdW5k ZWZpbmVkVmFsdWUsICgwKSk7CisgICAgaWYgKCF1bmRlZmluZWRWYWx1ZSkgeworICAgICAgICBX cml0ZXIgd3JpdGVyOworICAgICAgICB3cml0ZXIud3JpdGVVbmRlZmluZWQoKTsKKyAgICAgICAg U3RyaW5nIHdpcmVEYXRhID0gU3RyaW5nSW1wbDo6YWRvcHQod3JpdGVyLmRhdGEoKSk7CisgICAg ICAgIHVuZGVmaW5lZFZhbHVlID0gYWRvcHRSZWYobmV3IFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZSh3 aXJlRGF0YSkpOworICAgIH0KICAgICByZXR1cm4gdW5kZWZpbmVkVmFsdWUuZ2V0KCk7CiB9CiAK IFBhc3NSZWZQdHI8U2VyaWFsaXplZFNjcmlwdFZhbHVlPiBTZXJpYWxpemVkU2NyaXB0VmFsdWU6 OnJlbGVhc2UoKQogewotICAgIFJlZlB0cjxTZXJpYWxpemVkU2NyaXB0VmFsdWU+IHJlc3VsdCA9 IGFkb3B0UmVmKG5ldyBTZXJpYWxpemVkU2NyaXB0VmFsdWUobV9kYXRhLCBXaXJlRGF0YSkpOwor ICAgIFJlZlB0cjxTZXJpYWxpemVkU2NyaXB0VmFsdWU+IHJlc3VsdCA9IGFkb3B0UmVmKG5ldyBT ZXJpYWxpemVkU2NyaXB0VmFsdWUobV9kYXRhKSk7CiAgICAgbV9kYXRhID0gU3RyaW5nKCkuY3Jv c3NUaHJlYWRTdHJpbmcoKTsKICAgICByZXR1cm4gcmVzdWx0LnJlbGVhc2UoKTsKIH0KQEAgLTEx NjcsMTYgKzExODIsOSBAQCBTZXJpYWxpemVkU2NyaXB0VmFsdWU6OlNlcmlhbGl6ZWRTY3JpcHRW YWx1ZSh2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gdmFsdWUsIGJvb2wmCiAgICAgbV9kYXRhID0gU3Ry aW5nKFN0cmluZ0ltcGw6OmFkb3B0KHdyaXRlci5kYXRhKCkpKS5jcm9zc1RocmVhZFN0cmluZygp OwogfQogCi1TZXJpYWxpemVkU2NyaXB0VmFsdWU6OlNlcmlhbGl6ZWRTY3JpcHRWYWx1ZShTdHJp bmcgZGF0YSwgU3RyaW5nRGF0YU1vZGUgbW9kZSkKK1NlcmlhbGl6ZWRTY3JpcHRWYWx1ZTo6U2Vy aWFsaXplZFNjcmlwdFZhbHVlKFN0cmluZyB3aXJlRGF0YSkKIHsKLSAgICBpZiAobW9kZSA9PSBX aXJlRGF0YSkKLSAgICAgICAgbV9kYXRhID0gZGF0YS5jcm9zc1RocmVhZFN0cmluZygpOwotICAg IGVsc2UgewotICAgICAgICBBU1NFUlQobW9kZSA9PSBTdHJpbmdWYWx1ZSk7Ci0gICAgICAgIFdy aXRlciB3cml0ZXI7Ci0gICAgICAgIHdyaXRlci53cml0ZVdlYkNvcmVTdHJpbmcoZGF0YSk7Ci0g ICAgICAgIG1fZGF0YSA9IFN0cmluZyhTdHJpbmdJbXBsOjphZG9wdCh3cml0ZXIuZGF0YSgpKSku Y3Jvc3NUaHJlYWRTdHJpbmcoKTsKLSAgICB9CisgICAgbV9kYXRhID0gd2lyZURhdGEuY3Jvc3NU aHJlYWRTdHJpbmcoKTsKIH0KIAogdjg6OkhhbmRsZTx2ODo6VmFsdWU+IFNlcmlhbGl6ZWRTY3Jp cHRWYWx1ZTo6ZGVzZXJpYWxpemUoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvdjgvU2VyaWFsaXplZFNjcmlwdFZhbHVlLmggYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92 OC9TZXJpYWxpemVkU2NyaXB0VmFsdWUuaAppbmRleCBlYWQ5NTExMmUyODMyNTdiMGQ0NmNmNjcy OGMyODRmY2VjMjEyM2E5Li5kMGQ4NTc1NTIyYTM5YWNkODA3MjZiNmU1MTYyNGJlMGZiYjAwYmU0 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9TZXJpYWxpemVkU2NyaXB0 VmFsdWUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9TZXJpYWxpemVkU2NyaXB0 VmFsdWUuaApAQCAtNzIsNyArNzIsNyBAQCBwcml2YXRlOgogCiAgICAgU2VyaWFsaXplZFNjcmlw dFZhbHVlKCk7CiAgICAgU2VyaWFsaXplZFNjcmlwdFZhbHVlKHY4OjpIYW5kbGU8djg6OlZhbHVl PiwgYm9vbCYgZGlkVGhyb3cpOwotICAgIFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZShTdHJpbmcgZGF0 YSwgU3RyaW5nRGF0YU1vZGUgbW9kZSk7CisgICAgZXhwbGljaXQgU2VyaWFsaXplZFNjcmlwdFZh bHVlKFN0cmluZyB3aXJlRGF0YSk7CiAKICAgICBTdHJpbmcgbV9kYXRhOwogfTsK