53698 2011-02-03 11:45:37 -0800 Make the layer tree host keep track of the layer tree context 2011-02-03 11:52:56 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 344885 0 andersca 2011-02-03 11:45:37 -0800 Make the layer tree host keep track of the layer tree context 344886 1 81093 andersca 2011-02-03 11:46:57 -0800 Created attachment 81093 Patch 344887 2 81093 sam 2011-02-03 11:48:41 -0800 Comment on attachment 81093 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=81093&action=review > Source/WebKit2/Shared/mac/LayerTreeContextMac.mm:45 > +LayerTreeContext LayerTreeContext::makeWithSeed() { > + static uint64_t seed; { on the wrong line. Seed is also not a common name for this kind of thing in our code. Can we use ID? 344892 3 andersca 2011-02-03 11:52:56 -0800 Committed r77524: <http://trac.webkit.org/changeset/77524> 81093 2011-02-03 11:46:57 -0800 2011-02-03 11:48:41 -0800 Patch bug-53698-20110203114657.patch text/plain 5276 andersca SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDc3NTIyKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjggQEAKKzIwMTEtMDItMDMgIEFuZGVycyBD YXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBNYWtlIHRoZSBsYXllciB0cmVlIGhvc3Qga2VlcCB0cmFj ayBvZiB0aGUgbGF5ZXIgdHJlZSBjb250ZXh0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD01MzY5OAorCisgICAgICAgIEFkZCBhIExheWVyVHJlZUNvbnRl eHQgbWVtYmVyIHZhcmlhYmxlIHRvIHRoZSBMYXllclRyZWVIb3N0IG9iamVjdCwKKyAgICAgICAg YW5kIGFsc28gYWRkIGEgc2VlZCBjb3VudCB0byB0aGUgTGF5ZXJUcmVlQ29udGV4dCBzbyB3ZSBj YW4ga2VlcCB0cmFjayBvZiAKKyAgICAgICAgaG93IGxheWVyIHRyZWUgY29udGV4dHMgcmVsYXRl IHRvIGVhY2ggb3RoZXIuCisKKyAgICAgICAgKiBTaGFyZWQvTGF5ZXJUcmVlQ29udGV4dC5oOgor ICAgICAgICAqIFNoYXJlZC9tYWMvTGF5ZXJUcmVlQ29udGV4dE1hYy5tbToKKyAgICAgICAgKFdl YktpdDo6TGF5ZXJUcmVlQ29udGV4dDo6TGF5ZXJUcmVlQ29udGV4dCk6CisgICAgICAgIChXZWJL aXQ6OkxheWVyVHJlZUNvbnRleHQ6Om1ha2VXaXRoU2VlZCk6CisgICAgICAgIChXZWJLaXQ6Okxh eWVyVHJlZUNvbnRleHQ6OmVuY29kZSk6CisgICAgICAgIChXZWJLaXQ6OkxheWVyVHJlZUNvbnRl eHQ6OmRlY29kZSk6CisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL0xheWVyVHJl ZUhvc3RNYWMuaDoKKyAgICAgICAgQWRkIHRoZSBsYXllciB0cmVlIGNvbnRleHQgYXMgYSBtZW1i ZXIgdmFyaWFibGUuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL0xheWVyVHJl ZUhvc3RNYWMubW06CisgICAgICAgIChXZWJLaXQ6OkxheWVyVHJlZUhvc3RNYWM6OkxheWVyVHJl ZUhvc3RNYWMpOgorICAgICAgICBJbml0aWFsaXplIHRoZSBsYXllciB0cmVlIGNvbnRleHQuCisK IDIwMTEtMDItMDMgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBGaXgg UXQgYnVpbGQuCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvTGF5ZXJUcmVlQ29udGV4dC5o Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9MYXllclRyZWVDb250ZXh0LmgJ KHJldmlzaW9uIDc3NTE3KQorKysgU291cmNlL1dlYktpdDIvU2hhcmVkL0xheWVyVHJlZUNvbnRl eHQuaAkod29ya2luZyBjb3B5KQpAQCAtNDAsMTIgKzQwLDE1IEBAIHB1YmxpYzoKICAgICBMYXll clRyZWVDb250ZXh0KCk7CiAgICAgfkxheWVyVHJlZUNvbnRleHQoKTsKIAorICAgIHN0YXRpYyBM YXllclRyZWVDb250ZXh0IG1ha2VXaXRoU2VlZCgpOworCiAgICAgdm9pZCBlbmNvZGUoQ29yZUlQ Qzo6QXJndW1lbnRFbmNvZGVyKikgY29uc3Q7CiAgICAgc3RhdGljIGJvb2wgZGVjb2RlKENvcmVJ UEM6OkFyZ3VtZW50RGVjb2RlciosIExheWVyVHJlZUNvbnRleHQmKTsKIAogICAgIGJvb2wgaXNF bXB0eSgpIGNvbnN0OwogCiAjaWYgUExBVEZPUk0oTUFDKQorICAgIHVpbnQ2NF90IHNlZWQ7CiAg ICAgdWludDMyX3QgY29udGV4dElEOwogI2VuZGlmCiB9OwpJbmRleDogU291cmNlL1dlYktpdDIv U2hhcmVkL21hYy9MYXllclRyZWVDb250ZXh0TWFjLm1tCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJLaXQyL1NoYXJlZC9tYWMvTGF5ZXJUcmVlQ29udGV4dE1hYy5tbQkocmV2aXNpb24gNzc1MTcp CisrKyBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvbWFjL0xheWVyVHJlZUNvbnRleHRNYWMubW0JKHdv cmtpbmcgY29weSkKQEAgLTMyLDcgKzMyLDggQEAKIG5hbWVzcGFjZSBXZWJLaXQgewogCiBMYXll clRyZWVDb250ZXh0OjpMYXllclRyZWVDb250ZXh0KCkKLSAgICA6IGNvbnRleHRJRCgwKQorICAg IDogc2VlZCgwKQorICAgICwgY29udGV4dElEKDApCiB7CiB9CiAKQEAgLTQwLDEzICs0MSwyNyBA QCBMYXllclRyZWVDb250ZXh0Ojp+TGF5ZXJUcmVlQ29udGV4dCgpCiB7CiB9CiAKK0xheWVyVHJl ZUNvbnRleHQgTGF5ZXJUcmVlQ29udGV4dDo6bWFrZVdpdGhTZWVkKCkgeworICAgIHN0YXRpYyB1 aW50NjRfdCBzZWVkOworCisgICAgTGF5ZXJUcmVlQ29udGV4dCBsYXllclRyZWVDb250ZXh0Owor ICAgIGxheWVyVHJlZUNvbnRleHQuc2VlZCA9ICsrc2VlZDsKKyAgICBBU1NFUlQobGF5ZXJUcmVl Q29udGV4dC5zZWVkKTsKKworICAgIHJldHVybiBsYXllclRyZWVDb250ZXh0OworfQorCiB2b2lk IExheWVyVHJlZUNvbnRleHQ6OmVuY29kZShDb3JlSVBDOjpBcmd1bWVudEVuY29kZXIqIGVuY29k ZXIpIGNvbnN0CiB7CisgICAgZW5jb2Rlci0+ZW5jb2RlKHNlZWQpOwogICAgIGVuY29kZXItPmVu Y29kZShjb250ZXh0SUQpOwogfQogCiBib29sIExheWVyVHJlZUNvbnRleHQ6OmRlY29kZShDb3Jl SVBDOjpBcmd1bWVudERlY29kZXIqIGRlY29kZXIsIExheWVyVHJlZUNvbnRleHQmIHJlc3VsdCkK IHsKKyAgICBpZiAoIWRlY29kZXItPmRlY29kZShyZXN1bHQuc2VlZCkpCisgICAgICAgIHJldHVy biBmYWxzZTsKKwogICAgIHJldHVybiBkZWNvZGVyLT5kZWNvZGUocmVzdWx0LmNvbnRleHRJRCk7 CiB9CiAKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvTGF5ZXJU cmVlSG9zdE1hYy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2Vi UGFnZS9tYWMvTGF5ZXJUcmVlSG9zdE1hYy5oCShyZXZpc2lvbiA3NzUxNykKKysrIFNvdXJjZS9X ZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvTGF5ZXJUcmVlSG9zdE1hYy5oCSh3b3JraW5n IGNvcHkpCkBAIC0yNiw2ICsyNiw3IEBACiAjaWZuZGVmIExheWVyVHJlZUhvc3RNYWNfaAogI2Rl ZmluZSBMYXllclRyZWVIb3N0TWFjX2gKIAorI2luY2x1ZGUgIkxheWVyVHJlZUNvbnRleHQuaCIK ICNpbmNsdWRlICJMYXllclRyZWVIb3N0LmgiCiAjaW5jbHVkZSA8V2ViQ29yZS9HcmFwaGljc0xh eWVyQ2xpZW50Lmg+CiAjaW5jbHVkZSA8d3RmL093blB0ci5oPgpAQCAtNTgsNyArNTksMTEgQEAg cHJpdmF0ZToKICAgICB2b2lkIGZsdXNoUGVuZGluZ0xheWVyQ2hhbmdlc1J1bkxvb3BPYnNlcnZl ckNhbGxiYWNrKCk7CiAgICAgYm9vbCBmbHVzaFBlbmRpbmdMYXllckNoYW5nZXMoKTsKIAotICAg IGJvb2wgbV9pc1ZhbGlkOworICAgIC8vIFRoZSBjb250ZXh0IGZvciB0aGlzIGxheWVyIHRyZWUu CisgICAgTGF5ZXJUcmVlQ29udGV4dCBtX2xheWVyVHJlZUNvbnRleHQ7CisKKyAgICAvLyBXaGV0 aGVyIHRoZSBsYXllciB0cmVlIGhvc3QgaXMgdmFsaWQgb3Igbm90LgorICAgIGJvb2wgbV9pc1Zh bGlkOyAgICAKIAogICAgIC8vIFRoZSByb290IGxheWVyLgogICAgIE93blB0cjxXZWJDb3JlOjpH cmFwaGljc0xheWVyPiBtX3Jvb3RMYXllcjsKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nl c3MvV2ViUGFnZS9tYWMvTGF5ZXJUcmVlSG9zdE1hYy5tbQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL0xheWVyVHJlZUhvc3RNYWMubW0JKHJldmlz aW9uIDc3NTE3KQorKysgU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9MYXll clRyZWVIb3N0TWFjLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0yNyw3ICsyNyw2IEBACiAjaW1wb3J0 ICJMYXllclRyZWVIb3N0TWFjLmgiCiAKICNpbXBvcnQgIkRyYXdpbmdBcmVhUHJveHlNZXNzYWdl cy5oIgotI2ltcG9ydCAiTGF5ZXJUcmVlQ29udGV4dC5oIgogI2ltcG9ydCAiV2ViUGFnZS5oIgog I2ltcG9ydCAiV2ViUHJvY2Vzcy5oIgogI2ltcG9ydCA8V2ViQ29yZS9GcmFtZS5oPgpAQCAtNDcs NiArNDYsNyBAQCBQYXNzUmVmUHRyPExheWVyVHJlZUhvc3RNYWM+IExheWVyVHJlZUhvCiAKIExh eWVyVHJlZUhvc3RNYWM6OkxheWVyVHJlZUhvc3RNYWMoV2ViUGFnZSogd2ViUGFnZSwgR3JhcGhp Y3NMYXllciogZ3JhcGhpY3NMYXllcikKICAgICA6IExheWVyVHJlZUhvc3Qod2ViUGFnZSkKKyAg ICAsIG1fbGF5ZXJUcmVlQ29udGV4dChMYXllclRyZWVDb250ZXh0OjptYWtlV2l0aFNlZWQoKSkK ICAgICAsIG1faXNWYWxpZCh0cnVlKQogewogICAgIG1hY2hfcG9ydF90IHNlcnZlclBvcnQgPSBX ZWJQcm9jZXNzOjpzaGFyZWQoKS5jb21wb3NpdGluZ1JlbmRlclNlcnZlclBvcnQoKTsKQEAgLTY3 LDExICs2NywxMCBAQCBMYXllclRyZWVIb3N0TWFjOjpMYXllclRyZWVIb3N0TWFjKFdlYlBhCiAK ICAgICBzY2hlZHVsZUxheWVyRmx1c2goKTsKIAotICAgIExheWVyVHJlZUNvbnRleHQgbGF5ZXJU cmVlQ29udGV4dDsKLSAgICBsYXllclRyZWVDb250ZXh0LmNvbnRleHRJRCA9IFdLQ0FSZW1vdGVM YXllckNsaWVudEdldENsaWVudElkKG1fcmVtb3RlTGF5ZXJDbGllbnQuZ2V0KCkpOworICAgIG1f bGF5ZXJUcmVlQ29udGV4dC5jb250ZXh0SUQgPSBXS0NBUmVtb3RlTGF5ZXJDbGllbnRHZXRDbGll bnRJZChtX3JlbW90ZUxheWVyQ2xpZW50LmdldCgpKTsKIAogICAgIC8vIEZJWE1FOiBEb24ndCBz ZW5kIHRoaXMgaWYgd2UgZW50ZXIgYWNjZWxlcmF0ZWQgY29tcG9zaXRpbmcgYXMgYSByZXN1bHQg b2Ygc2V0U2l6ZS4KLSAgICBtX3dlYlBhZ2UtPnNlbmQoTWVzc2FnZXM6OkRyYXdpbmdBcmVhUHJv eHk6OkVudGVyQWNjZWxlcmF0ZWRDb21wb3NpdGluZ01vZGUobGF5ZXJUcmVlQ29udGV4dCkpOwor ICAgIG1fd2ViUGFnZS0+c2VuZChNZXNzYWdlczo6RHJhd2luZ0FyZWFQcm94eTo6RW50ZXJBY2Nl bGVyYXRlZENvbXBvc2l0aW5nTW9kZShtX2xheWVyVHJlZUNvbnRleHQpKTsKIH0KIAogTGF5ZXJU cmVlSG9zdE1hYzo6fkxheWVyVHJlZUhvc3RNYWMoKQo=