53687 2011-02-03 09:33:26 -0800 [v8] Bail out if to string conversion returned empty handle 2011-02-03 21:04:33 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 antonm antonm commit-queue oldest_to_newest 344777 0 antonm 2011-02-03 09:33:26 -0800 [v8] Bail out if to string conversion returned empty handle 344791 1 81071 antonm 2011-02-03 09:46:41 -0800 Created attachment 81071 Patch 344808 2 81071 abarth 2011-02-03 10:16:49 -0800 Comment on attachment 81071 Patch Generally speaking, we'd rather fix the root cause of the issue that bandaid over it like this. Maybe add an ASSERT_NOT_REACHED to emphasize that it shouldn't happen? Ideally we'd remove this code once we fixed the underlying bug... 344817 3 81076 antonm 2011-02-03 10:24:16 -0800 Created attachment 81076 Patch 344820 4 antonm 2011-02-03 10:26:02 -0800 (In reply to comment #2) > (From update of attachment 81071 [details]) > Generally speaking, we'd rather fix the root cause of the issue that bandaid over it like this. Maybe add an ASSERT_NOT_REACHED to emphasize that it shouldn't happen? Ideally we'd remove this code once we fixed the underlying bug... Definitely. I've got something which looks pretty much like a reduction for the core problem, but it's pure v8 API test. I am starting to work on it immediately. When issue in v8 is fixed, we'll run automated test with v8 patch applied and this patch removed. If things go smooth, I'll revert this patch. And ASSERT added 344825 5 81076 antonm 2011-02-03 10:28:40 -0800 Comment on attachment 81076 Patch Thank you again, Adam. 345314 6 81076 commit-queue 2011-02-03 21:04:28 -0800 Comment on attachment 81076 Patch Clearing flags on attachment: 81076 Committed r77597: <http://trac.webkit.org/changeset/77597> 345315 7 commit-queue 2011-02-03 21:04:33 -0800 All reviewed patches have been landed. Closing bug. 81071 2011-02-03 09:46:41 -0800 2011-02-03 10:24:11 -0800 Patch bug-53687-20110203204640.patch text/plain 2825 antonm ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0ZTMwYjhlZDk4YTVmNmM2OTNkZjgyNmQ3ODk1Mzg3MzdhODhjYzdmLi4z MmY0YjVjNzRkMWZkZjM4MGJiNjJiNjljYWNlZDIxNzA5NjQ4NmMwIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMjQgQEAKKzIwMTEtMDItMDMgIEFudG9uIE11aGluICA8YW50b25tQGNocm9taXVtLm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbdjhd IEJhaWwgb3V0IGlmIHRvIHN0cmluZyBjb252ZXJzaW9uIHJldHVybmVkIGVtcHR5IGhhbmRsZQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTM2ODcKKwor ICAgICAgICBUaGlzIGEgdGVtcG9yYXJ5IG1lYXN1cmU6IGFjdHVhbGx5IG9uZSBwcm9iYWJseSBz aG91bGQgbmV2ZXIgZ2V0IGVtcHR5IGhhbmRsZQorICAgICAgICBpZiB0aGVyZSB3YXMgbm8gZXhj ZXB0aW9uLiAgVGhlIHJvb3QgY2F1c2UgaXMgdW5kZXIgaW52ZXN0aWdhdGlvbi4KKyAgICAgICAg VGhlIGJhaWxvdXQgdGhvdWdoIGFsbG93cyBDaHJvbWl1bSBub3QgdG8gY3Jhc2gtLS1hdHRlbXB0 IHRvIGNvbnZlcnQgYW4gZW1wdHkKKyAgICAgICAgdjggaGFuZGUgaW50byBXZWJDb3JlIHN0cmlu ZyBjcmFzaGVzIHdpdGggaW52YWxpZCBtZW1vcnkgYWNjZXNzLgorCisgICAgICAgIFNlZSBodHRw Oi8vY29kZS5nb29nbGUuY29tL3AvY2hyb21pdW0vaXNzdWVzL2RldGFpbD9pZD03MTU0NAorCisg ICAgICAgIFRoZXJlIGlzIG5vIGtub3duIHJlZHVjdGlvbiBleHByZXNzaWJsZSBhcyBhIGxheW91 dCB0ZXN0IHNvIGZhci4gIFRoZSBjcmFzaCBmb3VuZCB3aXRoIGF1dG9tYXRlZCB0ZXN0aW5nIHRv b2xzLgorCisgICAgICAgICogYmluZGluZ3MvdjgvVjhCaW5kaW5nLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OnY4Tm9uU3RyaW5nVmFsdWVUb1dlYkNvcmVTdHJpbmcpOiBCYWlsIG91dCBvbiBlbXB0 eSBoYW5kbGUKKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOEJpbmRpbmcuaDoKKyAgICAgICAgKFdl YkNvcmU6OlY4UGFyYW1ldGVyQmFzZTo6cHJlcGFyZUJhc2UpOiBEaXR0bworCiAyMDExLTAyLTAz ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmll d2VkIGJ5IFNhbSBXZWluaWcuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92 OC9WOEJpbmRpbmcuY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhCaW5kaW5nLmNw cAppbmRleCA0YWMwMGE1NTdiMjA3Yzc4N2ZmOGRjYWE2MjBlZWUyMjdmYjVkYzYzLi42ZTNkMTA0 OTliMTE5OTIyNjM0OTAzMWRiYTJjZGJlYzNmZTA0YjRlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy92OC9WOEJpbmRpbmcuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL3Y4L1Y4QmluZGluZy5jcHAKQEAgLTQxMyw2ICs0MTMsMTEgQEAgU3RyaW5nIHY4Tm9uU3Ry aW5nVmFsdWVUb1dlYkNvcmVTdHJpbmcodjg6OkhhbmRsZTx2ODo6VmFsdWU+IG9iamVjdCkKICAg ICAgICAgdGhyb3dFcnJvcihibG9jay5FeGNlcHRpb24oKSk7CiAgICAgICAgIHJldHVybiBTdHJp bmdJbXBsOjplbXB0eSgpOwogICAgIH0KKyAgICAvLyBUaGlzIHBhdGggaXMgdW5leHBlY3RlZC4g IEhvd2V2ZXIgdGhlcmUgaXMgaHlwb3RoZXNpcyB0aGF0IGl0CisgICAgLy8gbWlnaHQgYmUgY29t YmluYXRpb24gb2YgdjggYW5kIHY4IGJpbmRpbmdzIGJ1Z3MuICBGb3Igbm93CisgICAgLy8ganVz dCBiYWlsb3V0IGFzIHdlJ2xsIGNyYXNoIGlmIGF0dGVtcHQgdG8gY29udmVydCBlbXB0eSBoYW5k bGUgaW50byBhIHN0cmluZy4KKyAgICBpZiAodjhTdHJpbmcuSXNFbXB0eSgpKQorICAgICAgICBy ZXR1cm4gU3RyaW5nSW1wbDo6ZW1wdHkoKTsKICAgICByZXR1cm4gdjhTdHJpbmdUb1dlYkNvcmVT dHJpbmc8U3RyaW5nPih2OFN0cmluZywgRG9Ob3RFeHRlcm5hbGl6ZSk7CiB9CiAKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4QmluZGluZy5oIGIvU291cmNlL1dlYkNv cmUvYmluZGluZ3MvdjgvVjhCaW5kaW5nLmgKaW5kZXggZGY5MmI0OGM5YjMyNzA4YTYzYmNkZGEz Mzc2NmQ1NjUyMDhjMjFiYS4uZDQwMTI0ZDQ0ZThiMDExMzQ3ZjNkOGZiOTU5NDg3NTlmM2I0NzMz NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhCaW5kaW5nLmgKKysr IGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhCaW5kaW5nLmgKQEAgLTIzNiw2ICsyMzYs MTIgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICAgICAgICAgIHJldHVybiBmYWxzZTsK ICAgICAgICAgICAgIH0KIAorICAgICAgICAgICAgLy8gVGhpcyBwYXRoIGlzIHVuZXhwZWN0ZWQu ICBIb3dldmVyIHRoZXJlIGlzIGh5cG90aGVzaXMgdGhhdCBpdAorICAgICAgICAgICAgLy8gbWln aHQgYmUgY29tYmluYXRpb24gb2YgdjggYW5kIHY4IGJpbmRpbmdzIGJ1Z3MuICBGb3Igbm93Cisg ICAgICAgICAgICAvLyBqdXN0IGJhaWxvdXQgYXMgd2UnbGwgY3Jhc2ggaWYgYXR0ZW1wdCB0byBj b252ZXJ0IGVtcHR5IGhhbmRsZSBpbnRvIGEgc3RyaW5nLgorICAgICAgICAgICAgaWYgKG1fdjhP YmplY3QuSXNFbXB0eSgpKQorICAgICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKwogICAgICAg ICAgICAgcmV0dXJuIHRydWU7CiAgICAgICAgIH0KIAo= 81076 2011-02-03 10:24:16 -0800 2011-02-03 21:04:28 -0800 Patch bug-53687-20110203212414.patch text/plain 2921 antonm ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0ZTMwYjhlZDk4YTVmNmM2OTNkZjgyNmQ3ODk1Mzg3MzdhODhjYzdmLi4z MmY0YjVjNzRkMWZkZjM4MGJiNjJiNjljYWNlZDIxNzA5NjQ4NmMwIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMjQgQEAKKzIwMTEtMDItMDMgIEFudG9uIE11aGluICA8YW50b25tQGNocm9taXVtLm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbdjhd IEJhaWwgb3V0IGlmIHRvIHN0cmluZyBjb252ZXJzaW9uIHJldHVybmVkIGVtcHR5IGhhbmRsZQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTM2ODcKKwor ICAgICAgICBUaGlzIGEgdGVtcG9yYXJ5IG1lYXN1cmU6IGFjdHVhbGx5IG9uZSBwcm9iYWJseSBz aG91bGQgbmV2ZXIgZ2V0IGVtcHR5IGhhbmRsZQorICAgICAgICBpZiB0aGVyZSB3YXMgbm8gZXhj ZXB0aW9uLiAgVGhlIHJvb3QgY2F1c2UgaXMgdW5kZXIgaW52ZXN0aWdhdGlvbi4KKyAgICAgICAg VGhlIGJhaWxvdXQgdGhvdWdoIGFsbG93cyBDaHJvbWl1bSBub3QgdG8gY3Jhc2gtLS1hdHRlbXB0 IHRvIGNvbnZlcnQgYW4gZW1wdHkKKyAgICAgICAgdjggaGFuZGUgaW50byBXZWJDb3JlIHN0cmlu ZyBjcmFzaGVzIHdpdGggaW52YWxpZCBtZW1vcnkgYWNjZXNzLgorCisgICAgICAgIFNlZSBodHRw Oi8vY29kZS5nb29nbGUuY29tL3AvY2hyb21pdW0vaXNzdWVzL2RldGFpbD9pZD03MTU0NAorCisg ICAgICAgIFRoZXJlIGlzIG5vIGtub3duIHJlZHVjdGlvbiBleHByZXNzaWJsZSBhcyBhIGxheW91 dCB0ZXN0IHNvIGZhci4gIFRoZSBjcmFzaCBmb3VuZCB3aXRoIGF1dG9tYXRlZCB0ZXN0aW5nIHRv b2xzLgorCisgICAgICAgICogYmluZGluZ3MvdjgvVjhCaW5kaW5nLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OnY4Tm9uU3RyaW5nVmFsdWVUb1dlYkNvcmVTdHJpbmcpOiBCYWlsIG91dCBvbiBlbXB0 eSBoYW5kbGUKKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOEJpbmRpbmcuaDoKKyAgICAgICAgKFdl YkNvcmU6OlY4UGFyYW1ldGVyQmFzZTo6cHJlcGFyZUJhc2UpOiBEaXR0bworCiAyMDExLTAyLTAz ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmll d2VkIGJ5IFNhbSBXZWluaWcuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92 OC9WOEJpbmRpbmcuY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhCaW5kaW5nLmNw cAppbmRleCA0YWMwMGE1NTdiMjA3Yzc4N2ZmOGRjYWE2MjBlZWUyMjdmYjVkYzYzLi4yYWNkMjlh OGUxOGE3ODlmZGExODVjYzc2MDk1MzRjNWFkMjgyZjE3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy92OC9WOEJpbmRpbmcuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL3Y4L1Y4QmluZGluZy5jcHAKQEAgLTQxMyw2ICs0MTMsMTMgQEAgU3RyaW5nIHY4Tm9uU3Ry aW5nVmFsdWVUb1dlYkNvcmVTdHJpbmcodjg6OkhhbmRsZTx2ODo6VmFsdWU+IG9iamVjdCkKICAg ICAgICAgdGhyb3dFcnJvcihibG9jay5FeGNlcHRpb24oKSk7CiAgICAgICAgIHJldHVybiBTdHJp bmdJbXBsOjplbXB0eSgpOwogICAgIH0KKyAgICAvLyBUaGlzIHBhdGggaXMgdW5leHBlY3RlZC4g IEhvd2V2ZXIgdGhlcmUgaXMgaHlwb3RoZXNpcyB0aGF0IGl0CisgICAgLy8gbWlnaHQgYmUgY29t YmluYXRpb24gb2YgdjggYW5kIHY4IGJpbmRpbmdzIGJ1Z3MuICBGb3Igbm93CisgICAgLy8ganVz dCBiYWlsb3V0IGFzIHdlJ2xsIGNyYXNoIGlmIGF0dGVtcHQgdG8gY29udmVydCBlbXB0eSBoYW5k bGUgaW50byBhIHN0cmluZy4KKyAgICBpZiAodjhTdHJpbmcuSXNFbXB0eSgpKSB7CisgICAgICAg IEFTU0VSVF9OT1RfUkVBQ0hFRCgpOworICAgICAgICByZXR1cm4gU3RyaW5nSW1wbDo6ZW1wdHko KTsKKyAgICB9CiAgICAgcmV0dXJuIHY4U3RyaW5nVG9XZWJDb3JlU3RyaW5nPFN0cmluZz4odjhT dHJpbmcsIERvTm90RXh0ZXJuYWxpemUpOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy92OC9WOEJpbmRpbmcuaCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4 QmluZGluZy5oCmluZGV4IGRmOTJiNDhjOWIzMjcwOGE2M2JjZGRhMzM3NjZkNTY1MjA4YzIxYmEu Ljc4NzNiNTRlYjcwMDViZTc4Y2E1MjM4MWJiMTRiMTExNTFlZDIyNWIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4QmluZGluZy5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL3Y4L1Y4QmluZGluZy5oCkBAIC0yMzYsNiArMjM2LDE0IEBAIG5hbWVzcGFjZSBX ZWJDb3JlIHsKICAgICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgICAgICAgICB9CiAK KyAgICAgICAgICAgIC8vIFRoaXMgcGF0aCBpcyB1bmV4cGVjdGVkLiAgSG93ZXZlciB0aGVyZSBp cyBoeXBvdGhlc2lzIHRoYXQgaXQKKyAgICAgICAgICAgIC8vIG1pZ2h0IGJlIGNvbWJpbmF0aW9u IG9mIHY4IGFuZCB2OCBiaW5kaW5ncyBidWdzLiAgRm9yIG5vdworICAgICAgICAgICAgLy8ganVz dCBiYWlsb3V0IGFzIHdlJ2xsIGNyYXNoIGlmIGF0dGVtcHQgdG8gY29udmVydCBlbXB0eSBoYW5k bGUgaW50byBhIHN0cmluZy4KKyAgICAgICAgICAgIGlmIChtX3Y4T2JqZWN0LklzRW1wdHkoKSkg eworICAgICAgICAgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOworICAgICAgICAgICAgICAg IHJldHVybiBmYWxzZTsKKyAgICAgICAgICAgIH0KKwogICAgICAgICAgICAgcmV0dXJuIHRydWU7 CiAgICAgICAgIH0KIAo=