53671 2011-02-03 04:18:12 -0800 [Qt] WebKit2 needs to support font size changing and getting default font size 2011-03-01 08:39:34 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 0 juha.savolainen webkit-unassigned abarth commit-queue eric kenneth kling webkit.review.bot oldest_to_newest 344627 0 juha.savolainen 2011-02-03 04:18:12 -0800 QWKPreferences should support setting/getting default font sizes. 344628 1 81050 juha.savolainen 2011-02-03 04:25:59 -0800 Created attachment 81050 Added fontSize enum and methods to get/set default font sizes. 344654 2 kling 2011-02-03 05:51:13 -0800 Any reason we can't have the exact same API as WK1 QWebSettings setFontSize/fontSize? 344768 3 juha.savolainen 2011-02-03 09:26:14 -0800 (In reply to comment #2) > Any reason we can't have the exact same API as WK1 QWebSettings setFontSize/fontSize? Do you mean missing enum QWebSettings::MinimumLogicalFontSize? If yes, I didnt find any C-function for this and in WK1 there is the following description: The minimum logical font size that is applied when zooming out with QWebFrame::setTextSizeMultiplier(). And in WK2 we don't have frame API so that was the reason. But if I have understand something wrong or you have noticed something else, please correct me. 359782 4 juha.savolainen 2011-03-01 03:46:27 -0800 Andreas, could you clarify this a little? 359797 5 kling 2011-03-01 04:22:44 -0800 (In reply to comment #4) > Andreas, could you clarify this a little? Sorry, I completely forgot about this patch. It's fine as-is, r=me :) 359852 6 81050 commit-queue 2011-03-01 06:13:19 -0800 Comment on attachment 81050 Added fontSize enum and methods to get/set default font sizes. Clearing flags on attachment: 81050 Committed r79997: <http://trac.webkit.org/changeset/79997> 359853 7 commit-queue 2011-03-01 06:13:24 -0800 All reviewed patches have been landed. Closing bug. 359911 8 webkit.review.bot 2011-03-01 08:39:34 -0800 http://trac.webkit.org/changeset/79997 might have broken GTK Linux 32-bit Debug 81050 2011-02-03 04:25:59 -0800 2011-03-01 06:13:19 -0800 Added fontSize enum and methods to get/set default font sizes. fontsize.patch text/plain 2905 juha.savolainen SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDc3NDc0KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDItMDMgIEp1aGEgU2F2 b2xhaW5lbiAgPGp1aGEuc2F2b2xhaW5lbkB3ZWVnby5maT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIFdlYktpdDIgbmVlZHMgdG8gc3VwcG9y dCBmb250IHNpemUgY2hhbmdpbmcgYW5kIGdldHRpbmcgZGVmYXVsdCBmb250IHNpemUKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUzNjcxCisKKyAgICAg ICAgQWRkZWQgbmV3IGVudW0gZm9yIGZvbnQgc2l6ZSB0eXBlIGFuZCBhZGRlZCBtZXRob2RzIHRv IHNldCBhbmQgZ2V0IGRlZmF1bHQgZm9udCBzaXplcy4KKworICAgICAgICAqIFVJUHJvY2Vzcy9B UEkvcXQvcXdrcHJlZmVyZW5jZXMuY3BwOgorICAgICAgICAoUVdLUHJlZmVyZW5jZXM6OnNldEZv bnRTaXplKTogQWRkZWQuCisgICAgICAgIChRV0tQcmVmZXJlbmNlczo6Zm9udFNpemUpOiBBZGRl ZC4KKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL3F0L3F3a3ByZWZlcmVuY2VzLmg6CisKIDIwMTEt MDItMDMgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAg ICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHI3NzQ0OS4KSW5kZXg6IFNvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvcXQvcXdrcHJlZmVyZW5jZXMuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXdrcHJlZmVyZW5jZXMuY3BwCShyZXZpc2lvbiA3 NzQ3MykKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXdrcHJlZmVyZW5jZXMu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xODQsMyArMTg0LDM2IEBAIHZvaWQgUVdLUHJlZmVyZW5j ZXM6OnNldEF0dHJpYnV0ZShXZWJBdHQKICAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CiAg ICAgfQogfQorCit2b2lkIFFXS1ByZWZlcmVuY2VzOjpzZXRGb250U2l6ZShGb250U2l6ZSB0eXBl LCBpbnQgc2l6ZSkKK3sKKyAgICBzd2l0Y2ggKHR5cGUpIHsKKyAgICBjYXNlIE1pbmltdW1Gb250 U2l6ZToKKyAgICAgICAgIFdLUHJlZmVyZW5jZXNTZXRNaW5pbXVtRm9udFNpemUoZC0+cmVmLCBz aXplKTsKKyAgICAgICAgIGJyZWFrOworICAgIGNhc2UgRGVmYXVsdEZvbnRTaXplOgorICAgICAg ICAgV0tQcmVmZXJlbmNlc1NldERlZmF1bHRGb250U2l6ZShkLT5yZWYsIHNpemUpOworICAgICAg ICAgYnJlYWs7CisgICAgY2FzZSBEZWZhdWx0Rml4ZWRGb250U2l6ZToKKyAgICAgICAgIFdLUHJl ZmVyZW5jZXNTZXREZWZhdWx0Rml4ZWRGb250U2l6ZShkLT5yZWYsIHNpemUpOworICAgICAgICAg YnJlYWs7CisgICAgZGVmYXVsdDoKKyAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CisgICAg fQorfQorCitpbnQgUVdLUHJlZmVyZW5jZXM6OmZvbnRTaXplKEZvbnRTaXplIHR5cGUpIGNvbnN0 Cit7CisgICAgc3dpdGNoICh0eXBlKSB7CisgICAgY2FzZSBNaW5pbXVtRm9udFNpemU6CisgICAg ICAgICByZXR1cm4gV0tQcmVmZXJlbmNlc0dldE1pbmltdW1Gb250U2l6ZShkLT5yZWYpOworICAg IGNhc2UgRGVmYXVsdEZvbnRTaXplOgorICAgICAgICAgcmV0dXJuIFdLUHJlZmVyZW5jZXNHZXRE ZWZhdWx0Rm9udFNpemUoZC0+cmVmKTsKKyAgICBjYXNlIERlZmF1bHRGaXhlZEZvbnRTaXplOgor ICAgICAgICAgcmV0dXJuIFdLUHJlZmVyZW5jZXNHZXREZWZhdWx0Rml4ZWRGb250U2l6ZShkLT5y ZWYpOworICAgIGRlZmF1bHQ6CisgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOworICAgICAg ICByZXR1cm4gZmFsc2U7CisgICAgfQorfQorCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL3F0L3F3a3ByZWZlcmVuY2VzLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9xdC9xd2twcmVmZXJlbmNlcy5oCShyZXZpc2lvbiA3NzQ3MykKKysrIFNv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXdrcHJlZmVyZW5jZXMuaAkod29ya2luZyBj b3B5KQpAQCAtNDksNiArNDksMTIgQEAgcHVibGljOgogICAgICAgICBEbnNQcmVmZXRjaEVuYWJs ZWQKICAgICB9OwogCisgICAgZW51bSBGb250U2l6ZSB7CisgICAgICAgIE1pbmltdW1Gb250U2l6 ZSwKKyAgICAgICAgRGVmYXVsdEZvbnRTaXplLAorICAgICAgICBEZWZhdWx0Rml4ZWRGb250U2l6 ZQorICAgIH07CisKICAgICBzdGF0aWMgUVdLUHJlZmVyZW5jZXMqIHNoYXJlZFByZWZlcmVuY2Vz KCk7CiAKICAgICB2b2lkIHNldEZvbnRGYW1pbHkoRm9udEZhbWlseSB3aGljaCwgY29uc3QgUVN0 cmluZyYgZmFtaWx5KTsKQEAgLTU3LDYgKzYzLDkgQEAgcHVibGljOgogICAgIHZvaWQgc2V0QXR0 cmlidXRlKFdlYkF0dHJpYnV0ZSBhdHRyLCBib29sIG9uKTsKICAgICBib29sIHRlc3RBdHRyaWJ1 dGUoV2ViQXR0cmlidXRlIGF0dHIpIGNvbnN0OwogCisgICAgdm9pZCBzZXRGb250U2l6ZShGb250 U2l6ZSB0eXBlLCBpbnQgc2l6ZSk7CisgICAgaW50IGZvbnRTaXplKEZvbnRTaXplIHR5cGUpIGNv bnN0OworCiBwcml2YXRlOgogICAgIFFfRElTQUJMRV9DT1BZKFFXS1ByZWZlcmVuY2VzKQogCg==