5365 2005-10-13 04:23:01 -0700 QuickTime plugin keeps playing audio after being destroyed 2005-12-14 14:15:43 -0800 1 1 1 Unclassified WebKit Plug-ins 420+ Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 mitz cblu chris.giddings oldest_to_newest 21967 0 mitz 2005-10-13 04:23:01 -0700 Summary: The QuickTime plugin continues to play audio after the OBJECT or EMBED element containing it is removed from the page. To reproduce: 1) Open the testcase in Safari 2) As soon as audio starts, click the Remove OBJECT link 3) Close the window Expected: audio to stop in step 2 Actual: audio only stops in step 3 More information: when the OBJECT element is removed, QWidget::removeFromSuperview() is called, which sends -removeFromSuperview on the plugin's NSView. In WebNetscapePluginView, this stops the plugin. In the QuickTime plugin, it does not. The view is only deallocated when the window is closed, and then audio stops. 21968 1 4340 mitz 2005-10-13 04:25:31 -0700 Created attachment 4340 testcase (uses external resource) 22092 2 4360 mitz 2005-10-14 09:09:31 -0700 Created attachment 4360 stop and destroy plugin when removed Send -webPlugInStop (or -pluginStop) and -webPluginDestroy (or -pluginDestroy) to complying plugins right when they're removed from the WebHTMLView, and also release them from the plugin controller's arrays. I think this patch makes WebKit behave more like plugins expect it to, which is the way it already behaves with Netscape plugins. I expect complying plugins to stop making noise when receiving the stop message, but QuickTime doesn't. If it's lucky, then it will be deallocated because of the release and will stop then. However, JS, for one, can retain the plugin (e.g. if you execute <javascript:document.getElementById('obj').width;> before clicking Remove OBJECT), in which case it will just keep playing. 22194 3 4360 hyatt 2005-10-17 20:44:18 -0700 Comment on attachment 4360 stop and destroy plugin when removed r=me 22829 4 mitz 2005-10-24 13:14:58 -0700 Tim Omernick landed the patch. 25977 5 mitz 2005-12-14 14:15:43 -0800 *** Bug 6082 has been marked as a duplicate of this bug. *** 4340 2005-10-13 04:25:31 -0700 2005-10-13 04:25:31 -0700 testcase (uses external resource) QTAudioContinues.html text/html 947 mitz PGh0bWw+PGhlYWQ+PHRpdGxlPlF1aWNrVGltZSBhdWRpbyBjb250aW51ZXMgYWZ0ZXIgT0JKRUNU IHJlbW92YWw8L3RpdGxlPjwvaGVhZD4KPGJvZHk+CjxkaXYgaWQ9ImZlUGxhY2VIb2xkZXIiPgo8 b2JqZWN0IGlkPSJvYmoiIGNsYXNzaWQ9Y2xzaWQ6MDJCRjI1RDUtOEMxNy00QjIzLUJDODAtRDM0 ODhBQkREQzZCIGNvZGViYXNlPSJodHRwOi8vd3d3LmFwcGxlLmNvbS9xdGFjdGl2ZXgvcXRwbHVn aW4uY2FiIiB3aWR0aD00MDAgaGVpZ2h0PTI1MD4KPHBhcmFtIG5hbWU9ImNhY2hlIiB2YWx1ZT10 cnVlPgo8cGFyYW0gbmFtZT0iZW5hYmxlamF2YXNjcmlwdCIgdmFsdWU9ZmFsc2U+CjxwYXJhbSBp ZD0ic3JjIiBuYW1lPSJzcmMiIHZhbHVlPSJodHRwOi8vd3d3LmZyZWVwbGF5bXVzaWMuY29tL3Nl YXJjaC9kb3dubG9hZF9wcmV2aWV3L2lkLzIxL2R1ci8xNS90eXBlL21wMy9tc2hhY2svZnBtcHJl dmlldy5tcDMiPgo8cGFyYW0gbmFtZT0iYXV0b3BsYXkiIHZhbHVlPXRydWU+CjxwYXJhbSBuYW1l PSJjb250cm9sbGVyIiB2YWx1ZT10cnVlPgo8L29iamVjdD4KPC9kaXY+CjxhIGhyZWY9ImphdmFz Y3JpcHQ6ZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2ZlUGxhY2VIb2xkZXInKS5yZW1vdmVDaGls ZChkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnb2JqJykpOyI+UmVtb3ZlIE9CSkVDVDwvYT4KPGEg aHJlZj0iamF2YXNjcmlwdDpkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnc3JjJykucGFyZW50Tm9k ZS5yZW1vdmVDaGlsZChkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnc3JjJykpOyI+UmVtb3ZlIHNy YzwvYT4KPGEgaHJlZj0iamF2YXNjcmlwdDpkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnZmVQbGFj ZUhvbGRlcicpLmlubmVySFRNTCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdmZVBsYWNlSG9s ZGVyJykuaW5uZXJIVE1MOyI+TW9yZSE8L2E+CjwvYm9keT4= 4360 2005-10-14 09:09:31 -0700 2005-10-17 20:44:18 -0700 stop and destroy plugin when removed 5365_r1.patch text/plain 2511 mitz SW5kZXg6IFBsdWdpbnMuc3VicHJvai9XZWJQbHVnaW5Db250cm9sbGVyLmgKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpS Q1MgZmlsZTogL2N2cy9yb290L1dlYktpdC9QbHVnaW5zLnN1YnByb2ovV2ViUGx1Z2luQ29udHJv bGxlci5oLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjE0CmRpZmYgLXAgLXUgLXIxLjE0IFdlYlBs dWdpbkNvbnRyb2xsZXIuaAotLS0gUGx1Z2lucy5zdWJwcm9qL1dlYlBsdWdpbkNvbnRyb2xsZXIu aAk1IEp1biAyMDA1IDE3OjU0OjM1IC0wMDAwCTEuMTQKKysrIFBsdWdpbnMuc3VicHJvai9XZWJQ bHVnaW5Db250cm9sbGVyLmgJMTQgT2N0IDIwMDUgMTU6NTY6MTkgLTAwMDAKQEAgLTQ3LDYgKzQ3 LDcgQEAKIC0gKGlkKWluaXRXaXRoRG9jdW1lbnRWaWV3OihOU1ZpZXcgKil2aWV3OwogCiAtICh2 b2lkKWFkZFBsdWdpbjooTlNWaWV3ICopdmlldzsKKy0gKHZvaWQpZGVzdHJveVBsdWdpbjooTlNW aWV3ICopdmlldzsKIAogLSAodm9pZClzdGFydEFsbFBsdWdpbnM7CiAtICh2b2lkKXN0b3BBbGxQ bHVnaW5zOwpJbmRleDogUGx1Z2lucy5zdWJwcm9qL1dlYlBsdWdpbkNvbnRyb2xsZXIubQo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Jvb3QvV2ViS2l0L1BsdWdpbnMuc3VicHJvai9XZWJQbHVn aW5Db250cm9sbGVyLm0sdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuNDQKZGlmZiAtcCAtdSAtcjEu NDQgV2ViUGx1Z2luQ29udHJvbGxlci5tCi0tLSBQbHVnaW5zLnN1YnByb2ovV2ViUGx1Z2luQ29u dHJvbGxlci5tCTUgSnVuIDIwMDUgMTc6NTQ6MzUgLTAwMDAJMS40NAorKysgUGx1Z2lucy5zdWJw cm9qL1dlYlBsdWdpbkNvbnRyb2xsZXIubQkxNCBPY3QgMjAwNSAxNTo1NjoyMCAtMDAwMApAQCAt MTc4LDYgKzE3OCwyNiBAQCBzdGF0aWMgTlNNdXRhYmxlU2V0ICpwbHVnaW5WaWV3cyA9IG5pbDsK ICAgICB9CiB9CiAKKy0gKHZvaWQpZGVzdHJveVBsdWdpbjooTlNWaWV3ICopdmlldworeworICAg IGlmIChbX3ZpZXdzIGNvbnRhaW5zT2JqZWN0OnZpZXddKSB7CisgICAgICAgIGlmIChfc3RhcnRl ZCkgeworICAgICAgICAgICAgaWYgKFt2aWV3IHJlc3BvbmRzVG9TZWxlY3RvcjpAc2VsZWN0b3Io d2ViUGx1Z0luU3RvcCldKQorICAgICAgICAgICAgICAgIFt2aWV3IHdlYlBsdWdJblN0b3BdOwor ICAgICAgICAgICAgZWxzZSBpZiAoW3ZpZXcgcmVzcG9uZHNUb1NlbGVjdG9yOkBzZWxlY3Rvcihw bHVnaW5TdG9wKV0pCisgICAgICAgICAgICAgICAgW3ZpZXcgcGx1Z2luU3RvcF07CisgICAgICAg ICAgICB9CisgICAgICAgIAorICAgICAgICBpZiAoW3ZpZXcgcmVzcG9uZHNUb1NlbGVjdG9yOkBz ZWxlY3Rvcih3ZWJQbHVnSW5EZXN0cm95KV0pCisgICAgICAgICAgICBbdmlldyB3ZWJQbHVnSW5E ZXN0cm95XTsKKyAgICAgICAgZWxzZSBpZiAoW3ZpZXcgcmVzcG9uZHNUb1NlbGVjdG9yOkBzZWxl Y3RvcihwbHVnaW5EZXN0cm95KV0pCisgICAgICAgICAgICBbdmlldyBwbHVnaW5EZXN0cm95XTsK KyAgICAgICAgCisgICAgICAgIFtwbHVnaW5WaWV3cyByZW1vdmVPYmplY3Q6dmlld107CisgICAg ICAgIFtfdmlld3MgcmVtb3ZlT2JqZWN0OnZpZXddOworICAgIH0KK30KKwogLSAodm9pZClfd2Vi UGx1Z2luQ29udGFpbmVyQ2FuY2VsQ2hlY2tJZkFsbG93ZWRUb0xvYWRSZXF1ZXN0OihpZCljaGVj a0lkZW50aWZpZXIKIHsKICAgICBbY2hlY2tJZGVudGlmaWVyIGNhbmNlbF07CkluZGV4OiBXZWJW aWV3LnN1YnByb2ovV2ViSFRNTFZpZXcubQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Jvb3Qv V2ViS2l0L1dlYlZpZXcuc3VicHJvai9XZWJIVE1MVmlldy5tLHYKcmV0cmlldmluZyByZXZpc2lv biAxLjQ3NgpkaWZmIC1wIC11IC1yMS40NzYgV2ViSFRNTFZpZXcubQotLS0gV2ViVmlldy5zdWJw cm9qL1dlYkhUTUxWaWV3Lm0JMTMgT2N0IDIwMDUgMTk6Mzc6MzEgLTAwMDAJMS40NzYKKysrIFdl YlZpZXcuc3VicHJvai9XZWJIVE1MVmlldy5tCTE0IE9jdCAyMDA1IDE1OjU2OjE5IC0wMDAwCkBA IC0yMTY5LDYgKzIxNjksMTMgQEAgc3RhdGljIFdlYkhUTUxWaWV3ICpsYXN0SGl0VmlldyA9IG5p bDsKICAgICB9CiB9CiAKKy0gKHZvaWQpd2lsbFJlbW92ZVN1YnZpZXc6KE5TVmlldyAqKXN1YnZp ZXcKK3sKKyAgICBpZiAoW1dlYlBsdWdpbkNvbnRyb2xsZXIgaXNQbHVnSW5WaWV3OnN1YnZpZXdd KQorICAgICAgICBbW3NlbGYgX3BsdWdpbkNvbnRyb2xsZXJdIGRlc3Ryb3lQbHVnaW46c3Vidmll d107CisgICAgW3N1cGVyIHdpbGxSZW1vdmVTdWJ2aWV3OnN1YnZpZXddOworfQorCiAtICh2b2lk KXJlYXBwbHlTdHlsZXMKIHsKICAgICBpZiAoIV9wcml2YXRlLT5uZWVkc1RvQXBwbHlTdHlsZXMp IHsK