53647 2011-02-02 17:02:28 -0800 [GTK] Need support for dumping focus rectangles in pixel results 2011-04-18 20:51:28 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P3 Normal --- 1 mrobinson webkit-unassigned zan oldest_to_newest 344429 0 mrobinson 2011-02-02 17:02:28 -0800 Pixel results do not dump focus rectangles. A prime example of a test that requires this is /editing/selection/transformed-selection-rects-expected.png. 377909 1 zan 2011-04-01 10:39:59 -0700 This test successfully passes with a release 64-bit build at revision 82691. Also the focus rectangle seems to be properly shown when running pixel tests. Are there any issues with this test in debug builds or should we try unskipping it? 377998 2 mrobinson 2011-04-01 12:55:57 -0700 (In reply to comment #1) > This test successfully passes with a release 64-bit build at revision 82691. Also the focus rectangle seems to be properly shown when running pixel tests. > > Are there any issues with this test in debug builds or should we try unskipping it? I think it's still missing the red rectangle. Compare the results: a. LayoutTests/platform/gtk/editing/selection/transformed-selection-rects-expected.png b. LayoutTests/platform/mac/editing/selection/transformed-selection-rects-expected.png b. LayoutTests/platform/chromium-win/editing/selection/transformed-selection-rects-expected.png 387247 3 89923 zan 2011-04-16 03:56:21 -0700 Created attachment 89923 Patch 387249 4 zan 2011-04-16 04:01:16 -0700 (In reply to comment #3) > Created an attachment (id=89923) [details] > Patch This patch adds support for dumping selection rectangle. The pixel results for editing/selection/transformed-selection-rects.html now have a proper red rectangle around the area of the selection. Grepping through the LayoutTests directory, these tests seem to utilize this functionality and should have their expected pixel results regenerated: editing/selection/4402375.html editing/selection/image-before-linebreak.html editing/selection/replaced-boundaries-1.html editing/selection/replaced-boundaries-2.html editing/selection/replaced-boundaries-3.html editing/selection/transformed-selection-rects.html svg/text/foreignObject-text-clipping-bug.xml svg/text/selection-doubleclick.svg svg/text/selection-tripleclick.svg svg/text/text-align-01-b.svg svg/text/text-align-02-b.svg svg/text/text-align-03-b.svg svg/text/text-align-04-b.svg svg/text/text-align-05-b.svg svg/text/text-align-06-b.svg svg/text/text-altglyph-01-b.svg svg/text/text-deco-01-b.svg svg/text/text-fonts-01-t.svg svg/text/text-fonts-02-t.svg svg/text/text-intro-05-t.svg svg/text/text-path-01-b.svg svg/text/text-spacing-01-b.svg svg/text/text-text-01-b.svg svg/text/text-text-03-b.svg svg/text/text-text-04-t.svg svg/text/text-text-05-t.svg svg/text/text-text-06-t.svg svg/text/text-text-07-t.svg svg/text/text-text-08-b.svg svg/text/text-tref-01-b.svg svg/text/text-tselect-01-b.svg svg/text/text-tselect-02-f.svg svg/text/text-tspan-01-b.svg svg/text/text-ws-01-t.svg svg/text/text-ws-02-t.svg svg/text/textPathBoundsBug.svg 387747 5 89923 mrobinson 2011-04-18 08:45:56 -0700 Comment on attachment 89923 Patch Great. I will land this and generate the results. 388272 6 mrobinson 2011-04-18 20:51:28 -0700 Committed r84221: <http://trac.webkit.org/changeset/84221> 89923 2011-04-16 03:56:21 -0700 2011-04-18 08:45:56 -0700 Patch bug-53647-20110416125619.patch text/plain 5135 zan U3VidmVyc2lvbiBSZXZpc2lvbjogODQwODcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3Rr L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwppbmRleCBhNTkzYTc0YWU2 MGNmNDg0N2QzODQ0NzFjOTY2MTcwZjJiZDliODUyLi41ODY0ZjlhN2FkOTQ4NjgyN2UwYjIxNWE3 Mjc4ZThkZDYyOThkMTYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEt MDQtMTYgIFphbiBEb2JlcnNlayAgPHphbmRvYmVyc2VrQGdtYWlsLmNvbT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR1RLXSBOZWVkIHN1cHBvcnQg Zm9yIGR1bXBpbmcgZm9jdXMgcmVjdGFuZ2xlcyBpbiBwaXhlbCByZXN1bHRzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MzY0NworCisgICAgICAgIEFk ZCBhIHN1cHBvcnQgZnVuY3Rpb24gdGhhdCByZXR1cm5zIHRoZSByZWN0YW5nbGUgb2YgdGhlIGN1 cnJlbnQKKyAgICAgICAgc2VsZWN0aW9uIGluIGZyYW1lLgorCisgICAgICAgICogV2ViQ29yZVN1 cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0R3RrLmNwcDoKKyAgICAgICAgKER1bXBSZW5kZXJU cmVlU3VwcG9ydEd0azo6cmVjdGFuZ2xlRm9yU2VsZWN0aW9uKToKKyAgICAgICAgKiBXZWJDb3Jl U3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRHdGsuaDoKKwogMjAxMS0wNC0xMiAgWGFuIExv cGV6ICA8eGxvcGV6QGlnYWxpYS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCBidWlsZCBmaXgu CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVy VHJlZVN1cHBvcnRHdGsuY3BwIGIvU291cmNlL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRHVt cFJlbmRlclRyZWVTdXBwb3J0R3RrLmNwcAppbmRleCBjZmRlYjI2MmRmZjE3NDAwZWRjMDRmMTAz YzdhMTViNDUyOWE3MjdmLi4xY2UwYWRhNzMzODc3OTllYzkzNDZhNzI5ZTU5MWE0MmE4NzY2MDkz IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVy VHJlZVN1cHBvcnRHdGsuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0 L0R1bXBSZW5kZXJUcmVlU3VwcG9ydEd0ay5jcHAKQEAgLTc0OCwzICs3NDgsMTYgQEAgdm9pZCBE dW1wUmVuZGVyVHJlZVN1cHBvcnRHdGs6OnNldFZhbHVlRm9yVXNlcihKU0NvbnRleHRSZWYgY29u dGV4dCwgSlNWYWx1ZVJlZgogICAgIEpTU3RyaW5nR2V0VVRGOENTdHJpbmcodmFsdWUsIHZhbHVl QnVmZmVyLmdldCgpLCBidWZmZXJTaXplKTsKICAgICBpbnB1dEVsZW1lbnQtPnNldFZhbHVlRm9y VXNlcihTdHJpbmc6OmZyb21VVEY4KHZhbHVlQnVmZmVyLmdldCgpKSk7CiB9CisKK3ZvaWQgRHVt cFJlbmRlclRyZWVTdXBwb3J0R3RrOjpyZWN0YW5nbGVGb3JTZWxlY3Rpb24oV2ViS2l0V2ViRnJh bWUqIGZyYW1lLCBHZGtSZWN0YW5nbGUqIHJlY3RhbmdsZSkKK3sKKyAgICBGcmFtZSogY29yZUZy YW1lID0gY29yZShmcmFtZSk7CisgICAgaWYgKCFjb3JlRnJhbWUpCisgICAgICAgIHJldHVybjsK KworICAgIEludFJlY3QgYm91bmRzID0gZW5jbG9zaW5nSW50UmVjdChjb3JlRnJhbWUtPnNlbGVj dGlvbigpLT5ib3VuZHMoKSk7CisgICAgcmVjdGFuZ2xlLT54ID0gYm91bmRzLngoKTsKKyAgICBy ZWN0YW5nbGUtPnkgPSBib3VuZHMueSgpOworICAgIHJlY3RhbmdsZS0+d2lkdGggPSBib3VuZHMu d2lkdGgoKTsKKyAgICByZWN0YW5nbGUtPmhlaWdodCA9IGJvdW5kcy5oZWlnaHQoKTsKK30KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVl U3VwcG9ydEd0ay5oIGIvU291cmNlL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRl clRyZWVTdXBwb3J0R3RrLmgKaW5kZXggOTU2YWQ2OWU3Y2IxNTg4MzJjMTFmYzcxZDEyNDNkZDJi MmQ3ZGFlYS4uNzczMTc5ODZiODE1NWZjYTZhZTg3MzlhYzY3YTdkM2ZkNGIyZjEzZSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBw b3J0R3RrLmgKKysrIGIvU291cmNlL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRl clRyZWVTdXBwb3J0R3RrLmgKQEAgLTk4LDYgKzk4LDcgQEAgcHVibGljOgogICAgIHN0YXRpYyBi b29sIHNlbGVjdGVkUmFuZ2UoV2ViS2l0V2ViVmlldyosIGludCogc3RhcnQsIGludCogZW5kKTsK ICAgICBzdGF0aWMgZG91YmxlIGRlZmF1bHRNaW5pbXVtVGltZXJJbnRlcnZhbCgpOyAvLyBOb3Qg cmVhbGx5IHRpZWQgdG8gV2ViVmlldwogICAgIHN0YXRpYyB2b2lkIHNldE1pbmltdW1UaW1lcklu dGVydmFsKFdlYktpdFdlYlZpZXcqLCBkb3VibGUpOworICAgIHN0YXRpYyB2b2lkIHJlY3Rhbmds ZUZvclNlbGVjdGlvbihXZWJLaXRXZWJGcmFtZSosIEdka1JlY3RhbmdsZSopOwogCiAgICAgLy8g QWNjZXNzaWJpbGl0eQogICAgIHN0YXRpYyB2b2lkIGluY3JlbWVudEFjY2Vzc2liaWxpdHlWYWx1 ZShBdGtPYmplY3QqKTsKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5n ZUxvZwppbmRleCBkODA4Mjc2MDdkZDYxZjdjMmJhYjNmNzllMmFiMWZjMWRhMDc3NjJhLi4wMTlh OWExMzBjYWFhZmZlZDBhMTQ4Y2Y5N2YxYWY5ODg0MTZmM2ZiIDEwMDY0NAotLS0gYS9Ub29scy9D aGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDQt MTYgIFphbiBEb2JlcnNlayAgPHphbmRvYmVyc2VrQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR1RLXSBOZWVkIHN1cHBvcnQgZm9y IGR1bXBpbmcgZm9jdXMgcmVjdGFuZ2xlcyBpbiBwaXhlbCByZXN1bHRzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MzY0NworCisgICAgICAgIER1bXAg dGhlIHNlbGVjdGlvbiByZWN0IGlmIGl0IGhhcyBiZWVuIHJlcXVlc3RlZC4KKworICAgICAgICAq IER1bXBSZW5kZXJUcmVlL2d0ay9QaXhlbER1bXBTdXBwb3J0R3RrLmNwcDoKKyAgICAgICAgKGNy ZWF0ZUJpdG1hcENvbnRleHRGcm9tV2ViVmlldyk6CisKIDIwMTEtMDQtMTYgIE9qYW4gVmFmYWkg IDxvamFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4K ZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9QaXhlbER1bXBTdXBwb3J0R3Rr LmNwcCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9QaXhlbER1bXBTdXBwb3J0R3RrLmNwcApp bmRleCAxZTU5MWJiODZmODhkZWVkN2IwZDM5YzdiMDU5MzdmZGExZmZmOTYyLi4yYmQ4ZmUyYTFk NGE1NzFiZmY5YmNmZjYwMDk4ZTI4ODQ4MDU1OTFhIDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVu ZGVyVHJlZS9ndGsvUGl4ZWxEdW1wU3VwcG9ydEd0ay5jcHAKKysrIGIvVG9vbHMvRHVtcFJlbmRl clRyZWUvZ3RrL1BpeGVsRHVtcFN1cHBvcnRHdGsuY3BwCkBAIC0zMiw5ICszMiwxMCBAQAogI2lu Y2x1ZGUgIkR1bXBSZW5kZXJUcmVlLmgiCiAjaW5jbHVkZSAiR3RrVmVyc2lvbmluZy5oIgogI2lu Y2x1ZGUgIlBpeGVsRHVtcFN1cHBvcnRDYWlyby5oIgorI2luY2x1ZGUgIldlYkNvcmVTdXBwb3J0 L0R1bXBSZW5kZXJUcmVlU3VwcG9ydEd0ay5oIgogI2luY2x1ZGUgPHdlYmtpdC93ZWJraXQuaD4K IAotUGFzc1JlZlB0cjxCaXRtYXBDb250ZXh0PiBjcmVhdGVCaXRtYXBDb250ZXh0RnJvbVdlYlZp ZXcoYm9vbCwgYm9vbCwgYm9vbCwgYm9vbCkKK1Bhc3NSZWZQdHI8Qml0bWFwQ29udGV4dD4gY3Jl YXRlQml0bWFwQ29udGV4dEZyb21XZWJWaWV3KGJvb2wsIGJvb2wsIGJvb2wsIGJvb2wgZHJhd1Nl bGVjdGlvblJlY3QpCiB7CiAgICAgV2ViS2l0V2ViVmlldyogdmlldyA9IHdlYmtpdF93ZWJfZnJh bWVfZ2V0X3dlYl92aWV3KG1haW5GcmFtZSk7CiAgICAgR3RrV2lkZ2V0KiB2aWV3Q29udGFpbmVy ID0gZ3RrX3dpZGdldF9nZXRfcGFyZW50KEdUS19XSURHRVQodmlldykpOwpAQCAtNDksNiArNTAs NyBAQCBQYXNzUmVmUHRyPEJpdG1hcENvbnRleHQ+IGNyZWF0ZUJpdG1hcENvbnRleHRGcm9tV2Vi Vmlldyhib29sLCBib29sLCBib29sLCBib29sKQogCiAgICAgY2Fpcm9fc3VyZmFjZV90KiBpbWFn ZVN1cmZhY2UgPSBjYWlyb19pbWFnZV9zdXJmYWNlX2NyZWF0ZShDQUlST19GT1JNQVRfQVJHQjMy LCB3aWR0aCwgaGVpZ2h0KTsKICAgICBjYWlyb190KiBjb250ZXh0ID0gY2Fpcm9fY3JlYXRlKGlt YWdlU3VyZmFjZSk7CisKICNpZmRlZiBHVEtfQVBJX1ZFUlNJT05fMgogICAgIGdka19jYWlyb19z ZXRfc291cmNlX3BpeG1hcChjb250ZXh0LCBwaXhtYXAsIDAsIDApOwogICAgIGNhaXJvX3BhaW50 KGNvbnRleHQpOwpAQCAtNTcsNSArNTksMTUgQEAgUGFzc1JlZlB0cjxCaXRtYXBDb250ZXh0PiBj cmVhdGVCaXRtYXBDb250ZXh0RnJvbVdlYlZpZXcoYm9vbCwgYm9vbCwgYm9vbCwgYm9vbCkKICAg ICBndGtfd2lkZ2V0X2RyYXcodmlld0NvbnRhaW5lciwgY29udGV4dCk7CiAjZW5kaWYKIAorICAg IGlmIChkcmF3U2VsZWN0aW9uUmVjdCkgeworICAgICAgICBHZGtSZWN0YW5nbGUgcmVjdGFuZ2xl OworICAgICAgICBEdW1wUmVuZGVyVHJlZVN1cHBvcnRHdGs6OnJlY3RhbmdsZUZvclNlbGVjdGlv bihtYWluRnJhbWUsICZyZWN0YW5nbGUpOworCisgICAgICAgIGNhaXJvX3NldF9saW5lX3dpZHRo KGNvbnRleHQsIDEuMCk7CisgICAgICAgIGNhaXJvX3JlY3RhbmdsZShjb250ZXh0LCByZWN0YW5n bGUueCwgcmVjdGFuZ2xlLnksIHJlY3RhbmdsZS53aWR0aCwgcmVjdGFuZ2xlLmhlaWdodCk7Cisg ICAgICAgIGNhaXJvX3NldF9zb3VyY2VfcmdiYShjb250ZXh0LCAxLjAsIDAuMCwgMC4wLCAxLjAp OworICAgICAgICBjYWlyb19zdHJva2UoY29udGV4dCk7CisgICAgfQorCiAgICAgcmV0dXJuIEJp dG1hcENvbnRleHQ6OmNyZWF0ZUJ5QWRvcHRpbmdCaXRtYXBBbmRDb250ZXh0KDAsIGNvbnRleHQp OwogfQo=