53633 2011-02-02 15:34:01 -0800 gl-teximage.html failing on some WebKit bots 2011-02-02 19:02:00 -0800 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) Mac OS X 10.6 RESOLVED FIXED P2 Normal --- 1 kbr kbr cmarrin eric jamesr mihaip zmo oldest_to_newest 344312 0 kbr 2011-02-02 15:34:01 -0800 The layout test fast/canvas/webgl/gl-teximage.html, in particular the indexed PNG test added in https://bugs.webkit.org/show_bug.cgi?id=47477 , is failing on some WebKit bots. The issue appears to be that the color profile of the display is affecting the color of the PNG uploaded to WebGL. Mihai points out that when DRT runs pixel tests (see in particular Tools/DumpRenderTree/mac/PixelDumpSupportMac.mm, setupMainDisplayColorProfile) it loads a specific color profile for consistency of the results. This isn't occurring when running the WebGL layout tests. This test loads and tests several other PNGs without trouble. I suspect that by stripping gamma and other colorspace information from this particular PNG that we can get consistent enough results without changing DRT to load a particular color profile even when not running pixel tests. 344318 1 80982 kbr 2011-02-02 15:38:45 -0800 Created attachment 80982 Patch 344484 2 kbr 2011-02-02 19:02:00 -0800 Committed r77458: <http://trac.webkit.org/changeset/77458> 80982 2011-02-02 15:38:45 -0800 2011-02-02 15:44:19 -0800 Patch bug-53633-20110202153844.patch text/plain 2532 kbr SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDc3NDI3KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDItMDIgIEtlbm5ldGggUnVzc2VsbCAg PGtickBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIGdsLXRleGltYWdlLmh0bWwgZmFpbGluZyBvbiBzb21lIFdlYktpdCBib3RzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MzYzMworCisg ICAgICAgICogZmFzdC9jYW52YXMvd2ViZ2wvZ2wtdGV4aW1hZ2UuaHRtbDoKKyAgICAgICAgICAt IFN5bmNlZCB3aXRoIHVwc3RyZWFtIHRlc3Q7IGRldGVjdCB3aGVuIHJ1bm5pbmcgaW4gRFJUIGFu ZAorICAgICAgICAgICAgYXZvaWQgcHJpbnRpbmcgdGhlIHNwZWNpZmljIHBpeGVsIHZhbHVlIHdo ZW4gdGhlIHRlc3Qgd2lsbCBwYXNzLgorICAgICAgICAqIGZhc3QvY2FudmFzL3dlYmdsL3Jlc291 cmNlcy9yZWQtaW5kZXhlZC5wbmc6CisgICAgICAgICAgLSBTdHJpcHBlZCBnYW1tYSBhbmQgb3Ro ZXIgY29sb3JzcGFjZSBpbmZvcm1hdGlvbi4KKwogMjAxMS0wMi0wMiAgWmhlbnlhbyBNbyAgPHpt b0Bnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGggUnVzc2VsbC4KSW5k ZXg6IExheW91dFRlc3RzL2Zhc3QvY2FudmFzL3dlYmdsL2dsLXRleGltYWdlLmh0bWwKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvd2ViZ2wvZ2wtdGV4aW1hZ2UuaHRtbAko cmV2aXNpb24gNzc0MTEpCisrKyBMYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy93ZWJnbC9nbC10ZXhp bWFnZS5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC04NiwxOCArODYsMjIgQEAgZnVuY3Rpb24gcnVu VGVzdHMoaW1ncykgewogICAgICAgICAgICAgICBjb2xvclsxXSArICIsICIgKwogICAgICAgICAg ICAgICBjb2xvclsyXSArICIsICIgKwogICAgICAgICAgICAgICBjb2xvclszXTsKLQorICAgIHZh ciBzdWJNc2cgPSAiIHdhcyAiICsKKyAgICAgICAgICAgICAgYnVmW29mZiArIDBdICsgIiwgIiAr CisgICAgICAgICAgICAgIGJ1ZltvZmYgKyAxXSArICIsICIgKworICAgICAgICAgICAgICBidWZb b2ZmICsgMl0gKyAiLCAiICsKKyAgICAgICAgICAgICAgYnVmW29mZiArIDNdOworICAgIC8vIFdo ZW4gcnVubmluZyBpbiBXZWJLaXQncyB0ZXN0IGhhcm5lc3MsIHdlIGRvbid0IHdhbnQgdG8gcHJp bnQgdGhlCisgICAgLy8gcGl4ZWwgdmFsdWUgd2hlbiB0aGUgdGVzdCBwYXNzZXMsIGJlY2F1c2Ug ZGlmZmVyZW50IG1hY2hpbmVzIG1pZ2h0CisgICAgLy8gaGF2ZSBkaWZmZXJlbnQgcmVzdWx0cyBh bmQgd2UgcmVjb3JkIHRoZSB0ZXh0IG91dHB1dC4KKyAgICB2YXIgaW5EdW1wUmVuZGVyVHJlZSA9 IHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcjsKICAgICBmb3IgKHZhciBpaSA9IDA7IGlpIDwg NDsgKytpaSkgewogICAgICAgaWYgKE1hdGguYWJzKGJ1ZltvZmYgKyBpaV0gLSBjb2xvcltpaV0p ID4gYWxsb3dlZFJhbmdlKSB7Ci0gICAgICAgIHRlc3RGYWlsZWQobXNnICsgIiB3YXMgIiArCi0g ICAgICAgICAgICBidWZbb2ZmICsgMF0gKyAiLCAiICsKLSAgICAgICAgICAgIGJ1ZltvZmYgKyAx XSArICIsICIgKwotICAgICAgICAgICAgYnVmW29mZiArIDJdICsgIiwgIiArCi0gICAgICAgICAg ICBidWZbb2ZmICsgM10pOworICAgICAgICB0ZXN0RmFpbGVkKG1zZyArIHN1Yk1zZyk7CiAgICAg ICAgIHJldHVybjsKICAgICAgIH0KICAgICB9Ci0gICAgdGVzdFBhc3NlZChtc2cpOworICAgIHRl c3RQYXNzZWQobXNnICsgKGluRHVtcFJlbmRlclRyZWUgPyAiIiA6IHN1Yk1zZykpOwogICB9CiAK ICAgdmFyIHRleCA9IGdsLmNyZWF0ZVRleHR1cmUoKTsKSW5kZXg6IExheW91dFRlc3RzL2Zhc3Qv Y2FudmFzL3dlYmdsL3Jlc291cmNlcy9yZWQtaW5kZXhlZC5wbmcKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpDYW5ub3Qg ZGlzcGxheTogZmlsZSBtYXJrZWQgYXMgYSBiaW5hcnkgdHlwZS4Kc3ZuOm1pbWUtdHlwZSA9IGFw cGxpY2F0aW9uL29jdGV0LXN0cmVhbQoKaVZCT1J3MEtHZ29BQUFBTlNVaEVVZ0FBQUFFQUFBQUJB UU1BQUFBbDIxYktBQUFBQTFCTVZFWC9BQUFaNGdrM0FBQUFDWEJJV1hNQQpBQXNUQUFBTEV3RUFt cHdZQUFBQUluUkZXSFJEYjIxdFpXNTBBRU55WldGMFpXUWdkMmwwYUNCSFNVMVFJRzl1SUdFZ1RX RmpoNmgzClF3QUFBQWQwU1UxRkI5c0JIQlk2RmNOZFlvc0FBQUFLU1VSQlZBalhZMkFBQUFBQ0FB SGlJYnd6QUFBQUFFbEZUa1N1UW1DQwoK