53632 2011-02-02 15:24:03 -0800 [Chromium] Option text in select popup does not align with menulist button text 2011-02-04 19:29:07 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 xiyuan webkit-unassigned commit-queue dglazkov sam tony oldest_to_newest 344305 0 80978 xiyuan 2011-02-02 15:24:03 -0800 Created attachment 80978 Screenshot of problem. Menulist button has addition paddings from m_innerBlock besides css paddings and PopupListBox should include those paddings as well. 344338 1 80987 xiyuan 2011-02-02 15:54:52 -0800 Created attachment 80987 Proposed patch. 344374 2 80987 xiyuan 2011-02-02 16:18:44 -0800 Comment on attachment 80987 Proposed patch. This patch has side effect that because the m_innerBlock padding include the space for scrollbar and PopupListBox::layout might add space for scrollbar again. 344410 3 80987 xiyuan 2011-02-02 16:50:43 -0800 Comment on attachment 80987 Proposed patch. Resurrect the patch as we are protected from counting scrollbar width twice in RenderMenuList::clientPaddingRight which returns fixed endOfLinePadding. 345557 4 80987 tony 2011-02-04 09:51:57 -0800 Comment on attachment 80987 Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=80987&action=review > Source/WebCore/rendering/RenderMenuList.cpp:489 > + return paddingLeft() + m_innerBlock->paddingLeft(); Won't this change the offset for all webkit platforms? Is that intentional? 345600 5 xiyuan 2011-02-04 10:32:13 -0800 (In reply to comment #4) > (From update of attachment 80987 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=80987&action=review > > > Source/WebCore/rendering/RenderMenuList.cpp:489 > > + return paddingLeft() + m_innerBlock->paddingLeft(); > > Won't this change the offset for all webkit platforms? Is that intentional? This should affect Windows and Linux. Both platforms have the alignment problem. Mac probably will not be affected by this because its popup shows up via showExternal which should use native widget for the popup. 345621 6 80987 tony 2011-02-04 11:05:18 -0800 Comment on attachment 80987 Proposed patch. If it only affects Windows and Linux, this is fine. For reference, IE & Firefox Win aligns the text in popups. This is consistent with native menu lists on Windows. GTK+ menu lists also align the text (actually, GTK+ drop downs are like OSX menu lists where the text doesn't move but the options appear above/below the currently selected item). 345980 7 80987 commit-queue 2011-02-04 18:19:56 -0800 Comment on attachment 80987 Proposed patch. Clearing flags on attachment: 80987 Committed r77716: <http://trac.webkit.org/changeset/77716> 345981 8 commit-queue 2011-02-04 18:20:01 -0800 All reviewed patches have been landed. Closing bug. 346015 9 commit-queue 2011-02-04 19:29:07 -0800 The commit-queue encountered the following flaky tests while processing attachment 80987: inspector/elements-panel-xhtml-structure.xhtml bug 53835 (authors: apavlov@chromium.org and pfeldman@chromium.org) The commit-queue is continuing to process your patch. 80978 2011-02-02 15:24:03 -0800 2011-02-02 15:24:03 -0800 Screenshot of problem. popup_alignment_problem.png image/png 3016 xiyuan iVBORw0KGgoAAAANSUhEUgAAAEoAAABxCAYAAABybTUfAAAAAXNSR0IArs4c6QAAC4JJREFUeNrt nXlQVFcWh7/GACpLI61RE4SAyiJKADeI0mpG3BAXQDBGu1OKGssqMFJSmZpYJjoZFSeUjIgSBMEA GoODKGkVNFFS7gZckHGLQDCyyKLTGkCge/5QOkDABWXp4Z2qW8W97/W99/3eucv5+r1GpFar1Qj2 XNMRJBCEEoQShOrE9kZLB7Kyb5B19UaXEsPJ3hqnodbNHhM1t+plZd8gZm8quurHXUqoGpEeC32n NytWsx6VdfUGuurHLPCajK2tbZcQ6dq1a8Qnp5GZff3Fhao3Gxsbuso2y8bGBkh7+TkKQKVSCbP4 iwglbNpfo0cplUqqqqro06dP191HqdXqPyUPDw/Wr1+vybu7u5Odnd3sua8zbd++HRMTk0YpIiLi tbbx2j1KrVZrjpWXlzfKt5WdPn2awMBA/P39NWXGxsbPbNfLy4sTJ040KpNKpSQnJ7e9RzU8JpPJ KC0tZfHixXzzzTeo1WqysrKYNm0a5ubmODg4EBkZiVqtJj8/n0GDBvHFF18wZswYbG1tCQkJYfv2 7YwfPx4bGxvWrFnT4t0+e/YsN2/eZObMmfj5+XHs2DEMDAye6SErV65EJBI1uqagoKD28aj6SlUq FTt37sTe3p6IiAjGjRvHvXv38PHxYfny5ezfv5/c3Fx8fHzo3bs3zs7OVFRUoKenR0ZGBmfPnsXT 0xN/f3+OHj1Kfn4+o0ePZv78+VhZWTVqs6CggKKiIhwdHVm7di2XLl0iICCA7t274+Xl1WL/XV1d kUqlGq9yc3PD1dW1Vd7fqlWvuTugVqtRKBQYGhoSEBAAwMCBA5HL5SQmJuLk5ATAvHnzUKvVODo6 AjB37lwALCwsEIvFFBYWYmlp2ahuMzMzbt++jYGBAQADBgzg8uXLxMbGMnv27Gde4IoVK8jIyNB4 WGtX8lZvD5oOQ7VaTWFhIUVFRQwePFhzrK6uDgsLC01eLBajVqs1Q0JfX19Tl46OTovDoGfPno3K raysOHjw4HMv3NXVFTc3N1QqFa6urm0j1POGXsPzVCoVEokEOzs7jhw5ojlWVlZGXV0d1dXVjc6t /3zDuur/btquQqEgLCysUb23bt3CwsLihYZRYGDgK2+gWzWZN8zr6uqSl5eHUqlk6tSp5OXlERcX R21tLXfv3sXPz4+tW7c2+9nn5evTiBEjuH37NpGRkdTW1nL+/Hni4uJYtGjRCy37Li4uuLi4vNL2 QOd5HtU0NfQolUqFl5cXa9asISIiAolEQnx8PElJSdja2jJx4kSGDx9OcHCw5m429aiWPKxhkkgk xMXFsW/fPqytrQkICGDdunWMGzeu2T62Nj3LmsUsMd+mkp2dzSdLPuxSYcrmqESGDBnCormeQlAs BMUdKVRFRQUmJiZdQoj79++/vFBO9tZkXb1BfHJal/Kax+jiPNTmJYQaao3k3NAuOcRa+nLhmUNP Nn5QlxJp1/FbrdtHCSYI1fZCPXz4kLKyMkGopjZv3jzCwsI0eR8fH65du9ZuHbx69aoGyWiVR1VU VLRb59LS0pDJZBryoDVCLVu2jPLyclasWMHevXsBuHLlCr6+vgwbNoyxY8cSFxcHwJ07dxg+fDgh ISFMmTKFUaNGsWXLFmJjY/H09GTkyJFs2LChxbbCw8MJDQ3VQECtEmrbtm2YmpqyefNmfH19KS8v Ry6XM2HCBC5evMiuXbuIiooiNTVVs9vV09Pj8OHDREREsHnzZvLz8zlw4AD79u1jx44d5OXlNduW t7c3CoUCZ2dn7V/10tPTMTAwYNmyZXTr1g0rKys++OADkpKSNOf4+voC4ODgoJnjRCIR5ubmGBsb U1xc3Gzd/fv3R0en8yzKb7zKh4uLiykpKWk02apUKgYMGKDJi8XiJ3fk6UV37979j7v0FP1qfVD8 PJNIJNja2pKSkqIpKysrQ6VSdYoJuEOHnq6uLr/++isPHz5k8uTJ5OXlkZiYSF1dHUVFRcjlciIj I4UN56xZs1i7di1RUVH07t2b2NhYkpOTcXR0xMPDAycnJ1atWvV/J5SopefMP49J65JB8ecLJwmx nhAUC0IJQglCCUI9NYFHtWAdxaNOnjzJjBkzsLOzY9SoUWzatIm6ujrt8aj24FGlpaUsXboUuVzO 5cuXSUhIQKFQEB0drR1CtRePunv3Lp6ennh7e6Orq8vgwYOZOnUqly5d0o6geNu2bYwePZrQ0FDG jBmj4VGLFy9m9+7d5OfnI5PJkEgkODo6NuJRFy5cwM/PD5lMxoEDBygoKOD9999n7ty5vPPOO43a cXBw0GAZgJqaGo4fP/7MxxA79arXljyq3qqrqwkMDMTU1BSZTKadmKWteVRhYSHLly/HzMyM6Oho 9PT0tFOotuRROTk5+Pv7I5PJ+Pjjj7VvH9UePKqkpAS5XM5HH33EzJkzKSwspLCwsF2/AdIKHpWQ kEB5eTkbN25k7NixmtSRnEvgUQKPEoJiQShBKEEoQSiBR2kLj1IoFLi7u2Nvb8+ECROIj4/vUKFe OoRpj91xbm4uQUFBREZGIpVKycnJYc6cOQwZMqTDnm7plDzK0tKSM2fOIJVKAaisrERXVxcjIyOB RzU1sViMUqlEKpWiVCpZtGhRoxcmBR7VwAwNDcnMzCQ9PZ3U1FSNtwo8qmkg+vR1WktLS/z8/Dh0 6BByuVzgUfV29OhRwsPD2b9/v6asqqoKfX19gUc1NCcnJ3Jzc4mJiaG2tpaff/6ZPXv24OfnJ/Co pp4aHR1NSkoKw4YNIygoiE8//ZRp06YJPErgUUJQLAglmCCUIJTAowQe9YJWXV3N9OnTCQ8P1y6P au9vazdt2sT169e1a+i15/t6ABkZGZw5cwY3NzftEqo939crKytj9erVhIaGduhTLK9l1WtLHhUc HMzChQuxtrbuFJN5p+RRcXFxqFSqDn1w7LUK1VY8as+ePRQUFGh+QLCyspKMjAwyMzOJiYnRjqHX HjwqNjaWw4cPk5qaSmpqKi4uLixYsICNGzdqzxzVHjyqb9++mJmZaVKPHj0wMjLq0N8jFnhUAxN4 lBAUd5JVL+CfiV1KjBEjRgkeJQy9zipUD309xIY9hTmqqa3/ZAFXbuST+H0GAF8FL+Tr745w8Vpu m3bMc/xIlvpOblQWlZRGyg/ntCOEMTbo0S4dsx9kTlLaKQ4eP68pe1RZpR2x3t+W+GBs1JPghbPZ uf8H0k9dZJB5P5bMmYyVWT+Uv1fy7/TTHDx+njdNxYT91Z8jJ7MYOWwwYsOefH/iAo8qq5no+i4S EyOOnr7EzuRjzbZlN9CMbt10WP/JAh4/riXlx3Okn7qoHXPUl18n8V/l74TEJJN+6iLGBj34e8B8 zmffwndlCJ/9KwFvd1fchg8BwMigBzW1tSxfF8k/vk7iw+nj6N+nFwH/iCIoJAavia681cf0T+30 MRUjERtxM+8un4UlsFvxE0vmTEI6wl476YHLuzZUVlXz3ZGTAPxWXIbip0zc33Pkeu5vABw5+cQL buQ9ydd7RVHpfR5VVmFqYsjde+WN6r1X/gDvFRupflwDQEn5Awaa98NDOpyMC1e1ELOYGGNqYsS3 X61qwJhEFJX+8bu7D3+vfMKpnoaUj2tq/2BXajUiRM3WXS9Svf1WXMZYJzvt9KgHykfk3ilhxYYd f0z2hj3R0RGh90brq3Z1tMVvythG9b7dV0LhPS16Da2mro5+vXvRQ1+PUxev8dabvZjq5oyOSIRE bMSXAR8yZ9J7r9Sp//xSwNt9TZn1l9HoiETYWZnhIR1Byo/ntMejfjx3haW+k5GYGJGQeoLVWxLx 93ZnkZc7NbW1/JSZQ+z+H+hlbNjqTt1XPuLzrXtYMmcSC2ZMoOKBku3fHiIz55fOyaMuXOi4O9hR QbHAo4SguBPMUc/iM13NRML/UheGniCUIJQglPbb/wCt1+DiiAXBGQAAAABJRU5ErkJggg== 80987 2011-02-02 15:54:52 -0800 2011-02-04 18:19:56 -0800 Proposed patch. webkit_53632.patch text/plain 1692 xiyuan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc3NDI3KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDItMDIgIFhpeXVhbiBY aWEgIDx4aXl1YW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFtDaHJvbWl1bV0gT3B0aW9uIHRleHQgaW4gc2VsZWN0IHBvcHVw IGRvZXMgbm90IGFsaWduIHdpdGggbWVudWxpc3QgYnV0dG9uIHRleHQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUzNjMyCisKKyAgICAgICAgVGhpcyBt YWtlcyBjbGllbnRQYWRkaW5nTGVmdCBhbmQgIGNsaWVudFBhZGRpbmdSaWdodCByZXR1cm4KKyAg ICAgICAgdGhlIGFkZGl0aW9uYWwgbV9pbm5lckJsb2NrJ3MgcGFkZGluZyBzbyB0aGF0IHRoZSBw b3B1cCBpdGVtIHRleHQKKyAgICAgICAgYWxpZ25zIHdpdGggdGhlIG1lbnVsaXN0IGJ1dHRvbiB0 ZXh0LgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlck1lbnVMaXN0LmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OlJlbmRlck1lbnVMaXN0OjpjbGllbnRQYWRkaW5nTGVmdCk6CisgICAgICAgIChX ZWJDb3JlOjpSZW5kZXJNZW51TGlzdDo6Y2xpZW50UGFkZGluZ1JpZ2h0KToKKwogMjAxMS0wMi0w MiAgUGV0ZXIgS2FzdGluZyAgPHBrYXN0aW5nQGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgRGF2aWQgTGV2aW4uCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy TWVudUxpc3QuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJNZW51TGlzdC5jcHAJKHJldmlzaW9uIDc3NDI0KQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlck1lbnVMaXN0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDg2LDcgKzQ4Niw3IEBA IGludCBSZW5kZXJNZW51TGlzdDo6Y2xpZW50SW5zZXRSaWdodCgpIGMKIAogaW50IFJlbmRlck1l bnVMaXN0OjpjbGllbnRQYWRkaW5nTGVmdCgpIGNvbnN0CiB7Ci0gICAgcmV0dXJuIHBhZGRpbmdM ZWZ0KCk7CisgICAgcmV0dXJuIHBhZGRpbmdMZWZ0KCkgKyBtX2lubmVyQmxvY2stPnBhZGRpbmdM ZWZ0KCk7CiB9CiAKIGNvbnN0IGludCBlbmRPZkxpbmVQYWRkaW5nID0gMjsKQEAgLTUwMiw3ICs1 MDIsNyBAQCBpbnQgUmVuZGVyTWVudUxpc3Q6OmNsaWVudFBhZGRpbmdSaWdodCgpCiAKICAgICAv LyBJZiB0aGUgYXBwZWFyYW5jZSBpc24ndCBNZW51bGlzdFBhcnQsIHRoZW4gdGhlIHNlbGVjdCBp cyBzdHlsZWQgKG5vbi1uYXRpdmUpLCBzbwogICAgIC8vIHdlIHdhbnQgdG8gcmV0dXJuIHRoZSB1 c2VyIHNwZWNpZmllZCBwYWRkaW5nLgotICAgIHJldHVybiBwYWRkaW5nUmlnaHQoKTsKKyAgICBy ZXR1cm4gcGFkZGluZ1JpZ2h0KCkgKyBtX2lubmVyQmxvY2stPnBhZGRpbmdSaWdodCgpOwogfQog CiBpbnQgUmVuZGVyTWVudUxpc3Q6Omxpc3RTaXplKCkgY29uc3QK