53607 2011-02-02 11:18:10 -0800 Add DerivedSources.make to some Visual Studio projects 2011-02-02 14:40:59 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 53625 1 jeffm jeffm abarth aroben commit-queue dbates eric oldest_to_newest 344074 0 jeffm 2011-02-02 11:18:10 -0800 Add DerivedSources.make to some Visual Studio projects 344085 1 80936 jeffm 2011-02-02 11:37:33 -0800 Created attachment 80936 Patch 344149 2 80936 commit-queue 2011-02-02 12:47:23 -0800 Comment on attachment 80936 Patch Rejecting attachment 80936 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-7', 'apply-..." exit_code: 2 Last 500 characters of output: le Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj.rej patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/WebCore.vcproj/WebCoreGenerated.vcproj Hunk #1 FAILED at 85. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/WebCore.vcproj/WebCoreGenerated.vcproj.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Darin Adler', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/7689262 344193 3 80961 jeffm 2011-02-02 13:37:38 -0800 Created attachment 80961 add a newline to the end of the last patch manually, I'm not sure why the generated patch failed but this seems to fix it 344195 4 eric 2011-02-02 13:39:28 -0800 Adam was just telling me that svn-apply may have trouble applying vcproj changes on git checkouts. If that's true, we need a bug and a fix. :) I'm not certain if that's the apply error your'e hitting or not (because I just heard of this 5 minutes ago). 344196 5 eric 2011-02-02 13:40:37 -0800 bug 53573 is where Adam had trouble with vcproj files and svn-apply. 344205 6 dbates 2011-02-02 13:46:03 -0800 (In reply to comment #4) > Adam was just telling me that svn-apply may have trouble applying vcproj changes on git checkouts. If that's true, we need a bug and a fix. :) Filed bug #53625 for this issue. 344211 7 jeffm 2011-02-02 13:49:45 -0800 I am not using git, and downloading the original patch attachment manually and applying it to my local sources also failed. I added a newline to the patch file, and the local apply worked. 344213 8 jeffm 2011-02-02 13:51:21 -0800 And FWIW, I was using patch, not svn-apply, to apply the patch locally. 344216 9 80961 commit-queue 2011-02-02 13:56:20 -0800 Comment on attachment 80961 add a newline to the end of the last patch manually, I'm not sure why the generated patch failed but this seems to fix it Rejecting attachment 80961 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-4', 'apply-..." exit_code: 2 Last 500 characters of output: le Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj.rej patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/WebCore.vcproj/WebCoreGenerated.vcproj Hunk #1 FAILED at 85. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/WebCore.vcproj/WebCoreGenerated.vcproj.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Steve Falkenburg', u'-..." exit_code: 1 Full output: http://queues.webkit.org/results/7685990 344223 10 dbates 2011-02-02 13:59:05 -0800 (In reply to comment #8) > And FWIW, I was using patch, not svn-apply, to apply the patch locally. What OS are you using? What version of patch(1) are you using? 344241 11 jeffm 2011-02-02 14:12:07 -0800 (In reply to comment #10) > (In reply to comment #8) > > And FWIW, I was using patch, not svn-apply, to apply the patch locally. > > What OS are you using? What version of patch(1) are you using? Windows 7. patch 2.5.8. In any case, it looks like the commit bot can't commit the updated patch, either, so, I'll have to find someone with commit privileges to do it for me. 344246 12 eric 2011-02-02 14:17:46 -0800 The commit-bots use Snow Leopard 10.6.6 with a git checkout. I suspect you're hitting bug 53625, just like Adam did. :( 344247 13 jeffm 2011-02-02 14:20:26 -0800 (In reply to comment #12) > The commit-bots use Snow Leopard 10.6.6 with a git checkout. I suspect you're hitting bug 53625, just like Adam did. :( Thanks for the info, that would explain it. 344267 14 aroben 2011-02-02 14:40:59 -0800 Committed r77420: <http://trac.webkit.org/changeset/77420> 80936 2011-02-02 11:37:33 -0800 2011-02-02 13:37:51 -0800 Patch bug-53607-20110202113729.patch text/plain 2205 jeffm SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gNzczOTApCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAK KzIwMTEtMDItMDIgIEplZmYgTWlsbGVyICA8amVmZm1AYXBwbGUuY29tPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBEZXJpdmVkU291cmNlcy5t YWtlIHRvIHNvbWUgVmlzdWFsIFN0dWRpbyBwcm9qZWN0cworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTM2MDcKKworICAgICAgICAqIEphdmFTY3JpcHRD b3JlLnZjcHJvai9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZUdlbmVyYXRlZC52Y3Byb2o6 IEFkZCBEZXJpdmVkU291cmNlcy5tYWtlLgorCiAyMDExLTAyLTAyICBTYW0gV2VpbmlnICA8c2Ft QHdlYmtpdC5vcmc+CiAKICAgICAgICAgRml4IHdpbmRvd3MgY2xlYW4gYnVpbGQuCkluZGV4OiBT b3VyY2UvSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUudmNwcm9qL0phdmFTY3JpcHRDb3Jl L0phdmFTY3JpcHRDb3JlR2VuZXJhdGVkLnZjcHJvago9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUudmNwcm9qL0phdmFTY3JpcHRDb3JlL0phdmFTY3Jp cHRDb3JlR2VuZXJhdGVkLnZjcHJvagkocmV2aXNpb24gNzczOTApCisrKyBTb3VyY2UvSmF2YVNj cmlwdENvcmUvSmF2YVNjcmlwdENvcmUudmNwcm9qL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRD b3JlR2VuZXJhdGVkLnZjcHJvagkod29ya2luZyBjb3B5KQpAQCAtODcsNiArODcsMTAgQEAKIAkJ CT4KIAkJPC9GaWxlPgogCQk8RmlsZQorCQkJUmVsYXRpdmVQYXRoPSIuLlwuLlxEZXJpdmVkU291 cmNlcy5tYWtlIgorCQkJPgorCQk8L0ZpbGU+CisJCTxGaWxlCiAJCQlSZWxhdGl2ZVBhdGg9Ii5c SmF2YVNjcmlwdENvcmVHZW5lcmF0ZWQubWFrZSIKIAkJCT4KIAkJPC9GaWxlPgpJbmRleDogU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkocmV2aXNpb24gNzczOTApCisrKyBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cJKHdvcmtp bmcgY29weSkKQEAgLTEsMyArMSwxMiBAQAorMjAxMS0wMi0wMiAgSmVmZiBNaWxsZXIgIDxqZWZm bUBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQWRkIERlcml2ZWRTb3VyY2VzLm1ha2UgdG8gc29tZSBWaXN1YWwgU3R1ZGlvIHByb2pl Y3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MzYw NworCisgICAgICAgICogV2ViQ29yZS52Y3Byb2ovV2ViQ29yZUdlbmVyYXRlZC52Y3Byb2o6IEFk ZCBEZXJpdmVkU291cmNlcy5tYWtlLgorCiAyMDExLTAyLTAyICBEYXZpZCBIeWF0dCAgPGh5YXR0 QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IFNv dXJjZS9XZWJDb3JlL1dlYkNvcmUudmNwcm9qL1dlYkNvcmVHZW5lcmF0ZWQudmNwcm9qCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL1dlYkNvcmUudmNwcm9qL1dlYkNvcmVHZW5lcmF0ZWQu dmNwcm9qCShyZXZpc2lvbiA3NzM5MCkKKysrIFNvdXJjZS9XZWJDb3JlL1dlYkNvcmUudmNwcm9q L1dlYkNvcmVHZW5lcmF0ZWQudmNwcm9qCSh3b3JraW5nIGNvcHkpCkBAIC04NSw2ICs4NSwxMCBA QAogCQkJPgogCQk8L0ZpbGU+CiAJCTxGaWxlCisJCQlSZWxhdGl2ZVBhdGg9Ii4uXERlcml2ZWRT b3VyY2VzLm1ha2UiCisJCQk+CisJCTwvRmlsZT4KKwkJPEZpbGUKIAkJCVJlbGF0aXZlUGF0aD0i LlxtaWdyYXRlLXNjcmlwdHMuc2giCiAJCQk+CiAJCTwvRmlsZT4K 80961 2011-02-02 13:37:38 -0800 2011-02-02 13:56:20 -0800 add a newline to the end of the last patch manually, I'm not sure why the generated patch failed but this seems to fix it file.patch text/plain 2205 jeffm SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gNzczOTApCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAK KzIwMTEtMDItMDIgIEplZmYgTWlsbGVyICA8amVmZm1AYXBwbGUuY29tPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBEZXJpdmVkU291cmNlcy5t YWtlIHRvIHNvbWUgVmlzdWFsIFN0dWRpbyBwcm9qZWN0cworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTM2MDcKKworICAgICAgICAqIEphdmFTY3JpcHRD b3JlLnZjcHJvai9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZUdlbmVyYXRlZC52Y3Byb2o6 IEFkZCBEZXJpdmVkU291cmNlcy5tYWtlLgorCiAyMDExLTAyLTAyICBTYW0gV2VpbmlnICA8c2Ft QHdlYmtpdC5vcmc+CiAKICAgICAgICAgRml4IHdpbmRvd3MgY2xlYW4gYnVpbGQuCkluZGV4OiBT b3VyY2UvSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUudmNwcm9qL0phdmFTY3JpcHRDb3Jl L0phdmFTY3JpcHRDb3JlR2VuZXJhdGVkLnZjcHJvago9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUudmNwcm9qL0phdmFTY3JpcHRDb3JlL0phdmFTY3Jp cHRDb3JlR2VuZXJhdGVkLnZjcHJvagkocmV2aXNpb24gNzczOTApCisrKyBTb3VyY2UvSmF2YVNj cmlwdENvcmUvSmF2YVNjcmlwdENvcmUudmNwcm9qL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRD b3JlR2VuZXJhdGVkLnZjcHJvagkod29ya2luZyBjb3B5KQpAQCAtODcsNiArODcsMTAgQEAKIAkJ CT4KIAkJPC9GaWxlPgogCQk8RmlsZQorCQkJUmVsYXRpdmVQYXRoPSIuLlwuLlxEZXJpdmVkU291 cmNlcy5tYWtlIgorCQkJPgorCQk8L0ZpbGU+CisJCTxGaWxlCiAJCQlSZWxhdGl2ZVBhdGg9Ii5c SmF2YVNjcmlwdENvcmVHZW5lcmF0ZWQubWFrZSIKIAkJCT4KIAkJPC9GaWxlPgpJbmRleDogU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkocmV2aXNpb24gNzczOTApCisrKyBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cJKHdvcmtp bmcgY29weSkKQEAgLTEsMyArMSwxMiBAQAorMjAxMS0wMi0wMiAgSmVmZiBNaWxsZXIgIDxqZWZm bUBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQWRkIERlcml2ZWRTb3VyY2VzLm1ha2UgdG8gc29tZSBWaXN1YWwgU3R1ZGlvIHByb2pl Y3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MzYw NworCisgICAgICAgICogV2ViQ29yZS52Y3Byb2ovV2ViQ29yZUdlbmVyYXRlZC52Y3Byb2o6IEFk ZCBEZXJpdmVkU291cmNlcy5tYWtlLgorCiAyMDExLTAyLTAyICBEYXZpZCBIeWF0dCAgPGh5YXR0 QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IFNv dXJjZS9XZWJDb3JlL1dlYkNvcmUudmNwcm9qL1dlYkNvcmVHZW5lcmF0ZWQudmNwcm9qCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL1dlYkNvcmUudmNwcm9qL1dlYkNvcmVHZW5lcmF0ZWQu dmNwcm9qCShyZXZpc2lvbiA3NzM5MCkKKysrIFNvdXJjZS9XZWJDb3JlL1dlYkNvcmUudmNwcm9q L1dlYkNvcmVHZW5lcmF0ZWQudmNwcm9qCSh3b3JraW5nIGNvcHkpCkBAIC04NSw2ICs4NSwxMCBA QAogCQkJPgogCQk8L0ZpbGU+CiAJCTxGaWxlCisJCQlSZWxhdGl2ZVBhdGg9Ii4uXERlcml2ZWRT b3VyY2VzLm1ha2UiCisJCQk+CisJCTwvRmlsZT4KKwkJPEZpbGUKIAkJCVJlbGF0aXZlUGF0aD0i LlxtaWdyYXRlLXNjcmlwdHMuc2giCiAJCQk+CiAJCTwvRmlsZT4K