53602 2011-02-02 09:40:52 -0800 [Chromium] Select popup with padding has white strip on right 2011-02-02 14:46:01 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 xiyuan webkit-unassigned commit-queue dglazkov tony oldest_to_newest 344011 0 80924 xiyuan 2011-02-02 09:40:52 -0800 Created attachment 80924 A test case html http://trac.webkit.org/changeset/76831 added overhang painting to WebCore::ScrollView::paint (base of PopupListBox). The overhang is derived in ScrollView::calculateOverhangAreasForPainting based on scroll position, contentSize and visibleContentRect. We excluded padding space from content size in PopupListBox::layout and thus the padding space is drawn as overhang. 344024 1 80925 xiyuan 2011-02-02 10:06:27 -0800 Created attachment 80925 Proposed patch. 344276 2 80925 commit-queue 2011-02-02 14:45:57 -0800 Comment on attachment 80925 Proposed patch. Clearing flags on attachment: 80925 Committed r77424: <http://trac.webkit.org/changeset/77424> 344277 3 commit-queue 2011-02-02 14:46:01 -0800 All reviewed patches have been landed. Closing bug. 80924 2011-02-02 09:40:52 -0800 2011-02-02 09:40:52 -0800 A test case html select_popup_with_padding.html text/html 148 xiyuan PGh0bWw+Cgo8Ym9keT4KCiAgPHNlbGVjdCBzaXplPSIxIiBzdHlsZT0icGFkZGluZzogMHB4IDIw cHg7Ij4KICAgIDxvcHRpb24+SXRlbSAxPC9vcHRpb24+CiAgICA8b3B0aW9uPkl0ZW0gMjwvb3B0 aW9uPgogIDwvc2VsZWN0PgoKPC9ib2R5Pgo8L2h0bWw+Cg== 80925 2011-02-02 10:06:27 -0800 2011-02-02 14:45:57 -0800 Proposed patch. webkit_53602.patch text/plain 1671 xiyuan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc3Mzc4KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDItMDIgIFhpeXVhbiBY aWEgIDx4aXl1YW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFtDaHJvbWl1bV0gU2VsZWN0IHBvcHVwIHdpdGggcGFkZGluZyBo YXMgd2hpdGUgc3RyaXAgb24gcmlnaHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTUzNjAyCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIGFzIHRoaXMgY2hh bmdlIHJlc3RvcmVzIG9sZCBiZWhhdmlvci4KKworICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVt L1BvcHVwTWVudUNocm9taXVtLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBvcHVwTGlzdEJveDo6 bGF5b3V0KToKKwogMjAxMS0wMi0wMiAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFjaWVqIFN0YWNob3dpYWsuCkluZGV4OiBTb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9Qb3B1cE1lbnVDaHJvbWl1bS5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vUG9wdXBNZW51Q2hyb21pdW0u Y3BwCShyZXZpc2lvbiA3NzM3NykKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVt L1BvcHVwTWVudUNocm9taXVtLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTM1MSwxNCArMTM1MSwx NCBAQCB2b2lkIFBvcHVwTGlzdEJveDo6bGF5b3V0KCkKICAgICBpbnQgY29udGVudFdpZHRoOwog ICAgIGlmIChtX3NldHRpbmdzLnJlc3RyaWN0V2lkdGhPZkxpc3RCb3gpIHsKICAgICAgICAgd2lu ZG93V2lkdGggPSBtX2Jhc2VXaWR0aDsKLSAgICAgICAgY29udGVudFdpZHRoID0gbV9iYXNlV2lk dGggLSBzY3JvbGxiYXJXaWR0aCAtIHBhZGRpbmdXaWR0aDsKKyAgICAgICAgY29udGVudFdpZHRo ID0gbV9iYXNlV2lkdGggLSBzY3JvbGxiYXJXaWR0aDsKICAgICB9IGVsc2UgewogICAgICAgICB3 aW5kb3dXaWR0aCA9IGJhc2VXaWR0aCArIHNjcm9sbGJhcldpZHRoICsgcGFkZGluZ1dpZHRoOwot ICAgICAgICBjb250ZW50V2lkdGggPSBiYXNlV2lkdGg7CisgICAgICAgIGNvbnRlbnRXaWR0aCA9 IGJhc2VXaWR0aCArIHBhZGRpbmdXaWR0aDsKIAogICAgICAgICBpZiAod2luZG93V2lkdGggPCBt X2Jhc2VXaWR0aCkgewogICAgICAgICAgICAgd2luZG93V2lkdGggPSBtX2Jhc2VXaWR0aDsKLSAg ICAgICAgICAgIGNvbnRlbnRXaWR0aCA9IG1fYmFzZVdpZHRoIC0gc2Nyb2xsYmFyV2lkdGggLSBw YWRkaW5nV2lkdGg7CisgICAgICAgICAgICBjb250ZW50V2lkdGggPSBtX2Jhc2VXaWR0aCAtIHNj cm9sbGJhcldpZHRoOwogICAgICAgICB9IGVsc2UKICAgICAgICAgICAgIG1fYmFzZVdpZHRoID0g YmFzZVdpZHRoOwogICAgIH0K