53601 2011-02-02 09:12:35 -0800 Unexpected treatment of exceptions thrown in to string conversion by HTMLDocument::write and HTMLDocument::writeln methods 2011-02-03 11:09:37 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) All All NEW P2 Normal --- 53596 1 antonm webkit-unassigned abarth ap oldest_to_newest 343998 0 80918 antonm 2011-02-02 09:12:35 -0800 Created attachment 80918 Change to layout tests which revealed the problem In the attachment you may find minor modifications to the corresponding layout tests. The problem is Safari (and Chromium as well), silently ignore exceptions thrown while converting objects into strings (substituting such arguments with empty strings) and rethrow pending exception after real write is performed. Firefox (4.0b9) behaves as expected: it throws exception and does no write. Interesting case might be to throw several exceptions and see what happens. I've got a patch for v8 bindings: https://bugs.webkit.org/show_bug.cgi?id=53596 (with "correct" expectations). And btw, this problem should plague v8 bindings. Maybe the situation is similar in JSC bindings. 80918 2011-02-02 09:12:35 -0800 2011-02-02 09:12:35 -0800 Change to layout tests which revealed the problem lt.patch text/plain 2454 antonm SW5kZXg6IHRoaXJkX3BhcnR5L1dlYktpdC9MYXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MRG9jdW1l bnQvd3JpdGVsbi1jYWxsLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gdGhpcmRfcGFydHkvV2ViS2l0L0xh eW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxEb2N1bWVudC93cml0ZWxuLWNhbGwuaHRtbAkocmV2aXNp b24gNzcyNDMpCisrKyB0aGlyZF9wYXJ0eS9XZWJLaXQvTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRN TERvY3VtZW50L3dyaXRlbG4tY2FsbC5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC03LDE0ICs3LDE2 IEBACiAJfQogCiAJZG9jdW1lbnQud3JpdGVsbigic3VjY2VzcyIpOworICB0cnkgeworICAgIGRv Y3VtZW50LndyaXRlbG4oImZvbyIsIHsgdG9TdHJpbmc6IGZ1bmN0aW9uKCkgeyB0aHJvdyAnZXhj ZXB0aW9uJzsgfX0pOworICB9IGNhdGNoIChlKSB7CisgICAgZG9jdW1lbnQud3JpdGVsbihlKTsK KyAgfQogfQogPC9zY3JpcHQ+CiA8L2hlYWQ+CiA8Ym9keT4KIDxwPlRlc3RzOiBjYWxsaW5nIEhU TUxEb2N1bWVudDo6d3JpdGVsbjwvcD4KLTxwPkNvbmRpdGlvbihzKTogPC9wPgotPHA+IFN1Y2Nl c3MgbWVzc2FnZTogc3VjY2VzcyA8L3A+Ci08cD5GYWlsdXJlIG1lc3NhZ2U6IFtubyBvdXRwdXRd IDwvcD4KIDxocj4KIDwvYm9keT4KIDxzY3JpcHQ+dGVzdCgpPC9zY3JpcHQ+CkluZGV4OiB0aGly ZF9wYXJ0eS9XZWJLaXQvTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTERvY3VtZW50L3dyaXRlLWNh bGwtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHRoaXJkX3BhcnR5L1dlYktpdC9MYXlvdXRU ZXN0cy9mYXN0L2RvbS9IVE1MRG9jdW1lbnQvd3JpdGUtY2FsbC1leHBlY3RlZC50eHQJKHJldmlz aW9uIDc3MjQzKQorKysgdGhpcmRfcGFydHkvV2ViS2l0L0xheW91dFRlc3RzL2Zhc3QvZG9tL0hU TUxEb2N1bWVudC93cml0ZS1jYWxsLWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMSw5 ICsxLDMgQEAKIFRlc3RzOiBjYWxsaW5nIEhUTUxEb2N1bWVudDo6d3JpdGUKIAotQ29uZGl0aW9u KHMpOgotCi1TdWNjZXNzIG1lc3NhZ2U6IHBhc3NlZAotCi1GYWlsdXJlIG1lc3NhZ2U6IFtubyBv dXRwdXRdCi0KLXBhc3NlZAorcGFzc2VkZXhjZXB0aW9uCkluZGV4OiB0aGlyZF9wYXJ0eS9XZWJL aXQvTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTERvY3VtZW50L3dyaXRlLWNhbGwuaHRtbAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSB0aGlyZF9wYXJ0eS9XZWJLaXQvTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTERv Y3VtZW50L3dyaXRlLWNhbGwuaHRtbAkocmV2aXNpb24gNzcyNDMpCisrKyB0aGlyZF9wYXJ0eS9X ZWJLaXQvTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTERvY3VtZW50L3dyaXRlLWNhbGwuaHRtbAko d29ya2luZyBjb3B5KQpAQCAtNywxNCArNywxNiBAQAogCX0KIAogCWRvY3VtZW50LndyaXRlKCJw YXNzZWQiKTsKKyAgdHJ5IHsKKyAgICBkb2N1bWVudC53cml0ZSgiZm9vIiwgeyB0b1N0cmluZzog ZnVuY3Rpb24oKSB7IHRocm93ICdleGNlcHRpb24nOyB9fSk7CisgIH0gY2F0Y2ggKGUpIHsKKyAg ICBkb2N1bWVudC53cml0ZShlKTsKKyAgfQogfQogPC9zY3JpcHQ+CiA8L2hlYWQ+CiA8Ym9keT4K IDxwPlRlc3RzOiBjYWxsaW5nIEhUTUxEb2N1bWVudDo6d3JpdGU8L3A+Ci08cD5Db25kaXRpb24o cyk6PC9wPgotPHA+U3VjY2VzcyBtZXNzYWdlOiBwYXNzZWQ8L3A+Ci08cD5GYWlsdXJlIG1lc3Nh Z2U6IFtubyBvdXRwdXRdPC9wPgogPGhyPgogPC9ib2R5PgogPHNjcmlwdD50ZXN0KCk8L3Njcmlw dD4KSW5kZXg6IHRoaXJkX3BhcnR5L1dlYktpdC9MYXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MRG9j dW1lbnQvd3JpdGVsbi1jYWxsLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSB0aGlyZF9wYXJ0 eS9XZWJLaXQvTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTERvY3VtZW50L3dyaXRlbG4tY2FsbC1l eHBlY3RlZC50eHQJKHJldmlzaW9uIDc3MjQzKQorKysgdGhpcmRfcGFydHkvV2ViS2l0L0xheW91 dFRlc3RzL2Zhc3QvZG9tL0hUTUxEb2N1bWVudC93cml0ZWxuLWNhbGwtZXhwZWN0ZWQudHh0CSh3 b3JraW5nIGNvcHkpCkBAIC0xLDkgKzEsMyBAQAogVGVzdHM6IGNhbGxpbmcgSFRNTERvY3VtZW50 Ojp3cml0ZWxuCiAKLUNvbmRpdGlvbihzKToKLQotU3VjY2VzcyBtZXNzYWdlOiBzdWNjZXNzCi0K LUZhaWx1cmUgbWVzc2FnZTogW25vIG91dHB1dF0KLQotc3VjY2Vzcworc3VjY2VzcyBleGNlcHRp b24K