53596 2011-02-02 08:05:57 -0800 [v8] Properly process exceptions thrown while converting objects to string in HTMLDocument.write{,ln} methods 2013-09-01 10:35:03 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED INVALID P2 Normal --- 53601 1 antonm antonm abarth andersca ap arv levin oldest_to_newest 343981 0 antonm 2011-02-02 08:05:57 -0800 [v8] Properly process exceptions thrown while converting objects to string in HTMLDocument.write{,ln} methods 343989 1 antonm 2011-02-02 08:40:36 -0800 This is a fix for 1st crash in http://code.google.com/p/chromium/issues/detail?id=71544 I am going to eventually nuke all unsafe uses of v8ValueToWebCoreString, but it require several patches )I think). I am going to make PSA asking v8 bindings hacking people do not use v8ValueToWebCoreString and friends. 344003 2 80920 antonm 2011-02-02 09:21:23 -0800 Created attachment 80920 Patch 344005 3 80920 antonm 2011-02-02 09:22:14 -0800 Comment on attachment 80920 Patch Pending on https://bugs.webkit.org/show_bug.cgi?id=53601 344017 4 levin 2011-02-02 09:57:56 -0800 (In reply to comment #1) > This is a fix for 1st crash in http://code.google.com/p/chromium/issues/detail?id=71544 > > I am going to eventually nuke all unsafe uses of v8ValueToWebCoreString, but it require several patches )I think). > > I am going to make PSA asking v8 bindings hacking people do not use v8ValueToWebCoreString and friends. fwiw, you could write a check in the style checker to catch this automatically (source at Tools/Scripts/webkitpy/style/checkers/cpp.py). 344019 5 antonm 2011-02-02 09:59:36 -0800 (In reply to comment #4) > (In reply to comment #1) > > This is a fix for 1st crash in http://code.google.com/p/chromium/issues/detail?id=71544 > > > > I am going to eventually nuke all unsafe uses of v8ValueToWebCoreString, but it require several patches )I think). > > > > I am going to make PSA asking v8 bindings hacking people do not use v8ValueToWebCoreString and friends. > > fwiw, you could write a check in the style checker to catch this automatically (source at Tools/Scripts/webkitpy/style/checkers/cpp.py). Very nice idea, David, thanks a lot. I'll do it if we decide to deprecate this behaviour. 344857 6 ap 2011-02-03 11:09:26 -0800 Is this problem unique to v8, or does it also affect JSC? 344865 7 abarth 2011-02-03 11:16:52 -0800 (In reply to comment #6) > Is this problem unique to v8, or does it also affect JSC? Presumably if the tests pass in JSC, it's not a problem in JSC. 344867 8 antonm 2011-02-03 11:18:32 -0800 This patch solves the issue with HTMLDocument::write and writeln not exiting quickly when first argument throwing an exception is met. So it's a solution for Chromium for https://bugs.webkit.org/show_bug.cgi?id=53601. And no, tests do not pass under Safari, again, see https://bugs.webkit.org/show_bug.cgi?id=53601 (In reply to comment #6) > Is this problem unique to v8, or does it also affect JSC? 344907 9 ap 2011-02-03 12:16:42 -0800 I believe that we normally want bug to bug compatibility for such things, when possible. 345431 10 antonm 2011-02-04 03:13:08 -0800 (In reply to comment #9) > I believe that we normally want bug to bug compatibility for such things, when possible. That's precisely why I removed r? and marked this bug as blocked by https://bugs.webkit.org/show_bug.cgi?id=53601 :) 923516 11 andersca 2013-09-01 10:35:03 -0700 V8 is gone. 80920 2011-02-02 09:21:23 -0800 2011-02-02 09:23:58 -0800 Patch bug-53596-20110202202121.patch text/plain 5630 antonm ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxEb2N1bWVudC93cml0ZS1jYWxs LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxEb2N1bWVudC93cml0ZS1j YWxsLWV4cGVjdGVkLnR4dAppbmRleCA2NWJlNzM1YWVlMjQ2YzcwN2NhYTA1MDdlZWI4NTgxNmVj MjQ5ZDAwLi4xNzYxOWFlODc4MDAwMGNmYWMyMTQ0N2Q3M2U1NzA4NzU4ZTMzZWM4IDEwMDY0NAot LS0gYS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MRG9jdW1lbnQvd3JpdGUtY2FsbC1leHBlY3Rl ZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTERvY3VtZW50L3dyaXRlLWNhbGwt ZXhwZWN0ZWQudHh0CkBAIC0xLDkgKzEsMyBAQAogVGVzdHM6IGNhbGxpbmcgSFRNTERvY3VtZW50 Ojp3cml0ZQogCi1Db25kaXRpb24ocyk6Ci0KLVN1Y2Nlc3MgbWVzc2FnZTogcGFzc2VkCi0KLUZh aWx1cmUgbWVzc2FnZTogW25vIG91dHB1dF0KLQotcGFzc2VkCitwYXNzZWRleGNlcHRpb24KZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxEb2N1bWVudC93cml0ZS1jYWxsLmh0 bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MRG9jdW1lbnQvd3JpdGUtY2FsbC5odG1sCmlu ZGV4IGMzMzQ0MmNkZGZkZmJjMTY0ZmQ1N2Q4NGI1OTI3ZDQ2OTIxOTdkYjYuLjQ3MTEwYWQ5OTA1 ZDhjMTQzZTEyOTBlYmY5NDFkMjQ0ODk1MzU0MzEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zh c3QvZG9tL0hUTUxEb2N1bWVudC93cml0ZS1jYWxsLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFz dC9kb20vSFRNTERvY3VtZW50L3dyaXRlLWNhbGwuaHRtbApAQCAtNywxNCArNywxNiBAQCBmdW5j dGlvbiB0ZXN0KCkgewogCX0KIAogCWRvY3VtZW50LndyaXRlKCJwYXNzZWQiKTsKKyAgdHJ5IHsK KyAgICBkb2N1bWVudC53cml0ZSgiZm9vIiwgeyB0b1N0cmluZzogZnVuY3Rpb24oKSB7IHRocm93 ICdleGNlcHRpb24nOyB9fSk7CisgIH0gY2F0Y2ggKGUpIHsKKyAgICBkb2N1bWVudC53cml0ZShl KTsKKyAgfQogfQogPC9zY3JpcHQ+CiA8L2hlYWQ+CiA8Ym9keT4KIDxwPlRlc3RzOiBjYWxsaW5n IEhUTUxEb2N1bWVudDo6d3JpdGU8L3A+Ci08cD5Db25kaXRpb24ocyk6PC9wPgotPHA+U3VjY2Vz cyBtZXNzYWdlOiBwYXNzZWQ8L3A+Ci08cD5GYWlsdXJlIG1lc3NhZ2U6IFtubyBvdXRwdXRdPC9w PgogPGhyPgogPC9ib2R5PgogPHNjcmlwdD50ZXN0KCk8L3NjcmlwdD4KZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxEb2N1bWVudC93cml0ZWxuLWNhbGwtZXhwZWN0ZWQudHh0 IGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTERvY3VtZW50L3dyaXRlbG4tY2FsbC1leHBlY3Rl ZC50eHQKaW5kZXggZjk4YWEyOTcyZGJkZDlkZmUzNDcyZTZhNjk1OTIzZjU1Yjk1MmRhYy4uMTdh NDJmODQ5ZjA4NDZhNWMzZGE2ZjQ2ZTNlZDU5YTQ0MGQ5YmYzOCAxMDA2NDQKLS0tIGEvTGF5b3V0 VGVzdHMvZmFzdC9kb20vSFRNTERvY3VtZW50L3dyaXRlbG4tY2FsbC1leHBlY3RlZC50eHQKKysr IGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTERvY3VtZW50L3dyaXRlbG4tY2FsbC1leHBlY3Rl ZC50eHQKQEAgLTEsOSArMSwzIEBACiBUZXN0czogY2FsbGluZyBIVE1MRG9jdW1lbnQ6OndyaXRl bG4KIAotQ29uZGl0aW9uKHMpOgotCi1TdWNjZXNzIG1lc3NhZ2U6IHN1Y2Nlc3MKLQotRmFpbHVy ZSBtZXNzYWdlOiBbbm8gb3V0cHV0XQotCi1zdWNjZXNzCitzdWNjZXNzIGV4Y2VwdGlvbgpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTERvY3VtZW50L3dyaXRlbG4tY2FsbC5o dG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTERvY3VtZW50L3dyaXRlbG4tY2FsbC5odG1s CmluZGV4IGE5YzY4MjMwYTEyYTY1YjA5OGIwNWJhMDQxY2IzYjBhMmJjYTg4OTguLjM3OWJhODIy OGVmNjE0NDc1YTMwZTk4NDhjNTRhNzk3ZTgxM2ZmNzYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L2Zhc3QvZG9tL0hUTUxEb2N1bWVudC93cml0ZWxuLWNhbGwuaHRtbAorKysgYi9MYXlvdXRUZXN0 cy9mYXN0L2RvbS9IVE1MRG9jdW1lbnQvd3JpdGVsbi1jYWxsLmh0bWwKQEAgLTcsMTQgKzcsMTYg QEAgZnVuY3Rpb24gdGVzdCgpIHsKIAl9CiAKIAlkb2N1bWVudC53cml0ZWxuKCJzdWNjZXNzIik7 CisgIHRyeSB7CisgICAgZG9jdW1lbnQud3JpdGVsbigiZm9vIiwgeyB0b1N0cmluZzogZnVuY3Rp b24oKSB7IHRocm93ICdleGNlcHRpb24nOyB9fSk7CisgIH0gY2F0Y2ggKGUpIHsKKyAgICBkb2N1 bWVudC53cml0ZWxuKGUpOworICB9CiB9CiA8L3NjcmlwdD4KIDwvaGVhZD4KIDxib2R5PgogPHA+ VGVzdHM6IGNhbGxpbmcgSFRNTERvY3VtZW50Ojp3cml0ZWxuPC9wPgotPHA+Q29uZGl0aW9uKHMp OiA8L3A+Ci08cD4gU3VjY2VzcyBtZXNzYWdlOiBzdWNjZXNzIDwvcD4KLTxwPkZhaWx1cmUgbWVz c2FnZTogW25vIG91dHB1dF0gPC9wPgogPGhyPgogPC9ib2R5PgogPHNjcmlwdD50ZXN0KCk8L3Nj cmlwdD4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJD b3JlL0NoYW5nZUxvZwppbmRleCA5NGMzZjdlMjg2M2I4NThhYjZiZTYzYWM4ZTMyOTI4ZmYyNmZm ZjlkLi4yZWIzNDEwMWEwYmQwMzJkOWNjOTVhODE2MGIxMGQ4ZTg2MTViMzE3IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDItMDIgIEFudG9uIE11aGluICA8YW50b25tQGNocm9t aXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBbdjhdIFByb3Blcmx5IHByb2Nlc3MgZXhjZXB0aW9ucyB0aHJvd24gd2hpbGUgY29udmVydGlu ZyBvYmplY3RzIHRvIHN0cmluZyBpbiBIVE1MRG9jdW1lbnQud3JpdGV7LGxufSBtZXRob2RzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MzU5NgorCisg ICAgICAgIGZhc3QvZG9tL0hUTUxEb2N1bWVudC93cml0ZXssbG59LWNhbGwuaHRtbCBoYXMgYmVl biBtb2RpZmllZCB0byB2ZXJpZnkgYmVoYXZpb3VyLgorCisgICAgICAgICogYmluZGluZ3Mvdjgv Y3VzdG9tL1Y4SFRNTERvY3VtZW50Q3VzdG9tLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OndyaXRl SGVscGVyR2V0U3RyaW5nKTogYmFpbCBvdXQgaWYgZXhjZXB0aW9uIGlzIHRocm93biBpbiBjb252 ZXJzaW9uCisgICAgICAgIChXZWJDb3JlOjpWOEhUTUxEb2N1bWVudDo6d3JpdGVDYWxsYmFjayk6 IERpdHRvCisgICAgICAgIChXZWJDb3JlOjpWOEhUTUxEb2N1bWVudDo6d3JpdGVsbkNhbGxiYWNr KTogRGl0dG8KKwogMjAxMS0wMi0wMiAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFjaWVqIFN0YWNob3dpYWsuCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhIVE1MRG9jdW1lbnRDdXN0b20uY3Bw IGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4SFRNTERvY3VtZW50Q3VzdG9t LmNwcAppbmRleCAyNGFjNDdjZWQ3MDI1ZGIxM2RiYTA0MjdhNDQyYzBiODVmOGJiNGNhLi40ZjE5 MGE3ZWFlMzllZjljZTQwYTkxY2JiNTRkZGJkY2E1Y2Y4ZTZkIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhIVE1MRG9jdW1lbnRDdXN0b20uY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEhUTUxEb2N1bWVudEN1c3RvbS5j cHAKQEAgLTEwMyw4ICsxMDMsMTMgQEAgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IFY4SFRNTERvY3Vt ZW50OjpHZXROYW1lZFByb3BlcnR5KEhUTUxEb2N1bWVudCogaHRtbERvY3VtZW4KIHN0YXRpYyBT dHJpbmcgd3JpdGVIZWxwZXJHZXRTdHJpbmcoY29uc3Qgdjg6OkFyZ3VtZW50cyYgYXJncykKIHsK ICAgICBTdHJpbmcgc3RyID0gIiI7Ci0gICAgZm9yIChpbnQgaSA9IDA7IGkgPCBhcmdzLkxlbmd0 aCgpOyArK2kpCi0gICAgICAgIHN0ciArPSB0b1dlYkNvcmVTdHJpbmcoYXJnc1tpXSk7CisgICAg Zm9yIChpbnQgaSA9IDA7IGkgPCBhcmdzLkxlbmd0aCgpOyArK2kpIHsKKyAgICAgICAgVjhQYXJh bWV0ZXI8V2l0aFVuZGVmaW5lZE9yTnVsbENoZWNrPiBhcmcoYXJnc1tpXSk7CisgICAgICAgIGlm ICghYXJnLnByZXBhcmUoKSkgLy8gRmFpbGVkIHRvIGNvbnZlcnQgdG8gc3RyaW5nLgorICAgICAg ICAgICAgcmV0dXJuIFN0cmluZygpOworCisgICAgICAgIHN0ciArPSBhcmcub3BlcmF0b3IgU3Ry aW5nKCk7CisgICAgfQogICAgIHJldHVybiBzdHI7CiB9CiAKQEAgLTExMyw3ICsxMTgsMTAgQEAg djg6OkhhbmRsZTx2ODo6VmFsdWU+IFY4SFRNTERvY3VtZW50Ojp3cml0ZUNhbGxiYWNrKGNvbnN0 IHY4OjpBcmd1bWVudHMmIGFyZ3MpCiAgICAgSU5DX1NUQVRTKCJET00uSFRNTERvY3VtZW50Lndy aXRlKCkiKTsKICAgICBIVE1MRG9jdW1lbnQqIGh0bWxEb2N1bWVudCA9IFY4SFRNTERvY3VtZW50 Ojp0b05hdGl2ZShhcmdzLkhvbGRlcigpKTsKICAgICBGcmFtZSogZnJhbWUgPSBWOFByb3h5Ojpy ZXRyaWV2ZUZyYW1lRm9yQ2FsbGluZ0NvbnRleHQoKTsKLSAgICBodG1sRG9jdW1lbnQtPndyaXRl KHdyaXRlSGVscGVyR2V0U3RyaW5nKGFyZ3MpLCBmcmFtZSA/IGZyYW1lLT5kb2N1bWVudCgpIDog TlVMTCk7CisgICAgU3RyaW5nIHMgPSB3cml0ZUhlbHBlckdldFN0cmluZyhhcmdzKTsKKyAgICBp ZiAocy5pc051bGwoKSkgLy8gQW4gZXhjZXB0aW9uIGhhcyBiZWVuIHRocm93biwgcmV0dXJuIGJh Y2sgdG8gSlMgQVNBUC4KKyAgICAgICAgcmV0dXJuIHY4OjpIYW5kbGU8djg6OlZhbHVlPigpOwor ICAgIGh0bWxEb2N1bWVudC0+d3JpdGUocywgZnJhbWUgPyBmcmFtZS0+ZG9jdW1lbnQoKSA6IDAp OwogICAgIHJldHVybiB2ODo6VW5kZWZpbmVkKCk7CiB9CiAKQEAgLTEyMiw3ICsxMzAsMTAgQEAg djg6OkhhbmRsZTx2ODo6VmFsdWU+IFY4SFRNTERvY3VtZW50Ojp3cml0ZWxuQ2FsbGJhY2soY29u c3Qgdjg6OkFyZ3VtZW50cyYgYXJncykKICAgICBJTkNfU1RBVFMoIkRPTS5IVE1MRG9jdW1lbnQu d3JpdGVsbigpIik7CiAgICAgSFRNTERvY3VtZW50KiBodG1sRG9jdW1lbnQgPSBWOEhUTUxEb2N1 bWVudDo6dG9OYXRpdmUoYXJncy5Ib2xkZXIoKSk7CiAgICAgRnJhbWUqIGZyYW1lID0gVjhQcm94 eTo6cmV0cmlldmVGcmFtZUZvckNhbGxpbmdDb250ZXh0KCk7Ci0gICAgaHRtbERvY3VtZW50LT53 cml0ZWxuKHdyaXRlSGVscGVyR2V0U3RyaW5nKGFyZ3MpLCBmcmFtZSA/IGZyYW1lLT5kb2N1bWVu dCgpIDogTlVMTCk7CisgICAgU3RyaW5nIHMgPSB3cml0ZUhlbHBlckdldFN0cmluZyhhcmdzKTsK KyAgICBpZiAocy5pc051bGwoKSkgLy8gQW4gZXhjZXB0aW9uIGhhcyBiZWVuIHRocm93biwgcmV0 dXJuIGJhY2sgdG8gSlMgQVNBUC4KKyAgICAgICAgcmV0dXJuIHY4OjpIYW5kbGU8djg6OlZhbHVl PigpOworICAgIGh0bWxEb2N1bWVudC0+d3JpdGVsbihzLCBmcmFtZSA/IGZyYW1lLT5kb2N1bWVu dCgpIDogMCk7CiAgICAgcmV0dXJuIHY4OjpVbmRlZmluZWQoKTsKIH0KIAo=