53574 2011-02-01 21:52:13 -0800 REGRESSION (r76012): :last-child:after not working as expected 2011-02-04 13:17:27 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) All All RESOLVED FIXED HasReduction, InRadar, Regression P2 Normal --- 52370 1 priyajeet.hora koivisto aestes dglazkov hyatt koivisto priyajeet.hora simon.fraser oldest_to_newest 343845 0 80888 priyajeet.hora 2011-02-01 21:52:13 -0800 Created attachment 80888 testcase Downstream bug: http://code.google.com/p/chromium/issues/detail?id=71213 Test case attached. Expected: *1X *2X *3 Actual *1X *2X *3X Happens in r77333 of webkit nightly, seems fine in r77224. <!DOCTYPE html> <html> <head> <title>:last-child:after</title> <style> li:after { content:"X"; } li:last-child:after{ content:""; } </style> </head> <body> <ul> <li>1</li> <li>2</li> <li>3</li> </ul> </body> </html> 344000 1 ap 2011-02-02 09:15:00 -0800 <rdar://problem/8948643> 344070 2 aestes 2011-02-02 11:09:58 -0800 Caused by <http://trac.webkit.org/changeset/76012>. 345597 3 dglazkov 2011-02-04 10:27:31 -0800 Here's another reduction: http://jsfiddle.net/dglazkov/NmKkQ/ Should display 1234. 345719 4 81274 koivisto 2011-02-04 13:08:44 -0800 Created attachment 81274 patch 345722 5 81274 dglazkov 2011-02-04 13:10:15 -0800 Comment on attachment 81274 patch yay! 345726 6 koivisto 2011-02-04 13:11:57 -0800 also fixes Bug 53610 345730 7 koivisto 2011-02-04 13:17:27 -0800 http://trac.webkit.org/changeset/77664 80888 2011-02-01 21:52:13 -0800 2011-02-01 21:52:13 -0800 testcase lastchild.html text/html 346 priyajeet.hora PCFET0NUWVBFIGh0bWw+CiAgPGh0bWw+CiAgICA8aGVhZD4KICAgICAgPHRpdGxlPjpsYXN0LWNo aWxkOmFmdGVyPC90aXRsZT4KICAgICAgPHN0eWxlPgogICAgICAgIGxpOmFmdGVyIHsKICAgICAg ICAgIGNvbnRlbnQ6IlgiOwogICAgICAgIH0KICAgIAogICAgICAgIGxpOmxhc3QtY2hpbGQ6YWZ0 ZXJ7CiAgICAgICAgICBjb250ZW50OiIiOwogICAgICAgIH0KICAgICAgPC9zdHlsZT4KICAgIDwv aGVhZD4KICAgIDxib2R5PgogICAgICA8dWw+CiAgICAgICAgPGxpPjE8L2xpPgogICAgICAgIDxs aT4yPC9saT4KICAgICAgICA8bGk+MzwvbGk+CiAgICAgIDwvdWw+CiAgICA8L2JvZHk+CiAgPC9o dG1sPg== 81274 2011-02-04 13:08:44 -0800 2011-02-04 13:10:14 -0800 patch style-sharing-regressions.patch text/plain 6574 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc3NjYwKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTEtMDItMDQgIEFudHRpIEtv aXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD01MzYxMAorICAgICAgICBSZWdyZXNzaW9uOiBhZGphY2VudCBzaWJsaW5nIHNlbGVjdG9yIG5v dCB3b3JraW5nIGFzIGV4cGVjdGVkCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS84OTYwMDMzPgor ICAgICAgICAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTUzNTc0CisgICAgICAgIFJFR1JFU1NJT04gKHI3NjAxMik6IDpsYXN0LWNoaWxkOmFmdGVyIG5v dCB3b3JraW5nIGFzIGV4cGVjdGVkCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS84OTQ4NjQzPgor ICAgICAgICAKKyAgICAgICAgVGVzdCBmb3IgYWRkaXRpb25hbCBjb25kaXRpb25zIGluIHBhcmVu dCBzdHlsZSB0aGF0IHByZXZlbnQgc2hhcmluZy4KKworICAgICAgICBUZXN0czogZmFzdC9zZWxl Y3RvcnMvc3R5bGUtc2hhcmluZy1hZGphY2VudC1zZWxlY3Rvci5odG1sCisgICAgICAgICAgICAg ICBmYXN0L3NlbGVjdG9ycy9zdHlsZS1zaGFyaW5nLWxhc3QtY2hpbGQuaHRtbAorCisgICAgICAg ICogY3NzL0NTU1N0eWxlU2VsZWN0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6cGFyZW50U3R5 bGVQcmV2ZW50c1NoYXJpbmcpOgorICAgICAgICAoV2ViQ29yZTo6Q1NTU3R5bGVTZWxlY3Rvcjo6 bG9jYXRlU2hhcmVkU3R5bGUpOgorCiAyMDExLTAyLTA0ICBSb2JlcnQgSG9nYW4gIDxyb2JlcnRA d2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBGaXNoZXIuCkluZGV4OiBT b3VyY2UvV2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkNvcmUvY3NzL0NTU1N0eWxlU2VsZWN0b3IuY3BwCShyZXZpc2lvbiA3NzUxNykKKysr IFNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcAkod29ya2luZyBjb3B5KQpA QCAtMTA5NSw2ICsxMDk1LDE0IEBAIGlubGluZSBOb2RlKiBDU1NTdHlsZVNlbGVjdG9yOjpmaW5k U2libGkKICAgICByZXR1cm4gbm9kZTsKIH0KIAorc3RhdGljIGlubGluZSBib29sIHBhcmVudFN0 eWxlUHJldmVudHNTaGFyaW5nKGNvbnN0IFJlbmRlclN0eWxlKiBwYXJlbnRTdHlsZSkKK3sKKyAg ICByZXR1cm4gcGFyZW50U3R5bGUtPmNoaWxkcmVuQWZmZWN0ZWRCeVBvc2l0aW9uYWxSdWxlcygp IAorICAgICAgICB8fCBwYXJlbnRTdHlsZS0+Y2hpbGRyZW5BZmZlY3RlZEJ5Rmlyc3RDaGlsZFJ1 bGVzKCkKKyAgICAgICAgfHwgcGFyZW50U3R5bGUtPmNoaWxkcmVuQWZmZWN0ZWRCeUxhc3RDaGls ZFJ1bGVzKCkgCisgICAgICAgIHx8IHBhcmVudFN0eWxlLT5jaGlsZHJlbkFmZmVjdGVkQnlEaXJl Y3RBZGphY2VudFJ1bGVzKCk7Cit9CisKIEFMV0FZU19JTkxJTkUgUmVuZGVyU3R5bGUqIENTU1N0 eWxlU2VsZWN0b3I6OmxvY2F0ZVNoYXJlZFN0eWxlKCkKIHsKICAgICBpZiAoIW1fc3R5bGVkRWxl bWVudCB8fCAhbV9wYXJlbnRTdHlsZSkKQEAgLTExMDUsNiArMTExMyw4IEBAIEFMV0FZU19JTkxJ TkUgUmVuZGVyU3R5bGUqIENTU1N0eWxlU2VsZWMKICAgICAvLyBJZHMgc3RvcCBzdHlsZSBzaGFy aW5nIGlmIHRoZXkgc2hvdyB1cCBpbiB0aGUgc3R5bGVzaGVldHMuCiAgICAgaWYgKG1fc3R5bGVk RWxlbWVudC0+aGFzSUQoKSAmJiBtX2lkc0luUnVsZXMuY29udGFpbnMobV9zdHlsZWRFbGVtZW50 LT5pZEZvclN0eWxlUmVzb2x1dGlvbigpLmltcGwoKSkpCiAgICAgICAgIHJldHVybiAwOworICAg IGlmIChwYXJlbnRTdHlsZVByZXZlbnRzU2hhcmluZyhtX3BhcmVudFN0eWxlKSkKKyAgICAgICAg cmV0dXJuIDA7CiAgICAgLy8gQ2hlY2sgcHJldmlvdXMgc2libGluZ3MuCiAgICAgdW5zaWduZWQg Y291bnQgPSAwOwogICAgIE5vZGUqIHNoYXJlTm9kZSA9IGZpbmRTaWJsaW5nRm9yU3R5bGVTaGFy aW5nKG1fc3R5bGVkRWxlbWVudC0+cHJldmlvdXNTaWJsaW5nKCksIGNvdW50KTsKQEAgLTExMTgs NyArMTEyOCw3IEBAIEFMV0FZU19JTkxJTkUgUmVuZGVyU3R5bGUqIENTU1N0eWxlU2VsZWMKICAg ICBpZiAobWF0Y2hlc1NpYmxpbmdSdWxlcygpKQogICAgICAgICByZXR1cm4gMDsKICAgICAvLyBU cmFja2luZyBjaGlsZCBpbmRleCByZXF1aXJlcyB1bmlxdWUgc3R5bGUgZm9yIGVhY2ggbm9kZS4g VGhpcyBtYXkgZ2V0IHNldCBieSB0aGUgc2libGluZyBydWxlIG1hdGNoIGFib3ZlLgotICAgIGlm IChtX3BhcmVudFN0eWxlLT5jaGlsZHJlbkFmZmVjdGVkQnlQb3NpdGlvbmFsUnVsZXMoKSkKKyAg ICBpZiAocGFyZW50U3R5bGVQcmV2ZW50c1NoYXJpbmcobV9wYXJlbnRTdHlsZSkpCiAgICAgICAg IHJldHVybiAwOwogICAgIHJldHVybiBzaGFyZU5vZGUtPnJlbmRlclN0eWxlKCk7CiB9CkluZGV4 OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCShyZXZpc2lvbiA3NzY2MCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBj b3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDExLTAyLTA0ICBBbnR0aSBLb2l2aXN0byAgPGFudHRp QGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTM2MTAKKyAgICAg ICAgUmVncmVzc2lvbjogYWRqYWNlbnQgc2libGluZyBzZWxlY3RvciBub3Qgd29ya2luZyBhcyBl eHBlY3RlZAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vODk2MDAzMz4KKyAgICAgICAgCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MzU3NAorICAgICAg ICBSRUdSRVNTSU9OIChyNzYwMTIpOiA6bGFzdC1jaGlsZDphZnRlciBub3Qgd29ya2luZyBhcyBl eHBlY3RlZAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vODk0ODY0Mz4KKworICAgICAgICAqIGZh c3Qvc2VsZWN0b3JzL3N0eWxlLXNoYXJpbmctYWRqYWNlbnQtc2VsZWN0b3ItZXhwZWN0ZWQudHh0 OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L3NlbGVjdG9ycy9zdHlsZS1zaGFyaW5nLWFkamFjZW50 LXNlbGVjdG9yLmh0bWw6IEFkZGVkLgorICAgICAgICAqIGZhc3Qvc2VsZWN0b3JzL3N0eWxlLXNo YXJpbmctbGFzdC1jaGlsZC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3Qvc2Vs ZWN0b3JzL3N0eWxlLXNoYXJpbmctbGFzdC1jaGlsZC5odG1sOiBBZGRlZC4KKwogMjAxMS0wMi0w NCAgUm9iZXJ0IEhvZ2FuICA8cm9iZXJ0QHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgRGFyaW4gRmlzaGVyLgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9zZWxlY3RvcnMvc3R5bGUt c2hhcmluZy1hZGphY2VudC1zZWxlY3Rvci1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5 b3V0VGVzdHMvZmFzdC9zZWxlY3RvcnMvc3R5bGUtc2hhcmluZy1hZGphY2VudC1zZWxlY3Rvci1l eHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L3NlbGVjdG9ycy9z dHlsZS1zaGFyaW5nLWFkamFjZW50LXNlbGVjdG9yLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkK QEAgLTAsMCArMSw3IEBACitUaGlzIHRleHQgc2hvdWxkIGJlIGJsYWNrLgorCitUaGlzIHRleHQg c2hvdWxkIGJlIHJlZC4KKworVGhpcyB0ZXh0IHNob3VsZCBiZSBibGFjay4KKworUEFTUwpJbmRl eDogTGF5b3V0VGVzdHMvZmFzdC9zZWxlY3RvcnMvc3R5bGUtc2hhcmluZy1hZGphY2VudC1zZWxl Y3Rvci5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3Qvc2VsZWN0b3JzL3N0eWxl LXNoYXJpbmctYWRqYWNlbnQtc2VsZWN0b3IuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRl c3RzL2Zhc3Qvc2VsZWN0b3JzL3N0eWxlLXNoYXJpbmctYWRqYWNlbnQtc2VsZWN0b3IuaHRtbAko cmV2aXNpb24gMCkKQEAgLTAsMCArMSwyMiBAQAorPGh0bWw+IA0KKzxoZWFkPiANCis8c2NyaXB0 Pg0KK2lmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpDQorICAgIGxheW91dFRlc3RDb250 cm9sbGVyLmR1bXBBc1RleHQoKTsNCisNCitmdW5jdGlvbiB0ZXN0KCkgew0KKyAgICB2YXIgcGFz c2VkID0gd2luZG93LmdldENvbXB1dGVkU3R5bGUoZG9jdW1lbnQuZ2V0RWxlbWVudHNCeVRhZ05h bWUoJ3AnKVsyXSkuY29sb3IgPT09ICJyZ2IoMCwgMCwgMCkiOw0KKyAgICBkb2N1bWVudC5nZXRF bGVtZW50c0J5VGFnTmFtZSgnZGl2JylbMF0uaW5uZXJUZXh0ID0gcGFzc2VkID8gIlBBU1MiIDog IkZBSUwiOw0KK30NCis8L3NjcmlwdD4NCis8c3R5bGU+IA0KKyAgICBwLmZvbyArIHAgeyBjb2xv cjogcmVkOyB9DQorPC9zdHlsZT4gDQorPC9oZWFkPiANCis8Ym9keSBvbmxvYWQ9InRlc3QoKSI+ IA0KKyAgICA8cCBjbGFzcz0iZm9vIj5UaGlzIHRleHQgc2hvdWxkIGJlIGJsYWNrLjwvcD4gDQor ICAgIDxwPlRoaXMgdGV4dCBzaG91bGQgYmUgcmVkLjwvcD4gDQorICAgIDxwPlRoaXMgdGV4dCBz aG91bGQgYmUgYmxhY2suPC9wPg0KKyAgICA8ZGl2PjwvZGl2Pg0KKzwvYm9keT4NCis8L2h0bWw+ DQpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9zZWxlY3RvcnMvc3R5bGUtc2hhcmluZy1sYXN0LWNo aWxkLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L3NlbGVjdG9y cy9zdHlsZS1zaGFyaW5nLWxhc3QtY2hpbGQtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysg TGF5b3V0VGVzdHMvZmFzdC9zZWxlY3RvcnMvc3R5bGUtc2hhcmluZy1sYXN0LWNoaWxkLWV4cGVj dGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwzIEBACitZb3Ugc2hvdWxkIHNlZSAxMjM0 IGJlbG93ICg0IHdvbid0IGJlIHZpc2libGUgaW4gdGhlIERSVCB0ZXh0IGR1bXAsIGJ1dCBpdCBz aG91bGQgc3RpbGwgc2F5IFBBU1MgYmVsb3cpCisxMjMKK1BBU1MKSW5kZXg6IExheW91dFRlc3Rz L2Zhc3Qvc2VsZWN0b3JzL3N0eWxlLXNoYXJpbmctbGFzdC1jaGlsZC5odG1sCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIExheW91dFRlc3RzL2Zhc3Qvc2VsZWN0b3JzL3N0eWxlLXNoYXJpbmctbGFzdC1jaGlsZC5o dG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9zZWxlY3RvcnMvc3R5bGUtc2hh cmluZy1sYXN0LWNoaWxkLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMjkgQEAKKzxodG1s PgorPGhlYWQ+Cis8c2NyaXB0PgoraWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAg ICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisKK2Z1bmN0aW9uIHRlc3QoKSB7 CisgICAgdmFyIHBhc3NlZCA9IGRvY3VtZW50LmdldEVsZW1lbnRzQnlUYWdOYW1lKCdsaScpWzJd Lm9mZnNldFdpZHRoID4gZG9jdW1lbnQuZ2V0RWxlbWVudHNCeVRhZ05hbWUoJ2xpJylbMF0ub2Zm c2V0V2lkdGg7CisgICAgZG9jdW1lbnQuZ2V0RWxlbWVudHNCeVRhZ05hbWUoJ2RpdicpWzBdLmlu bmVyVGV4dCA9IHBhc3NlZCA/ICJQQVNTIiA6ICJGQUlMIjsKK30KKzwvc2NyaXB0PgorPHN0eWxl IHR5cGU9InRleHQvY3NzIj4KKyAgICB1bCwgbGkge2Rpc3BsYXk6IGlubGluZTt9CisgICAgdWwg e21hcmdpbjogMDt9CisgICAgbGkgeyBmbG9hdDogbGVmdDsgfQorICAgIGxpOmxhc3QtY2hpbGQ6 YWZ0ZXIge2NvbnRlbnQ6ICI0Ijt9Cis8L3N0eWxlPgorPC9oZWFkPgorPGJvZHkgb25sb2FkPSJ0 ZXN0KCkiPgorICAgIFlvdSBzaG91bGQgc2VlIDEyMzQgYmVsb3cgKDQgd29uJ3QgYmUgdmlzaWJs ZSBpbiB0aGUgRFJUIHRleHQgZHVtcCwgYnV0IGl0IHNob3VsZCBzdGlsbCBzYXkgUEFTUyBiZWxv dyk8YnI+CisgICAgPHVsPgorICAgICAgICA8bGk+MTwvbGk+CisgICAgICAgIDxsaT4yPC9saT4K KyAgICAgICAgPGxpPjM8L2xpPgorICAgIDwvdWw+CisgICAgPGJyPgorICAgIDxkaXY+PC9kaXY+ Cis8L2JvZHk+Cis8L2h0bWw+Cg==