5357 2005-10-12 15:49:22 -0700 REGRESSION: Scriptable plugin hides properties of OBJECT element 2005-11-07 23:08:25 -0800 1 1 1 Unclassified WebKit JavaScriptCore 420+ Mac OS X 10.4 VERIFIED FIXED P1 Major --- 1 mitz ggaren oldest_to_newest 21925 0 mitz 2005-10-12 15:49:22 -0700 A plugin that implements a scriptable object in ObjC can cause all properties of the OBJECT element containing it to be undefined. To reproduce: open the testcase in Safari. It tests for the children property not being undefined. This happens when the plugin does not respond to invokeUndefinedMethodFromWebScript:withArguments:. 21926 1 4330 mitz 2005-10-12 15:50:51 -0700 Created attachment 4330 testcase 21927 2 4331 mitz 2005-10-12 15:58:51 -0700 Created attachment 4331 proposed patch The bug resulted from the path for bug 4313, specifically the change in RuntimeObjectImp::getOwnPropertySlot. An alternative fix is to undo that change. 21973 3 4331 darin 2005-10-13 07:17:03 -0700 Comment on attachment 4331 proposed patch I believe the underlying cause here is that Objective-C "undefined" values are not returned true to isUndefined(). I think we should fix that rather than applying this patch or undoing the change from bug 4313. 22246 4 4331 mitz 2005-10-19 00:08:52 -0700 Comment on attachment 4331 proposed patch Asking Maciej to review this patch, after I talked with Darin. 22970 5 4331 mjs 2005-10-25 22:24:10 -0700 Comment on attachment 4331 proposed patch r=me 4330 2005-10-12 15:50:51 -0700 2005-10-12 15:50:51 -0700 testcase pluginHidesProperties.html text/html 598 mitz PGh0bWw+CjxoZWFkPgo8dGl0bGU+UGx1Z2luIGhpZGVzIE9CSkVDVCdzIHByb3BlcnRpZXM8L3Rp dGxlPgo8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCI+CmZ1bmN0aW9uIHRlc3QoKQp7CiAg ICB2YXIgcmVzdWx0ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ29iaicpLmNoaWxkcmVuID09 IHVuZGVmaW5lZCA/ICJGQUlMRUQiIDogIlBBU1NFRCI7CiAgICBkb2N1bWVudC5nZXRFbGVtZW50 QnlJZCgicmVzdWx0IikuaW5uZXJUZXh0ID0gcmVzdWx0Owp9Cjwvc2NyaXB0Pgo8L2hlYWQ+Cjxi b2R5IG9ubG9hZD0idGVzdCgpIj4KPHA+ClRoaXMgdGVzdCBjaGVja3MgZm9yIGEgcmVncmVzc2lv biB3aGVyZSBzY3JpcHRhYmxlIHBsdWdpbnMgaGlkZSBwcm9wZXJ0aWVzIG9mCnRoZSBPQkpFQ1Qg ZWxlbWVudC4KSWYgdGhlIHRlc3QgcGFzc2VzLCB5b3Ugd2lsbCBzZWUgYSAiUEFTU0VEIiBtZXNz YWdlIGJlbG93Lgo8L3A+CjxwIGlkPSJyZXN1bHQiPjwvcD4KPG9iamVjdCBpZD0ib2JqIiBjbGFz c2lkPSJjbHNpZDowMkJGMjVENS04QzE3LTRCMjMtQkM4MC1EMzQ4OEFCRERDNkIiPjwhLS0gcXVp Y2t0aW1lIC0tPgo8L29iamVjdD4KPC9ib2R5Pg== 4331 2005-10-12 15:58:51 -0700 2005-10-25 22:24:10 -0700 proposed patch 5357_r1.patch text/plain 911 mitz SW5kZXg6IG9iamNfY2xhc3MubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9yb290L0phdmFT Y3JpcHRDb3JlL2JpbmRpbmdzL29iamMvb2JqY19jbGFzcy5tbSx2CnJldHJpZXZpbmcgcmV2aXNp b24gMS4xMQpkaWZmIC1wIC11IC1yMS4xMSBvYmpjX2NsYXNzLm1tCi0tLSBvYmpjX2NsYXNzLm1t CTMgT2N0IDIwMDUgMjE6MTE6NDYgLTAwMDAJMS4xMQorKysgb2JqY19jbGFzcy5tbQkxMiBPY3Qg MjAwNSAyMjo1NjoyOCAtMDAwMApAQCAtMjM2LDcgKzIzNiwxMiBAQCBGaWVsZCAqT2JqY0NsYXNz OjpmaWVsZE5hbWVkKGNvbnN0IGNoYXIgCiAKIFZhbHVlSW1wICpPYmpjQ2xhc3M6OmZhbGxiYWNr T2JqZWN0IChFeGVjU3RhdGUgKmV4ZWMsIEluc3RhbmNlICppbnN0YW5jZSwgY29uc3QgSWRlbnRp ZmllciAmcHJvcGVydHlOYW1lKQogewotICAgIHJldHVybiBuZXcgT2JqY0ZhbGxiYWNrT2JqZWN0 SW1wKHN0YXRpY19jYXN0PE9iamNJbnN0YW5jZSo+KGluc3RhbmNlKSwgcHJvcGVydHlOYW1lKTsK KyAgICBPYmpjSW5zdGFuY2UgKiBvYmpjSW5zdGFuY2UgPSBzdGF0aWNfY2FzdDxPYmpjSW5zdGFu Y2UqPihpbnN0YW5jZSk7CisgICAgaWQgdGFyZ2V0T2JqZWN0ID0gb2JqY0luc3RhbmNlLT5nZXRP YmplY3QoKTsKKyAgICAKKyAgICBpZiAoIVt0YXJnZXRPYmplY3QgcmVzcG9uZHNUb1NlbGVjdG9y OkBzZWxlY3RvcihpbnZva2VVbmRlZmluZWRNZXRob2RGcm9tV2ViU2NyaXB0OndpdGhBcmd1bWVu dHM6KV0pCisgICAgICAgIHJldHVybiBqc1VuZGVmaW5lZCgpOworICAgIHJldHVybiBuZXcgT2Jq Y0ZhbGxiYWNrT2JqZWN0SW1wKG9iamNJbnN0YW5jZSwgcHJvcGVydHlOYW1lKTsKIH0KIAogfQo=