53561 2011-02-01 17:40:27 -0800 Stepping through print previews in WebKit2 mode steps in and out of printing mode a lot 2011-02-02 10:52:50 -0800 1 1 1 Unclassified WebKit Printing 528+ (Nightly build) Mac OS X 10.6 RESOLVED FIXED InRadar P2 Normal --- 1 ap ap sam oldest_to_newest 343713 0 ap 2011-02-01 17:40:27 -0800 This makes performance of stepping through print preview really bad on documents with many pages, such as <http://www.whatwg.org/specs/web-apps/current-work/> <rdar://problem/8900228> 343720 1 80862 ap 2011-02-01 17:47:39 -0800 Created attachment 80862 proposed patch 343760 2 80862 sam 2011-02-01 18:35:18 -0800 Comment on attachment 80862 proposed patch I think this would be cleaner if we added beginPrinting() endPrinting() calls to PageClient, and do the autodisplay() calls in the mac implementation of them. What do you think? 344037 3 ap 2011-02-02 10:20:58 -0800 I don't like beginPrinting/endPrinting - we already have methods with these names, and they do different things, being called at a different time. It might be better to just get a WKView (or NSWindow) pointer somehow, and have this code inside WKPrintingView, not in a page client. Not sure how to best do that, will land as is for now. 344057 4 ap 2011-02-02 10:52:17 -0800 Committed <http://trac.webkit.org/changeset/77386>. 80862 2011-02-01 17:47:39 -0800 2011-02-02 10:52:50 -0800 proposed patch autodisplay.txt text/plain 5839 ap SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDc3MzQzKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMzAgQEAKKzIwMTEtMDItMDEgIEFsZXhleSBQ cm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTUzNTYxCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS84OTAwMjI4PiBTdGVwcGluZyB0aHJv dWdoIHByaW50IHByZXZpZXdzIGluIFdlYktpdDIgbW9kZSBzdGVwcyBpbiBhbmQgb3V0IG9mCisg ICAgICAgIHByaW50aW5nIG1vZGUgYSBsb3QKKworICAgICAgICBEaXNhYmxlIE5TVmlldyBhdXRv ZGlzcGxheSwgc28gdGhhdCAtW1dLVmlldyBkcmF3UmVjdDpdIGlzbid0IGNhbGxlZCAob3RoZXIg dGhhbiB3aGVuCisgICAgICAgIHJlc2l6aW5nIHRoZSB3aW5kb3cpLCBzbyB3ZSBkb24ndCBoYXZl IHRvIHN3aXRjaCBtb2RlcyBhbGwgdGhlIHRpbWUuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJ L21hYy9QYWdlQ2xpZW50SW1wbC5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvbWFjL1BhZ2VD bGllbnRJbXBsLm1tOgorICAgICAgICAoV2ViS2l0OjpQYWdlQ2xpZW50SW1wbDo6c2V0QXV0b2Rp c3BsYXkpOgorICAgICAgICAqIFVJUHJvY2Vzcy9QYWdlQ2xpZW50Lmg6CisgICAgICAgICogVUlQ cm9jZXNzL1dlYlBhZ2VQcm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6 c2V0QXV0b2Rpc3BsYXkpOgorICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQYWdlUHJveHkuaDoKKyAg ICAgICAgUGlwZSB0aGUgY2FsbCBmcm9tIFdLUHJpbnRpbmdWaWV3IGRvd24gdG8gV0tWaWV3Lgor CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9tYWMvV0tQcmludGluZ1ZpZXcubW06CisgICAgICAg ICgtW1dLUHJpbnRpbmdWaWV3IGJlZ2luRG9jdW1lbnRdKTogQWRkZWQuIFdlIGRvbid0IHdhbnQg dG8gYXV0b2Rpc3BsYXkgV0tWaWV3IHdoaWxlIHByaW50aW5nLAorICAgICAgICBiZWNhdXNlIGxh eW91dCBpcyBjaGFuZ2VkIHRvIHByaW50IGF0IHRoZSB0aW1lLCBhbmQgZHJhd2luZyB0byBzY3Jl ZW4gcmVxdWlyZXMgcmVsYXlvdXQuCisgICAgICAgIAorICAgICAgICAoLVtXS1ByaW50aW5nVmll dyBlbmREb2N1bWVudF0pOiBXaGVuIG5vdCBwcmludGluZywgdHVybiBhdXRvZGlzcGxheSBiYWNr IG9uLiBBbHNvLCBjYWxsCisgICAgICAgIC1bc3VwZXIgZW5kRG9jdW1lbnRdIGZvciB1bmtub3du IGJ1dCBkZWZpbml0aXZlIGdvb2QgKG9vcHMhKS4KKwogMjAxMS0wMi0wMSAgQW5kZXJzIENhcmxz c29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCBXaW5kb3dzIGJ1aWxkLgpJ bmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1BhZ2VDbGllbnQuaAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvUGFnZUNsaWVudC5oCShyZXZpc2lvbiA3NzMyMSkK KysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9QYWdlQ2xpZW50LmgJKHdvcmtpbmcgY29weSkK QEAgLTEyNyw2ICsxMjcsNyBAQCBwdWJsaWM6CiAKICNpZiBQTEFURk9STShNQUMpCiAgICAgdmly dHVhbCB2b2lkIHNldENvbXBsZXhUZXh0SW5wdXRFbmFibGVkKHVpbnQ2NF90IHBsdWdpbkNvbXBs ZXhUZXh0SW5wdXRJZGVudGlmaWVyLCBib29sIGNvbXBsZXhUZXh0SW5wdXRFbmFibGVkKSA9IDA7 CisgICAgdmlydHVhbCB2b2lkIHNldEF1dG9kaXNwbGF5KGJvb2wpID0gMDsKIAogICAgIHZpcnR1 YWwgQ0dDb250ZXh0UmVmIGNvbnRhaW5pbmdXaW5kb3dHcmFwaGljc0NvbnRleHQoKSA9IDA7CiAj ZW5kaWYKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCShy ZXZpc2lvbiA3NzMyMSkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHku Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNDk4LDYgKzI0OTgsMTEgQEAgdm9pZCBXZWJQYWdlUHJv eHk6OnNldENvbXBsZXhUZXh0SW5wdXRFbgogewogICAgIG1fcGFnZUNsaWVudC0+c2V0Q29tcGxl eFRleHRJbnB1dEVuYWJsZWQocGx1Z2luQ29tcGxleFRleHRJbnB1dElkZW50aWZpZXIsIGNvbXBs ZXhUZXh0SW5wdXRFbmFibGVkKTsKIH0KKwordm9pZCBXZWJQYWdlUHJveHk6OnNldEF1dG9kaXNw bGF5KGJvb2wgbmV3U3RhdGUpCit7CisgICAgbV9wYWdlQ2xpZW50LT5zZXRBdXRvZGlzcGxheShu ZXdTdGF0ZSk7Cit9CiAjZW5kaWYKIAogdm9pZCBXZWJQYWdlUHJveHk6OmJhY2tGb3J3YXJkUmVt b3ZlZEl0ZW0odWludDY0X3QgaXRlbUlEKQpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L1dlYlBhZ2VQcm94eS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9X ZWJQYWdlUHJveHkuaAkocmV2aXNpb24gNzczMjEpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvV2ViUGFnZVByb3h5LmgJKHdvcmtpbmcgY29weSkKQEAgLTI5Miw2ICsyOTIsMTAgQEAgcHVi bGljOgogICAgIHZvaWQgZHJhd0hlYWRlcihXZWJGcmFtZVByb3h5KiwgY29uc3QgV2ViQ29yZTo6 RmxvYXRSZWN0Jik7CiAgICAgdm9pZCBkcmF3Rm9vdGVyKFdlYkZyYW1lUHJveHkqLCBjb25zdCBX ZWJDb3JlOjpGbG9hdFJlY3QmKTsKIAorI2lmIFBMQVRGT1JNKE1BQykKKyAgICB2b2lkIHNldEF1 dG9kaXNwbGF5KGJvb2wpOworI2VuZGlmCisKICAgICB2b2lkIHJlY2VpdmVkUG9saWN5RGVjaXNp b24oV2ViQ29yZTo6UG9saWN5QWN0aW9uLCBXZWJGcmFtZVByb3h5KiwgdWludDY0X3QgbGlzdGVu ZXJJRCk7CiAKICAgICB2b2lkIGJhY2tGb3J3YXJkUmVtb3ZlZEl0ZW0odWludDY0X3QgaXRlbUlE KTsKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1BhZ2VDbGllbnRJbXBs LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvUGFnZUNs aWVudEltcGwuaAkocmV2aXNpb24gNzczMjEpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL21hYy9QYWdlQ2xpZW50SW1wbC5oCSh3b3JraW5nIGNvcHkpCkBAIC05MCw2ICs5MCw3IEBA IHByaXZhdGU6CiAKICAgICB2aXJ0dWFsIHZvaWQgYWNjZXNzaWJpbGl0eUNoaWxkVG9rZW5SZWNl aXZlZChjb25zdCBDb3JlSVBDOjpEYXRhUmVmZXJlbmNlJik7ICAgIAogICAgIHZpcnR1YWwgdm9p ZCBzZXRDb21wbGV4VGV4dElucHV0RW5hYmxlZCh1aW50NjRfdCBwbHVnaW5Db21wbGV4VGV4dElu cHV0SWRlbnRpZmllciwgYm9vbCBjb21wbGV4VGV4dElucHV0RW5hYmxlZCk7CisgICAgdmlydHVh bCB2b2lkIHNldEF1dG9kaXNwbGF5KGJvb2wpOwogCiAgICAgdmlydHVhbCBDR0NvbnRleHRSZWYg Y29udGFpbmluZ1dpbmRvd0dyYXBoaWNzQ29udGV4dCgpOwogCkluZGV4OiBTb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL21hYy9QYWdlQ2xpZW50SW1wbC5tbQo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9QYWdlQ2xpZW50SW1wbC5tbQkocmV2aXNpb24g NzczMjEpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9QYWdlQ2xpZW50SW1w bC5tbQkod29ya2luZyBjb3B5KQpAQCAtMzU1LDYgKzM1NSwxNiBAQCB2b2lkIFBhZ2VDbGllbnRJ bXBsOjpzZXRDb21wbGV4VGV4dElucHV0CiAgICAgW21fd2tWaWV3IF9zZXRDb21wbGV4VGV4dElu cHV0RW5hYmxlZDpjb21wbGV4VGV4dElucHV0RW5hYmxlZCBwbHVnaW5Db21wbGV4VGV4dElucHV0 SWRlbnRpZmllcjpwbHVnaW5Db21wbGV4VGV4dElucHV0SWRlbnRpZmllcl07CiB9CiAKK3ZvaWQg UGFnZUNsaWVudEltcGw6OnNldEF1dG9kaXNwbGF5KGJvb2wgbmV3U3RhdGUpCit7CisgICAgaWYg KCFuZXdTdGF0ZSAmJiBbW21fd2tWaWV3IHdpbmRvd10gaXNBdXRvZGlzcGxheV0pCisgICAgICAg IFttX3drVmlldyBkaXNwbGF5SWZOZWVkZWRdOworICAgIGVsc2UKKyAgICAgICAgW21fd2tWaWV3 IHNldE5lZWRzRGlzcGxheTpOT107CisgICAgCisgICAgW1ttX3drVmlldyB3aW5kb3ddIHNldEF1 dG9kaXNwbGF5Om5ld1N0YXRlXTsKK30KKwogQ0dDb250ZXh0UmVmIFBhZ2VDbGllbnRJbXBsOjpj b250YWluaW5nV2luZG93R3JhcGhpY3NDb250ZXh0KCkKIHsKICAgICByZXR1cm4gc3RhdGljX2Nh c3Q8Q0dDb250ZXh0UmVmPihbW1ttX3drVmlldyB3aW5kb3ddIGdyYXBoaWNzQ29udGV4dF0gZ3Jh cGhpY3NQb3J0XSk7CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9XS1By aW50aW5nVmlldy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L21hYy9XS1ByaW50aW5nVmlldy5tbQkocmV2aXNpb24gNzczMjEpCisrKyBTb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL21hYy9XS1ByaW50aW5nVmlldy5tbQkod29ya2luZyBjb3B5KQpAQCAt NTA1LDYgKzUwNSwxOSBAQCAtIChOU1BvaW50KWxvY2F0aW9uT2ZQcmludFJlY3Q6KE5TUmVjdClh CiAgICAgcmV0dXJuIE5TTWFrZVBvaW50KFtbX3ByaW50T3BlcmF0aW9uIHByaW50SW5mb10gbGVm dE1hcmdpbl0sIFtbX3ByaW50T3BlcmF0aW9uIHByaW50SW5mb10gYm90dG9tTWFyZ2luXSk7CiB9 CiAKKy0gKHZvaWQpYmVnaW5Eb2N1bWVudAoreworICAgIEFTU0VSVChfcHJpbnRPcGVyYXRpb24g PT0gW05TUHJpbnRPcGVyYXRpb24gY3VycmVudE9wZXJhdGlvbl0pOworCisgICAgLy8gRm9yY2lu ZyBwcmV2aWV3IHVwZGF0ZSBnZXRzIHVzIGhlcmUsIGJ1dCBwYWdlIHNldHVwIGhhc24ndCBhY3R1 YWxseSBjaGFuZ2VkLgorICAgIGlmIChfaXNGb3JjaW5nUHJldmlld1VwZGF0ZSkKKyAgICAgICAg cmV0dXJuOworCisgICAgW3N1cGVyIGJlZ2luRG9jdW1lbnRdOworCisgICAgX3dlYkZyYW1lLT5w YWdlKCktPnNldEF1dG9kaXNwbGF5KGZhbHNlKTsKK30KKwogLSAodm9pZCllbmREb2N1bWVudAog ewogICAgIEFTU0VSVChfcHJpbnRPcGVyYXRpb24gPT0gW05TUHJpbnRPcGVyYXRpb24gY3VycmVu dE9wZXJhdGlvbl0pOwpAQCAtNTI1LDUgKzUzOCw5IEBAIC0gKHZvaWQpZW5kRG9jdW1lbnQKICAg ICBfZXhwZWN0ZWRQcmV2aWV3Q2FsbGJhY2tzLmNsZWFyKCk7CiAgICAgX2xhdGVzdEV4cGVjdGVk UHJldmlld0NhbGxiYWNrID0gMDsKICAgICBfZXhwZWN0ZWRQcmludENhbGxiYWNrID0gMDsKKwor ICAgIF93ZWJGcmFtZS0+cGFnZSgpLT5zZXRBdXRvZGlzcGxheSh0cnVlKTsKKworICAgIFtzdXBl ciBlbmREb2N1bWVudF07CiB9CiBAZW5kCg==