53552 2011-02-01 16:44:28 -0800 Pass enter/exit accelerated compositing mode to the WKView 2011-02-01 23:16:52 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 andersca andersca abarth eric ossy webkit.review.bot oldest_to_newest 343669 0 andersca 2011-02-01 16:44:28 -0800 Pass enter/exit accelerated compositing mode to the WKView 343671 1 80854 andersca 2011-02-01 16:45:35 -0800 Created attachment 80854 Patch 343672 2 80854 mitz 2011-02-01 16:46:47 -0800 Comment on attachment 80854 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=80854&action=review > Source/WebKit2/UIProcess/WebPageProxy.h:318 > +#endif > + > +#if USE(ACCELERATED_COMPOSITING) Is this really necessary? 343675 3 andersca 2011-02-01 16:48:30 -0800 Committed r77334: <http://trac.webkit.org/changeset/77334> 343691 4 webkit.review.bot 2011-02-01 17:07:04 -0800 http://trac.webkit.org/changeset/77334 might have broken Windows Release (Build) and Windows Debug (Build) 343880 5 ossy 2011-02-01 23:16:52 -0800 win builfix: http://trac.webkit.org/changeset/77339 Qt buildfix: http://trac.webkit.org/changeset/77365 Is it a big request, that don't break Qt build and leave it red again and again? Now there are 50 patches stucked in the EWS because of this breakage. Unfortunately Qt EWS can't build your patch before landing, because Hyatt made a similar breakage ... 80854 2011-02-01 16:45:35 -0800 2011-02-01 16:46:47 -0800 Patch bug-53552-20110201164534.patch text/plain 7284 andersca SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDc3MzMzKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjcgQEAKKzIwMTEtMDItMDEgIEFuZGVycyBD YXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBQYXNzIGVudGVyL2V4aXQgYWNjZWxlcmF0ZWQgY29tcG9z aXRpbmcgbW9kZSB0byB0aGUgV0tWaWV3CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD01MzU1MgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9tYWMvUGFn ZUNsaWVudEltcGwuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL21hYy9QYWdlQ2xpZW50SW1w bC5tbToKKyAgICAgICAgKFdlYktpdDo6UGFnZUNsaWVudEltcGw6OmVudGVyQWNjZWxlcmF0ZWRD b21wb3NpdGluZ01vZGUpOgorICAgICAgICAoV2ViS2l0OjpQYWdlQ2xpZW50SW1wbDo6ZXhpdEFj Y2VsZXJhdGVkQ29tcG9zaXRpbmdNb2RlKToKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL21hYy9X S1ZpZXcubW06CisgICAgICAgICgtW1dLVmlldyBfZW50ZXJBY2NlbGVyYXRlZENvbXBvc2l0aW5n TW9kZTpdKToKKyAgICAgICAgKC1bV0tWaWV3IF9leGl0QWNjZWxlcmF0ZWRDb21wb3NpdGluZ01v ZGVdKToKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXdJbnRlcm5hbC5oOgorICAg ICAgICAqIFVJUHJvY2Vzcy9EcmF3aW5nQXJlYVByb3h5SW1wbC5jcHA6CisgICAgICAgIChXZWJL aXQ6OkRyYXdpbmdBcmVhUHJveHlJbXBsOjplbnRlckFjY2VsZXJhdGVkQ29tcG9zaXRpbmdNb2Rl KToKKyAgICAgICAgKFdlYktpdDo6RHJhd2luZ0FyZWFQcm94eUltcGw6OmV4aXRBY2NlbGVyYXRl ZENvbXBvc2l0aW5nTW9kZSk6CisgICAgICAgICogVUlQcm9jZXNzL1BhZ2VDbGllbnQuaDoKKyAg ICAgICAgKiBVSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2Vi UGFnZVByb3h5OjplbnRlckFjY2VsZXJhdGVkQ29tcG9zaXRpbmdNb2RlKToKKyAgICAgICAgKFdl YktpdDo6V2ViUGFnZVByb3h5OjpleGl0QWNjZWxlcmF0ZWRDb21wb3NpdGluZ01vZGUpOgorICAg ICAgICAqIFVJUHJvY2Vzcy9XZWJQYWdlUHJveHkuaDoKKwogMjAxMS0wMi0wMSAgQ3NhYmEgT3N6 dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQgUXQgYnVp bGRmaXggYWZ0ZXIgcjc3Mjg2LgpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0RyYXdp bmdBcmVhUHJveHlJbXBsLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvRHJhd2luZ0FyZWFQcm94eUltcGwuY3BwCShyZXZpc2lvbiA3NzMyNykKKysrIFNvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9EcmF3aW5nQXJlYVByb3h5SW1wbC5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTE0NywxNCArMTQ3LDE0IEBAIHZvaWQgRHJhd2luZ0FyZWFQcm94eUltcGw6OmRpZFNldFNp emUoY28KICAgICBpbmNvcnBvcmF0ZVVwZGF0ZSh1cGRhdGVJbmZvKTsKIH0KIAotdm9pZCBEcmF3 aW5nQXJlYVByb3h5SW1wbDo6ZW50ZXJBY2NlbGVyYXRlZENvbXBvc2l0aW5nTW9kZShjb25zdCBM YXllclRyZWVDb250ZXh0JiBjb250ZXh0KQordm9pZCBEcmF3aW5nQXJlYVByb3h5SW1wbDo6ZW50 ZXJBY2NlbGVyYXRlZENvbXBvc2l0aW5nTW9kZShjb25zdCBMYXllclRyZWVDb250ZXh0JiBsYXll clRyZWVDb250ZXh0KQogewotICAgIC8vIEZJWE1FOiBJbXBsZW1lbnQuCisgICAgbV93ZWJQYWdl UHJveHktPmVudGVyQWNjZWxlcmF0ZWRDb21wb3NpdGluZ01vZGUobGF5ZXJUcmVlQ29udGV4dCk7 CiB9CiAKIHZvaWQgRHJhd2luZ0FyZWFQcm94eUltcGw6OmV4aXRBY2NlbGVyYXRlZENvbXBvc2l0 aW5nTW9kZSgpCiB7Ci0gICAgLy8gRklYTUU6IEltcGxlbWVudC4KKyAgICBtX3dlYlBhZ2VQcm94 eS0+ZXhpdEFjY2VsZXJhdGVkQ29tcG9zaXRpbmdNb2RlKCk7CiB9CiAKIHZvaWQgRHJhd2luZ0Fy ZWFQcm94eUltcGw6OmluY29ycG9yYXRlVXBkYXRlKGNvbnN0IFVwZGF0ZUluZm8mIHVwZGF0ZUlu Zm8pCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvUGFnZUNsaWVudC5oCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9QYWdlQ2xpZW50LmgJKHJldmlzaW9uIDc3 MzI3KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1BhZ2VDbGllbnQuaAkod29ya2luZyBj b3B5KQpAQCAtMTE3LDYgKzExNyw5IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQgc2V0Rmlu ZEluZGljYXRvcihQYXNzUmVmUHRyPEZpbmRJbmRpY2F0b3I+LCBib29sIGZhZGVPdXQpID0gMDsK IAogI2lmIFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykKKyAgICB2aXJ0dWFsIHZvaWQgZW50 ZXJBY2NlbGVyYXRlZENvbXBvc2l0aW5nTW9kZShjb25zdCBMYXllclRyZWVDb250ZXh0JikgPSAw OworICAgIHZpcnR1YWwgdm9pZCBleGl0QWNjZWxlcmF0ZWRDb21wb3NpdGluZ01vZGUoKSA9IDA7 CisgICAgCiAgICAgdmlydHVhbCB2b2lkIHBhZ2VEaWRFbnRlckFjY2VsZXJhdGVkQ29tcG9zaXRp bmcoKSA9IDA7CiAgICAgdmlydHVhbCB2b2lkIHBhZ2VEaWRMZWF2ZUFjY2VsZXJhdGVkQ29tcG9z aXRpbmcoKSA9IDA7CiAjZW5kaWYKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQ YWdlUHJveHkuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQ YWdlUHJveHkuY3BwCShyZXZpc2lvbiA3NzMyNykKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9XZWJQYWdlUHJveHkuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNDA4LDYgKzI0MDgsMTUgQEAg V2ViUGFnZUNyZWF0aW9uUGFyYW1ldGVycyBXZWJQYWdlUHJveHk6OgogfQogCiAjaWYgVVNFKEFD Q0VMRVJBVEVEX0NPTVBPU0lUSU5HKQordm9pZCBXZWJQYWdlUHJveHk6OmVudGVyQWNjZWxlcmF0 ZWRDb21wb3NpdGluZ01vZGUoY29uc3QgTGF5ZXJUcmVlQ29udGV4dCYgbGF5ZXJUcmVlQ29udGV4 dCkKK3sKKyAgICBtX3BhZ2VDbGllbnQtPmVudGVyQWNjZWxlcmF0ZWRDb21wb3NpdGluZ01vZGUo bGF5ZXJUcmVlQ29udGV4dCk7Cit9CisKK3ZvaWQgV2ViUGFnZVByb3h5OjpleGl0QWNjZWxlcmF0 ZWRDb21wb3NpdGluZ01vZGUoKQoreworICAgIG1fcGFnZUNsaWVudC0+ZXhpdEFjY2VsZXJhdGVk Q29tcG9zaXRpbmdNb2RlKCk7Cit9CiAKIHZvaWQgV2ViUGFnZVByb3h5OjpkaWRFbnRlckFjY2Vs ZXJhdGVkQ29tcG9zaXRpbmcoKQogewpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dl YlBhZ2VQcm94eS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQ YWdlUHJveHkuaAkocmV2aXNpb24gNzczMjcpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv V2ViUGFnZVByb3h5LmgJKHdvcmtpbmcgY29weSkKQEAgLTMxMSw2ICszMTEsMTEgQEAgcHVibGlj OgogICAgIHZvaWQgcHJvY2Vzc0RpZENyYXNoKCk7CiAKICNpZiBVU0UoQUNDRUxFUkFURURfQ09N UE9TSVRJTkcpCisgICAgdmlydHVhbCB2b2lkIGVudGVyQWNjZWxlcmF0ZWRDb21wb3NpdGluZ01v ZGUoY29uc3QgTGF5ZXJUcmVlQ29udGV4dCYpOworICAgIHZpcnR1YWwgdm9pZCBleGl0QWNjZWxl cmF0ZWRDb21wb3NpdGluZ01vZGUoKTsKKyNlbmRpZgorICAgIAorI2lmIFVTRShBQ0NFTEVSQVRF RF9DT01QT1NJVElORykKICAgICB2b2lkIGRpZEVudGVyQWNjZWxlcmF0ZWRDb21wb3NpdGluZygp OwogICAgIHZvaWQgZGlkTGVhdmVBY2NlbGVyYXRlZENvbXBvc2l0aW5nKCk7CiAjZW5kaWYKSW5k ZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1BhZ2VDbGllbnRJbXBsLmgKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvUGFnZUNsaWVudElt cGwuaAkocmV2aXNpb24gNzczMjcpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21h Yy9QYWdlQ2xpZW50SW1wbC5oCSh3b3JraW5nIGNvcHkpCkBAIC04Myw2ICs4Myw5IEBAIHByaXZh dGU6CiAKICAgICB2b2lkIHNldEZpbmRJbmRpY2F0b3IoUGFzc1JlZlB0cjxGaW5kSW5kaWNhdG9y PiwgYm9vbCBmYWRlT3V0KTsKIAorICAgIHZpcnR1YWwgdm9pZCBlbnRlckFjY2VsZXJhdGVkQ29t cG9zaXRpbmdNb2RlKGNvbnN0IExheWVyVHJlZUNvbnRleHQmKTsKKyAgICB2aXJ0dWFsIHZvaWQg ZXhpdEFjY2VsZXJhdGVkQ29tcG9zaXRpbmdNb2RlKCk7CisKICNpZiBVU0UoQUNDRUxFUkFURURf Q09NUE9TSVRJTkcpCiAgICAgdmlydHVhbCB2b2lkIHBhZ2VEaWRFbnRlckFjY2VsZXJhdGVkQ29t cG9zaXRpbmcoKTsKICAgICB2aXJ0dWFsIHZvaWQgcGFnZURpZExlYXZlQWNjZWxlcmF0ZWRDb21w b3NpdGluZygpOwpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvUGFnZUNs aWVudEltcGwubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9t YWMvUGFnZUNsaWVudEltcGwubW0JKHJldmlzaW9uIDc3MzI3KQorKysgU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9tYWMvUGFnZUNsaWVudEltcGwubW0JKHdvcmtpbmcgY29weSkKQEAgLTMz OSw2ICszMzksMTYgQEAgdm9pZCBQYWdlQ2xpZW50SW1wbDo6YWNjZXNzaWJpbGl0eUNoaWxkVAog fQogICAgIAogI2lmIFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykKK3ZvaWQgUGFnZUNsaWVu dEltcGw6OmVudGVyQWNjZWxlcmF0ZWRDb21wb3NpdGluZ01vZGUoY29uc3QgTGF5ZXJUcmVlQ29u dGV4dCYgbGF5ZXJUcmVlQ29udGV4dCkKK3sKKyAgICBbbV93a1ZpZXcgX2VudGVyQWNjZWxlcmF0 ZWRDb21wb3NpdGluZ01vZGU6bGF5ZXJUcmVlQ29udGV4dF07Cit9CisKK3ZvaWQgUGFnZUNsaWVu dEltcGw6OmV4aXRBY2NlbGVyYXRlZENvbXBvc2l0aW5nTW9kZSgpCit7CisgICAgW21fd2tWaWV3 IF9leGl0QWNjZWxlcmF0ZWRDb21wb3NpdGluZ01vZGVdOworfQorCiB2b2lkIFBhZ2VDbGllbnRJ bXBsOjpwYWdlRGlkRW50ZXJBY2NlbGVyYXRlZENvbXBvc2l0aW5nKCkKIHsKICAgICBbbV93a1Zp ZXcgX3BhZ2VEaWRFbnRlckFjY2VsZXJhdGVkQ29tcG9zaXRpbmddOwpJbmRleDogU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbQkocmV2aXNpb24gNzczMjcpCisrKyBT b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW0JKHdvcmtpbmcgY29weSkK QEAgLTMyLDYgKzMyLDcgQEAKICNpbXBvcnQgIkZpbmRJbmRpY2F0b3IuaCIKICNpbXBvcnQgIkZp bmRJbmRpY2F0b3JXaW5kb3cuaCIKICNpbXBvcnQgIkxheWVyQmFja2VkRHJhd2luZ0FyZWFQcm94 eS5oIgorI2ltcG9ydCAiTGF5ZXJUcmVlQ29udGV4dC5oIgogI2ltcG9ydCAiTG9nZ2luZy5oIgog I2ltcG9ydCAiTmF0aXZlV2ViS2V5Ym9hcmRFdmVudC5oIgogI2ltcG9ydCAiUERGVmlld0NvbnRy b2xsZXIuaCIKQEAgLTE4NTIsNiArMTg1MywxNiBAQCAtICh2b2lkKV9zd2l0Y2hUb0RyYXdpbmdB cmVhVHlwZUlmTmVjZXNzCiAgICAgX2RhdGEtPl9wYWdlLT5zZXREcmF3aW5nQXJlYShuZXdEcmF3 aW5nQXJlYS5yZWxlYXNlKCkpOwogfQogCistICh2b2lkKV9lbnRlckFjY2VsZXJhdGVkQ29tcG9z aXRpbmdNb2RlOihjb25zdCBMYXllclRyZWVDb250ZXh0JilsYXllclRyZWVDb250ZXh0Cit7Cisg ICAgLy8gRklYTUU6IEltcGxlbWVudC4KK30KKworLSAodm9pZClfZXhpdEFjY2VsZXJhdGVkQ29t cG9zaXRpbmdNb2RlCit7CisgICAgLy8gRklYTUU6IEltcGxlbWVudC4KK30KKwogLSAodm9pZClf cGFnZURpZEVudGVyQWNjZWxlcmF0ZWRDb21wb3NpdGluZwogewogICAgIFtzZWxmIF9zd2l0Y2hU b0RyYXdpbmdBcmVhVHlwZUlmTmVjZXNzYXJ5OkRyYXdpbmdBcmVhSW5mbzo6TGF5ZXJCYWNrZWRd OwpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3SW50ZXJuYWwu aAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXdJ bnRlcm5hbC5oCShyZXZpc2lvbiA3NzMyNykKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvbWFjL1dLVmlld0ludGVybmFsLmgJKHdvcmtpbmcgY29weSkKQEAgLTQ5LDYgKzQ5LDkgQEAg QGludGVyZmFjZSBXS1ZpZXcgKEludGVybmFsKQogLSAoTlNSZWN0KV9jb252ZXJ0VG9Vc2VyU3Bh Y2U6KE5TUmVjdClyZWN0OwogLSAodm9pZClfc2V0RmluZEluZGljYXRvcjooUGFzc1JlZlB0cjxX ZWJLaXQ6OkZpbmRJbmRpY2F0b3I+KWZpbmRJbmRpY2F0b3IgZmFkZU91dDooQk9PTClmYWRlT3V0 OwogCistICh2b2lkKV9lbnRlckFjY2VsZXJhdGVkQ29tcG9zaXRpbmdNb2RlOihjb25zdCBXZWJL aXQ6OkxheWVyVHJlZUNvbnRleHQmKWxheWVyVHJlZUNvbnRleHQ7CistICh2b2lkKV9leGl0QWNj ZWxlcmF0ZWRDb21wb3NpdGluZ01vZGU7CisKICNpZiBVU0UoQUNDRUxFUkFURURfQ09NUE9TSVRJ TkcpCiAtICh2b2lkKV9zdGFydEFjY2VsZXJhdGVkQ29tcG9zaXRpbmc6KENBTGF5ZXIgKilyb290 TGF5ZXI7CiAtICh2b2lkKV9zdG9wQWNjZWxlcmF0ZWRDb21wb3NpdGluZzsK