53549 2011-02-01 16:21:25 -0800 Remove useless comment 2011-02-01 21:58:05 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 53474 1 abarth abarth commit-queue oldest_to_newest 343649 0 abarth 2011-02-01 16:21:25 -0800 Remove useless comment 343660 1 80851 abarth 2011-02-01 16:31:45 -0800 Created attachment 80851 Patch 343665 2 80851 kling 2011-02-01 16:37:25 -0800 Comment on attachment 80851 Patch Quite useless indeed. 343820 3 80851 commit-queue 2011-02-01 21:13:52 -0800 Comment on attachment 80851 Patch Clearing flags on attachment: 80851 Committed r77361: <http://trac.webkit.org/changeset/77361> 343821 4 commit-queue 2011-02-01 21:13:57 -0800 All reviewed patches have been landed. Closing bug. 343834 5 ap 2011-02-01 21:37:17 -0800 Actually, I found this comment extremely useful when working on this code. 343840 6 abarth 2011-02-01 21:46:14 -0800 (In reply to comment #5) > Actually, I found this comment extremely useful when working on this code. I can't tell whether you're kidding. Maybe we should change the true/false to be an enum? (I couldn't have been the "no clue why" part that was useful, right?) 343847 7 ap 2011-02-01 21:58:05 -0800 Yes, this was essentially a FIXME comment. The fact that this generic code somehow special cased a certain kind of plug-ins was worth drawing special attention for me when I looked at this function, and I was glad that Eric (I think) has added it. 80851 2011-02-01 16:31:45 -0800 2011-02-01 21:13:52 -0800 Patch bug-53549-20110201163143.patch text/plain 1380 abarth SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc3MzMyKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDItMDEgIEFkYW0gQmFy dGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBSZW1vdmUgdXNlbGVzcyBjb21tZW50CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MzU0OQorCisgICAgICAgIFRoZSByZWFz b24gZm9yIHRoaXMgcGFyYW1ldGVyIGlzIGNhcHR1cmVkIGluCisgICAgICAgIHBsdWdpbnMvbmV0 c2NhcGUtcGx1Z2luLXNldHdpbmRvdy1zaXplLmh0bWwsIHdoaWNoIGlzIGEgYmV0dGVyIHBsYWNl IHRvCisgICAgICAgIGNhcHR1cmUgaXQgdGhhbiBpbiB0aGlzIGNvbW1lbnQgKHdoaWNoIG90aGVy d2lzZSBqdXN0IHJlLWl0ZXJhdGVzIHRoZQorICAgICAgICBuYW1lIG9mIHRoZSBwYXJhbWV0ZXIp LgorCisgICAgICAgICogaHRtbC9IVE1MUGx1Z0luSW1hZ2VFbGVtZW50LmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkhUTUxQbHVnSW5JbWFnZUVsZW1lbnQ6OnVwZGF0ZVdpZGdldElmTmVjZXNzYXJ5 KToKKwogMjAxMS0wMi0wMSAgSm9obm55IERpbmcgIDxqbmRAY2hyb21pdW0ub3JnPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpJbmRleDogU291cmNlL1dlYkNvcmUvaHRtbC9I VE1MUGx1Z0luSW1hZ2VFbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9o dG1sL0hUTUxQbHVnSW5JbWFnZUVsZW1lbnQuY3BwCShyZXZpc2lvbiA3NzI2NikKKysrIFNvdXJj ZS9XZWJDb3JlL2h0bWwvSFRNTFBsdWdJbkltYWdlRWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTE2Niw3ICsxNjYsNiBAQCB2b2lkIEhUTUxQbHVnSW5JbWFnZUVsZW1lbnQ6OnVwZGF0ZVdp ZGdlCiAgICAgaWYgKCFyZW5kZXJFbWJlZGRlZE9iamVjdCgpIHx8IHJlbmRlckVtYmVkZGVkT2Jq ZWN0KCktPnBsdWdpbkNyYXNoZWRPcldhc01pc3NpbmcoKSkKICAgICAgICAgcmV0dXJuOwogCi0g ICAgLy8gVHJ1ZSBpbmRpY2F0ZXMgdGhhdCB0aGlzIGNvZGUgcGF0aCBzaG91bGQgb25seSBjcmVh dGUgbm9uLW5ldHNjYXBlIHBsdWdpbnMgKG5vIGNsdWUgd2h5KS4KICAgICB1cGRhdGVXaWRnZXQo dHJ1ZSk7CiB9CiAK