53535 2011-02-01 14:28:08 -0800 Don't clear the callbacks ref in the proxy layer for IndexedDB 2011-02-03 17:19:53 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 jorlow jorlow andreip dgrogan hans japhet oldest_to_newest 343546 0 jorlow 2011-02-01 14:28:08 -0800 Don't clear the callbacks ref in the proxy layer for IndexedDB 343548 1 80829 jorlow 2011-02-01 14:29:47 -0800 Created attachment 80829 Patch 343745 2 andreip 2011-02-01 18:15:54 -0800 > learing the callbacks doesn't actually solve any problems and makes > this code behave subtly differently than how it would in Safari and > other single process environments. Let's remove the difference. Rather than this, I'd explicitly say what are the differences (especially since they are subtle :)) 343753 3 jorlow 2011-02-01 18:21:41 -0800 (In reply to comment #2) > > learing the callbacks doesn't actually solve any problems and makes > > this code behave subtly differently than how it would in Safari and > > other single process environments. Let's remove the difference. > > Rather than this, I'd explicitly say what are the differences (especially since they are subtle :)) The differences are in the timing of when stuff gets freed. Which is significant because ActiveDOMObjects can't be freed at certain points. 345200 4 jorlow 2011-02-03 17:19:53 -0800 Committed r77572: <http://trac.webkit.org/changeset/77572> 80829 2011-02-01 14:29:47 -0800 2011-02-03 15:10:34 -0800 Patch bug-53535-20110201142946.patch text/plain 3991 jorlow ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggZDVmZDE4NDBmNjg5MTQ1ZDNjODAxZTExNDk2 MzM2NGYwYjdkOTBiNC4uZDM5ODc1Nzk1MjA1NjZhNWMxNzZhOTFiZDU5YTcwZmEyMGRiZDBkNSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNl L1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAxMS0wMi0wMSAg SmVyZW15IE9ybG93ICA8am9ybG93QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEb24ndCBjbGVhciB0aGUgY2FsbGJhY2tzIHJl ZiBpbiB0aGUgcHJveHkgbGF5ZXIgZm9yIEluZGV4ZWREQgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTM1MzUKKworICAgICAgICBDbGVhcmluZyB0aGUg Y2FsbGJhY2tzIGRvZXNuJ3QgYWN0dWFsbHkgc29sdmUgYW55IHByb2JsZW1zIGFuZCBtYWtlcwor ICAgICAgICB0aGlzIGNvZGUgYmVoYXZlIHN1YnRseSBkaWZmZXJlbnRseSB0aGFuIGhvdyBpdCB3 b3VsZCBpbiBTYWZhcmkgYW5kCisgICAgICAgIG90aGVyIHNpbmdsZSBwcm9jZXNzIGVudmlyb25t ZW50cy4gTGV0J3MgcmVtb3ZlIHRoZSBkaWZmZXJlbmNlLgorCisgICAgICAgICogc3JjL0lEQkNh bGxiYWNrc1Byb3h5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OklEQkNhbGxiYWNrc1Byb3h5Ojpv bkVycm9yKToKKyAgICAgICAgKFdlYkNvcmU6OklEQkNhbGxiYWNrc1Byb3h5OjpvblN1Y2Nlc3Mp OgorICAgICAgICAqIHNyYy9JREJUcmFuc2FjdGlvbkNhbGxiYWNrc1Byb3h5LmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OklEQlRyYW5zYWN0aW9uQ2FsbGJhY2tzUHJveHk6Om9uQWJvcnQpOgorICAg ICAgICAoV2ViQ29yZTo6SURCVHJhbnNhY3Rpb25DYWxsYmFja3NQcm94eTo6b25Db21wbGV0ZSk6 CisgICAgICAgIChXZWJDb3JlOjpJREJUcmFuc2FjdGlvbkNhbGxiYWNrc1Byb3h5OjpvblRpbWVv dXQpOgorCiAyMDExLTAxLTI0ICBaaGVueWFvIE1vICA8em1vQGdvb2dsZS5jb20+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL3NyYy9JREJDYWxsYmFja3NQcm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L3NyYy9JREJDYWxsYmFja3NQcm94eS5jcHAKaW5kZXggNjkwNTFkMGE2ZGE3YzY2YzBkMDc1ZjNm Yjk5Y2FiOWQyOTMzZGVjMi4uNTU4MTJhYTYzZDJlNGY5YTlkNDUyY2NlMTQ2MGI5NGU4NDQ2ZmQy ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvSURCQ2FsbGJhY2tzUHJv eHkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0lEQkNhbGxiYWNrc1Byb3h5 LmNwcApAQCAtNjIsNTUgKzYyLDQ2IEBAIElEQkNhbGxiYWNrc1Byb3h5Ojp+SURCQ2FsbGJhY2tz UHJveHkoKQogdm9pZCBJREJDYWxsYmFja3NQcm94eTo6b25FcnJvcihQYXNzUmVmUHRyPElEQkRh dGFiYXNlRXJyb3I+IGlkYkRhdGFiYXNlRXJyb3IpCiB7CiAgICAgbV9jYWxsYmFja3MtPm9uRXJy b3IoV2ViS2l0OjpXZWJJREJEYXRhYmFzZUVycm9yKGlkYkRhdGFiYXNlRXJyb3IpKTsKLSAgICBt X2NhbGxiYWNrcy5jbGVhcigpOwogfQogCiB2b2lkIElEQkNhbGxiYWNrc1Byb3h5OjpvblN1Y2Nl c3MoKQogewogICAgIG1fY2FsbGJhY2tzLT5vblN1Y2Nlc3MoKTsKLSAgICBtX2NhbGxiYWNrcy5j bGVhcigpOwogfQogCiB2b2lkIElEQkNhbGxiYWNrc1Byb3h5OjpvblN1Y2Nlc3MoUGFzc1JlZlB0 cjxJREJDdXJzb3JCYWNrZW5kSW50ZXJmYWNlPiBpZGJDdXJzb3JCYWNrZW5kKQogewogICAgIG1f Y2FsbGJhY2tzLT5vblN1Y2Nlc3MobmV3IFdlYktpdDo6V2ViSURCQ3Vyc29ySW1wbChpZGJDdXJz b3JCYWNrZW5kKSk7Ci0gICAgbV9jYWxsYmFja3MuY2xlYXIoKTsKIH0KIAogdm9pZCBJREJDYWxs YmFja3NQcm94eTo6b25TdWNjZXNzKFBhc3NSZWZQdHI8SURCRGF0YWJhc2VCYWNrZW5kSW50ZXJm YWNlPiBiYWNrZW5kKQogewogICAgIG1fY2FsbGJhY2tzLT5vblN1Y2Nlc3MobmV3IFdlYktpdDo6 V2ViSURCRGF0YWJhc2VJbXBsKGJhY2tlbmQpKTsKLSAgICBtX2NhbGxiYWNrcy5jbGVhcigpOwog fQogCiB2b2lkIElEQkNhbGxiYWNrc1Byb3h5OjpvblN1Y2Nlc3MoUGFzc1JlZlB0cjxJREJJbmRl eEJhY2tlbmRJbnRlcmZhY2U+IGJhY2tlbmQpCiB7CiAgICAgbV9jYWxsYmFja3MtPm9uU3VjY2Vz cyhuZXcgV2ViS2l0OjpXZWJJREJJbmRleEltcGwoYmFja2VuZCkpOwotICAgIG1fY2FsbGJhY2tz LmNsZWFyKCk7CiB9CiAKIHZvaWQgSURCQ2FsbGJhY2tzUHJveHk6Om9uU3VjY2VzcyhQYXNzUmVm UHRyPElEQktleT4gaWRiS2V5KQogewogICAgIG1fY2FsbGJhY2tzLT5vblN1Y2Nlc3MoV2ViS2l0 OjpXZWJJREJLZXkoaWRiS2V5KSk7Ci0gICAgbV9jYWxsYmFja3MuY2xlYXIoKTsKIH0KIAogdm9p ZCBJREJDYWxsYmFja3NQcm94eTo6b25TdWNjZXNzKFBhc3NSZWZQdHI8SURCT2JqZWN0U3RvcmVC YWNrZW5kSW50ZXJmYWNlPiBiYWNrZW5kKQogewogICAgIG1fY2FsbGJhY2tzLT5vblN1Y2Nlc3Mo bmV3IFdlYktpdDo6V2ViSURCT2JqZWN0U3RvcmVJbXBsKGJhY2tlbmQpKTsKLSAgICBtX2NhbGxi YWNrcy5jbGVhcigpOwogfQogCiB2b2lkIElEQkNhbGxiYWNrc1Byb3h5OjpvblN1Y2Nlc3MoUGFz c1JlZlB0cjxJREJUcmFuc2FjdGlvbkJhY2tlbmRJbnRlcmZhY2U+IGJhY2tlbmQpCiB7CiAgICAg bV9jYWxsYmFja3MtPm9uU3VjY2VzcyhuZXcgV2ViS2l0OjpXZWJJREJUcmFuc2FjdGlvbkltcGwo YmFja2VuZCkpOwotICAgIG1fY2FsbGJhY2tzLmNsZWFyKCk7CiB9CiAKIHZvaWQgSURCQ2FsbGJh Y2tzUHJveHk6Om9uU3VjY2VzcyhQYXNzUmVmUHRyPFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZT4gc2Vy aWFsaXplZFNjcmlwdFZhbHVlKQogewogICAgIG1fY2FsbGJhY2tzLT5vblN1Y2Nlc3MoV2ViS2l0 OjpXZWJTZXJpYWxpemVkU2NyaXB0VmFsdWUoc2VyaWFsaXplZFNjcmlwdFZhbHVlKSk7Ci0gICAg bV9jYWxsYmFja3MuY2xlYXIoKTsKIH0KIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvSURCVHJhbnNhY3Rpb25DYWxsYmFja3NQ cm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9JREJUcmFuc2FjdGlvbkNhbGxi YWNrc1Byb3h5LmNwcAppbmRleCAzYTE5ZmUyZWRmNjhmY2YxYjliMjJmMTNiOWQyZWE0OTUwMjAx ZTNlLi5lMjMzNmY0YjJmMzllNTYxM2VkZDA2MzRiYjQxMGQyM2EzODkzNmE0IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9JREJUcmFuc2FjdGlvbkNhbGxiYWNrc1Byb3h5 LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9JREJUcmFuc2FjdGlvbkNhbGxi YWNrc1Byb3h5LmNwcApAQCAtNTIsMTkgKzUyLDE2IEBAIElEQlRyYW5zYWN0aW9uQ2FsbGJhY2tz UHJveHk6On5JREJUcmFuc2FjdGlvbkNhbGxiYWNrc1Byb3h5KCkKIHZvaWQgSURCVHJhbnNhY3Rp b25DYWxsYmFja3NQcm94eTo6b25BYm9ydCgpCiB7CiAgICAgbV9jYWxsYmFja3MtPm9uQWJvcnQo KTsKLSAgICBtX2NhbGxiYWNrcy5jbGVhcigpOwogfQogCiB2b2lkIElEQlRyYW5zYWN0aW9uQ2Fs bGJhY2tzUHJveHk6Om9uQ29tcGxldGUoKQogewogICAgIG1fY2FsbGJhY2tzLT5vbkNvbXBsZXRl KCk7Ci0gICAgbV9jYWxsYmFja3MuY2xlYXIoKTsKIH0KIAogdm9pZCBJREJUcmFuc2FjdGlvbkNh bGxiYWNrc1Byb3h5OjpvblRpbWVvdXQoKQogewogICAgIG1fY2FsbGJhY2tzLT5vblRpbWVvdXQo KTsKLSAgICBtX2NhbGxiYWNrcy5jbGVhcigpOwogfQogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3Jl Cg==