53531 2011-02-01 14:00:56 -0800 Fix the incorrect usage of RetainPtr cases in GraphicsContext3DCG.cpp 2011-02-01 14:30:02 -0800 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 47477 1 zmo zmo kbr thakis oldest_to_newest 343519 0 zmo 2011-02-01 14:00:56 -0800 With this fix, the random crash while running WebGL conformance tests should be gone. 343524 1 80822 zmo 2011-02-01 14:05:06 -0800 Created attachment 80822 Patch 343528 2 kbr 2011-02-01 14:12:23 -0800 Thanks for fixing this and sorry for the bad code. 343550 3 zmo 2011-02-01 14:30:02 -0800 Committed r77305: <http://trac.webkit.org/changeset/77305> 80822 2011-02-01 14:05:06 -0800 2011-02-01 14:08:09 -0800 Patch bug-53531-20110201140505.patch text/plain 2380 zmo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc3Mjk2KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDItMDEgIFpoZW55YW8g TW8gIDx6bW9AZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBGaXggdGhlIGluY29ycmVjdCB1c2FnZSBvZiBSZXRhaW5QdHIgY2FzZXMg aW4gR3JhcGhpY3NDb250ZXh0M0RDRy5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTUzNTMxCisKKyAgICAgICAgV2l0aCB0aGlzIGZpeCwgcnVubmlu ZyBXZWJHTCBjb25mb3JtYW5jZSB0ZXN0cyBzaG91bGQgbm8gbG9uZ2VyIGNyYXNoIHJhbmRvbWx5 LgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2cvR3JhcGhpY3NDb250ZXh0M0RDRy5j cHA6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQzRDo6Z2V0SW1hZ2VEYXRhKToK KwogMjAxMS0wMi0wMSAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IEJldGggRGFraW4uCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9jZy9HcmFwaGljc0NvbnRleHQzRENHLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jZy9HcmFwaGljc0NvbnRleHQzRENHLmNwcAkocmV2aXNp b24gNzcyNjEpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jZy9HcmFwaGlj c0NvbnRleHQzRENHLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTA1LDcgKzEwNSw3IEBAIGJvb2wg R3JhcGhpY3NDb250ZXh0M0Q6OmdldEltYWdlRGF0YShJbWEKICAgICAgICAgZGVjb2Rlci5zZXRE YXRhKGltYWdlLT5kYXRhKCksIHRydWUpOwogICAgICAgICBpZiAoIWRlY29kZXIuZnJhbWVDb3Vu dCgpKQogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwotICAgICAgICBkZWNvZGVkSW1hZ2UgPSBk ZWNvZGVyLmNyZWF0ZUZyYW1lQXRJbmRleCgwKTsKKyAgICAgICAgZGVjb2RlZEltYWdlLmFkb3B0 Q0YoZGVjb2Rlci5jcmVhdGVGcmFtZUF0SW5kZXgoMCkpOwogICAgICAgICBjZ0ltYWdlID0gZGVj b2RlZEltYWdlLmdldCgpOwogICAgIH0gZWxzZQogICAgICAgICBjZ0ltYWdlID0gaW1hZ2UtPm5h dGl2ZUltYWdlRm9yQ3VycmVudEZyYW1lKCk7CkBAIC0xMjEsMTEgKzEyMSwxMCBAQCBib29sIEdy YXBoaWNzQ29udGV4dDNEOjpnZXRJbWFnZURhdGEoSW1hCiAgICAgLy8gc28sIHJlLXJlbmRlciBp dCBpbnRvIGFuIFJHQiBjb2xvciBzcGFjZS4gVGhlIGltYWdlIHJlLXBhY2tpbmcKICAgICAvLyBj b2RlIHJlcXVpcmVzIGNvbG9yIGRhdGEsIG5vdCBjb2xvciB0YWJsZSBpbmRpY2VzLCBmb3IgdGhl CiAgICAgLy8gaW1hZ2UgZGF0YS4KLSAgICBSZXRhaW5QdHI8Q0dDb2xvclNwYWNlUmVmPiBjb2xv clNwYWNlKEFkb3B0Q0YsIENHSW1hZ2VHZXRDb2xvclNwYWNlKGNnSW1hZ2UpKTsKLSAgICBDR0Nv bG9yU3BhY2VNb2RlbCBtb2RlbCA9IENHQ29sb3JTcGFjZUdldE1vZGVsKGNvbG9yU3BhY2UuZ2V0 KCkpOwotICAgIFJldGFpblB0cjxDR0NvbnRleHRSZWY+IGJpdG1hcENvbnRleHQ7CisgICAgQ0dD b2xvclNwYWNlUmVmIGNvbG9yU3BhY2UgPSBDR0ltYWdlR2V0Q29sb3JTcGFjZShjZ0ltYWdlKTsK KyAgICBDR0NvbG9yU3BhY2VNb2RlbCBtb2RlbCA9IENHQ29sb3JTcGFjZUdldE1vZGVsKGNvbG9y U3BhY2UpOwogICAgIGlmIChtb2RlbCA9PSBrQ0dDb2xvclNwYWNlTW9kZWxJbmRleGVkKSB7Ci0g ICAgICAgIFJldGFpblB0cjxDR0NvbG9yU3BhY2VSZWY+IGJhc2VDb2xvclNwYWNlKENHQ29sb3JT cGFjZUdldEJhc2VDb2xvclNwYWNlKGNvbG9yU3BhY2UuZ2V0KCkpKTsKKyAgICAgICAgUmV0YWlu UHRyPENHQ29udGV4dFJlZj4gYml0bWFwQ29udGV4dDsKICAgICAgICAgLy8gRklYTUU6IHdlIHNo b3VsZCBwcm9iYWJseSBtYW51YWxseSBjb252ZXJ0IHRoZSBpbWFnZSBieSBpbmRleGluZyBpbnRv CiAgICAgICAgIC8vIHRoZSBjb2xvciB0YWJsZSwgd2hpY2ggd291bGQgYWxsb3cgdXMgdG8gYXZv aWQgcHJlbXVsdGlwbHlpbmcgdGhlCiAgICAgICAgIC8vIGFscGhhIGNoYW5uZWwuIENyZWF0aW9u IG9mIGEgYml0bWFwIGNvbnRleHQgd2l0aCBhbiBhbHBoYSBjaGFubmVsCg==