<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>53506</bug_id>
          
          <creation_ts>2011-02-01 09:54:03 -0800</creation_ts>
          <short_desc>Modify RandomNumberSeed.h to use USE(MERSENNE_TWISTER_19937)</short_desc>
          <delta_ts>2011-02-01 11:32:42 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Web Template Framework</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Other</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>53253</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Daniel Bates">dbates</reporter>
          <assigned_to name="Daniel Bates">dbates</assigned_to>
          <cc>abarth</cc>
    
    <cc>buildbot</cc>
    
    <cc>dglazkov</cc>
    
    <cc>eric</cc>
    
    <cc>paroga</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>343281</commentid>
    <comment_count>0</comment_count>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2011-02-01 09:54:03 -0800</bug_when>
    <thetext>Following up from bug #53253, we should guard code in RandomNumberSeed.h that uses the Mersenne Twister pseudorandom number generator with USE(MERSENNE_TWISTER_19937).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>343302</commentid>
    <comment_count>1</comment_count>
      <attachid>80780</attachid>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2011-02-01 10:12:03 -0800</bug_when>
    <thetext>Created attachment 80780
Patch

I filed bug #53508 to add support for the Mersenne Twister PRNG for all ports that don&apos;t use srand(3) and rand(3).

I am open to suggestions on how best to write this patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>343307</commentid>
    <comment_count>2</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-02-01 10:15:13 -0800</bug_when>
    <thetext>Attachment 80780 did not build on chromium:
Build output: http://queues.webkit.org/results/7680840</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>343309</commentid>
    <comment_count>3</comment_count>
    <who name="Patrick R. Gansterer">paroga</who>
    <bug_when>2011-02-01 10:18:21 -0800</bug_when>
    <thetext>I don&apos;t like the return. What about the following?

#if OS(DARWIN)
// On Darwin we use arc4random which initialises itself.
#elif OS(WINCE)
// initialize rand()
srand(GetTickCount());
#elif COMPILER(MSVC) &amp;&amp; defined(_CRT_RAND_S)
// On Windows we use rand_s which initialises itself
#elif PLATFORM(BREWMP)
// On Brew MP we use AEECLSID_RANDOM which initialises itself
#elif OS(UNIX)
// srandomdev is not guaranteed to exist on linux so we use this poor seed, this should be improved
timeval time;
gettimeofday(&amp;time, 0);
srandom(static_cast&lt;unsigned&gt;(time.tv_usec * getpid()));
#else
srand(static_cast&lt;unsigned&gt;(time(0)));
#endif

#if USE(MERSENNE_TWISTER_19937)
// use rand() to initialize the Mersenne Twister random number generator.
unsigned long initializationBuffer[4];
initializationBuffer[0] = (rand() &lt;&lt; 16) | rand();
initializationBuffer[1] = (rand() &lt;&lt; 16) | rand();
initializationBuffer[2] = (rand() &lt;&lt; 16) | rand();
initializationBuffer[3] = (rand() &lt;&lt; 16) | rand();
init_by_array(initializationBuffer, 4);
#endif</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>343310</commentid>
    <comment_count>4</comment_count>
      <attachid>80781</attachid>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2011-02-01 10:20:58 -0800</bug_when>
    <thetext>Created attachment 80781
Patch

Updated patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>343317</commentid>
    <comment_count>5</comment_count>
      <attachid>80781</attachid>
    <who name="Patrick R. Gansterer">paroga</who>
    <bug_when>2011-02-01 10:26:23 -0800</bug_when>
    <thetext>Comment on attachment 80781
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=80781&amp;action=review

&gt; Source/JavaScriptCore/wtf/RandomNumberSeed.h:71
&gt; +// FIXME: Add Mersenne Twister support for platforms that don&apos;t use srand(3) and rand(3).
&gt; +// See &lt;https://bugs.webkit.org/show_bug.cgi?id=53508&gt;.

Is there any value in this comments? Other ports don&apos;t use rand and _don&apos;t_ need Mersenne Twister. (See comments above.)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>343323</commentid>
    <comment_count>6</comment_count>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2011-02-01 10:28:15 -0800</bug_when>
    <thetext>(In reply to comment #5)
&gt; (From update of attachment 80781 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=80781&amp;action=review
&gt; 
&gt; &gt; Source/JavaScriptCore/wtf/RandomNumberSeed.h:71
&gt; &gt; +// FIXME: Add Mersenne Twister support for platforms that don&apos;t use srand(3) and rand(3).
&gt; &gt; +// See &lt;https://bugs.webkit.org/show_bug.cgi?id=53508&gt;.
&gt; 
&gt; Is there any value in this comments? Other ports don&apos;t use rand and _don&apos;t_ need Mersenne Twister. (See comments above.)

Will remove it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>343329</commentid>
    <comment_count>7</comment_count>
      <attachid>80783</attachid>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2011-02-01 10:32:13 -0800</bug_when>
    <thetext>Created attachment 80783
Patch

Updated patch based on Patrick Gansterer&apos;s comment and marked bug #53508 as invalid.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>343342</commentid>
    <comment_count>8</comment_count>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2011-02-01 10:50:43 -0800</bug_when>
    <thetext>Committed r77260: &lt;http://trac.webkit.org/changeset/77260&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>343344</commentid>
    <comment_count>9</comment_count>
    <who name="Build Bot">buildbot</who>
    <bug_when>2011-02-01 10:51:04 -0800</bug_when>
    <thetext>Attachment 80780 did not build on win:
Build output: http://queues.webkit.org/results/7680852</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>343378</commentid>
    <comment_count>10</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-02-01 11:32:42 -0800</bug_when>
    <thetext>http://trac.webkit.org/changeset/77260 might have broken SnowLeopard Intel Release (Tests)</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>80780</attachid>
            <date>2011-02-01 10:12:03 -0800</date>
            <delta_ts>2011-02-01 10:20:58 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>Bug53506.patch</filename>
            <type>text/plain</type>
            <size>3271</size>
            <attacher name="Daniel Bates">dbates</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gNzcyNTQpCisrKyBTb3VyY2Uv
SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAK
KzIwMTEtMDItMDEgIERhbmllbCBCYXRlcyAgPGRiYXRlc0ByaW0uY29tPgorCisgICAgICAgIFJl
dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1vZGlmeSBSYW5kb21OdW1iZXJT
ZWVkLmggdG8gdXNlIFVTRShNRVJTRU5ORV9UV0lTVEVSXzE5OTM3KQorICAgICAgICBodHRwczov
L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTM1MDYKKworICAgICAgICBDdXJyZW50
bHksIHVzZSBvZiB0aGUgTWVyc2VubmUgVHdpc3RlciBwc2V1ZG9yYW5kb20gbnVtYmVyIGdlbmVy
YXRvcgorICAgICAgICBpcyBoYXJkY29kZWQgdG8gdGhlIFdpbmRvd3MgQ0UgcG9ydC4gV2l0aCB0
aGUgcGFzc2luZyBvZiBidWcgIzUzMjUzLAorICAgICAgICB3ZSBjYW4gZ2VuZXJhbGl6ZSBzdXBw
b3J0IGZvciB0aGlzIFBSTkcgdG8gYWxsIHBvcnRzIHRoYXQgdXNlIHNyYW5kKDMpCisgICAgICAg
IGFuZCByYW5kKDMpLCBpbmNsdWRpbmcgV2luZG93cyBDRS4KKworICAgICAgICAqIHd0Zi9SYW5k
b21OdW1iZXJTZWVkLmg6CisgICAgICAgIChXVEY6OmluaXRpYWxpemVSYW5kb21OdW1iZXJHZW5l
cmF0b3IpOgorCiAyMDExLTAyLTAxICBEYXZlIFRhcHVza2EgIDxkdGFwdXNrYUByaW0uY29tPgog
CiAgICAgICAgIFJldmlld2VkIGJ5IEdhdmluIEJhcnJhY2xvdWdoLgpJbmRleDogU291cmNlL0ph
dmFTY3JpcHRDb3JlL3d0Zi9SYW5kb21OdW1iZXJTZWVkLmgKPT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl
L0phdmFTY3JpcHRDb3JlL3d0Zi9SYW5kb21OdW1iZXJTZWVkLmgJKHJldmlzaW9uIDc3MTYwKQor
KysgU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9SYW5kb21OdW1iZXJTZWVkLmgJKHdvcmtpbmcg
Y29weSkKQEAgLTM4LDcgKzM4LDcgQEAKICNpbmNsdWRlIDx1bmlzdGQuaD4KICNlbmRpZgogCi0j
aWYgT1MoV0lOQ0UpCisjaWYgVVNFKE1FUlNFTk5FX1RXSVNURVJfMTk5MzcpCiBleHRlcm4gIkMi
IHsKIHZvaWQgaW5pdF9ieV9hcnJheSh1bnNpZ25lZCBsb25nIGluaXRfa2V5W10saW50IGtleV9s
ZW5ndGgpOwogfQpAQCAtNTAsMzAgKzUwLDM2IEBAIG5hbWVzcGFjZSBXVEYgewogaW5saW5lIHZv
aWQgaW5pdGlhbGl6ZVJhbmRvbU51bWJlckdlbmVyYXRvcigpCiB7CiAjaWYgT1MoREFSV0lOKQot
ICAgIC8vIE9uIERhcndpbiB3ZSB1c2UgYXJjNHJhbmRvbSB3aGljaCBpbml0aWFsaXNlcyBpdHNl
bGYuCi0jZWxpZiBPUyhXSU5DRSkKLSAgICAvLyBpbml0aWFsaXplIHJhbmQoKQotICAgIHNyYW5k
KEdldFRpY2tDb3VudCgpKTsKLQotICAgIC8vIHVzZSByYW5kKCkgdG8gaW5pdGlhbGl6ZSB0aGUg
cmVhbCBSTkcKLSAgICB1bnNpZ25lZCBsb25nIGluaXRpYWxpemF0aW9uQnVmZmVyWzRdOwotICAg
IGluaXRpYWxpemF0aW9uQnVmZmVyWzBdID0gKHJhbmQoKSA8PCAxNikgfCByYW5kKCk7Ci0gICAg
aW5pdGlhbGl6YXRpb25CdWZmZXJbMV0gPSAocmFuZCgpIDw8IDE2KSB8IHJhbmQoKTsKLSAgICBp
bml0aWFsaXphdGlvbkJ1ZmZlclsyXSA9IChyYW5kKCkgPDwgMTYpIHwgcmFuZCgpOwotICAgIGlu
aXRpYWxpemF0aW9uQnVmZmVyWzNdID0gKHJhbmQoKSA8PCAxNikgfCByYW5kKCk7Ci0gICAgaW5p
dF9ieV9hcnJheShpbml0aWFsaXphdGlvbkJ1ZmZlciwgNCk7CisgICAgcmV0dXJuOyAvLyBPbiBE
YXJ3aW4gd2UgdXNlIGFyYzRyYW5kb20gd2hpY2ggaW5pdGlhbGlzZXMgaXRzZWxmLgogI2VsaWYg
Q09NUElMRVIoTVNWQykgJiYgZGVmaW5lZChfQ1JUX1JBTkRfUykKLSAgICAvLyBPbiBXaW5kb3dz
IHdlIHVzZSByYW5kX3Mgd2hpY2ggaW5pdGlhbGlzZXMgaXRzZWxmCisgICAgcmV0dXJuOyAvLyBP
biBXaW5kb3dzIHdlIHVzZSByYW5kX3Mgd2hpY2ggaW5pdGlhbGlzZXMgaXRzZWxmCiAjZWxpZiBQ
TEFURk9STShCUkVXTVApCi0gICAgLy8gT24gQnJldyBNUCB3ZSB1c2UgQUVFQ0xTSURfUkFORE9N
IHdoaWNoIGluaXRpYWxpc2VzIGl0c2VsZgorICAgIHJldHVybjsgLy8gT24gQnJldyBNUCB3ZSB1
c2UgQUVFQ0xTSURfUkFORE9NIHdoaWNoIGluaXRpYWxpc2VzIGl0c2VsZgogI2VsaWYgT1MoVU5J
WCkKICAgICAvLyBzcmFuZG9tZGV2IGlzIG5vdCBndWFyYW50ZWVkIHRvIGV4aXN0IG9uIGxpbnV4
IHNvIHdlIHVzZSB0aGlzIHBvb3Igc2VlZCwgdGhpcyBzaG91bGQgYmUgaW1wcm92ZWQKICAgICB0
aW1ldmFsIHRpbWU7CiAgICAgZ2V0dGltZW9mZGF5KCZ0aW1lLCAwKTsKICAgICBzcmFuZG9tKHN0
YXRpY19jYXN0PHVuc2lnbmVkPih0aW1lLnR2X3VzZWMgKiBnZXRwaWQoKSkpOworICAgIHJldHVy
bjsKKyNlbmRpZgorCisjaWYgT1MoV0lOQ0UpCisgICAgc3JhbmQoR2V0VGlja0NvdW50KCkpOwog
I2Vsc2UKICAgICBzcmFuZChzdGF0aWNfY2FzdDx1bnNpZ25lZD4odGltZSgwKSkpOwogI2VuZGlm
CisKKy8vIEZJWE1FOiBBZGQgTWVyc2VubmUgVHdpc3RlciBzdXBwb3J0IGZvciBwbGF0Zm9ybXMg
dGhhdCBkb24ndCB1c2Ugc3JhbmQoMykgYW5kIHJhbmQoMykuCisvLyBTZWUgPGh0dHBzOi8vYnVn
cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MzUwOD4uCisjaWYgVVNFKE1FUlNFTk5FX1RX
SVNURVJfMTk5MzcpCisgICAgLy8gdXNlIHJhbmQoKSB0byBpbml0aWFsaXplIHRoZSBNZXJzZW5u
ZSBUd2lzdGVyIHJhbmRvbSBudW1iZXIgZ2VuZXJhdG9yLgorICAgIHVuc2lnbmVkIGxvbmcgaW5p
dGlhbGl6YXRpb25CdWZmZXJbNF07CisgICAgaW5pdGlhbGl6YXRpb25CdWZmZXJbMF0gPSAocmFu
ZCgpIDw8IDE2KSB8IHJhbmQoKTsKKyAgICBpbml0aWFsaXphdGlvbkJ1ZmZlclsxXSA9IChyYW5k
KCkgPDwgMTYpIHwgcmFuZCgpOworICAgIGluaXRpYWxpemF0aW9uQnVmZmVyWzJdID0gKHJhbmQo
KSA8PCAxNikgfCByYW5kKCk7CisgICAgaW5pdGlhbGl6YXRpb25CdWZmZXJbM10gPSAocmFuZCgp
IDw8IDE2KSB8IHJhbmQoKTsKKyAgICBpbml0X2J5X2FycmF5KGluaXRpYWxpemF0aW9uQnVmZmVy
LCA0KTsKKyNlbmRpZgogfQogCiB9Cg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>80781</attachid>
            <date>2011-02-01 10:20:58 -0800</date>
            <delta_ts>2011-02-01 10:32:13 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>Bug53506.patch</filename>
            <type>text/plain</type>
            <size>2652</size>
            <attacher name="Daniel Bates">dbates</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gNzcyNTQpCisrKyBTb3VyY2Uv
SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAK
KzIwMTEtMDItMDEgIERhbmllbCBCYXRlcyAgPGRiYXRlc0ByaW0uY29tPgorCisgICAgICAgIFJl
dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1vZGlmeSBSYW5kb21OdW1iZXJT
ZWVkLmggdG8gdXNlIFVTRShNRVJTRU5ORV9UV0lTVEVSXzE5OTM3KQorICAgICAgICBodHRwczov
L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTM1MDYKKworICAgICAgICBDdXJyZW50
bHksIHVzZSBvZiB0aGUgTWVyc2VubmUgVHdpc3RlciBwc2V1ZG9yYW5kb20gbnVtYmVyIGdlbmVy
YXRvcgorICAgICAgICBpcyBoYXJkY29kZWQgdG8gdGhlIFdpbmRvd3MgQ0UgcG9ydC4gV2l0aCB0
aGUgcGFzc2luZyBvZiBidWcgIzUzMjUzLAorICAgICAgICB3ZSBjYW4gZ2VuZXJhbGl6ZSBzdXBw
b3J0IGZvciB0aGlzIFBSTkcgdG8gYWxsIHBvcnRzIHRoYXQgdXNlIHNyYW5kKDMpCisgICAgICAg
IGFuZCByYW5kKDMpLCBpbmNsdWRpbmcgV2luZG93cyBDRS4KKworICAgICAgICAqIHd0Zi9SYW5k
b21OdW1iZXJTZWVkLmg6CisgICAgICAgIChXVEY6OmluaXRpYWxpemVSYW5kb21OdW1iZXJHZW5l
cmF0b3IpOgorCiAyMDExLTAyLTAxICBEYXZlIFRhcHVza2EgIDxkdGFwdXNrYUByaW0uY29tPgog
CiAgICAgICAgIFJldmlld2VkIGJ5IEdhdmluIEJhcnJhY2xvdWdoLgpJbmRleDogU291cmNlL0ph
dmFTY3JpcHRDb3JlL3d0Zi9SYW5kb21OdW1iZXJTZWVkLmgKPT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl
L0phdmFTY3JpcHRDb3JlL3d0Zi9SYW5kb21OdW1iZXJTZWVkLmgJKHJldmlzaW9uIDc3MTYwKQor
KysgU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9SYW5kb21OdW1iZXJTZWVkLmgJKHdvcmtpbmcg
Y29weSkKQEAgLTM4LDcgKzM4LDcgQEAKICNpbmNsdWRlIDx1bmlzdGQuaD4KICNlbmRpZgogCi0j
aWYgT1MoV0lOQ0UpCisjaWYgVVNFKE1FUlNFTk5FX1RXSVNURVJfMTk5MzcpCiBleHRlcm4gIkMi
IHsKIHZvaWQgaW5pdF9ieV9hcnJheSh1bnNpZ25lZCBsb25nIGluaXRfa2V5W10saW50IGtleV9s
ZW5ndGgpOwogfQpAQCAtNTQsMTQgKzU0LDYgQEAgaW5saW5lIHZvaWQgaW5pdGlhbGl6ZVJhbmRv
bU51bWJlckdlbmVyYQogI2VsaWYgT1MoV0lOQ0UpCiAgICAgLy8gaW5pdGlhbGl6ZSByYW5kKCkK
ICAgICBzcmFuZChHZXRUaWNrQ291bnQoKSk7Ci0KLSAgICAvLyB1c2UgcmFuZCgpIHRvIGluaXRp
YWxpemUgdGhlIHJlYWwgUk5HCi0gICAgdW5zaWduZWQgbG9uZyBpbml0aWFsaXphdGlvbkJ1ZmZl
cls0XTsKLSAgICBpbml0aWFsaXphdGlvbkJ1ZmZlclswXSA9IChyYW5kKCkgPDwgMTYpIHwgcmFu
ZCgpOwotICAgIGluaXRpYWxpemF0aW9uQnVmZmVyWzFdID0gKHJhbmQoKSA8PCAxNikgfCByYW5k
KCk7Ci0gICAgaW5pdGlhbGl6YXRpb25CdWZmZXJbMl0gPSAocmFuZCgpIDw8IDE2KSB8IHJhbmQo
KTsKLSAgICBpbml0aWFsaXphdGlvbkJ1ZmZlclszXSA9IChyYW5kKCkgPDwgMTYpIHwgcmFuZCgp
OwotICAgIGluaXRfYnlfYXJyYXkoaW5pdGlhbGl6YXRpb25CdWZmZXIsIDQpOwogI2VsaWYgQ09N
UElMRVIoTVNWQykgJiYgZGVmaW5lZChfQ1JUX1JBTkRfUykKICAgICAvLyBPbiBXaW5kb3dzIHdl
IHVzZSByYW5kX3Mgd2hpY2ggaW5pdGlhbGlzZXMgaXRzZWxmCiAjZWxpZiBQTEFURk9STShCUkVX
TVApCkBAIC03NCw2ICs2NiwxOCBAQCBpbmxpbmUgdm9pZCBpbml0aWFsaXplUmFuZG9tTnVtYmVy
R2VuZXJhCiAjZWxzZQogICAgIHNyYW5kKHN0YXRpY19jYXN0PHVuc2lnbmVkPih0aW1lKDApKSk7
CiAjZW5kaWYKKworLy8gRklYTUU6IEFkZCBNZXJzZW5uZSBUd2lzdGVyIHN1cHBvcnQgZm9yIHBs
YXRmb3JtcyB0aGF0IGRvbid0IHVzZSBzcmFuZCgzKSBhbmQgcmFuZCgzKS4KKy8vIFNlZSA8aHR0
cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUzNTA4Pi4KKyNpZiBVU0UoTUVS
U0VOTkVfVFdJU1RFUl8xOTkzNykKKyAgICAvLyB1c2UgcmFuZCgpIHRvIGluaXRpYWxpemUgdGhl
IE1lcnNlbm5lIFR3aXN0ZXIgcmFuZG9tIG51bWJlciBnZW5lcmF0b3IuCisgICAgdW5zaWduZWQg
bG9uZyBpbml0aWFsaXphdGlvbkJ1ZmZlcls0XTsKKyAgICBpbml0aWFsaXphdGlvbkJ1ZmZlclsw
XSA9IChyYW5kKCkgPDwgMTYpIHwgcmFuZCgpOworICAgIGluaXRpYWxpemF0aW9uQnVmZmVyWzFd
ID0gKHJhbmQoKSA8PCAxNikgfCByYW5kKCk7CisgICAgaW5pdGlhbGl6YXRpb25CdWZmZXJbMl0g
PSAocmFuZCgpIDw8IDE2KSB8IHJhbmQoKTsKKyAgICBpbml0aWFsaXphdGlvbkJ1ZmZlclszXSA9
IChyYW5kKCkgPDwgMTYpIHwgcmFuZCgpOworICAgIGluaXRfYnlfYXJyYXkoaW5pdGlhbGl6YXRp
b25CdWZmZXIsIDQpOworI2VuZGlmCiB9CiAKIH0K
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>80783</attachid>
            <date>2011-02-01 10:32:13 -0800</date>
            <delta_ts>2011-02-01 10:41:36 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>Bug53506.patch</filename>
            <type>text/plain</type>
            <size>2504</size>
            <attacher name="Daniel Bates">dbates</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gNzcyNTQpCisrKyBTb3VyY2Uv
SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAK
KzIwMTEtMDItMDEgIERhbmllbCBCYXRlcyAgPGRiYXRlc0ByaW0uY29tPgorCisgICAgICAgIFJl
dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1vZGlmeSBSYW5kb21OdW1iZXJT
ZWVkLmggdG8gdXNlIFVTRShNRVJTRU5ORV9UV0lTVEVSXzE5OTM3KQorICAgICAgICBodHRwczov
L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTM1MDYKKworICAgICAgICBDdXJyZW50
bHksIHVzZSBvZiB0aGUgTWVyc2VubmUgVHdpc3RlciBwc2V1ZG9yYW5kb20gbnVtYmVyIGdlbmVy
YXRvcgorICAgICAgICBpcyBoYXJkY29kZWQgdG8gdGhlIFdpbmRvd3MgQ0UgcG9ydC4gV2l0aCB0
aGUgcGFzc2luZyBvZiBidWcgIzUzMjUzLAorICAgICAgICB3ZSBjYW4gZ2VuZXJhbGl6ZSBzdXBw
b3J0IGZvciB0aGlzIFBSTkcgdG8gYWxsIHBvcnRzIHRoYXQgdXNlIHNyYW5kKDMpCisgICAgICAg
IGFuZCByYW5kKDMpLCBpbmNsdWRpbmcgV2luZG93cyBDRS4KKworICAgICAgICAqIHd0Zi9SYW5k
b21OdW1iZXJTZWVkLmg6CisgICAgICAgIChXVEY6OmluaXRpYWxpemVSYW5kb21OdW1iZXJHZW5l
cmF0b3IpOgorCiAyMDExLTAyLTAxICBEYXZlIFRhcHVza2EgIDxkdGFwdXNrYUByaW0uY29tPgog
CiAgICAgICAgIFJldmlld2VkIGJ5IEdhdmluIEJhcnJhY2xvdWdoLgpJbmRleDogU291cmNlL0ph
dmFTY3JpcHRDb3JlL3d0Zi9SYW5kb21OdW1iZXJTZWVkLmgKPT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl
L0phdmFTY3JpcHRDb3JlL3d0Zi9SYW5kb21OdW1iZXJTZWVkLmgJKHJldmlzaW9uIDc3MTYwKQor
KysgU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9SYW5kb21OdW1iZXJTZWVkLmgJKHdvcmtpbmcg
Y29weSkKQEAgLTM4LDcgKzM4LDcgQEAKICNpbmNsdWRlIDx1bmlzdGQuaD4KICNlbmRpZgogCi0j
aWYgT1MoV0lOQ0UpCisjaWYgVVNFKE1FUlNFTk5FX1RXSVNURVJfMTk5MzcpCiBleHRlcm4gIkMi
IHsKIHZvaWQgaW5pdF9ieV9hcnJheSh1bnNpZ25lZCBsb25nIGluaXRfa2V5W10saW50IGtleV9s
ZW5ndGgpOwogfQpAQCAtNTQsMTQgKzU0LDYgQEAgaW5saW5lIHZvaWQgaW5pdGlhbGl6ZVJhbmRv
bU51bWJlckdlbmVyYQogI2VsaWYgT1MoV0lOQ0UpCiAgICAgLy8gaW5pdGlhbGl6ZSByYW5kKCkK
ICAgICBzcmFuZChHZXRUaWNrQ291bnQoKSk7Ci0KLSAgICAvLyB1c2UgcmFuZCgpIHRvIGluaXRp
YWxpemUgdGhlIHJlYWwgUk5HCi0gICAgdW5zaWduZWQgbG9uZyBpbml0aWFsaXphdGlvbkJ1ZmZl
cls0XTsKLSAgICBpbml0aWFsaXphdGlvbkJ1ZmZlclswXSA9IChyYW5kKCkgPDwgMTYpIHwgcmFu
ZCgpOwotICAgIGluaXRpYWxpemF0aW9uQnVmZmVyWzFdID0gKHJhbmQoKSA8PCAxNikgfCByYW5k
KCk7Ci0gICAgaW5pdGlhbGl6YXRpb25CdWZmZXJbMl0gPSAocmFuZCgpIDw8IDE2KSB8IHJhbmQo
KTsKLSAgICBpbml0aWFsaXphdGlvbkJ1ZmZlclszXSA9IChyYW5kKCkgPDwgMTYpIHwgcmFuZCgp
OwotICAgIGluaXRfYnlfYXJyYXkoaW5pdGlhbGl6YXRpb25CdWZmZXIsIDQpOwogI2VsaWYgQ09N
UElMRVIoTVNWQykgJiYgZGVmaW5lZChfQ1JUX1JBTkRfUykKICAgICAvLyBPbiBXaW5kb3dzIHdl
IHVzZSByYW5kX3Mgd2hpY2ggaW5pdGlhbGlzZXMgaXRzZWxmCiAjZWxpZiBQTEFURk9STShCUkVX
TVApCkBAIC03NCw2ICs2NiwxNiBAQCBpbmxpbmUgdm9pZCBpbml0aWFsaXplUmFuZG9tTnVtYmVy
R2VuZXJhCiAjZWxzZQogICAgIHNyYW5kKHN0YXRpY19jYXN0PHVuc2lnbmVkPih0aW1lKDApKSk7
CiAjZW5kaWYKKworI2lmIFVTRShNRVJTRU5ORV9UV0lTVEVSXzE5OTM3KQorICAgIC8vIHVzZSBy
YW5kKCkgdG8gaW5pdGlhbGl6ZSB0aGUgTWVyc2VubmUgVHdpc3RlciByYW5kb20gbnVtYmVyIGdl
bmVyYXRvci4KKyAgICB1bnNpZ25lZCBsb25nIGluaXRpYWxpemF0aW9uQnVmZmVyWzRdOworICAg
IGluaXRpYWxpemF0aW9uQnVmZmVyWzBdID0gKHJhbmQoKSA8PCAxNikgfCByYW5kKCk7CisgICAg
aW5pdGlhbGl6YXRpb25CdWZmZXJbMV0gPSAocmFuZCgpIDw8IDE2KSB8IHJhbmQoKTsKKyAgICBp
bml0aWFsaXphdGlvbkJ1ZmZlclsyXSA9IChyYW5kKCkgPDwgMTYpIHwgcmFuZCgpOworICAgIGlu
aXRpYWxpemF0aW9uQnVmZmVyWzNdID0gKHJhbmQoKSA8PCAxNikgfCByYW5kKCk7CisgICAgaW5p
dF9ieV9hcnJheShpbml0aWFsaXphdGlvbkJ1ZmZlciwgNCk7CisjZW5kaWYKIH0KIAogfQo=
</data>
<flag name="review"
          id="72277"
          type_id="1"
          status="+"
          setter="tonikitoo"
    />
          </attachment>
      

    </bug>

</bugzilla>