53500 2011-02-01 09:13:46 -0800 Web Inspector: [Chromium] Heap snapshots are not preserved on "Back" button click when no CPU profiles gathered 2011-02-01 09:23:28 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 mnaganov mnaganov apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 343253 0 mnaganov 2011-02-01 09:13:46 -0800 http://code.google.com/p/chromium/issues/detail?id=71560 What steps will reproduce the problem? 1. Open google.com. 2. Click "Images" link (to populate history with a same-domain link. 3. Open DevTools. 4. Gather a heap profile. 5. Click "Back" button in browser. 6. Heap profile is removed. If before step 5 a CPU profile was also gathered, heap profile remains -- this is the correct behavior. The fix is easy -- check if we have heap snapshots gathered the same way we are checking for CPU profiles. 343256 1 80768 mnaganov 2011-02-01 09:18:26 -0800 Created attachment 80768 patch 343261 2 mnaganov 2011-02-01 09:23:28 -0800 Manually committed http://trac.webkit.org/changeset/77254 2011-02-01 Mikhail Naganov <mnaganov@chromium.org> Reviewed by Pavel Feldman. Web Inspector: Fix profiles reset to avoid clearing heap profiles in Chromium. https://bugs.webkit.org/show_bug.cgi?id=53500 * inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::resetFrontendProfiles): 80768 2011-02-01 09:18:26 -0800 2011-02-01 09:19:24 -0800 patch patch-53500 text/plain 1249 mnaganov ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBlMDJjNmNlLi5jZWJjOGQ0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTEtMDItMDEgIE1pa2hhaWwgTmFnYW5vdiAgPG1uYWdhbm92QGNocm9taXVtLm9yZz4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWIgSW5z cGVjdG9yOiBGaXggcHJvZmlsZXMgcmVzZXQgdG8gYXZvaWQgY2xlYXJpbmcgaGVhcCBwcm9maWxl cyBpbiBDaHJvbWl1bS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NTM1MDAKKworICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JQcm9maWxlckFn ZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3RvclByb2ZpbGVyQWdlbnQ6OnJlc2V0 RnJvbnRlbmRQcm9maWxlcyk6CisKIDIwMTEtMDItMDEgIEFkYW0gUm9iZW4gIDxhcm9iZW5AYXBw bGUuY29tPgogCiAgICAgICAgIEZpeCBsaW5rZXIgd2FybmluZ3MgaW4gUmVsZWFzZV9MVENHIGJ1 aWxkcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclByb2Zp bGVyQWdlbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclByb2ZpbGVy QWdlbnQuY3BwCmluZGV4IDQ3ZGM1ODUuLjU1MGZlYmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2luc3BlY3Rvci9JbnNwZWN0b3JQcm9maWxlckFnZW50LmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yUHJvZmlsZXJBZ2VudC5jcHAKQEAgLTIyMCw3ICsyMjAs OSBAQCB2b2lkIEluc3BlY3RvclByb2ZpbGVyQWdlbnQ6OnJlc2V0U3RhdGUoKQogCiB2b2lkIElu c3BlY3RvclByb2ZpbGVyQWdlbnQ6OnJlc2V0RnJvbnRlbmRQcm9maWxlcygpCiB7Ci0gICAgaWYg KG1fZnJvbnRlbmQgJiYgbV9wcm9maWxlcy5iZWdpbigpID09IG1fcHJvZmlsZXMuZW5kKCkpCisg ICAgaWYgKG1fZnJvbnRlbmQKKyAgICAgICAgJiYgbV9wcm9maWxlcy5iZWdpbigpID09IG1fcHJv ZmlsZXMuZW5kKCkKKyAgICAgICAgJiYgbV9zbmFwc2hvdHMuYmVnaW4oKSA9PSBtX3NuYXBzaG90 cy5lbmQoKSkKICAgICAgICAgbV9mcm9udGVuZC0+cmVzZXRQcm9maWxlcygpOwogfQogCg==