53499 2011-02-01 09:04:49 -0800 Remove global variable $httpdPath and replace with the return value of getHTTPDPath(). 2011-04-06 18:37:46 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 0 sccameron webkit-unassigned commit-queue dbates webkit.review.bot oldest_to_newest 343248 0 sccameron 2011-02-01 09:04:49 -0800 There is a getHTTPDPath() function in httpd.pm that is only used once. In other cases, a global $httpdPath variable is used. I propose removing the global $httpdPath variable and using local calls to getHTTPDPath() instead. 343250 1 80764 sccameron 2011-02-01 09:06:36 -0800 Created attachment 80764 use getHTTPDPath() 343266 2 80771 sccameron 2011-02-01 09:30:10 -0800 Created attachment 80771 tab was present in changelog and added link to this bug 343396 3 webkit.review.bot 2011-02-01 11:53:28 -0800 Attachment 80764 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/run-iexp..." exit_code: 1 Tools/ChangeLog:6: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 380558 4 80771 eric 2011-04-06 10:23:16 -0700 Comment on attachment 80771 tab was present in changelog and added link to this bug We don't use "get" in method names generally. 380559 5 80771 eric 2011-04-06 10:23:50 -0700 Comment on attachment 80771 tab was present in changelog and added link to this bug Ah, but I guess you didn't add this method. 381035 6 80771 commit-queue 2011-04-06 18:37:43 -0700 Comment on attachment 80771 tab was present in changelog and added link to this bug Clearing flags on attachment: 80771 Committed r83129: <http://trac.webkit.org/changeset/83129> 381036 7 commit-queue 2011-04-06 18:37:46 -0700 All reviewed patches have been landed. Closing bug. 80764 2011-02-01 09:06:36 -0800 2011-02-01 09:30:10 -0800 use getHTTPDPath() httpd.pm.patch text/plain 3139 sccameron RnJvbSA0ZjczMTllZTc3MGUwOTRmODRkNTUzNDA3YjgwYjk5MzFiZWMwMGI0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTY290dCBDYW1lcm9uIDxzY2NhbWVyb25AcmltLmNvbT4KRGF0 ZTogVHVlLCAxIEZlYiAyMDExIDExOjQ2OjU3IC0wNTAwClN1YmplY3Q6IFtQQVRDSF0gMjAxMS0w Mi0wMSAgU2NvdHQgQ2FtZXJvbiAgPHNjY2FtZXJvbkByaW0uY29tPgoKICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KCiAgICAgICAgUmVtb3ZlIGdsb2JhbCB2YXJpYWJsZSAkaHR0 cGRQYXRoIGFuZCByZXBsYWNlIHdpdGggdGhlIHJldHVybiB2YWx1ZSBvZgogICAgICAgIGdldEhU VFBEUGF0aCgpLiAgQWxzbyByZW1vdmUgdW5uZWNlc3NhcnkgY2FsbHMgdG8gZ2V0SFRUUERQYXRo KCkuCgogICAgICAgICogU2NyaXB0cy9ydW4taWV4cGxvZGVyLXRlc3RzOgogICAgICAgICogU2Ny aXB0cy93ZWJraXRwZXJsL2h0dHBkLnBtOgotLS0KIFRvb2xzL0NoYW5nZUxvZyAgICAgICAgICAg ICAgICAgICB8ICAgMTAgKysrKysrKysrKwogVG9vbHMvU2NyaXB0cy9ydW4taWV4cGxvZGVyLXRl c3RzIHwgICAgMSAtCiBUb29scy9TY3JpcHRzL3dlYmtpdHBlcmwvaHR0cGQucG0gfCAgICA2ICsr Ky0tLQogMyBmaWxlcyBjaGFuZ2VkLCAxMyBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQoK ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAwMDgx ZWJjLi4yMzdmNjUwIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDItMDEgIFNjb3R0IENhbWVyb24gIDxzY2Nh bWVyb25AcmltLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBSZW1vdmUgZ2xvYmFsIHZhcmlhYmxlICRodHRwZFBhdGggYW5kIHJlcGxhY2Ugd2l0 aCB0aGUgcmV0dXJuIHZhbHVlIG9mCisJCWdldEhUVFBEUGF0aCgpLiAgQWxzbyByZW1vdmUgdW5u ZWNlc3NhcnkgY2FsbHMgdG8gZ2V0SFRUUERQYXRoKCkuCisKKyAgICAgICAgKiBTY3JpcHRzL3J1 bi1pZXhwbG9kZXItdGVzdHM6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRwZXJsL2h0dHBkLnBt OgorCiAyMDExLTAyLTAxICBab2x0YW4gSG9ydmF0aCAgPHpvbHRhbkB3ZWJraXQub3JnPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IEFuZHJlYXMgS2xpbmcuCmRpZmYgLS1naXQgYS9Ub29scy9TY3Jp cHRzL3J1bi1pZXhwbG9kZXItdGVzdHMgYi9Ub29scy9TY3JpcHRzL3J1bi1pZXhwbG9kZXItdGVz dHMKaW5kZXggOTdlMzYzMC4uY2I2OTZhMiAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9ydW4t aWV4cGxvZGVyLXRlc3RzCisrKyBiL1Rvb2xzL1NjcmlwdHMvcnVuLWlleHBsb2Rlci10ZXN0cwpA QCAtMTE0LDcgKzExNCw2IEBAIHN1YiBjb25maWd1cmVBbmRPcGVuSFRUUERJZk5lZWRlZCgpCiB7 CiAgICAgcmV0dXJuIGlmICRpc0h0dHBkT3BlbjsKICAgICBta2RpciAkaUV4cGxvZGVyVGVzdERp cmVjdG9yeTsKLSAgICBteSAkaHR0cGRQYXRoID0gZ2V0SFRUUERQYXRoKCk7CiAgICAgbXkgJHdl YmtpdERpcmVjdG9yeSA9IGdldGN3ZCgpOwogICAgIG15ICR0ZXN0RGlyZWN0b3J5ID0gJHdlYmtp dERpcmVjdG9yeSAuICIvTGF5b3V0VGVzdHMiOwogICAgIG15ICRpRXhwbG9kZXJEaXJlY3Rvcnkg PSAkd2Via2l0RGlyZWN0b3J5IC4gIi9Ub29scy9pRXhwbG9kZXIvaUV4cGxvZGVyLTEuMy4yIjsK ZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cGVybC9odHRwZC5wbSBiL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cGVybC9odHRwZC5wbQppbmRleCBlMDU1MmZiLi5hOWE4OGZlIDEwMDY0NAot LS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHBlcmwvaHR0cGQucG0KKysrIGIvVG9vbHMvU2NyaXB0 cy93ZWJraXRwZXJsL2h0dHBkLnBtCkBAIC02Myw3ICs2Myw2IEBAICR0bXBEaXIgPSBjb252ZXJ0 TXN5c1BhdGgoJHRtcERpcikgaWYgaXNNc3lzKCk7CiBteSAkaHR0cGRMb2NrUHJlZml4ID0gIldl YktpdEh0dHBkLmxvY2suIjsKIG15ICRteUxvY2tGaWxlOwogbXkgJGV4Y2x1c2l2ZUxvY2tGaWxl ID0gRmlsZTo6U3BlYy0+Y2F0ZmlsZSgkdG1wRGlyLCAiV2ViS2l0LmxvY2siKTsKLW15ICRodHRw ZFBhdGg7CiBteSAkaHR0cGRQaWREaXIgPSBGaWxlOjpTcGVjLT5jYXRmaWxlKCR0bXBEaXIsICJX ZWJLaXQiKTsKIG15ICRodHRwZFBpZEZpbGUgPSBGaWxlOjpTcGVjLT5jYXRmaWxlKCRodHRwZFBp ZERpciwgImh0dHBkLnBpZCIpOwogbXkgJGh0dHBkUGlkOwpAQCAtNzYsNiArNzUsNyBAQCAkU0lH eydURVJNJ30gPSAnaGFuZGxlSW50ZXJydXB0JzsKIAogc3ViIGdldEhUVFBEUGF0aAogeworICAg IG15ICRodHRwZFBhdGg7CiAgICAgaWYgKGlzRGViaWFuQmFzZWQoKSkgewogICAgICAgICAkaHR0 cGRQYXRoID0gIi91c3Ivc2Jpbi9hcGFjaGUyIjsKICAgICB9IGVsc2lmIChpc01zeXMoKSkgewpA QCAtMTMwLDcgKzEzMCw3IEBAIHN1YiBnZXRIVFRQRENvbmZpZ1BhdGhGb3JUZXN0RGlyZWN0b3J5 CiAgICAgbXkgKCR0ZXN0RGlyZWN0b3J5KSA9IEBfOwogICAgIGRpZSAiTm8gdGVzdCBkaXJlY3Rv cnkgaGFzIGJlZW4gc3BlY2lmaWVkLiIgdW5sZXNzICgkdGVzdERpcmVjdG9yeSk7CiAgICAgbXkg JGh0dHBkQ29uZmlnOwotICAgIGdldEhUVFBEUGF0aCgpOworICAgIG15ICRodHRwZFBhdGggPSBn ZXRIVFRQRFBhdGgoKTsKICAgICBpZiAoaXNDeWd3aW4oKSkgewogICAgICAgICBteSAkd2luZG93 c0NvbmZEaXJlY3RvcnkgPSAiJHRlc3REaXJlY3RvcnkvaHR0cC9jb25mLyI7CiAgICAgICAgIHVu bGVzcyAoLXggIi91c3IvbGliL2FwYWNoZS9saWJwaHA0LmRsbCIpIHsKQEAgLTE3Myw3ICsxNzMs NyBAQCBzdWIgb3BlbkhUVFBEKEApCiAgICAgICAgIHVubGluayAkaHR0cGRQaWRGaWxlOwogICAg IH0KIAotICAgICRodHRwZFBhdGggPSAiL3Vzci9zYmluL2h0dHBkIiB1bmxlc3MgKCRodHRwZFBh dGgpOworICAgIG15ICRodHRwZFBhdGggPSBnZXRIVFRQRFBhdGgoKTsKIAogICAgIG9wZW4yKCI+ JjEiLCBcKkhUVFBESU4sICRodHRwZFBhdGgsIEBhcmdzKTsKIAotLSAKMS43LjIuMy5tc3lzZ2l0 LjAKCg== 80771 2011-02-01 09:30:10 -0800 2011-04-06 18:37:43 -0700 tab was present in changelog and added link to this bug httpd.pm.patch text/plain 3255 sccameron RnJvbSAxMDlhNTYyNzVhMGMzNzU0YWU0ZGJhYmM2Nzk4Nzg0NTcwZDgyMjAxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTY290dCBDYW1lcm9uIDxzY2NhbWVyb25AcmltLmNvbT4KRGF0 ZTogVHVlLCAxIEZlYiAyMDExIDExOjQ2OjU3IC0wNTAwClN1YmplY3Q6IFtQQVRDSF0gMjAxMS0w Mi0wMSAgU2NvdHQgQ2FtZXJvbiAgPHNjY2FtZXJvbkByaW0uY29tPgoKICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KCiAgICAgICAgUmVtb3ZlIGdsb2JhbCB2YXJpYWJsZSAkaHR0 cGRQYXRoIGFuZCByZXBsYWNlIHdpdGggdGhlIHJldHVybiB2YWx1ZSBvZgogICAgICAgIGdldEhU VFBEUGF0aCgpLiAgQWxzbyByZW1vdmUgdW5uZWNlc3NhcnkgY2FsbHMgdG8gZ2V0SFRUUERQYXRo KCkuCiAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUzNDk5 CgogICAgICAgICogU2NyaXB0cy9ydW4taWV4cGxvZGVyLXRlc3RzOgogICAgICAgICogU2NyaXB0 cy93ZWJraXRwZXJsL2h0dHBkLnBtOgotLS0KIFRvb2xzL0NoYW5nZUxvZyAgICAgICAgICAgICAg ICAgICB8ICAgMTEgKysrKysrKysrKysKIFRvb2xzL1NjcmlwdHMvcnVuLWlleHBsb2Rlci10ZXN0 cyB8ICAgIDEgLQogVG9vbHMvU2NyaXB0cy93ZWJraXRwZXJsL2h0dHBkLnBtIHwgICAgNiArKyst LS0KIDMgZmlsZXMgY2hhbmdlZCwgMTQgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKCmRp ZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDA4MWVi Yy4uNGYyNjg5NCAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDExLTAyLTAxICBTY290dCBDYW1lcm9uICA8c2NjYW1l cm9uQHJpbS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgUmVtb3ZlIGdsb2JhbCB2YXJpYWJsZSAkaHR0cGRQYXRoIGFuZCByZXBsYWNlIHdpdGgg dGhlIHJldHVybiB2YWx1ZSBvZgorICAgICAgICBnZXRIVFRQRFBhdGgoKS4gIEFsc28gcmVtb3Zl IHVubmVjZXNzYXJ5IGNhbGxzIHRvIGdldEhUVFBEUGF0aCgpLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTM0OTkKKworICAgICAgICAqIFNjcmlwdHMv cnVuLWlleHBsb2Rlci10ZXN0czoKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHBlcmwvaHR0cGQu cG06CisKIDIwMTEtMDItMDEgIFpvbHRhbiBIb3J2YXRoICA8em9sdGFuQHdlYmtpdC5vcmc+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgQW5kcmVhcyBLbGluZy4KZGlmZiAtLWdpdCBhL1Rvb2xzL1Nj cmlwdHMvcnVuLWlleHBsb2Rlci10ZXN0cyBiL1Rvb2xzL1NjcmlwdHMvcnVuLWlleHBsb2Rlci10 ZXN0cwppbmRleCA5N2UzNjMwLi5jYjY5NmEyIDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3J1 bi1pZXhwbG9kZXItdGVzdHMKKysrIGIvVG9vbHMvU2NyaXB0cy9ydW4taWV4cGxvZGVyLXRlc3Rz CkBAIC0xMTQsNyArMTE0LDYgQEAgc3ViIGNvbmZpZ3VyZUFuZE9wZW5IVFRQRElmTmVlZGVkKCkK IHsKICAgICByZXR1cm4gaWYgJGlzSHR0cGRPcGVuOwogICAgIG1rZGlyICRpRXhwbG9kZXJUZXN0 RGlyZWN0b3J5OwotICAgIG15ICRodHRwZFBhdGggPSBnZXRIVFRQRFBhdGgoKTsKICAgICBteSAk d2Via2l0RGlyZWN0b3J5ID0gZ2V0Y3dkKCk7CiAgICAgbXkgJHRlc3REaXJlY3RvcnkgPSAkd2Vi a2l0RGlyZWN0b3J5IC4gIi9MYXlvdXRUZXN0cyI7CiAgICAgbXkgJGlFeHBsb2RlckRpcmVjdG9y eSA9ICR3ZWJraXREaXJlY3RvcnkgLiAiL1Rvb2xzL2lFeHBsb2Rlci9pRXhwbG9kZXItMS4zLjIi OwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRwZXJsL2h0dHBkLnBtIGIvVG9vbHMv U2NyaXB0cy93ZWJraXRwZXJsL2h0dHBkLnBtCmluZGV4IGUwNTUyZmIuLmE5YTg4ZmUgMTAwNjQ0 Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cGVybC9odHRwZC5wbQorKysgYi9Ub29scy9TY3Jp cHRzL3dlYmtpdHBlcmwvaHR0cGQucG0KQEAgLTYzLDcgKzYzLDYgQEAgJHRtcERpciA9IGNvbnZl cnRNc3lzUGF0aCgkdG1wRGlyKSBpZiBpc01zeXMoKTsKIG15ICRodHRwZExvY2tQcmVmaXggPSAi V2ViS2l0SHR0cGQubG9jay4iOwogbXkgJG15TG9ja0ZpbGU7CiBteSAkZXhjbHVzaXZlTG9ja0Zp bGUgPSBGaWxlOjpTcGVjLT5jYXRmaWxlKCR0bXBEaXIsICJXZWJLaXQubG9jayIpOwotbXkgJGh0 dHBkUGF0aDsKIG15ICRodHRwZFBpZERpciA9IEZpbGU6OlNwZWMtPmNhdGZpbGUoJHRtcERpciwg IldlYktpdCIpOwogbXkgJGh0dHBkUGlkRmlsZSA9IEZpbGU6OlNwZWMtPmNhdGZpbGUoJGh0dHBk UGlkRGlyLCAiaHR0cGQucGlkIik7CiBteSAkaHR0cGRQaWQ7CkBAIC03Niw2ICs3NSw3IEBAICRT SUd7J1RFUk0nfSA9ICdoYW5kbGVJbnRlcnJ1cHQnOwogCiBzdWIgZ2V0SFRUUERQYXRoCiB7Cisg ICAgbXkgJGh0dHBkUGF0aDsKICAgICBpZiAoaXNEZWJpYW5CYXNlZCgpKSB7CiAgICAgICAgICRo dHRwZFBhdGggPSAiL3Vzci9zYmluL2FwYWNoZTIiOwogICAgIH0gZWxzaWYgKGlzTXN5cygpKSB7 CkBAIC0xMzAsNyArMTMwLDcgQEAgc3ViIGdldEhUVFBEQ29uZmlnUGF0aEZvclRlc3REaXJlY3Rv cnkKICAgICBteSAoJHRlc3REaXJlY3RvcnkpID0gQF87CiAgICAgZGllICJObyB0ZXN0IGRpcmVj dG9yeSBoYXMgYmVlbiBzcGVjaWZpZWQuIiB1bmxlc3MgKCR0ZXN0RGlyZWN0b3J5KTsKICAgICBt eSAkaHR0cGRDb25maWc7Ci0gICAgZ2V0SFRUUERQYXRoKCk7CisgICAgbXkgJGh0dHBkUGF0aCA9 IGdldEhUVFBEUGF0aCgpOwogICAgIGlmIChpc0N5Z3dpbigpKSB7CiAgICAgICAgIG15ICR3aW5k b3dzQ29uZkRpcmVjdG9yeSA9ICIkdGVzdERpcmVjdG9yeS9odHRwL2NvbmYvIjsKICAgICAgICAg dW5sZXNzICgteCAiL3Vzci9saWIvYXBhY2hlL2xpYnBocDQuZGxsIikgewpAQCAtMTczLDcgKzE3 Myw3IEBAIHN1YiBvcGVuSFRUUEQoQCkKICAgICAgICAgdW5saW5rICRodHRwZFBpZEZpbGU7CiAg ICAgfQogCi0gICAgJGh0dHBkUGF0aCA9ICIvdXNyL3NiaW4vaHR0cGQiIHVubGVzcyAoJGh0dHBk UGF0aCk7CisgICAgbXkgJGh0dHBkUGF0aCA9IGdldEhUVFBEUGF0aCgpOwogCiAgICAgb3BlbjIo Ij4mMSIsIFwqSFRUUERJTiwgJGh0dHBkUGF0aCwgQGFyZ3MpOwogCi0tIAoxLjcuMi4zLm1zeXNn aXQuMAoK