53493 2011-02-01 08:02:15 -0800 DevTools: assertion failure upon devtools window reopen. 2012-04-19 12:13:03 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 pfeldman vivekgalatage vivekgalatage webkit.review.bot yurys oldest_to_newest 343221 0 pfeldman 2011-02-01 08:02:15 -0800 Patch to follow. 605507 1 vivekgalatage 2012-04-19 05:09:10 -0700 Pavel, if it is ok with you, I have a patch for the bug and I can upload the same for your review. 605511 2 vivekgalatage 2012-04-19 05:17:53 -0700 in method WebInspectorClientFrontend::closeWindow() should explicitly call m_page->inspector()->destroyInspectorPage(); in order to reset the pointers. 605514 3 137882 vivekgalatage 2012-04-19 05:30:05 -0700 Created attachment 137882 Patch 605515 4 137883 vivekgalatage 2012-04-19 05:37:05 -0700 Created attachment 137883 Patch 605614 5 137883 pfeldman 2012-04-19 09:10:06 -0700 Comment on attachment 137883 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=137883&action=review > Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:75 > + m_page->inspector()->destroyInspectorPage(); It sounds like you should inline destroyInspectorPage into didClose in the WebInspector instead. 605736 6 137932 vivekgalatage 2012-04-19 11:30:06 -0700 Created attachment 137932 Patch 605779 7 137932 webkit.review.bot 2012-04-19 12:12:59 -0700 Comment on attachment 137932 Patch Clearing flags on attachment: 137932 Committed r114665: <http://trac.webkit.org/changeset/114665> 605780 8 webkit.review.bot 2012-04-19 12:13:03 -0700 All reviewed patches have been landed. Closing bug. 137882 2012-04-19 05:30:05 -0700 2012-04-19 05:31:46 -0700 Patch bug-53493-20120419175959.patch text/plain 1421 vivekgalatage SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDExNDYyNikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA0LTE5ICBWaXZlayBH YWxhdGFnZSAgPHZpdmVrZ2FsYXRhZ2VAZ21haWwuY29tPgorCisgICAgICAgIFZpc2libGVTZWxl Y3Rpb246OnNldFdpdGhvdXRWYWxpZGF0aW9uKCkgc2hvdWxkIGFsbG93IGNhcmV0IHNlbGVjdGlv bi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUzNDkz CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIHBv aW50ZXJzIHBvaW50ZWQgdG8gYnkgV2ViSW5zcGVjdG9yIG11c3QgYmUgZXhwbGljaXRseSByZXNl dAorICAgICAgICBieSBjYWxsaW5nIGRlc3Ryb3lJbnNwZWN0b3JQYWdlKCkKKworICAgICAgICAq IFdlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViSW5zcGVjdG9yRnJvbnRlbmRDbGllbnQuY3Bw OgorICAgICAgICAoV2ViS2l0OjpXZWJJbnNwZWN0b3JGcm9udGVuZENsaWVudDo6Y2xvc2VXaW5k b3cpOgorCiAyMDEyLTA0LTE4ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAg ICAgICAgIEZ1bGwgU2NyZWVuIG1vZGUgZG9lcyBub3QgcHJlc2VydmUgQ0FMYXllciBvcmRlcmlu ZyBhZnRlciBleGl0aW5nLgpJbmRleDogU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3Jl U3VwcG9ydC9XZWJJbnNwZWN0b3JGcm9udGVuZENsaWVudC5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJJbnNwZWN0b3JGcm9udGVu ZENsaWVudC5jcHAJKHJldmlzaW9uIDExNDEzOSkKKysrIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nl c3MvV2ViQ29yZVN1cHBvcnQvV2ViSW5zcGVjdG9yRnJvbnRlbmRDbGllbnQuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC03Miw2ICs3Miw3IEBAIHZvaWQgV2ViSW5zcGVjdG9yRnJvbnRlbmRDbGllbnQ6 OmNsb3NlV2kKIHsKICAgICBtX3BhZ2UtPmNvcmVQYWdlKCktPmluc3BlY3RvckNvbnRyb2xsZXIo KS0+ZGlzY29ubmVjdEZyb250ZW5kKCk7CiAgICAgbV9wYWdlLT5pbnNwZWN0b3IoKS0+ZGlkQ2xv c2UoKTsKKyAgICBtX3BhZ2UtPmluc3BlY3RvcigpLT5kZXN0cm95SW5zcGVjdG9yUGFnZSgpOwog fQogCiB2b2lkIFdlYkluc3BlY3RvckZyb250ZW5kQ2xpZW50OjphdHRhY2hXaW5kb3coKQo= 137883 2012-04-19 05:37:05 -0700 2012-04-19 11:29:59 -0700 Patch bug-53493-20120419180659.patch text/plain 1407 vivekgalatage SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDExNDYyNikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA0LTE5ICBWaXZlayBH YWxhdGFnZSAgPHZpdmVrZ2FsYXRhZ2VAZ21haWwuY29tPgorCisgICAgICAgIERldlRvb2xzOiBh c3NlcnRpb24gZmFpbHVyZSB1cG9uIGRldnRvb2xzIHdpbmRvdyByZW9wZW4uCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MzQ5MworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBwb2ludGVycyBwb2ludGVk IHRvIGJ5IFdlYkluc3BlY3RvciBtdXN0IGJlIGV4cGxpY2l0bHkgcmVzZXQKKyAgICAgICAgYnkg Y2FsbGluZyBkZXN0cm95SW5zcGVjdG9yUGFnZSgpCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dl YkNvcmVTdXBwb3J0L1dlYkluc3BlY3RvckZyb250ZW5kQ2xpZW50LmNwcDoKKyAgICAgICAgKFdl YktpdDo6V2ViSW5zcGVjdG9yRnJvbnRlbmRDbGllbnQ6OmNsb3NlV2luZG93KToKKwogMjAxMi0w NC0xOCAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KIAogICAgICAgICBGdWxsIFNj cmVlbiBtb2RlIGRvZXMgbm90IHByZXNlcnZlIENBTGF5ZXIgb3JkZXJpbmcgYWZ0ZXIgZXhpdGlu Zy4KSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViSW5z cGVjdG9yRnJvbnRlbmRDbGllbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1dl YlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViSW5zcGVjdG9yRnJvbnRlbmRDbGllbnQuY3BwCShy ZXZpc2lvbiAxMTQxMzkpCisrKyBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBw b3J0L1dlYkluc3BlY3RvckZyb250ZW5kQ2xpZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzIs NiArNzIsNyBAQCB2b2lkIFdlYkluc3BlY3RvckZyb250ZW5kQ2xpZW50OjpjbG9zZVdpCiB7CiAg ICAgbV9wYWdlLT5jb3JlUGFnZSgpLT5pbnNwZWN0b3JDb250cm9sbGVyKCktPmRpc2Nvbm5lY3RG cm9udGVuZCgpOwogICAgIG1fcGFnZS0+aW5zcGVjdG9yKCktPmRpZENsb3NlKCk7CisgICAgbV9w YWdlLT5pbnNwZWN0b3IoKS0+ZGVzdHJveUluc3BlY3RvclBhZ2UoKTsKIH0KIAogdm9pZCBXZWJJ bnNwZWN0b3JGcm9udGVuZENsaWVudDo6YXR0YWNoV2luZG93KCkK 137932 2012-04-19 11:30:06 -0700 2012-04-19 12:12:59 -0700 Patch bug-53493-20120420000001.patch text/plain 1945 vivekgalatage SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDExNDY1NSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA0LTE5ICBWaXZlayBH YWxhdGFnZSAgPHZpdmVrZ2FsYXRhZ2VAZ21haWwuY29tPgorCisgICAgICAgIERldlRvb2xzOiBh c3NlcnRpb24gZmFpbHVyZSB1cG9uIGRldnRvb2xzIHdpbmRvdyByZW9wZW4uCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MzQ5MworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBwb2ludGVycyBwb2ludGVk IHRvIGJ5IFdlYkluc3BlY3RvciBtdXN0IGJlIHJlc2V0IGV4cGxpY2l0bHkKKyAgICAgICAgaW4g V2ViSW5zcGVjdG9yOjpkaWRDbG9zZSgpIG1ldGhvZAorCisgICAgICAgICogV2ViUHJvY2Vzcy9X ZWJDb3JlU3VwcG9ydC9XZWJJbnNwZWN0b3JDbGllbnQuY3BwOgorICAgICAgICAoV2ViS2l0OjpX ZWJJbnNwZWN0b3JDbGllbnQ6OmNsb3NlSW5zcGVjdG9yRnJvbnRlbmQpOgorICAgICAgICAqIFdl YlByb2Nlc3MvV2ViUGFnZS9XZWJJbnNwZWN0b3IuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJJ bnNwZWN0b3I6OmRpZENsb3NlKToKKwogMjAxMi0wNC0xOSAgWmFsYW4gQnVqdGFzICA8emJ1anRh c0BnbWFpbC5jb20+CiAKICAgICAgICAgW1F0XVtXSzJdIFpvb20gb3V0IG9uIHRoZSBzZWNvbmQg ZG91YmxlIGNsaWNrIGRvZXMgbm90IGFsd2F5cyBzY2FsZSByaWdodC4KSW5kZXg6IFNvdXJjZS9X ZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViSW5zcGVjdG9yQ2xpZW50LmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dl Ykluc3BlY3RvckNsaWVudC5jcHAJKHJldmlzaW9uIDExNDY0NykKKysrIFNvdXJjZS9XZWJLaXQy L1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViSW5zcGVjdG9yQ2xpZW50LmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtNTMsNyArNTMsNiBAQCB2b2lkIFdlYkluc3BlY3RvckNsaWVudDo6Y2xvc2VJ bnNwZWN0b3JGCiB7CiAgICAgaWYgKG1fcGFnZS0+aW5zcGVjdG9yKCkpIHsKICAgICAgICAgbV9w YWdlLT5pbnNwZWN0b3IoKS0+ZGlkQ2xvc2UoKTsKLSAgICAgICAgbV9wYWdlLT5pbnNwZWN0b3Io KS0+ZGVzdHJveUluc3BlY3RvclBhZ2UoKTsKICAgICB9CiB9CiAKSW5kZXg6IFNvdXJjZS9XZWJL aXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJJbnNwZWN0b3IuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJJbnNwZWN0b3IuY3BwCShyZXZpc2lv biAxMTQ2NDcpCisrKyBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViSW5zcGVj dG9yLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTAyLDYgKzEwMiw3IEBAIHZvaWQgV2ViSW5zcGVj dG9yOjpkaWRMb2FkSW5zcGVjdG9yUGFnZSgKIHZvaWQgV2ViSW5zcGVjdG9yOjpkaWRDbG9zZSgp CiB7CiAgICAgV2ViUHJvY2Vzczo6c2hhcmVkKCkuY29ubmVjdGlvbigpLT5zZW5kKE1lc3NhZ2Vz OjpXZWJJbnNwZWN0b3JQcm94eTo6RGlkQ2xvc2UoKSwgbV9wYWdlLT5wYWdlSUQoKSk7CisgICAg ZGVzdHJveUluc3BlY3RvclBhZ2UoKTsKIH0KIAogdm9pZCBXZWJJbnNwZWN0b3I6OmJyaW5nVG9G cm9udCgpCg==