53482 2011-02-01 04:09:17 -0800 Web Inspector: [Chromium] Wrongly labelled context-menu item for links in Web Inspector's side-pane 2011-02-01 06:53:33 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 apavlov apavlov apavlov bweinstein commit-queue joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 343127 0 apavlov 2011-02-01 04:09:17 -0800 1. Open a web page with a background image. 2. Open the Developers Tools. 3. Select the DOM element with the background image. 4. Right click on the image link in the right panel. What is the expected result? Item with text: "Open link in new tab" What happens instead? Item with text: "Open Link in New Window" 343174 1 80750 apavlov 2011-02-01 05:50:35 -0800 Created attachment 80750 [PATCH] Suggested fix 343183 2 80750 yurys 2011-02-01 06:10:04 -0800 Comment on attachment 80750 [PATCH] Suggested fix View in context: https://bugs.webkit.org/attachment.cgi?id=80750&action=review > Source/WebKit/chromium/src/js/DevTools.js:98 > +WebInspector.openLinkExternallyLabel = function() Why not use the same mechanism in Chrome and in Safari? 343204 3 80750 commit-queue 2011-02-01 06:53:28 -0800 Comment on attachment 80750 [PATCH] Suggested fix Clearing flags on attachment: 80750 Committed r77249: <http://trac.webkit.org/changeset/77249> 343205 4 commit-queue 2011-02-01 06:53:33 -0800 All reviewed patches have been landed. Closing bug. 80750 2011-02-01 05:50:35 -0800 2011-02-01 06:53:28 -0800 [PATCH] Suggested fix openinnewtab.patch text/plain 4289 apavlov Y29tbWl0IGVmNDJhMzRkMmNlMjUyMTc3ZmFlYzA5MTY4MDY1MzY3NTZhZjljNjEKQXV0aG9yOiBB bGV4YW5kZXIgUGF2bG92IDxhcGF2bG92QGNocm9taXVtLm9yZz4KRGF0ZTogICBUdWUgRmViIDEg MTY6MjE6NTAgMjAxMSArMDMwMAoKICAgIEZpeEl0ZW1MYWJlbAoKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA5ODk2 ODAwLi5mODIwNDhkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIv U291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDItMDEgIEFs ZXhhbmRlciBQYXZsb3YgIDxhcGF2bG92QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBbQ2hyb21pdW1d IFdyb25nbHkgbGFiZWxsZWQgY29udGV4dC1tZW51IGl0ZW0gZm9yIGxpbmtzIGluIFdlYiBJbnNw ZWN0b3IncyBzaWRlLXBhbmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTUzNDgyCisKKyAgICAgICAgKiBFbmdsaXNoLmxwcm9qL2xvY2FsaXplZFN0cmlu Z3MuanM6CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9FbGVtZW50c1BhbmVsLmpzOgor ICAgICAgICAoV2ViSW5zcGVjdG9yLkVsZW1lbnRzUGFuZWwucHJvdG90eXBlLnBvcHVsYXRlSHJl ZkNvbnRleHRNZW51KToKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5q czoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5yZXNvdXJjZUZvclVSTCk6CisgICAgICAgIChXZWJJ bnNwZWN0b3Iub3BlbkxpbmtFeHRlcm5hbGx5TGFiZWwpOgorCiAyMDExLTAyLTAxICBab2x0YW4g SGVyY3plZyAgPHpoZXJjemVnQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGly ayBTY2h1bHplLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvRW5nbGlzaC5scHJvai9sb2Nh bGl6ZWRTdHJpbmdzLmpzIGIvU291cmNlL1dlYkNvcmUvRW5nbGlzaC5scHJvai9sb2NhbGl6ZWRT dHJpbmdzLmpzCmluZGV4IDdhZWNiYjZiMWViNTM4MzZhMTU2MjM4ZmQ1ZGFjNDY1YWM0MDU4N2Eu LmZkZTlkY2IwZWFjMjc3NDkwNjViOGQxZjA3YTllNTA5YjE1MDllZDUgMTAwNjQ0CkdJVCBiaW5h cnkgcGF0Y2gKZGVsdGEgMzgKcGNtYlEhJiU5Xj9eTSpNb3RSVzFFM2B2dWhyfDNnajRednp4cEd5 KGp5ZWoyVzUmI2sjNDwtTnIKCmRlbHRhIDE4CmFjbVoyOWZxNzBwXk0qTW9sVmVpKEhYRWRWTiYp figxcWMhVgoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQv RWxlbWVudHNQYW5lbC5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRWxl bWVudHNQYW5lbC5qcwppbmRleCA5Mjk5NDc5Li4wOTRmMjA5IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRzUGFuZWwuanMKKysrIGIvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FbGVtZW50c1BhbmVsLmpzCkBAIC0yNTUsOCAr MjU1LDcgQEAgV2ViSW5zcGVjdG9yLkVsZW1lbnRzUGFuZWwucHJvdG90eXBlID0gewogICAgICAg ICAgICAgcmV0dXJuIGZhbHNlOwogCiAgICAgICAgIC8vIEFkZCByZXNvdXJjZS1yZWxhdGVkIGFj dGlvbnMuCi0gICAgICAgIC8vIEtlZXAgdGhlc2UgY29uc2lzdGVudCB3aXRoIHRob3NlIGFkZGVk IGluIFdlYkluc3BlY3Rvci5TdHlsZXNTaWRlYmFyUGFuZS5wcm90b3R5cGUuX3BvcHVsYXRlSHJl ZkNvbnRleHRNZW51KCkuCi0gICAgICAgIGNvbnRleHRNZW51LmFwcGVuZEl0ZW0oV2ViSW5zcGVj dG9yLlVJU3RyaW5nKCJPcGVuIExpbmsgaW4gTmV3IFdpbmRvdyIpLCBXZWJJbnNwZWN0b3Iub3Bl blJlc291cmNlLmJpbmQobnVsbCwgcmVzb3VyY2VVUkwsIGZhbHNlKSk7CisgICAgICAgIGNvbnRl eHRNZW51LmFwcGVuZEl0ZW0oV2ViSW5zcGVjdG9yLm9wZW5MaW5rRXh0ZXJuYWxseUxhYmVsKCks IFdlYkluc3BlY3Rvci5vcGVuUmVzb3VyY2UuYmluZChudWxsLCByZXNvdXJjZVVSTCwgZmFsc2Up KTsKICAgICAgICAgaWYgKFdlYkluc3BlY3Rvci5yZXNvdXJjZUZvclVSTChyZXNvdXJjZVVSTCkp CiAgICAgICAgICAgICBjb250ZXh0TWVudS5hcHBlbmRJdGVtKFdlYkluc3BlY3Rvci5VSVN0cmlu ZygiT3BlbiBMaW5rIGluIFJlc291cmNlcyBQYW5lbCIpLCBXZWJJbnNwZWN0b3Iub3BlblJlc291 cmNlLmJpbmQobnVsbCwgcmVzb3VyY2VVUkwsIHRydWUpKTsKICAgICAgICAgcmV0dXJuIHRydWU7 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rv ci5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmpzCmlu ZGV4IDE0NDM3YmUuLmY0Yjg2OGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvaW5zcGVjdG9yLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9m cm9udC1lbmQvaW5zcGVjdG9yLmpzCkBAIC00NDksNiArNDQ5LDExIEBAIHZhciBXZWJJbnNwZWN0 b3IgPSB7CiAgICAgcmVzb3VyY2VGb3JVUkw6IGZ1bmN0aW9uKHVybCkKICAgICB7CiAgICAgICAg IHJldHVybiB0aGlzLnJlc291cmNlVHJlZU1vZGVsLnJlc291cmNlRm9yVVJMKHVybCk7CisgICAg fSwKKworICAgIG9wZW5MaW5rRXh0ZXJuYWxseUxhYmVsOiBmdW5jdGlvbigpCisgICAgeworICAg ICAgICByZXR1cm4gV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJPcGVuIExpbmsgaW4gTmV3IFdpbmRv dyIpOwogICAgIH0KIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFu Z2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwppbmRleCBkMGVkNGM2Li44 MmVhY2I5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZworKysg Yi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEx LTAyLTAxICBBbGV4YW5kZXIgUGF2bG92ICA8YXBhdmxvdkBjaHJvbWl1bS5vcmc+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViIEluc3BlY3Rvcjog W0Nocm9taXVtXSBXcm9uZ2x5IGxhYmVsbGVkIGNvbnRleHQtbWVudSBpdGVtIGZvciBsaW5rcyBp biBXZWIgSW5zcGVjdG9yJ3Mgc2lkZS1wYW5lCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD01MzQ4MgorCisgICAgICAgICogc3JjL2pzL0RldlRvb2xzLmpz OgorICAgICAgICAoV2ViSW5zcGVjdG9yLm9wZW5MaW5rRXh0ZXJuYWxseUxhYmVsKTogT3ZlcnJp ZGUgdG8gY3VzdG9taXplIGEgY29udGV4dCBtZW51IGl0ZW0gbGFiZWwKKwogMjAxMS0wMi0wMSAg SGFucyBXZW5uYm9yZyAgPGhhbnNAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IEplcmVteSBPcmxvdy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL2pz L0RldlRvb2xzLmpzIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvanMvRGV2VG9vbHMuanMK aW5kZXggNjM3ZmQxZi4uM2Q2MWJlNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1 bS9zcmMvanMvRGV2VG9vbHMuanMKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvanMv RGV2VG9vbHMuanMKQEAgLTg5LDYgKzg5LDE4IEBAIFdlYkluc3BlY3Rvci5VSVN0cmluZyA9IGZ1 bmN0aW9uKHN0cmluZykKIH07CiAKIAorLyoKKyAqIFRoaXMgbGFiZWwgbXVzdCBiZSBrZXB0IGNv bnNpc3RlbnQgd2l0aCB0aGF0IGluIEVuZ2xpc2gubHByb2ovbG9jYWxpemVkU3RyaW5ncy5qcwor ICoKKyAqIGh0dHA6Ly9jb2RlLmdvb2dsZS5jb20vcC9jaHJvbWl1bS9pc3N1ZXMvZGV0YWlsP2lk PTYxMzAyIHJlcXVpcmVzIGEgY3VzdG9tIGxhYmVsIGZvciBDaHJvbWl1bSwKKyAqIHNpbmNlIGl0 cyBiZWhhdmlvciBpcyBkaWZmZXJlbnQuCisgKi8KK1dlYkluc3BlY3Rvci5vcGVuTGlua0V4dGVy bmFsbHlMYWJlbCA9IGZ1bmN0aW9uKCkKK3sKKyAgICByZXR1cm4gV2ViSW5zcGVjdG9yLlVJU3Ry aW5nKCJPcGVuIExpbmsgaW4gTmV3IFRhYiIpOworfTsKKworCiAvKiogUGVuZGluZyBXZWJLaXQg dXBzdHJlYW0gYnkgYXBhdmxvdikuIEZpeGVzIGlmcmFtZSB2cyBkcmFnIHByb2JsZW0uICovCiAo ZnVuY3Rpb24oKQogewo=