53462 2011-01-31 15:57:42 -0800 Using Control-C to cancel webkit-patch or other python tools causes unpleasant traceback console spew 2011-02-01 12:36:04 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 darin webkit-unassigned abarth commit-queue eric mihaip ojan oldest_to_newest 342880 0 darin 2011-01-31 15:57:42 -0800 For example, I hit Control-C when webkit-patch was asking me about a diff Was that diff correct? [Y/n]: Traceback (most recent call last): File "/Users/darin/Safari/OpenSource/Tools/Scripts/webkit-patch", line 70, in <module> main() File "/Users/darin/Safari/OpenSource/Tools/Scripts/webkit-patch", line 65, in main WebKitPatch(__file__).main() File "/Volumes/Home/darin/Safari/OpenSource/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 308, in main result = command.check_arguments_and_execute(options, args, self) File "/Volumes/Home/darin/Safari/OpenSource/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 117, in check_arguments_and_execute return self.execute(options, args, tool) or 0 File "/Volumes/Home/darin/Safari/OpenSource/Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py", line 51, in execute self._sequence.run_and_handle_errors(tool, options, state) File "/Volumes/Home/darin/Safari/OpenSource/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 70, in run_and_handle_errors self._run(tool, options, state) File "/Volumes/Home/darin/Safari/OpenSource/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 64, in _run step(tool, options).run(state) File "/Volumes/Home/darin/Safari/OpenSource/Tools/Scripts/webkitpy/tool/steps/confirmdiff.py", line 73, in run diff_correct = self._tool.user.confirm("Was that diff correct?") File "/Volumes/Home/darin/Safari/OpenSource/Tools/Scripts/webkitpy/common/system/user.py", line 128, in confirm response = raw_input("%s [%s]: " % (message, choice)) KeyboardInterrupt Yuck! Who else should I cc on this bug? 342882 1 eric 2011-01-31 15:59:25 -0800 We could catch these, sure. For now we've enjoyed the default handler's print-the-stacktrace behavior. 342902 2 darin 2011-01-31 16:09:54 -0800 Since I’m using the scripts, not developing them, the traceback is never useful to me. 342903 3 eric 2011-01-31 16:11:36 -0800 Yes, I think you are correct that these scripts have moved from a development stage to being deployed and used and we should get rid of debug messages like these. I agree with this bug completely. 343369 4 80793 abarth 2011-02-01 11:22:26 -0800 Created attachment 80793 Patch 343381 5 80793 mihaip 2011-02-01 11:35:22 -0800 Comment on attachment 80793 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=80793&action=review > Tools/Scripts/webkit-patch:72 > + pass Exiting with a non-0 exit code seems better (see http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py#L440) 343388 6 80797 abarth 2011-02-01 11:39:15 -0800 Created attachment 80797 Patch 343413 7 80797 eric 2011-02-01 12:23:28 -0800 Comment on attachment 80797 Patch I would hav elogged "user interupted". I might even put this in the multicommandtool.py instead. Also, isn't there a python helper for the 128 + bit? I don't think this should exit 0 though, so you're right in returning the signal code. 343425 8 80797 commit-queue 2011-02-01 12:35:58 -0800 Comment on attachment 80797 Patch Clearing flags on attachment: 80797 Committed r77275: <http://trac.webkit.org/changeset/77275> 343427 9 commit-queue 2011-02-01 12:36:04 -0800 All reviewed patches have been landed. Closing bug. 80793 2011-02-01 11:22:26 -0800 2011-02-01 11:39:12 -0800 Patch bug-53462-20110201112225.patch text/plain 973 abarth SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDc3MjYzKQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTUgQEAKKzIwMTEtMDItMDEgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVc2luZyBDb250 cm9sLUMgdG8gY2FuY2VsIHdlYmtpdC1wYXRjaCBvciBvdGhlciBweXRob24gdG9vbHMgY2F1c2Vz CisgICAgICAgIHVucGxlYXNhbnQgdHJhY2ViYWNrIGNvbnNvbGUgc3BldworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTM0NjIKKworICAgICAgICBDYXRj aCB0aGUgZXhjZXB0aW9uIGFuZCBkb24ndCBwcmludCB0aGUgc3RhY2sgdHJhY2UuCisKKyAgICAg ICAgKiBTY3JpcHRzL3dlYmtpdC1wYXRjaDoKKwogMjAxMS0wMi0wMSAgQmFsYXpzIEtlbGVtZW4g IDxrYmFsYXpzQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW5kcmVhcyBLbGlu Zy4KSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0LXBhdGNoCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xz L1NjcmlwdHMvd2Via2l0LXBhdGNoCShyZXZpc2lvbiA3NzI2MikKKysrIFRvb2xzL1NjcmlwdHMv d2Via2l0LXBhdGNoCSh3b3JraW5nIGNvcHkpCkBAIC02Niw1ICs2Niw3IEBAIGRlZiBtYWluKCk6 CiAKIAogaWYgX19uYW1lX18gPT0gIl9fbWFpbl9fIjoKLQotICAgIG1haW4oKQorICAgIHRyeToK KyAgICAgICAgbWFpbigpCisgICAgZXhjZXB0IEtleWJvYXJkSW50ZXJydXB0OgorICAgICAgICBw YXNzCg== 80797 2011-02-01 11:39:15 -0800 2011-02-01 12:35:58 -0800 Patch bug-53462-20110201113914.patch text/plain 1137 abarth SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDc3MjYzKQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTUgQEAKKzIwMTEtMDItMDEgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVc2luZyBDb250 cm9sLUMgdG8gY2FuY2VsIHdlYmtpdC1wYXRjaCBvciBvdGhlciBweXRob24gdG9vbHMgY2F1c2Vz CisgICAgICAgIHVucGxlYXNhbnQgdHJhY2ViYWNrIGNvbnNvbGUgc3BldworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTM0NjIKKworICAgICAgICBDYXRj aCB0aGUgZXhjZXB0aW9uIGFuZCBkb24ndCBwcmludCB0aGUgc3RhY2sgdHJhY2UuCisKKyAgICAg ICAgKiBTY3JpcHRzL3dlYmtpdC1wYXRjaDoKKwogMjAxMS0wMi0wMSAgQmFsYXpzIEtlbGVtZW4g IDxrYmFsYXpzQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW5kcmVhcyBLbGlu Zy4KSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0LXBhdGNoCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xz L1NjcmlwdHMvd2Via2l0LXBhdGNoCShyZXZpc2lvbiA3NzI2MikKKysrIFRvb2xzL1NjcmlwdHMv d2Via2l0LXBhdGNoCSh3b3JraW5nIGNvcHkpCkBAIC0zMyw2ICszMyw3IEBACiAKIGltcG9ydCBs b2dnaW5nCiBpbXBvcnQgb3MKK2ltcG9ydCBzaWduYWwKIGltcG9ydCBzeXMKIAogZnJvbSB3ZWJr aXRweS5jb21tb24uc3lzdGVtLmxvZ3V0aWxzIGltcG9ydCBjb25maWd1cmVfbG9nZ2luZwpAQCAt NjYsNSArNjcsNyBAQCBkZWYgbWFpbigpOgogCiAKIGlmIF9fbmFtZV9fID09ICJfX21haW5fXyI6 Ci0KLSAgICBtYWluKCkKKyAgICB0cnk6CisgICAgICAgIG1haW4oKQorICAgIGV4Y2VwdCBLZXli b2FyZEludGVycnVwdDoKKyAgICAgICAgc3lzLmV4aXQoc2lnbmFsLlNJR0lOVCArIDEyOCkK