53452 2011-01-31 14:20:32 -0800 Improve audio latency on Mac OS X for chromium port 2011-01-31 14:59:01 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 0 crogers webkit-unassigned jorlow oldest_to_newest 342809 0 crogers 2011-01-31 14:20:32 -0800 Improve audio latency on Mac OS X for chromium port 342811 1 80679 crogers 2011-01-31 14:22:42 -0800 Created attachment 80679 Patch 342824 2 80679 jorlow 2011-01-31 14:41:29 -0800 Comment on attachment 80679 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=80679&action=review r=me > Source/WebKit/chromium/src/AudioDestinationChromium.cpp:45 > +// Chromium audio backend now supports lower latency CoreAudio API so a lower buffer size is possible. This sentence doesn't seem quite grammatically right. 342832 3 crogers 2011-01-31 14:54:52 -0800 Thanks, Jeremy. I'll land with a (hopefully) better comment. 342835 4 crogers 2011-01-31 14:59:01 -0800 Committed r77162: <http://trac.webkit.org/changeset/77162> 80679 2011-01-31 14:22:42 -0800 2011-01-31 14:41:29 -0800 Patch bug-53452-20110131142241.patch text/plain 1495 crogers SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA3NzE1OCkKKysrIFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTEtMDEtMzEgIENocmlzIFJvZ2VycyAgPGNyb2dlcnNAZ29vZ2xlLmNvbT4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbXByb3ZlIGF1ZGlv IGxhdGVuY3kgb24gTWFjIE9TIFggZm9yIGNocm9taXVtIHBvcnQKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUzNDUyCisKKyAgICAgICAgKiBzcmMvQXVk aW9EZXN0aW5hdGlvbkNocm9taXVtLmNwcDoKKwogMjAxMS0wMS0yOSAgUGF0cmljayBHYW5zdGVy ZXIgIDxwYXJvZ2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXZpZCBLaWx6 ZXIuCkluZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9BdWRpb0Rlc3RpbmF0aW9uQ2hy b21pdW0uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0F1ZGlv RGVzdGluYXRpb25DaHJvbWl1bS5jcHAJKHJldmlzaW9uIDc3MTU4KQorKysgU291cmNlL1dlYktp dC9jaHJvbWl1bS9zcmMvQXVkaW9EZXN0aW5hdGlvbkNocm9taXVtLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtNDEsMTAgKzQxLDE1IEBAIHVzaW5nIG5hbWVzcGFjZSBXZWJLaXQ7CiBuYW1lc3BhY2Ug V2ViQ29yZSB7CiAKIC8vIEJ1ZmZlciBzaXplIHRoYXQgdGhlIENocm9taXVtIGF1ZGlvIHN5c3Rl bSB3aWxsIGNhbGwgdXMgYmFjayB3aXRoLgorI2lmIE9TKERBUldJTikKKy8vIENocm9taXVtIGF1 ZGlvIGJhY2tlbmQgbm93IHN1cHBvcnRzIGxvd2VyIGxhdGVuY3kgQ29yZUF1ZGlvIEFQSSBzbyBh IGxvd2VyIGJ1ZmZlciBzaXplIGlzIHBvc3NpYmxlLgorY29uc3QgdW5zaWduZWQgY2FsbGJhY2tC dWZmZXJTaXplID0gMTI4OworI2Vsc2UKIC8vIFRoaXMgdmFsdWUgbWF5IG5lZWQgdG8gYmUgdHVu ZWQgYmFzZWQgb24gdGhlIE9TLgogLy8gRklYTUU6IEl0IG1heSBiZSBwb3NzaWJsZSB0byByZWR1 Y2UgdGhpcyB2YWx1ZSBvbmNlIHJlYWwtdGltZSB0aHJlYWRzCiAvLyBhbmQgb3RoZXIgQ2hyb21p dW0gYXVkaW8gaW1wcm92ZW1lbnRzIGFyZSBtYWRlLgogY29uc3QgdW5zaWduZWQgY2FsbGJhY2tC dWZmZXJTaXplID0gMjA0ODsKKyNlbmRpZgogCiAvLyBCdWZmZXIgc2l6ZSBhdCB3aGljaCB0aGUg d2ViIGF1ZGlvIGVuZ2luZSB3aWxsIHJlbmRlci4KIGNvbnN0IHVuc2lnbmVkIHJlbmRlckJ1ZmZl clNpemUgPSAxMjg7Cg==