53440 2011-01-31 11:12:07 -0800 Allow access if security origin access is asked for is the same to the this 2011-02-01 12:27:20 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 antonm antonm abarth commit-queue sam oldest_to_newest 342690 0 antonm 2011-01-31 11:12:07 -0800 Allow access if security origin access is asked for is the same to the this 342697 1 80664 antonm 2011-01-31 11:22:32 -0800 Created attachment 80664 Patch 342701 2 80664 abarth 2011-01-31 11:24:49 -0800 Comment on attachment 80664 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=80664&action=review > Source/WebCore/ChangeLog:5 > + Allow access if security origin access is asked for is the same to the this "is the same to the this" => "is the same as this" ? > Source/WebCore/ChangeLog:8 > + Covered by the existing tests. How is this covered by existing tests if none of the tests changed as a result of this patch? 342706 3 antonm 2011-01-31 11:29:01 -0800 (In reply to comment #2) > (From update of attachment 80664 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=80664&action=review > > > Source/WebCore/ChangeLog:5 > > + Allow access if security origin access is asked for is the same to the this > > "is the same to the this" > => "is the same as this" ? Done. > > > Source/WebCore/ChangeLog:8 > > + Covered by the existing tests. > > How is this covered by existing tests if none of the tests changed as a result of this patch? I mean that nothing started to break with this change. Does that make sense? If not, may you suggest how I can reword this phrase? And I am afraid it'd be pretty much difficult to write a test which will trigger this path right now. 342713 4 abarth 2011-01-31 11:33:39 -0800 Yeah, I don't think it's possible to trigger that branch now. We should just say that in the ChangeLog. To give folks reading this bug more context, Anton and I have been discussing adding some defense-in-depth security checks at various points in the bindings. Those points have SecurityOrigin objects, but not necessarily DOMWindow objects. Currently, the "you can always access yourself" check is done by comparing DOMWindows. Adding this branch here is redundant today, but won't be redundant in the future once we add these extra checks. 342733 5 80669 antonm 2011-01-31 12:15:17 -0800 Created attachment 80669 Patch 342734 6 antonm 2011-01-31 12:15:54 -0800 Adam, may you have another look? (In reply to comment #5) > Created an attachment (id=80669) [details] > Patch 342762 7 sam 2011-01-31 12:47:05 -0800 (In reply to comment #4) > Yeah, I don't think it's possible to trigger that branch now. We should just say that in the ChangeLog. > > To give folks reading this bug more context, Anton and I have been discussing adding some defense-in-depth security checks at various points in the bindings. Those points have SecurityOrigin objects, but not necessarily DOMWindow objects. Currently, the "you can always access yourself" check is done by comparing DOMWindows. Adding this branch here is redundant today, but won't be redundant in the future once we add these extra checks. Can we remove some of the DOMWindow comparing to themselves checks then? 342803 8 abarth 2011-01-31 14:02:02 -0800 > Can we remove some of the DOMWindow comparing to themselves checks then? That's a good idea. We should be able to remove them after/in this patch. 343141 9 antonm 2011-02-01 04:39:42 -0800 Guys, if you're fine with this patch, may I ask you to r+ it? (In reply to comment #8) > > Can we remove some of the DOMWindow comparing to themselves checks then? > > That's a good idea. We should be able to remove them after/in this patch. 343375 10 80669 abarth 2011-02-01 11:28:16 -0800 Comment on attachment 80669 Patch Sure. I think a followup patch to remove the DOMWindow equality comparison might be worth doing too. 343380 11 80669 antonm 2011-02-01 11:34:35 -0800 Comment on attachment 80669 Patch Thanks a lot, Adam. I'll try to do further cleanup with a separate patch. 343416 12 80669 commit-queue 2011-02-01 12:27:13 -0800 Comment on attachment 80669 Patch Clearing flags on attachment: 80669 Committed r77272: <http://trac.webkit.org/changeset/77272> 343417 13 commit-queue 2011-02-01 12:27:20 -0800 All reviewed patches have been landed. Closing bug. 80664 2011-01-31 11:22:32 -0800 2011-01-31 12:15:12 -0800 Patch bug-53440-20110131222230.patch text/plain 1253 antonm ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAyMDk4MmI1NzE0NmZiNzY5MjlkMmVjYWVkY2VhMWRmODRmNTJlYWIxLi5m Y2M5ODdkNmY1YzA5NDk1ZmQxOGJhM2JlOTIxOGQzYzdhMzlkODdmIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTUgQEAKKzIwMTEtMDEtMzEgIEFudG9uIE11aGluICA8YW50b25tQGNocm9taXVtLm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBbGxv dyBhY2Nlc3MgaWYgc2VjdXJpdHkgb3JpZ2luIGFjY2VzcyBpcyBhc2tlZCBmb3IgaXMgdGhlIHNh bWUgdG8gdGhlIHRoaXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTUzNDQwCisKKyAgICAgICAgQ292ZXJlZCBieSB0aGUgZXhpc3RpbmcgdGVzdHMuCisK KyAgICAgICAgKiBwYWdlL1NlY3VyaXR5T3JpZ2luLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNl Y3VyaXR5T3JpZ2luOjpjYW5BY2Nlc3MpOiBhbGxvdyBhY2Nlc3MgaWYgdGhpcyA9PSBvdGhlcgor CiAyMDExLTAxLTMxICBTaGFuZSBTdGVwaGVucyAgPHNoYW5lc3RlcGhlbnNAZ29vZ2xlLmNvbT4K IAogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBGcmFzZXIuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wYWdlL1NlY3VyaXR5T3JpZ2luLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvU2Vj dXJpdHlPcmlnaW4uY3BwCmluZGV4IDc4OWZkZjkzOTMyNzJjMmZlZjJiZDVlYmM2YThiZmE4ZGY4 ZGIzMDMuLmM3NTA1ZjNmNGU1YzIzMmUxMzQ5NjhkYmRiMGM4NTU3ZTAyMzI1MDIgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvU2VjdXJpdHlPcmlnaW4uY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BhZ2UvU2VjdXJpdHlPcmlnaW4uY3BwCkBAIC0xNzgsNiArMTc4LDkgQEAgYm9vbCBT ZWN1cml0eU9yaWdpbjo6Y2FuQWNjZXNzKGNvbnN0IFNlY3VyaXR5T3JpZ2luKiBvdGhlcikgY29u c3QKICAgICBpZiAobV91bml2ZXJzYWxBY2Nlc3MpCiAgICAgICAgIHJldHVybiB0cnVlOwogCisg ICAgaWYgKHRoaXMgPT0gb3RoZXIpCisgICAgICAgIHJldHVybiB0cnVlOworCiAgICAgaWYgKGlz VW5pcXVlKCkgfHwgb3RoZXItPmlzVW5pcXVlKCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAo= 80669 2011-01-31 12:15:17 -0800 2011-02-01 12:27:13 -0800 Patch bug-53440-20110131231515.patch text/plain 1250 antonm ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAyMDk4MmI1NzE0NmZiNzY5MjlkMmVjYWVkY2VhMWRmODRmNTJlYWIxLi5i ZGE2ZDFjODIxYmVhYjIyMDM2OWU4NjU0MmJkMjgxZjVhMTUxOTJjIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTUgQEAKKzIwMTEtMDEtMzEgIEFudG9uIE11aGluICA8YW50b25tQGNocm9taXVtLm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBbGxv dyBhY2Nlc3MgZm9yIHNlY3VyaXR5IG9yaWdpbiBzYW1lIGFzIHRoaXMuCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MzQ0MAorCisgICAgICAgIEhhcmQg dG8gdGVzdCBhcyBuZXdseSBhZGRlZCBwYXRoIGN1cnJlbnRseSBpcyBuZXZlciBoaXQuCisKKyAg ICAgICAgKiBwYWdlL1NlY3VyaXR5T3JpZ2luLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNlY3Vy aXR5T3JpZ2luOjpjYW5BY2Nlc3MpOiBhbGxvdyBhY2Nlc3MgaWYgdGhpcyA9PSBvdGhlcgorCiAy MDExLTAxLTMxICBTaGFuZSBTdGVwaGVucyAgPHNoYW5lc3RlcGhlbnNAZ29vZ2xlLmNvbT4KIAog ICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBGcmFzZXIuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wYWdlL1NlY3VyaXR5T3JpZ2luLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvU2VjdXJp dHlPcmlnaW4uY3BwCmluZGV4IDc4OWZkZjkzOTMyNzJjMmZlZjJiZDVlYmM2YThiZmE4ZGY4ZGIz MDMuLmM3NTA1ZjNmNGU1YzIzMmUxMzQ5NjhkYmRiMGM4NTU3ZTAyMzI1MDIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BhZ2UvU2VjdXJpdHlPcmlnaW4uY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BhZ2UvU2VjdXJpdHlPcmlnaW4uY3BwCkBAIC0xNzgsNiArMTc4LDkgQEAgYm9vbCBTZWN1 cml0eU9yaWdpbjo6Y2FuQWNjZXNzKGNvbnN0IFNlY3VyaXR5T3JpZ2luKiBvdGhlcikgY29uc3QK ICAgICBpZiAobV91bml2ZXJzYWxBY2Nlc3MpCiAgICAgICAgIHJldHVybiB0cnVlOwogCisgICAg aWYgKHRoaXMgPT0gb3RoZXIpCisgICAgICAgIHJldHVybiB0cnVlOworCiAgICAgaWYgKGlzVW5p cXVlKCkgfHwgb3RoZXItPmlzVW5pcXVlKCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAo=