53420 2011-01-31 05:49:11 -0800 [Qt] PluginViewQt.cpp not compiling with ENABLE_NETSCAPE_PLUGIN_API=1 2011-03-01 15:26:15 -0800 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) PC Linux RESOLVED WORKSFORME Qt, QtTriaged P3 Normal --- 36702 0 romaxa webkit-unassigned benjamin robert oldest_to_newest 342542 0 romaxa 2011-01-31 05:49:11 -0800 Attempt to compile Webkit2 Qt with plugins enabled, it fails: ../../../WebCore/plugins/qt/PluginViewQt.cpp:69:24: error: qwebpage_p.h: No such file or directory ../../../WebCore/plugins/qt/PluginViewQt.cpp: In member function 'void WebCore::PluginView::updatePluginWidget()': ../../../WebCore/plugins/qt/PluginViewQt.cpp:167: error: 'QWebPagePrivate' has not been declared ../../../WebCore/plugins/qt/PluginViewQt.cpp: In function 'void WebCore::setXKeyEventSpecificFields(XEvent*, WebCore::KeyboardEvent*)': ../../../WebCore/plugins/qt/PluginViewQt.cpp:422: error: 'QWebPagePrivate' has not been declared Sounds like it is not very good idea to use WebKit API's from WebCore module. Change has been introduced in http://trac.webkit.org/changeset/61505 https://bugs.webkit.org/show_bug.cgi?id=36702 342543 1 romaxa 2011-01-31 05:55:23 -0800 Simon suggested to move "drtRun" into WebCore... but I'm not sure, because all other ports are doing exactly the same checks as Qt port, but not drtRun check. Interesting if bug 36702 was reproducible on Qt port only or on other platform also.. 342725 2 80668 romaxa 2011-01-31 11:58:26 -0800 Created attachment 80668 Fix Qt Plugins compilation Not, sure if we can do that, but would be nice to know why it is needed in Qt port, and not in other ports like Gtk... 342730 3 robert 2011-01-31 12:09:52 -0800 (In reply to comment #2) > Created an attachment (id=80668) [details] > Fix Qt Plugins compilation > > Not, sure if we can do that, but would be nice to know why it is needed in Qt port, and not in other ports like Gtk... // (ii) if we are running layout tests from DRT, paint() won't ever get called // so we need to call setNPWindowIfNeeded() if window geometry has changed if (!m_windowRect.intersects(frameView->frameRect()) || (QWebPagePrivate::drtRun && platformPluginWidget() && (m_windowRect != oldWindowRect || m_clipRect != oldClipRect))) setNPWindowIfNeeded(); I believe Qt layout tests are run headless, Gtk tests are not. 343088 4 80668 romaxa 2011-02-01 01:53:35 -0800 Comment on attachment 80668 Fix Qt Plugins compilation Fail to apply 360302 5 romaxa 2011-03-01 15:26:15 -0800 Problem is not reproducible on webkit trunk 80668 2011-01-31 11:58:26 -0800 2011-02-01 01:53:52 -0800 Fix Qt Plugins compilation try_it.diff text/plain 1856 romaxa RnJvbSA3ODViN2JhYmJkM2QyYmZmNTBhZTdmMzllN2I2YzI3ZGYzNDhkNDYzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBPbGVnIFJvbWFzaGluIDxvbGVnLnJvbWFzaGluQG5va2lhLmNv bT4KRGF0ZTogTW9uLCAzMSBKYW4gMjAxMSAyMTo0OToxNiArMDIwMApTdWJqZWN0OiBbUEFUQ0hd IEF0dGVtcHQgdG8gd3IgZml4IGJ1ZyA1MzQyMAoKLS0tCiBXZWJDb3JlL3BsdWdpbnMvcXQvUGx1 Z2luVmlld1F0LmNwcCB8ICAgIDUgKystLS0KIDEgZmlsZXMgY2hhbmdlZCwgMiBpbnNlcnRpb25z KCspLCAzIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGx1Z2lucy9xdC9QbHVn aW5WaWV3UXQuY3BwIGIvV2ViQ29yZS9wbHVnaW5zL3F0L1BsdWdpblZpZXdRdC5jcHAKaW5kZXgg ZmRiZTU1Mi4uYTY1M2IzOSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbHVnaW5zL3F0L1BsdWdpblZp ZXdRdC5jcHAKKysrIGIvV2ViQ29yZS9wbHVnaW5zL3F0L1BsdWdpblZpZXdRdC5jcHAKQEAgLTY2 LDcgKzY2LDYgQEAKICNpbmNsdWRlICJTY3JpcHRDb250cm9sbGVyLmgiCiAjaW5jbHVkZSAiU2V0 dGluZ3MuaCIKICNpbmNsdWRlICJucHJ1bnRpbWVfaW1wbC5oIgotI2luY2x1ZGUgInF3ZWJwYWdl X3AuaCIKICNpbmNsdWRlICJydW50aW1lX3Jvb3QuaCIKIAogI2luY2x1ZGUgPFFBcHBsaWNhdGlv bj4KQEAgLTE2NCw3ICsxNjMsNyBAQCB2b2lkIFBsdWdpblZpZXc6OnVwZGF0ZVBsdWdpbldpZGdl dCgpCiAgICAgLy8gKGlpKSBpZiB3ZSBhcmUgcnVubmluZyBsYXlvdXQgdGVzdHMgZnJvbSBEUlQs IHBhaW50KCkgd29uJ3QgZXZlciBnZXQgY2FsbGVkCiAgICAgLy8gc28gd2UgbmVlZCB0byBjYWxs IHNldE5QV2luZG93SWZOZWVkZWQoKSBpZiB3aW5kb3cgZ2VvbWV0cnkgaGFzIGNoYW5nZWQKICAg ICBpZiAoIW1fd2luZG93UmVjdC5pbnRlcnNlY3RzKGZyYW1lVmlldy0+ZnJhbWVSZWN0KCkpCi0g ICAgICAgIHx8IChRV2ViUGFnZVByaXZhdGU6OmRydFJ1biAmJiBwbGF0Zm9ybVBsdWdpbldpZGdl dCgpICYmIChtX3dpbmRvd1JlY3QgIT0gb2xkV2luZG93UmVjdCB8fCBtX2NsaXBSZWN0ICE9IG9s ZENsaXBSZWN0KSkpCisgICAgICAgIHx8IChwbGF0Zm9ybVBsdWdpbldpZGdldCgpICYmIChtX3dp bmRvd1JlY3QgIT0gb2xkV2luZG93UmVjdCB8fCBtX2NsaXBSZWN0ICE9IG9sZENsaXBSZWN0KSkp CiAgICAgICAgIHNldE5QV2luZG93SWZOZWVkZWQoKTsKIAogICAgIGlmICghbV9wbGF0Zm9ybUxh eWVyKSB7CkBAIC00MTksNyArNDE4LDcgQEAgdm9pZCBzZXRYS2V5RXZlbnRTcGVjaWZpY0ZpZWxk cyhYRXZlbnQqIHhFdmVudCwgS2V5Ym9hcmRFdmVudCogZXZlbnQpCiAgICAgLy8gV2UgbWF5IG5v dCBoYXZlIGEgbmF0aXZlU2NhbkNvZGUoKSBpZiB0aGUga2V5IGV2ZW50IGlzIGZyb20gRFJUJ3Mg ZXZlbnRzZW5kZXIuIEluIHRoYXQKICAgICAvLyBjYXNlIGp1c3QgcG9wdWxhdGUgdGhlIFhFdmVu dCdzIGtleWNvZGUgd2l0aCB0aGUgUXQgcGxhdGZvcm0taW5kZXBlbmRlbnQga2V5Y29kZS4gVGhl IG9ubHkKICAgICAvLyBwbGFjZSB0aGlzIGtleWNvZGUgd2lsbCBiZSB1c2VkIGlzIGluIHdlYmtp dF90ZXN0X3BsdWdpbl9oYW5kbGVfZXZlbnQoKS4KLSAgICBpZiAoUVdlYlBhZ2VQcml2YXRlOjpk cnRSdW4gJiYgIXhFdmVudC0+eGtleS5rZXljb2RlKSB7CisgICAgaWYgKCF4RXZlbnQtPnhrZXku a2V5Y29kZSkgewogICAgICAgICBRS2V5RXZlbnQqIHFLZXlFdmVudCA9IGtleUV2ZW50LT5xdEV2 ZW50KCk7CiAgICAgICAgIEFTU0VSVChxS2V5RXZlbnQpOwogICAgICAgICBpZiAoIXFLZXlFdmVu dC0+dGV4dCgpLmlzRW1wdHkoKSkKLS0gCjEuNi4xCgo=