53402 2011-01-30 12:58:01 -0800 Add sanity check to help diagnose bug 52819 2011-01-31 20:04:33 -0800 1 1 1 Unclassified WebKit History 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 52819 0 creis webkit-unassigned commit-queue mihaip oldest_to_newest 342360 0 creis 2011-01-30 12:58:01 -0800 We're seeing many crash reports for bug 52819 in HistoryController::itemsAreClones. The crashes happen when fromItem in recursiveSetProvisionalItem is null, which happens if the parent HistoryItem does not have a child item with the target frame name. The crash reports suggest that fromItem has 0 children, which should be impossible. (The previous call to itemsAreClones should verify that fromItem and item have the same number of children, and item clearly has children.) On the flip side, it's possible for the crash to happen if fromItem has ended up with two children of the same name, though the crash reports don't seen to be consistent with that. This bug is for adding a sanity check to help diagnose which (if either) of these is happening in practice, since we don't have any information about how to reproduce the crash yet. 342363 1 80599 creis 2011-01-30 13:05:12 -0800 Created attachment 80599 Patch 342985 2 80599 commit-queue 2011-01-31 20:04:29 -0800 Comment on attachment 80599 Patch Clearing flags on attachment: 80599 Committed r77210: <http://trac.webkit.org/changeset/77210> 342986 3 commit-queue 2011-01-31 20:04:33 -0800 All reviewed patches have been landed. Closing bug. 80599 2011-01-30 13:05:12 -0800 2011-01-31 20:04:29 -0800 Patch bug-53402-20110130130511.patch text/plain 1697 creis SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc2NTc4KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDEtMzAgIENoYXJsaWUg UmVpcyAgPGNyZWlzQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBBZGQgc2FuaXR5IGNoZWNrIHRvIGhlbHAgZGlhZ25vc2UgYnVn IDUyODE5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01 MzQwMgorCisgICAgICAgIENyYXNoIGVhcmx5IGlmIHRoZSBjaGlsZHJlbiBvZiBmcm9tSXRlbSBs b29rIGludmFsaWQuCisKKyAgICAgICAgKiBsb2FkZXIvSGlzdG9yeUNvbnRyb2xsZXIuY3BwOgor CiAyMDExLTAxLTI1ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4K IAogICAgICAgICBSZXZpZXdlZCBieSBNYXJ0aW4gUm9iaW5zb24uCkluZGV4OiBTb3VyY2UvV2Vi Q29yZS9sb2FkZXIvSGlzdG9yeUNvbnRyb2xsZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL2xvYWRlci9IaXN0b3J5Q29udHJvbGxlci5jcHAJKHJldmlzaW9uIDc2NTc4KQorKysg U291cmNlL1dlYkNvcmUvbG9hZGVyL0hpc3RvcnlDb250cm9sbGVyLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtNjIwLDYgKzYyMCwxOCBAQCB2b2lkIEhpc3RvcnlDb250cm9sbGVyOjpyZWN1cnNpdmVT ZXRQcm92CiAgICAgICAgIGNvbnN0IEhpc3RvcnlJdGVtVmVjdG9yJiBjaGlsZEl0ZW1zID0gaXRl bS0+Y2hpbGRyZW4oKTsKIAogICAgICAgICBpbnQgc2l6ZSA9IGNoaWxkSXRlbXMuc2l6ZSgpOwor CisgICAgICAgIC8vIFNhbml0eSBjaGVja3MgZm9yIGh0dHA6Ly93ZWJraXQub3JnL2IvNTI4MTku CisgICAgICAgIGlmIChzaXplID4gMCkgeworICAgICAgICAgICAgLy8gZnJvbUl0ZW0gc2hvdWxk IGhhdmUgc2FtZSBudW1iZXIgb2YgY2hpbGRyZW4gYWNjb3JkaW5nIHRvIGhhc1NhbWVGcmFtZXMs CisgICAgICAgICAgICAvLyBidXQgY3Jhc2ggZHVtcHMgc3VnZ2VzdCBpdCBtaWdodCBoYXZlIDAu CisgICAgICAgICAgICBpZiAoIWZyb21JdGVtLT5jaGlsZHJlbigpLnNpemUoKSkKKyAgICAgICAg ICAgICAgICBDUkFTSCgpOworICAgICAgICAgICAgLy8gaXRlbXNBcmVDbG9uZXMgY2hlY2tlZCBm cm9tSXRlbS0+aGFzU2FtZUZyYW1lcyhpdGVtKS4gQ2hlY2sgdmljZSB2ZXJzYS4KKyAgICAgICAg ICAgIGlmICghaXRlbS0+aGFzU2FtZUZyYW1lcyhmcm9tSXRlbSkpCisgICAgICAgICAgICAgICAg Q1JBU0goKTsKKyAgICAgICAgfQorCiAgICAgICAgIGZvciAoaW50IGkgPSAwOyBpIDwgc2l6ZTsg KytpKSB7CiAgICAgICAgICAgICBTdHJpbmcgY2hpbGRGcmFtZU5hbWUgPSBjaGlsZEl0ZW1zW2ld LT50YXJnZXQoKTsKICAgICAgICAgICAgIEhpc3RvcnlJdGVtKiBmcm9tQ2hpbGRJdGVtID0gZnJv bUl0ZW0tPmNoaWxkSXRlbVdpdGhUYXJnZXQoY2hpbGRGcmFtZU5hbWUpOwo=