53399 2011-01-30 09:54:35 -0800 FindController::updateFindIndicator() crashes if selection isn't visible 2011-01-31 07:28:12 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P1 Critical --- 1 jeffm jeffm commit-queue sfalken oldest_to_newest 342331 0 jeffm 2011-01-30 09:54:35 -0800 1. Goto www.google.com in Safari. 2. Type Ctrl+F to bring up find in page. 3. Search for "goo". This results in 3 matches, only 2 of which are visible. 4. Hit F3, F3, F3 to go to the third, invisible match. 5. WebKit process crashes. 342332 1 80595 jeffm 2011-01-30 10:11:01 -0800 Created attachment 80595 Patch 342333 2 80595 mitz 2011-01-30 10:15:54 -0800 Comment on attachment 80595 Patch Is there a way to make an API test for this? 342337 3 jeffm 2011-01-30 10:34:33 -0800 It seems like this should be possible with some changes to Tools/TestWebKitAPI/Tests/WebKit2/Find.cpp and Find.html, I'll look into this. 342353 4 80595 commit-queue 2011-01-30 12:04:54 -0800 Comment on attachment 80595 Patch Clearing flags on attachment: 80595 Committed r77091: <http://trac.webkit.org/changeset/77091> 342354 5 commit-queue 2011-01-30 12:04:58 -0800 All reviewed patches have been landed. Closing bug. 342374 6 sfalken 2011-01-30 14:00:54 -0800 Ignore my r+ looks like this was already fixed. 80595 2011-01-30 10:11:01 -0800 2011-01-31 07:28:12 -0800 Patch bug-53399-20110130101049.patch text/plain 1559 jeffm SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDc3MDg4KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDEtMzAgIEplZmYgTWls bGVyICA8amVmZm1AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEZpbmRDb250cm9sbGVyOjp1cGRhdGVGaW5kSW5kaWNhdG9yKCkgY3Jh c2hlcyBpZiBzZWxlY3Rpb24gaXNuJ3QgdmlzaWJsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTMzOTkKKworICAgICAgICAqIFdlYlByb2Nlc3MvV2Vi UGFnZS9GaW5kQ29udHJvbGxlci5jcHA6CisgICAgICAgIChXZWJLaXQ6OkZpbmRDb250cm9sbGVy Ojp1cGRhdGVGaW5kSW5kaWNhdG9yKTogUmV0dXJuIGZhbHNlIGlmIFNoYXJlYWJsZUJpdG1hcDo6 Y3JlYXRlU2hhcmVhYmxlKCkgcmV0dXJucyBudWxsICh0eXBpY2FsbHkgYmVjYXVzZSB0aGUgc2Vs ZWN0aW9uIHJlY3QgaXMgZW1wdHkpLgorCiAyMDExLTAxLTMwICBDc2FiYSBPc3p0cm9nb27DoWMg IDxvc3N5QHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZC4KSW5kZXg6IFNvdXJjZS9X ZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9GaW5kQ29udHJvbGxlci5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0ZpbmRDb250cm9sbGVyLmNwcAko cmV2aXNpb24gNzcwODgpCisrKyBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvRmlu ZENvbnRyb2xsZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNjAsNiArMTYwLDkgQEAgYm9vbCBG aW5kQ29udHJvbGxlcjo6dXBkYXRlRmluZEluZGljYXRvcgogCiAgICAgLy8gQ3JlYXRlIGEgYmFj a2luZyBzdG9yZSBhbmQgcGFpbnQgdGhlIGZpbmQgaW5kaWNhdG9yIHRleHQgaW50byBpdC4KICAg ICBSZWZQdHI8U2hhcmVhYmxlQml0bWFwPiBmaW5kSW5kaWNhdG9yVGV4dEJhY2tpbmdTdG9yZSA9 IFNoYXJlYWJsZUJpdG1hcDo6Y3JlYXRlU2hhcmVhYmxlKHNlbGVjdGlvblJlY3RJbldpbmRvd0Nv b3JkaW5hdGVzLnNpemUoKSk7CisgICAgaWYgKCFmaW5kSW5kaWNhdG9yVGV4dEJhY2tpbmdTdG9y ZSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIAogICAgIE93blB0cjxHcmFwaGljc0NvbnRl eHQ+IGdyYXBoaWNzQ29udGV4dCA9IGZpbmRJbmRpY2F0b3JUZXh0QmFja2luZ1N0b3JlLT5jcmVh dGVHcmFwaGljc0NvbnRleHQoKTsKIAogICAgIGdyYXBoaWNzQ29udGV4dC0+dHJhbnNsYXRlKC1z ZWxlY3Rpb25SZWN0SW5XaW5kb3dDb29yZGluYXRlcy54KCksIC1zZWxlY3Rpb25SZWN0SW5XaW5k b3dDb29yZGluYXRlcy55KCkpOwo=