53397 2011-01-30 08:49:45 -0800 Web Inspector: speed up network panel rendering. 2011-01-31 06:45:15 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 pfeldman webkit-unassigned apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 342304 0 pfeldman 2011-01-30 08:49:45 -0800 Network panel is recalculating styles for ages. Open standalone front-end and execute for (var i = 0; i < 1000; ++i) WebInspector.networkManager._dispatcher.didLoadResourceFromMemoryCache(new Date().getTime(), {url:"foo", response: {}, loader: { url: "foo" }}); in the console. It'll fill network panel with 1K entries. Now try switching to/from panel. Also try showing resource content and closing it. You will see 600ms delay upon panel switch and 2s delay upon resource content close. We need to split content using iframes, but this is a long road. This patch will improve things a lot in the short term. 342305 1 80591 pfeldman 2011-01-30 08:52:31 -0800 Created attachment 80591 Patch 342341 2 80591 timothy 2011-01-30 10:47:24 -0800 Comment on attachment 80591 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=80591&action=review > Source/WebCore/inspector/front-end/NetworkPanel.js:1032 > + _onScroll: function(e) I prefer "_didScroll" or "_updateOffscreenRows" over the generic "onScroll". 342554 3 pfeldman 2011-01-31 06:45:15 -0800 Committed r77127: <http://trac.webkit.org/changeset/77127> 80591 2011-01-30 08:52:31 -0800 2011-01-30 10:47:23 -0800 Patch bug-53397-20110130195227.patch text/plain 4961 pfeldman ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA2MzEzN2Y2YTBmNzk3MDQ5NTBhODdjMjQ3NmI1NzhhOWI4YWQ5YmU0Li5k YWMzY2E5YjM3OTUxZDIxMmZlNmNkMDkzYjJkODlkZDQ3YTZmMmQ0IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMjMgQEAKKzIwMTEtMDEtMzAgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg V2ViIEluc3BlY3Rvcjogc3BlZWQgdXAgbmV0d29yayBwYW5lbCByZW5kZXJpbmcuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MzM5NworCisgICAgICAg ICogaW5zcGVjdG9yL2Zyb250LWVuZC9EYXRhR3JpZC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rv ci5EYXRhR3JpZC5wcm90b3R5cGUuZ2V0IHNjcm9sbENvbnRhaW5lcik6CisgICAgICAgICogaW5z cGVjdG9yL2Zyb250LWVuZC9OZXR3b3JrUGFuZWwuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3Iu TmV0d29ya1BhbmVsLnByb3RvdHlwZS5lbGVtZW50c1RvUmVzdG9yZVNjcm9sbFBvc2l0aW9uc0Zv cik6CisgICAgICAgIChXZWJJbnNwZWN0b3IuTmV0d29ya1BhbmVsLnByb3RvdHlwZS5fcG9zaXRp b25TdW1tYXJ5QmFyKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5OZXR3b3JrUGFuZWwucHJvdG90 eXBlLl9jcmVhdGVUYWJsZSk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuTmV0d29ya1BhbmVsLnBy b3RvdHlwZS5fZXhwb3J0UmVzb3VyY2UpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLk5ldHdvcmtQ YW5lbC5wcm90b3R5cGUuX29uU2Nyb2xsKToKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5k L25ldHdvcmtQYW5lbC5jc3M6CisgICAgICAgICgubmV0d29yay1zaWRlYmFyIC5kYXRhLWdyaWQu c21hbGwgdHIub2Zmc2NyZWVuKToKKyAgICAgICAgKC5uZXR3b3JrLXNpZGViYXIgLmRhdGEtZ3Jp ZCB0ci5vZmZzY3JlZW4pOgorICAgICAgICAoLm5ldHdvcmstc2lkZWJhciAuZGF0YS1ncmlkIHRy Lm9mZnNjcmVlbiB0ZCk6CisKIDIwMTEtMDEtMjcgIFBhdmVsIFBvZGl2aWxvdiAgPHBvZGl2aWxv dkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgUGF2ZWwgRmVsZG1hbi4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRGF0YUdyaWQuanMg Yi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0RhdGFHcmlkLmpzCmluZGV4IDU4 MzFkMWU2ZjNlMzRmMDBlMjcyNjkzZTI3ZWViOGJkZjA2OWIzNDYuLjQ1ZjBiNTVhMmYwNjkyMjNk NmI4ZTU3ZjhiMTg3OTc4NzZhZjIyNzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3Bl Y3Rvci9mcm9udC1lbmQvRGF0YUdyaWQuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y L2Zyb250LWVuZC9EYXRhR3JpZC5qcwpAQCAtNDkzLDYgKzQ5MywxMSBAQCBXZWJJbnNwZWN0b3Iu RGF0YUdyaWQucHJvdG90eXBlID0gewogICAgICAgICB0aGlzLl9jb2x1bW5XaWR0aHNJbml0aWFs aXplZCA9IGZhbHNlOwogICAgIH0sCiAKKyAgICBnZXQgc2Nyb2xsQ29udGFpbmVyKCkKKyAgICB7 CisgICAgICAgIHJldHVybiB0aGlzLl9zY3JvbGxDb250YWluZXI7ICAgICAgICAKKyAgICB9LAor CiAgICAgaXNTY3JvbGxlZFRvTGFzdFJvdzogZnVuY3Rpb24oKQogICAgIHsKICAgICAgICAgcmV0 dXJuIHRoaXMuX3Njcm9sbENvbnRhaW5lci5pc1Njcm9sbGVkVG9Cb3R0b20oKTsKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvTmV0d29ya1BhbmVsLmpzIGIv U291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9OZXR3b3JrUGFuZWwuanMKaW5kZXgg OGJmNGNiZWY5MzkwMDllOWNjMDZhZDgzMzZkNThhYmI2ZDk4ZTRkMi4uNzQ3YjY3NTMzMDFjYzZk MmI3MjZlZTg4ODc5NDc5OTY3N2NiNWU0ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5z cGVjdG9yL2Zyb250LWVuZC9OZXR3b3JrUGFuZWwuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5z cGVjdG9yL2Zyb250LWVuZC9OZXR3b3JrUGFuZWwuanMKQEAgLTEwMyw3ICsxMDMsNyBAQCBXZWJJ bnNwZWN0b3IuTmV0d29ya1BhbmVsLnByb3RvdHlwZSA9IHsKIAogICAgIGVsZW1lbnRzVG9SZXN0 b3JlU2Nyb2xsUG9zaXRpb25zRm9yOiBmdW5jdGlvbigpCiAgICAgewotICAgICAgICByZXR1cm4g W3RoaXMuY29udGFpbmVyRWxlbWVudF07CisgICAgICAgIHJldHVybiBbdGhpcy5jb250YWluZXJF bGVtZW50LCB0aGlzLl9kYXRhR3JpZC5zY3JvbGxDb250YWluZXJdOwogICAgIH0sCiAKICAgICBy ZXNpemU6IGZ1bmN0aW9uKCkKQEAgLTE1OCw2ICsxNTgsNyBAQCBXZWJJbnNwZWN0b3IuTmV0d29y a1BhbmVsLnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgIHRoaXMuX2RhdGFHcmlkLmVsZW1lbnQu c3R5bGUuYm90dG9tID0gMDsKICAgICAgICAgICAgIHRoaXMuX3NvcnRJdGVtcygpOwogICAgICAg ICB9CisgICAgICAgIHRoaXMuX29uU2Nyb2xsKCk7CiAgICAgfSwKIAogICAgIF9yZXNldFN1bW1h cnlCYXI6IGZ1bmN0aW9uKCkKQEAgLTIxNCw2ICsyMTUsNyBAQCBXZWJJbnNwZWN0b3IuTmV0d29y a1BhbmVsLnByb3RvdHlwZSA9IHsKICAgICAgICAgdGhpcy5jb250YWluZXJFbGVtZW50LmFwcGVu ZENoaWxkKHRoaXMuX2RhdGFHcmlkLmVsZW1lbnQpOwogICAgICAgICB0aGlzLl9kYXRhR3JpZC5h ZGRFdmVudExpc3RlbmVyKCJzb3J0aW5nIGNoYW5nZWQiLCB0aGlzLl9zb3J0SXRlbXMsIHRoaXMp OwogICAgICAgICB0aGlzLl9kYXRhR3JpZC5hZGRFdmVudExpc3RlbmVyKCJ3aWR0aCBjaGFuZ2Vk IiwgdGhpcy5fdXBkYXRlRGl2aWRlcnNJZk5lZWRlZCwgdGhpcyk7CisgICAgICAgIHRoaXMuX2Rh dGFHcmlkLnNjcm9sbENvbnRhaW5lci5hZGRFdmVudExpc3RlbmVyKCJzY3JvbGwiLCB0aGlzLl9v blNjcm9sbC5iaW5kKHRoaXMpKTsKIAogICAgICAgICB0aGlzLl9wYXRjaFRpbWVsaW5lSGVhZGVy KCk7CiAgICAgfSwKQEAgLTEwMjUsNiArMTAyNywzMiBAQCBXZWJJbnNwZWN0b3IuTmV0d29ya1Bh bmVsLnByb3RvdHlwZSA9IHsKICAgICB7CiAgICAgICAgIHZhciBoYXIgPSAobmV3IFdlYkluc3Bl Y3Rvci5IQVJFbnRyeShyZXNvdXJjZSkpLmJ1aWxkKCk7CiAgICAgICAgIG9mZmVyRmlsZUZvckRv d25sb2FkKEpTT04uc3RyaW5naWZ5KGhhcikpOworICAgIH0sCisKKyAgICBfb25TY3JvbGw6IGZ1 bmN0aW9uKGUpCisgICAgeworICAgICAgICB2YXIgZGF0YVRhYmxlQm9keSA9IHRoaXMuX2RhdGFH cmlkLmRhdGFUYWJsZUJvZHk7CisgICAgICAgIHZhciByb3dzID0gZGF0YVRhYmxlQm9keS5jaGls ZHJlbjsKKyAgICAgICAgdmFyIHJlY29yZHNDb3VudCA9IHJvd3MubGVuZ3RoOworICAgICAgICBp ZiAocmVjb3Jkc0NvdW50IDwgMikKKyAgICAgICAgICAgIHJldHVybjsgIC8vIEZpbGxlciByb3cg b25seS4KKworICAgICAgICB2YXIgdmlzaWJsZVRvcCA9IHRoaXMuX2RhdGFHcmlkLnNjcm9sbENv bnRhaW5lci5zY3JvbGxUb3A7CisgICAgICAgIHZhciB2aXNpYmxlQm90dG9tID0gdmlzaWJsZVRv cCArIHRoaXMuX2RhdGFHcmlkLnNjcm9sbENvbnRhaW5lci5vZmZzZXRIZWlnaHQ7CisKKyAgICAg ICAgdmFyIHJvd0hlaWdodCA9IHJvd3NbMF0ub2Zmc2V0SGVpZ2h0OworCisgICAgICAgIGZvciAo dmFyIGkgPSAwOyBpIDwgcmVjb3Jkc0NvdW50OyArK2kpIHsKKyAgICAgICAgICAgIHZhciByb3cg PSByb3dzW2ldOworICAgICAgICAgICAgdmFyIHJvd0lzVmlzaWJsZSA9IGkgKiByb3dIZWlnaHQg PCB2aXNpYmxlQm90dG9tICYmIChpICsgMSkgKiByb3dIZWlnaHQgPiB2aXNpYmxlVG9wOworICAg ICAgICAgICAgaWYgKHJvd0lzVmlzaWJsZSAhPT0gcm93LnJvd0lzVmlzaWJsZSkgeworICAgICAg ICAgICAgICAgIGlmIChyb3dJc1Zpc2libGUpCisgICAgICAgICAgICAgICAgICAgIHJvdy5yZW1v dmVTdHlsZUNsYXNzKCJvZmZzY3JlZW4iKTsKKyAgICAgICAgICAgICAgICBlbHNlCisgICAgICAg ICAgICAgICAgICAgIHJvdy5hZGRTdHlsZUNsYXNzKCJvZmZzY3JlZW4iKTsKKyAgICAgICAgICAg ICAgICByb3cucm93SXNWaXNpYmxlID0gcm93SXNWaXNpYmxlOworICAgICAgICAgICAgfQorICAg ICAgICB9CiAgICAgfQogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv ZnJvbnQtZW5kL25ldHdvcmtQYW5lbC5jc3MgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL25ldHdvcmtQYW5lbC5jc3MKaW5kZXggOTVlZDFiZjQwZDc2OWZjYzA4YTdkMmRiMDNl YmFlZTRjMWVmYWE1Ni4uYzc1MDMyMzU5MWZjODFlNTNiN2RhYzcxMTYzMzM1MDk2MTFlODI1NiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9uZXR3b3JrUGFu ZWwuY3NzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvbmV0d29ya1Bh bmVsLmNzcwpAQCAtNjUsNiArNjUsMTggQEAKICAgICBmb250LXdlaWdodDogYm9sZDsKIH0KIAor Lm5ldHdvcmstc2lkZWJhciAuZGF0YS1ncmlkLnNtYWxsIHRyLm9mZnNjcmVlbiB7CisgICAgaGVp Z2h0OiAyMXB4OworfQorCisubmV0d29yay1zaWRlYmFyIC5kYXRhLWdyaWQgdHIub2Zmc2NyZWVu IHsKKyAgICBoZWlnaHQ6IDQxcHg7Cit9CisKKy5uZXR3b3JrLXNpZGViYXIgLmRhdGEtZ3JpZCB0 ci5vZmZzY3JlZW4gdGQgeworICAgIGRpc3BsYXk6IG5vbmU7Cit9CisKIC5uZXR3b3JrLXNpZGVi YXIgLmRhdGEtZ3JpZCB0ci5maWxsZXIgewogICAgIGJhY2tncm91bmQtY29sb3I6IHdoaXRlOwog fQo=