53391 2011-01-29 21:37:02 -0800 Switched heap to use the Bitmap class and removed CollectorBitmap 2011-01-29 21:58:40 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ggaren ggaren oldest_to_newest 342193 0 ggaren 2011-01-29 21:37:02 -0800 Switched heap to use the Bitmap class and removed CollectorBitmap 342195 1 80586 ggaren 2011-01-29 21:39:47 -0800 Created attachment 80586 Patch 342196 2 80586 mjs 2011-01-29 21:48:34 -0800 Comment on attachment 80586 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=80586&action=review r=me; see tiny comment though. > Source/JavaScriptCore/wtf/Bitmap.h:79 > +inline bool Bitmap<size>::getset(size_t n) I think testAndSet would be a more conventional name for this operation. 342198 3 ggaren 2011-01-29 21:58:40 -0800 Committed r77080: <http://trac.webkit.org/changeset/77080> 80586 2011-01-29 21:39:47 -0800 2011-01-29 21:48:34 -0800 Patch bug-53391-20110129213946.patch text/plain 5943 ggaren SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gNzcwNzkpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjMgQEAK KzIwMTEtMDEtMjkgIEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTd2l0Y2hlZCBoZWFwIHRv IHVzZSB0aGUgQml0bWFwIGNsYXNzIGFuZCByZW1vdmVkIENvbGxlY3RvckJpdG1hcAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTMzOTEKKworICAgICAg ICAqIHJ1bnRpbWUvTWFya2VkU3BhY2UuY3BwOgorICAgICAgICAoSlNDOjpNYXJrZWRTcGFjZTo6 YWxsb2NhdGUpOiBVcGRhdGVkIGZvciByZW5hbWUgYW5kIHJldHVybmluZyBhIHZhbHVlCisgICAg ICAgIHJhdGhlciB0aGFuIHRha2luZyBhIHZhbHVlIGJ5IHJlZmVyZW5jZS4KKworICAgICAgICAq IHJ1bnRpbWUvTWFya2VkU3BhY2UuaDogQ29kZSByZXVzZSBpcyBnb29kLgorCisgICAgICAgICog d3RmL0JpdG1hcC5oOgorICAgICAgICAoV1RGOjo6OmdldHNldCk6IEFkZGVkLCBzaW5jZSB0aGlz IGlzIHRoZSBvbmUgdGhpbmcgQml0bWFwIHdhcyBtaXNzaW5nCisgICAgICAgIHdoaWNoIENvbGxl Y3RvckJpdG1hcCBoYWQuCisKKyAgICAgICAgKFdURjo6OjpuZXh0UG9zc2libHlVbnNldCk6IFJl bmFtZWQgYW5kIGNoYW5nZWQgdG8gcmV0dXJuIGEgdmFsdWUgZm9yCisgICAgICAgIGNsYXJpdHku IEl0J3MgYWxsIHRoZSBzYW1lIHdpdGggaW5saW5pbmcuCisKIDIwMTEtMDEtMjggIEdlb2ZmcmV5 IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBNYWNpZWog U3RhY2hvd2lhay4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL01hcmtlZFNw YWNlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9NYXJr ZWRTcGFjZS5jcHAJKHJldmlzaW9uIDc3MDc5KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1 bnRpbWUvTWFya2VkU3BhY2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNTAsNyArMTUwLDcgQEAg dm9pZCogTWFya2VkU3BhY2U6OmFsbG9jYXRlKHNpemVfdCBzKQogICAgICAgICAgICAgICAgICsr bV9oZWFwLm5leHRDZWxsOwogICAgICAgICAgICAgICAgIHJldHVybiBjZWxsOwogICAgICAgICAg ICAgfQotICAgICAgICAgICAgYmxvY2stPm1hcmtlZC5hZHZhbmNlVG9OZXh0UG9zc2libGVGcmVl Q2VsbChtX2hlYXAubmV4dENlbGwpOworICAgICAgICAgICAgbV9oZWFwLm5leHRDZWxsID0gYmxv Y2stPm1hcmtlZC5uZXh0UG9zc2libHlVbnNldChtX2hlYXAubmV4dENlbGwpOwogICAgICAgICB9 IHdoaWxlIChtX2hlYXAubmV4dENlbGwgIT0gSGVhcENvbnN0YW50czo6Y2VsbHNQZXJCbG9jayk7 CiAgICAgICAgIG1faGVhcC5uZXh0Q2VsbCA9IDA7CiAgICAgfSB3aGlsZSAoKyttX2hlYXAubmV4 dEJsb2NrICE9IG1faGVhcC51c2VkQmxvY2tzKTsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9ydW50aW1lL01hcmtlZFNwYWNlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRD b3JlL3J1bnRpbWUvTWFya2VkU3BhY2UuaAkocmV2aXNpb24gNzcwNzkpCisrKyBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvcnVudGltZS9NYXJrZWRTcGFjZS5oCSh3b3JraW5nIGNvcHkpCkBAIC0yNCw2 ICsyNCw3IEBACiAKICNpbmNsdWRlICJNYWNoaW5lU3RhY2tNYXJrZXIuaCIKICNpbmNsdWRlICJQ YWdlQWxsb2NhdGlvbkFsaWduZWQuaCIKKyNpbmNsdWRlIDx3dGYvQml0bWFwLmg+CiAjaW5jbHVk ZSA8d3RmL0ZpeGVkQXJyYXkuaD4KICNpbmNsdWRlIDx3dGYvSGFzaENvdW50ZWRTZXQuaD4KICNp bmNsdWRlIDx3dGYvTm9uY29weWFibGUuaD4KQEAgLTEyNCw1MCArMTI1LDYgQEAgbmFtZXNwYWNl IEpTQyB7CiAgICAgY29uc3Qgc2l6ZV90IENFTExfQUxJR05fTUFTSyA9IH5DRUxMX01BU0s7CiAg ICAgY29uc3Qgc2l6ZV90IENFTExTX1BFUl9CTE9DSyA9IChCTE9DS19TSVpFIC0gc2l6ZW9mKE1h cmtlZFNwYWNlKikpICogOCAqIENFTExfU0laRSAvICg4ICogQ0VMTF9TSVpFICsgMSkgLyBDRUxM X1NJWkU7IC8vIG9uZSBiaXRtYXAgYnl0ZSBjYW4gcmVwcmVzZW50IDggY2VsbHMuCiAgICAgCi0g ICAgY29uc3Qgc2l6ZV90IEJJVE1BUF9TSVpFID0gKENFTExTX1BFUl9CTE9DSyArIDcpIC8gODsK LSAgICBjb25zdCBzaXplX3QgQklUTUFQX1dPUkRTID0gKEJJVE1BUF9TSVpFICsgMykgLyBzaXpl b2YodWludDMyX3QpOwotCi0gICAgc3RydWN0IENvbGxlY3RvckJpdG1hcCB7Ci0gICAgICAgIEZp eGVkQXJyYXk8dWludDMyX3QsIEJJVE1BUF9XT1JEUz4gYml0czsKLSAgICAgICAgYm9vbCBnZXQo c2l6ZV90IG4pIGNvbnN0IHsgcmV0dXJuICEhKGJpdHNbbiA+PiA1XSAmICgxIDw8IChuICYgMHgx RikpKTsgfSAKLSAgICAgICAgdm9pZCBzZXQoc2l6ZV90IG4pIHsgYml0c1tuID4+IDVdIHw9ICgx IDw8IChuICYgMHgxRikpOyB9IAotICAgICAgICBib29sIGdldHNldChzaXplX3QgbikKLSAgICAg ICAgewotICAgICAgICAgICAgdW5zaWduZWQgaSA9ICgxIDw8IChuICYgMHgxRikpOwotICAgICAg ICAgICAgdWludDMyX3QmIGIgPSBiaXRzW24gPj4gNV07Ci0gICAgICAgICAgICBib29sIHIgPSAh IShiICYgaSk7Ci0gICAgICAgICAgICBiIHw9IGk7Ci0gICAgICAgICAgICByZXR1cm4gcjsKLSAg ICAgICAgfSAKLSAgICAgICAgdm9pZCBjbGVhcihzaXplX3QgbikgeyBiaXRzW24gPj4gNV0gJj0g figxIDw8IChuICYgMHgxRikpOyB9IAotICAgICAgICB2b2lkIGNsZWFyQWxsKCkgeyBtZW1zZXQo Yml0cy5kYXRhKCksIDAsIHNpemVvZihiaXRzKSk7IH0KLSAgICAgICAgQUxXQVlTX0lOTElORSB2 b2lkIGFkdmFuY2VUb05leHRQb3NzaWJsZUZyZWVDZWxsKHNpemVfdCYgc3RhcnRDZWxsKQotICAg ICAgICB7Ci0gICAgICAgICAgICBpZiAoIX5iaXRzW3N0YXJ0Q2VsbCA+PiA1XSkKLSAgICAgICAg ICAgICAgICBzdGFydENlbGwgPSAoc3RhcnRDZWxsICYgKH4weDFGKSkgKyAzMjsKLSAgICAgICAg ICAgIGVsc2UKLSAgICAgICAgICAgICAgICArK3N0YXJ0Q2VsbDsKLSAgICAgICAgfQotICAgICAg ICBzaXplX3QgY291bnQoc2l6ZV90IHN0YXJ0Q2VsbCA9IDApCi0gICAgICAgIHsKLSAgICAgICAg ICAgIHNpemVfdCByZXN1bHQgPSAwOwotICAgICAgICAgICAgZm9yICggOyAoc3RhcnRDZWxsICYg MHgxRikgIT0gMDsgKytzdGFydENlbGwpIHsKLSAgICAgICAgICAgICAgICBpZiAoZ2V0KHN0YXJ0 Q2VsbCkpCi0gICAgICAgICAgICAgICAgICAgICsrcmVzdWx0OwotICAgICAgICAgICAgfQotICAg ICAgICAgICAgZm9yIChzaXplX3QgaSA9IHN0YXJ0Q2VsbCA+PiA1OyBpIDwgQklUTUFQX1dPUkRT OyArK2kpCi0gICAgICAgICAgICAgICAgcmVzdWx0ICs9IFdURjo6Yml0Q291bnQoYml0c1tpXSk7 Ci0gICAgICAgICAgICByZXR1cm4gcmVzdWx0OwotICAgICAgICB9Ci0gICAgICAgIHNpemVfdCBp c0VtcHR5KCkgLy8gTXVjaCBtb3JlIGVmZmljaWVudCB0aGFuIHRlc3RpbmcgY291bnQoKSA9PSAw LgotICAgICAgICB7Ci0gICAgICAgICAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IEJJVE1BUF9X T1JEUzsgKytpKQotICAgICAgICAgICAgICAgIGlmIChiaXRzW2ldICE9IDApCi0gICAgICAgICAg ICAgICAgICAgIHJldHVybiBmYWxzZTsKLSAgICAgICAgICAgIHJldHVybiB0cnVlOwotICAgICAg ICB9Ci0gICAgfTsKLSAgCiAgICAgc3RydWN0IENvbGxlY3RvckNlbGwgewogICAgICAgICBGaXhl ZEFycmF5PGRvdWJsZSwgQ0VMTF9BUlJBWV9MRU5HVEg+IG1lbW9yeTsKICAgICB9OwpAQCAtMTc1 LDcgKzEzMiw3IEBAIG5hbWVzcGFjZSBKU0MgewogICAgIGNsYXNzIENvbGxlY3RvckJsb2NrIHsK ICAgICBwdWJsaWM6CiAgICAgICAgIEZpeGVkQXJyYXk8Q29sbGVjdG9yQ2VsbCwgQ0VMTFNfUEVS X0JMT0NLPiBjZWxsczsKLSAgICAgICAgQ29sbGVjdG9yQml0bWFwIG1hcmtlZDsKKyAgICAgICAg V1RGOjpCaXRtYXA8Q0VMTFNfUEVSX0JMT0NLPiBtYXJrZWQ7CiAgICAgICAgIEhlYXAqIGhlYXA7 CiAgICAgfTsKIApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9CaXRtYXAuaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL0JpdG1hcC5oCShyZXZpc2lvbiA3 NzA3OSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvQml0bWFwLmgJKHdvcmtpbmcgY29w eSkKQEAgLTIxLDcgKzIxLDYgQEAKIAogI2luY2x1ZGUgIkZpeGVkQXJyYXkuaCIKICNpbmNsdWRl ICJTdGRMaWJFeHRyYXMuaCIKLQogI2luY2x1ZGUgPHN0ZGludC5oPgogCiBuYW1lc3BhY2UgV1RG IHsKQEAgLTM2LDkgKzM1LDEwIEBAIHB1YmxpYzoKIAogICAgIGJvb2wgZ2V0KHNpemVfdCkgY29u c3Q7CiAgICAgdm9pZCBzZXQoc2l6ZV90KTsKKyAgICBib29sIGdldHNldChzaXplX3QpOworICAg IHNpemVfdCBuZXh0UG9zc2libHlVbnNldChzaXplX3QpIGNvbnN0OwogICAgIHZvaWQgY2xlYXIo c2l6ZV90KTsKICAgICB2b2lkIGNsZWFyQWxsKCk7Ci0gICAgdm9pZCBhZHZhbmNlVG9OZXh0RnJl ZUJpdChzaXplX3QmKSBjb25zdDsKICAgICBzaXplX3QgY291bnQoc2l6ZV90ID0gMCkgY29uc3Q7 CiAgICAgc2l6ZV90IGlzRW1wdHkoKSBjb25zdDsKICAgICBzaXplX3QgaXNGdWxsKCkgY29uc3Q7 CkBAIC03Niw2ICs3NiwxNiBAQCBpbmxpbmUgdm9pZCBCaXRtYXA8c2l6ZT46OnNldChzaXplX3Qg bikKIH0KIAogdGVtcGxhdGU8c2l6ZV90IHNpemU+CitpbmxpbmUgYm9vbCBCaXRtYXA8c2l6ZT46 OmdldHNldChzaXplX3QgbikKK3sKKyAgICBXb3JkVHlwZSBtYXNrID0gb25lIDw8IChuICUgd29y ZFNpemUpOworICAgIHNpemVfdCBpbmRleCA9IG4gLyB3b3JkU2l6ZTsKKyAgICBib29sIHJlc3Vs dCA9IGJpdHNbaW5kZXhdICYgbWFzazsKKyAgICBiaXRzW2luZGV4XSB8PSBtYXNrOworICAgIHJl dHVybiByZXN1bHQ7Cit9CisKK3RlbXBsYXRlPHNpemVfdCBzaXplPgogaW5saW5lIHZvaWQgQml0 bWFwPHNpemU+OjpjbGVhcihzaXplX3QgbikKIHsKICAgICBiaXRzW24gLyB3b3JkU2l6ZV0gJj0g fihvbmUgPDwgKG4gJSB3b3JkU2l6ZSkpOwpAQCAtODgsMTIgKzk4LDExIEBAIGlubGluZSB2b2lk IEJpdG1hcDxzaXplPjo6Y2xlYXJBbGwoKQogfQogCiB0ZW1wbGF0ZTxzaXplX3Qgc2l6ZT4KLWlu bGluZSB2b2lkIEJpdG1hcDxzaXplPjo6YWR2YW5jZVRvTmV4dEZyZWVCaXQoc2l6ZV90JiBzdGFy dCkgY29uc3QKK2lubGluZSBzaXplX3QgQml0bWFwPHNpemU+OjpuZXh0UG9zc2libHlVbnNldChz aXplX3Qgc3RhcnQpIGNvbnN0CiB7CiAgICAgaWYgKCF+Yml0c1tzdGFydCAvIHdvcmRTaXplXSkK LSAgICAgICAgc3RhcnQgPSAoKHN0YXJ0IC8gd29yZFNpemUpICsgMSkgKiB3b3JkU2l6ZTsKLSAg ICBlbHNlCi0gICAgICAgICsrc3RhcnQ7CisgICAgICAgIHJldHVybiAoKHN0YXJ0IC8gd29yZFNp emUpICsgMSkgKiB3b3JkU2l6ZTsKKyAgICByZXR1cm4gc3RhcnQgKyAxOwogfQogCiB0ZW1wbGF0 ZTxzaXplX3Qgc2l6ZT4K