53384 2011-01-29 15:52:54 -0800 RenderFullScreen::createFullScreenStyle() leaks 2011-03-16 17:49:34 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser jer.noble abarth aroben commit-queue eric jer.noble simon.fraser webkit.review.bot oldest_to_newest 342160 0 simon.fraser 2011-01-29 15:52:54 -0800 Leak bot output, at <http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r77071%20(14433)/DumpRenderTree10-leaks.txt>, shows this leak: Leak: 0x11baec1d0 size=32 zone: DefaultMallocZone_0x105977000 string '' Call stack: [thread 0x7fff70b12c20]: | 0x2 | start | main | dumpRenderTree(int, char const**) | runTestingServerLoop() | runTest(std::string const&) | -[NSRunLoop(NSRunLoop) runMode:beforeDate:] | CFRunLoopRunSpecific | __CFRunLoopRun | __CFRunLoopDoSources0 | MultiplexerSource::perform() | URLConnectionClient::processEvents() | URLConnectionClient::ClientConnectionEventQueue::processAllEventsAndConsumePayload(XConnectionEventInfo<XClientEvent, XClientEventParams>*, long) | URLConnectionClient::_clientDidReceiveData(__CFData const*, URLConnectionClient::ClientConnectionEventQueue*) | _NSURLConnectionDidReceiveData | -[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:] | WebCore::ResourceLoader::didReceiveData(WebCore::ResourceHandle*, char const*, int, int) | WebCore::MainResourceLoader::didReceiveData(char const*, int, long long, bool) | WebCore::ResourceLoader::didReceiveData(char const*, int, long long, bool) | WebCore::MainResourceLoader::addData(char const*, int, bool) | WebCore::DocumentLoader::receivedData(char const*, int) | WebCore::DocumentLoader::commitLoad(char const*, int) | WebFrameLoaderClient::committedLoad(WebCore::DocumentLoader*, char const*, int) | -[WebDataSource(WebInternal) _receivedData:] | -[WebHTMLRepresentation receivedData:withDataSource:] | -[WebFrame(WebInternal) _commitData:] | WebCore::DocumentLoader::commitData(char const*, int) | WebCore::DocumentWriter::addData(char const*, int, bool) | WebCore::DecodedDataDocumentParser::appendBytes(WebCore::DocumentWriter*, char const*, int, bool) | WebCore::HTMLDocumentParser::append(WebCore::SegmentedString const&) | WebCore::HTMLDocumentParser::pumpTokenizerIfPossible(WebCore::HTMLDocumentParser::SynchronousMode) | WebCore::HTMLDocumentParser::pumpTokenizer(WebCore::HTMLDocumentParser::SynchronousMode) | WebCore::HTMLDocumentParser::runScriptsForPausedTreeBuilder() | WebCore::HTMLScriptRunner::execute(WTF::PassRefPtr<WebCore::Element>, WTF::TextPosition<WTF::OneBasedNumber> const&) | WebCore::HTMLScriptRunner::runScript(WebCore::Element*, WTF::TextPosition<WTF::OneBasedNumber> const&) | WebCore::ScriptElement::executeScript(WebCore::ScriptSourceCode const&) | WebCore::ScriptController::executeScript(WebCore::ScriptSourceCode const&, WebCore::ShouldAllowXSS) | WebCore::ScriptController::evaluate(WebCore::ScriptSourceCode const&, WebCore::ShouldAllowXSS) | WebCore::ScriptController::evaluateInWorld(WebCore::ScriptSourceCode const&, WebCore::DOMWrapperWorld*, WebCore::ShouldAllowXSS) | WebCore::JSMainThreadExecState::evaluate(JSC::ExecState*, JSC::ScopeChain&, JSC::SourceCode const&, JSC::JSValue) | JSC::evaluate(JSC::ExecState*, JSC::ScopeChain&, JSC::SourceCode const&, JSC::JSValue) | JSC::Interpreter::execute(JSC::ProgramExecutable*, JSC::ExecState*, JSC::ScopeChainNode*, JSC::JSObject*) | JSC::JITCode::execute(JSC::RegisterFile*, JSC::ExecState*, JSC::JSGlobalData*) | 0x56847de001b8 | WebCore::jsElementPrototypeFunctionWebkitRequestFullScreen(JSC::ExecState*) | WebCore::Element::webkitRequestFullScreen(unsigned short) | WebCore::Document::webkitRequestFullScreenForElement(WebCore::Element*, unsigned short) | WebChromeClient::enterFullScreenForElement(WebCore::Element*) | CallUIDelegate(WebView*, objc_selector*, objc_object*, objc_object*) | CallDelegate(WebView*, objc_object*, objc_selector*, objc_object*, objc_object*) | -[UIDelegate webView:enterFullScreenForElement:listener:] | -[WebKitFullScreenListener webkitWillEnterFullScreen] | WebCore::Document::webkitWillEnterFullScreenForElement(WebCore::Element*) | WebCore::Document::recalcStyle(WebCore::Node::StyleChange) | WebCore::Element::recalcStyle(WebCore::Node::StyleChange) | WebCore::Element::recalcStyle(WebCore::Node::StyleChange) | WebCore::Element::recalcStyle(WebCore::Node::StyleChange) | WebCore::Element::recalcStyle(WebCore::Node::StyleChange) | WebCore::Element::attach() | WebCore::Node::createRendererIfNeeded() | WebCore::RenderFullScreen::createFullScreenStyle() | WebCore::RenderStyle::createDefaultStyle() | WebCore::RenderStyle::RenderStyle(bool) | WebCore::DataRef<WebCore::StyleFlexibleBoxData>::init() | WebCore::StyleFlexibleBoxData::create() | WTF::RefCounted<WebCore::StyleFlexibleBoxData>::operator new(unsigned long) | WTF::fastMalloc(unsigned long) | malloc | malloc_zone_malloc Leak: 0x11baec1f0 size=32 zone: DefaultMallocZone_0x105977000 string '' 342162 1 simon.fraser 2011-01-29 15:55:14 -0800 Here's another one: Leak: 0x11bae9ec0 size=336 zone: DefaultMallocZone_0x105977000 0x1bac3940 0x00000001 0x00000130 0x00000000 @9......0....... 0xdba00aea 0x00000000 0x02c91d70 0x00000001 ........p....... 0x1baea010 0x00000001 0x00000001 0x00000000 ................ 0x1bae9538 0x00000001 0x00000000 0x00000000 8............... 0x00000000 0x00000000 0x00000000 0x00000000 ................ 0x00000000 0x00000000 0x00000000 0x00000000 ................ 0x00000000 0x00000000 0x00000320 0x00000258 ........ ...X... 0x00000000 0x00000000 0x00000320 0x00000258 ........ ...X... ... Call stack: [thread 0x7fff70b12c20]: | 0x2 | start | main | dumpRenderTree(int, char const**) | runTestingServerLoop() | runTest(std::string const&) | -[NSRunLoop(NSRunLoop) runMode:beforeDate:] | CFRunLoopRunSpecific | __CFRunLoopRun | __CFRunLoopDoSources0 | MultiplexerSource::perform() | URLConnectionClient::processEvents() | URLConnectionClient::ClientConnectionEventQueue::processAllEventsAndConsumePayload(XConnectionEventInfo<XClientEvent, XClientEventParams>*, long) | URLConnectionClient::_clientDidReceiveData(__CFData const*, URLConnectionClient::ClientConnectionEventQueue*) | _NSURLConnectionDidReceiveData | -[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:] | WebCore::ResourceLoader::didReceiveData(WebCore::ResourceHandle*, char const*, int, int) | WebCore::MainResourceLoader::didReceiveData(char const*, int, long long, bool) | WebCore::ResourceLoader::didReceiveData(char const*, int, long long, bool) | WebCore::MainResourceLoader::addData(char const*, int, bool) | WebCore::DocumentLoader::receivedData(char const*, int) | WebCore::DocumentLoader::commitLoad(char const*, int) | WebFrameLoaderClient::committedLoad(WebCore::DocumentLoader*, char const*, int) | -[WebDataSource(WebInternal) _receivedData:] | -[WebHTMLRepresentation receivedData:withDataSource:] | -[WebFrame(WebInternal) _commitData:] | WebCore::DocumentLoader::commitData(char const*, int) | WebCore::DocumentWriter::addData(char const*, int, bool) | WebCore::DecodedDataDocumentParser::appendBytes(WebCore::DocumentWriter*, char const*, int, bool) | WebCore::HTMLDocumentParser::append(WebCore::SegmentedString const&) | WebCore::HTMLDocumentParser::pumpTokenizerIfPossible(WebCore::HTMLDocumentParser::SynchronousMode) | WebCore::HTMLDocumentParser::pumpTokenizer(WebCore::HTMLDocumentParser::SynchronousMode) | WebCore::HTMLDocumentParser::runScriptsForPausedTreeBuilder() | WebCore::HTMLScriptRunner::execute(WTF::PassRefPtr<WebCore::Element>, WTF::TextPosition<WTF::OneBasedNumber> const&) | WebCore::HTMLScriptRunner::runScript(WebCore::Element*, WTF::TextPosition<WTF::OneBasedNumber> const&) | WebCore::ScriptElement::executeScript(WebCore::ScriptSourceCode const&) | WebCore::ScriptController::executeScript(WebCore::ScriptSourceCode const&, WebCore::ShouldAllowXSS) | WebCore::ScriptController::evaluate(WebCore::ScriptSourceCode const&, WebCore::ShouldAllowXSS) | WebCore::ScriptController::evaluateInWorld(WebCore::ScriptSourceCode const&, WebCore::DOMWrapperWorld*, WebCore::ShouldAllowXSS) | WebCore::JSMainThreadExecState::evaluate(JSC::ExecState*, JSC::ScopeChain&, JSC::SourceCode const&, JSC::JSValue) | JSC::evaluate(JSC::ExecState*, JSC::ScopeChain&, JSC::SourceCode const&, JSC::JSValue) | JSC::Interpreter::execute(JSC::ProgramExecutable*, JSC::ExecState*, JSC::ScopeChainNode*, JSC::JSObject*) | JSC::JITCode::execute(JSC::RegisterFile*, JSC::ExecState*, JSC::JSGlobalData*) | 0x56847de001b8 | WebCore::jsElementPrototypeFunctionWebkitRequestFullScreen(JSC::ExecState*) | WebCore::Element::webkitRequestFullScreen(unsigned short) | WebCore::Document::webkitRequestFullScreenForElement(WebCore::Element*, unsigned short) | WebChromeClient::enterFullScreenForElement(WebCore::Element*) | CallUIDelegate(WebView*, objc_selector*, objc_object*, objc_object*) | CallDelegate(WebView*, objc_object*, objc_selector*, objc_object*, objc_object*) | -[UIDelegate webView:enterFullScreenForElement:listener:] | -[WebKitFullScreenListener webkitWillEnterFullScreen] | WebCore::Document::webkitWillEnterFullScreenForElement(WebCore::Element*) | WebCore::Document::recalcStyle(WebCore::Node::StyleChange) | WebCore::Element::recalcStyle(WebCore::Node::StyleChange) | WebCore::Element::recalcStyle(WebCore::Node::StyleChange) | WebCore::Element::recalcStyle(WebCore::Node::StyleChange) | WebCore::Element::recalcStyle(WebCore::Node::StyleChange) | WebCore::Element::attach() | WebCore::Node::createRendererIfNeeded() | WebCore::RenderObject::setStyle(WTF::PassRefPtr<WebCore::RenderStyle>) | WebCore::RenderBlock::styleDidChange(WebCore::StyleDifference, WebCore::RenderStyle const*) | WebCore::RenderBox::styleDidChange(WebCore::StyleDifference, WebCore::RenderStyle const*) | WebCore::RenderBoxModelObject::styleDidChange(WebCore::StyleDifference, WebCore::RenderStyle const*) | WebCore::RenderLayer::operator new(unsigned long, WebCore::RenderArena*) | WebCore::RenderArena::allocate(unsigned long) | malloc | malloc_zone_malloc 342174 2 jer.noble 2011-01-29 17:35:55 -0800 Looks like the last line of createFullScreenStyle() should be changed from: return fullscreenStyle; to: return fullscreenStyle.release(); As per the "Mixing RefPtr and PassRefPtr" section of http://webkit.org/coding/RefPtr.html. 342181 3 sam 2011-01-29 18:01:18 -0800 *** Bug 53385 has been marked as a duplicate of this bug. *** 367982 4 jer.noble 2011-03-15 15:20:55 -0700 *** Bug 56419 has been marked as a duplicate of this bug. *** 367983 5 jer.noble 2011-03-15 15:22:31 -0700 <rdar://problem/9138229> 367984 6 aroben 2011-03-15 15:25:34 -0700 (In reply to comment #2) > Looks like the last line of createFullScreenStyle() should be changed from: > > return fullscreenStyle; > > to: > > return fullscreenStyle.release(); > > As per the "Mixing RefPtr and PassRefPtr" section of http://webkit.org/coding/RefPtr.html. That would be a good change to make. But I don't think it will have any effect on this leak. All it will do is save an unnecessary ref()/deref() pair from occurring. 367988 7 jer.noble 2011-03-15 15:28:14 -0700 (In reply to comment #6) > (In reply to comment #2) > > Looks like the last line of createFullScreenStyle() should be changed from: > > > > return fullscreenStyle; > > > > to: > > > > return fullscreenStyle.release(); > > > > As per the "Mixing RefPtr and PassRefPtr" section of http://webkit.org/coding/RefPtr.html. > > That would be a good change to make. But I don't think it will have any effect on this leak. All it will do is save an unnecessary ref()/deref() pair from occurring. Okay, I'll keep investigating then. 368246 8 jer.noble 2011-03-16 00:42:38 -0700 Replacing RenderStyle::createDefaultStyle() with RenderStyle::create() drops the number of leaks found while running the Layout/fullscreen tests from 25 -> 12. I haven't yet been able to track down exactly what is causing the remaining leaks yet. 368253 9 jer.noble 2011-03-16 00:53:36 -0700 (continuing)...though that's probably due to the contents of the leaked object being smaller, due to less initialization being done. 368543 10 85975 jer.noble 2011-03-16 14:27:09 -0700 Created attachment 85975 Patch `run-layout-tests -l fullscreen` now results in 1 total leak found. 368547 11 85975 aroben 2011-03-16 14:29:35 -0700 Comment on attachment 85975 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=85975&action=review > Source/WebCore/ChangeLog:15 > + (WebCore::Document::setFullScreenRenderer): release() the return value. > + * rendering/RenderFullScreen.cpp: > + (RenderFullScreen::createFullScreenStyle): Destroy the current renderer when a new one is set. This comments are backward. 368552 12 85975 jer.noble 2011-03-16 14:37:39 -0700 Comment on attachment 85975 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=85975&action=review >> Source/WebCore/ChangeLog:15 >> + (RenderFullScreen::createFullScreenStyle): Destroy the current renderer when a new one is set. > > This comments are backward. ::facepalm:: Fixed. 368555 13 85980 jer.noble 2011-03-16 14:40:29 -0700 Created attachment 85980 Patch 368570 14 jer.noble 2011-03-16 15:02:10 -0700 The remaining leak is: Call stack: [thread 0x7fff74efa8d0]: 0x2 start main dumpRenderTree(int, char const**) prepareConsistentTestingEnvironment() setDefaultsToConsistentValuesForTesting() resetDefaultsToConsistentValues() LayoutTestController::setSerializeHTTPLoads(bool) objc_msgSend lookUpMethod prepareForMethodLookup _class_initialize +[WebView initialize] JSC::initializeThreading() pthread_once JSC::initializeThreadingOnce() JSC::JSGlobalData::storeVPtrs() JSC::ExecutableBase::createStructure(JSC::JSValue) JSC::Structure::create(JSC::JSValue, JSC::TypeInfo const&, unsigned int, JSC::ClassInfo const*) WTF::RefCounted<JSC::Structure>::operator new(unsigned long) WTF::fastMalloc(unsigned long) malloc malloc_zone_malloc So, unlikely to be related to full screen. 368642 15 85980 commit-queue 2011-03-16 16:49:06 -0700 Comment on attachment 85980 Patch Clearing flags on attachment: 85980 Committed r81291: <http://trac.webkit.org/changeset/81291> 368643 16 commit-queue 2011-03-16 16:49:12 -0700 All reviewed patches have been landed. Closing bug. 368689 17 webkit.review.bot 2011-03-16 17:49:34 -0700 http://trac.webkit.org/changeset/81291 might have broken Windows 7 Release (Tests) The following tests are not passing: fast/events/popup-blocking-timers.html 85975 2011-03-16 14:27:09 -0700 2011-03-16 14:40:27 -0700 Patch bug-53384-20110316142707.patch text/plain 2258 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogODExODUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAxYTc4OTBjOGNlZThiN2U5 YzM0OWVmZWJlMWFiN2Y2OWQyYjk1YTk1Li41YWEyMTllNGNjMDUzZjY1N2ZmYmI3YWM3MDc1NGEx MmE2NWM5ODFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDMtMTYgIEplciBO b2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgUmVuZGVyRnVsbFNjcmVlbjo6Y3JlYXRlRnVsbFNjcmVlblN0 eWxlKCkgbGVha3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTUzMzg0CisKKyAgICAgICAgVHdvIHByb2JsZW1zOiBhKSBub3QgY2FsbGluZyByZWxlYXNl KCkgb24gdGhlIHN0eWxlIHJldHVybmVkIGluIHNldEZ1bGxTY3JlZW5SZW5kZXJlcgorICAgICAg ICBjYXVzZXMgYW4gdW5uZWNlc3NhcnkgcmVmL2RlcmVmLCBhbmQgYikgdGhlIGZ1bGxzY3JlZW4g cmVuZGVyZXIgbmVlZHMgdG8gYmUgZGVzdHJveWVkLAorICAgICAgICBub3QganVzdCBkZXRhY2hl ZCwgd2hlbiBpdCBpcyBubyBsb25nZXIgbmVlZGVkLgorCisgICAgICAgICogZG9tL0RvY3VtZW50 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50OjpzZXRGdWxsU2NyZWVuUmVuZGVyZXIp OiByZWxlYXNlKCkgdGhlIHJldHVybiB2YWx1ZS4KKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVy RnVsbFNjcmVlbi5jcHA6CisgICAgICAgIChSZW5kZXJGdWxsU2NyZWVuOjpjcmVhdGVGdWxsU2Ny ZWVuU3R5bGUpOiBEZXN0cm95IHRoZSBjdXJyZW50IHJlbmRlcmVyIHdoZW4gYSBuZXcgb25lIGlz IHNldC4KKwogMjAxMS0wMy0xNSAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAog ICAgICAgICBSZXZpZXdlZCBieSBUb255IENoYW5nLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvZG9tL0RvY3VtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKaW5k ZXggZmVlMmFmMmVhYjg5YzMyOGY0YmExYjhhN2RmMzFjYzdjMTJhYzcwNy4uZTRiZTlmNDVjYjhm ZjE5ZjQ1Y2E1YWFjNmU2OWU0ZWU0ZjJlNDJlMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv ZG9tL0RvY3VtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCkBA IC00OTc5LDYgKzQ5NzksMTEgQEAgdm9pZCBEb2N1bWVudDo6d2Via2l0RGlkRXhpdEZ1bGxTY3Jl ZW5Gb3JFbGVtZW50KEVsZW1lbnQqKQogICAgIAogdm9pZCBEb2N1bWVudDo6c2V0RnVsbFNjcmVl blJlbmRlcmVyKFJlbmRlckZ1bGxTY3JlZW4qIHJlbmRlcmVyKQogeworICAgIGlmIChyZW5kZXJl ciA9PSBtX2Z1bGxTY3JlZW5SZW5kZXJlcikKKyAgICAgICAgcmV0dXJuOworCisgICAgaWYgKG1f ZnVsbFNjcmVlblJlbmRlcmVyKQorICAgICAgICBtX2Z1bGxTY3JlZW5SZW5kZXJlci0+ZGVzdHJv eSgpOwogICAgIG1fZnVsbFNjcmVlblJlbmRlcmVyID0gcmVuZGVyZXI7CiAgICAgCiAgICAgLy8g VGhpcyBub3RpZmljYXRpb24gY2FuIGNvbWUgaW4gYWZ0ZXIgdGhlIHBhZ2UgaGFzIGJlZW4gZGVz dHJveWVkLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZ1bGxT Y3JlZW4uY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZ1bGxTY3JlZW4uY3Bw CmluZGV4IGNjNTNhNmU2Y2E0OWRhY2Q4Y2E5OGZkZDM4ZjUzZGFhMWU5NDBkODQuLmE2ODUwNjQ3 NmY3ZTBhODQwNjdjNTYzZTNhMmViZmU3NGMxZmEzNGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJGdWxsU2NyZWVuLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyRnVsbFNjcmVlbi5jcHAKQEAgLTY0LDcgKzY0LDcgQEAgUGFzc1JlZlB0 cjxSZW5kZXJTdHlsZT4gUmVuZGVyRnVsbFNjcmVlbjo6Y3JlYXRlRnVsbFNjcmVlblN0eWxlKCkK ICAgICAKICAgICBmdWxsc2NyZWVuU3R5bGUtPnNldEJhY2tncm91bmRDb2xvcihDb2xvcjo6Ymxh Y2spOwogICAgIAotICAgIHJldHVybiBmdWxsc2NyZWVuU3R5bGU7CisgICAgcmV0dXJuIGZ1bGxz Y3JlZW5TdHlsZS5yZWxlYXNlKCk7CiB9CiAKICNlbmRpZgo= 85980 2011-03-16 14:40:29 -0700 2011-03-16 16:49:06 -0700 Patch bug-53384-20110316144028.patch text/plain 2258 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogODExODUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAxYTc4OTBjOGNlZThiN2U5 YzM0OWVmZWJlMWFiN2Y2OWQyYjk1YTk1Li5hYTUzMGRiNTJlMGM0NGM4NWI5ZGQ0NWYwOTM1NzAw MzJhMWRhOGYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDMtMTYgIEplciBO b2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgUmVuZGVyRnVsbFNjcmVlbjo6Y3JlYXRlRnVsbFNjcmVlblN0 eWxlKCkgbGVha3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTUzMzg0CisKKyAgICAgICAgVHdvIHByb2JsZW1zOiBhKSBub3QgY2FsbGluZyByZWxlYXNl KCkgb24gdGhlIHN0eWxlIHJldHVybmVkIGluIHNldEZ1bGxTY3JlZW5SZW5kZXJlcgorICAgICAg ICBjYXVzZXMgYW4gdW5uZWNlc3NhcnkgcmVmL2RlcmVmLCBhbmQgYikgdGhlIGZ1bGxzY3JlZW4g cmVuZGVyZXIgbmVlZHMgdG8gYmUgZGVzdHJveWVkLAorICAgICAgICBub3QganVzdCBkZXRhY2hl ZCwgd2hlbiBpdCBpcyBubyBsb25nZXIgbmVlZGVkLgorCisgICAgICAgICogZG9tL0RvY3VtZW50 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50OjpzZXRGdWxsU2NyZWVuUmVuZGVyZXIp OiBEZXN0cm95IHRoZSBjdXJyZW50IHJlbmRlcmVyIHdoZW4gYSBuZXcgb25lIGlzIHNldC4KKyAg ICAgICAgKiByZW5kZXJpbmcvUmVuZGVyRnVsbFNjcmVlbi5jcHA6CisgICAgICAgIChSZW5kZXJG dWxsU2NyZWVuOjpjcmVhdGVGdWxsU2NyZWVuU3R5bGUpOiByZWxlYXNlKCkgdGhlIHJldHVybiB2 YWx1ZS4KKwogMjAxMS0wMy0xNSAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAog ICAgICAgICBSZXZpZXdlZCBieSBUb255IENoYW5nLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvZG9tL0RvY3VtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKaW5k ZXggZmVlMmFmMmVhYjg5YzMyOGY0YmExYjhhN2RmMzFjYzdjMTJhYzcwNy4uZTRiZTlmNDVjYjhm ZjE5ZjQ1Y2E1YWFjNmU2OWU0ZWU0ZjJlNDJlMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv ZG9tL0RvY3VtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCkBA IC00OTc5LDYgKzQ5NzksMTEgQEAgdm9pZCBEb2N1bWVudDo6d2Via2l0RGlkRXhpdEZ1bGxTY3Jl ZW5Gb3JFbGVtZW50KEVsZW1lbnQqKQogICAgIAogdm9pZCBEb2N1bWVudDo6c2V0RnVsbFNjcmVl blJlbmRlcmVyKFJlbmRlckZ1bGxTY3JlZW4qIHJlbmRlcmVyKQogeworICAgIGlmIChyZW5kZXJl ciA9PSBtX2Z1bGxTY3JlZW5SZW5kZXJlcikKKyAgICAgICAgcmV0dXJuOworCisgICAgaWYgKG1f ZnVsbFNjcmVlblJlbmRlcmVyKQorICAgICAgICBtX2Z1bGxTY3JlZW5SZW5kZXJlci0+ZGVzdHJv eSgpOwogICAgIG1fZnVsbFNjcmVlblJlbmRlcmVyID0gcmVuZGVyZXI7CiAgICAgCiAgICAgLy8g VGhpcyBub3RpZmljYXRpb24gY2FuIGNvbWUgaW4gYWZ0ZXIgdGhlIHBhZ2UgaGFzIGJlZW4gZGVz dHJveWVkLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZ1bGxT Y3JlZW4uY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZ1bGxTY3JlZW4uY3Bw CmluZGV4IGNjNTNhNmU2Y2E0OWRhY2Q4Y2E5OGZkZDM4ZjUzZGFhMWU5NDBkODQuLmE2ODUwNjQ3 NmY3ZTBhODQwNjdjNTYzZTNhMmViZmU3NGMxZmEzNGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJGdWxsU2NyZWVuLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyRnVsbFNjcmVlbi5jcHAKQEAgLTY0LDcgKzY0LDcgQEAgUGFzc1JlZlB0 cjxSZW5kZXJTdHlsZT4gUmVuZGVyRnVsbFNjcmVlbjo6Y3JlYXRlRnVsbFNjcmVlblN0eWxlKCkK ICAgICAKICAgICBmdWxsc2NyZWVuU3R5bGUtPnNldEJhY2tncm91bmRDb2xvcihDb2xvcjo6Ymxh Y2spOwogICAgIAotICAgIHJldHVybiBmdWxsc2NyZWVuU3R5bGU7CisgICAgcmV0dXJuIGZ1bGxz Y3JlZW5TdHlsZS5yZWxlYXNlKCk7CiB9CiAKICNlbmRpZgo=