53382 2011-01-29 14:39:51 -0800 Remove reference to ${CMAKE_SOURCE_DIR}/Source in CMake files 2011-01-29 15:14:51 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Other RESOLVED FIXED P2 Normal --- 1 dbates dbates eric paroga oldest_to_newest 342141 0 dbates 2011-01-29 14:39:51 -0800 Following up on bug 53253 comment 5, we should remove references to ${CMAKE_SOURCE_DIR}/Source in CMake files since CMAKE_SOURCE_DIR is taken to be /Source as implied by the definitions of JAVASCRIPTCORE_DIR, WEBCORE_DIR, WEBKIT_DIR, and TOOLS_DIR in /Source/CMakeLists.txt. 342151 1 80578 dbates 2011-01-29 14:55:11 -0800 Created attachment 80578 Patch 342152 2 paroga 2011-01-29 14:56:47 -0800 LGTM 342156 3 dbates 2011-01-29 15:14:51 -0800 Committed r77073: <http://trac.webkit.org/changeset/77073> 80578 2011-01-29 14:55:11 -0800 2011-01-29 15:09:27 -0800 Patch bug-53382-20110129145510.patch text/plain 2366 dbates SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDc3MDcx KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDEt MjkgIERhbmllbCBCYXRlcyAgPGRiYXRlc0ByaW0uY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSByZWZlcmVuY2UgdG8gJHtDTUFLRV9T T1VSQ0VfRElSfS9Tb3VyY2UgaW4gQ01ha2UgZmlsZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUzMzgyCisKKyAgICAgICAgT3VyIGZpbGUgc3lzdGVt IGhpZXJhcmNoeSBlbnN1cmVzIHRoYXQgQ01BS0VfU09VUkNFX0RJUiBpcyBkZWZpbmVkIHRvIGJl IC9Tb3VyY2UuCisgICAgICAgIFNvLCAke0NNQUtFX1NPVVJDRV9ESVJ9L1NvdXJjZSBldmFsdWF0 ZXMgdG8gdGhlIG5vbi1leGlzdGVudCBkaXJlY3RvcnkgL1NvdXJjZS9Tb3VyY2UuCisgICAgICAg IFRoZXJlZm9yZSwgd2Ugc2hvdWxkIHJlbW92ZSBzdWNoIHJlZmVyZW5jZXMuCisKKyAgICAgICAg KiBTb3VyY2UvY21ha2UvT3B0aW9uc0NvbW1vbi5jbWFrZToKKwogMjAxMS0wMS0yOSAgRGFuaWVs IEJhdGVzICA8ZGJhdGVzQHJpbS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlk ZWwuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiA3NzA3MSkKKysrIFNvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDExLTAxLTI5ICBEYW5p ZWwgQmF0ZXMgIDxkYmF0ZXNAcmltLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgcmVmZXJlbmNlIHRvICR7Q01BS0VfU09VUkNFX0RJ Un0vU291cmNlIGluIENNYWtlIGZpbGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD01MzM4MgorCisgICAgICAgIE91ciBmaWxlIHN5c3RlbSBoaWVyYXJj aHkgZW5zdXJlcyB0aGF0IENNQUtFX1NPVVJDRV9ESVIgaXMgZGVmaW5lZCB0byBiZSAvU291cmNl LgorICAgICAgICBTbywgJHtDTUFLRV9TT1VSQ0VfRElSfS9Tb3VyY2UgZXZhbHVhdGVzIHRvIHRo ZSBub24tZXhpc3RlbnQgZGlyZWN0b3J5IC9Tb3VyY2UvU291cmNlLgorICAgICAgICBUaGVyZWZv cmUsIHdlIHNob3VsZCByZW1vdmUgc3VjaCByZWZlcmVuY2VzLgorCisgICAgICAgICogQ01ha2VM aXN0cy50eHQ6CisKIDIwMTEtMDEtMjkgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAog ICAgICAgICBSZXZpZXdlZCBieSBKb24gSG9uZXljdXR0LgpJbmRleDogU291cmNlL1dlYkNvcmUv Q01ha2VMaXN0cy50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50 eHQJKHJldmlzaW9uIDc3MDY5KQorKysgU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQJKHdv cmtpbmcgY29weSkKQEAgLTgwLDcgKzgwLDYgQEAgU0VUKFdlYkNvcmVfSU5DTFVERV9ESVJFQ1RP UklFUwogICAgICIke0pBVkFTQ1JJUFRDT1JFX0RJUn0vd3RmL3VuaWNvZGUiCiAgICAgIiR7REVS SVZFRF9TT1VSQ0VTX0RJUn0iCiAgICAgIiR7Q01BS0VfU09VUkNFX0RJUn0iCi0gICAgIiR7Q01B S0VfU09VUkNFX0RJUn0vU291cmNlIgogICAgICIke0NNQUtFX0JJTkFSWV9ESVJ9IgogKQogCklu ZGV4OiBTb3VyY2UvY21ha2UvT3B0aW9uc0NvbW1vbi5jbWFrZQo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvY21ha2UvT3B0aW9uc0NvbW1vbi5jbWFrZQkocmV2aXNpb24gNzcwNjkpCisrKyBTb3VyY2Uv Y21ha2UvT3B0aW9uc0NvbW1vbi5jbWFrZQkod29ya2luZyBjb3B5KQpAQCAtNSw3ICs1LDYgQEAg U0VUKFdURl9JTkNMVURFX0RJUkVDVE9SSUVTCiAgICAgIiR7SkFWQVNDUklQVENPUkVfRElSfSIK ICAgICAiJHtKQVZBU0NSSVBUQ09SRV9ESVJ9L3d0ZiIKICAgICAiJHtKQVZBU0NSSVBUQ09SRV9E SVJ9L3d0Zi91bmljb2RlIgotICAgICIke0NNQUtFX1NPVVJDRV9ESVJ9L1NvdXJjZSIKICAgICAi JHtERVJJVkVEX1NPVVJDRVNfRElSfSIKICkKIAo=