53374 2011-01-29 02:04:06 -0800 Remove uses of unsafe string functions in debugging code 2011-01-29 12:31:54 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 zwarich zwarich oldest_to_newest 342062 0 zwarich 2011-01-29 02:04:06 -0800 We might as well remove uses in debugging code to avoid false positives in checking tools. 342063 1 80556 zwarich 2011-01-29 02:05:47 -0800 Created attachment 80556 Proposed patch 342126 2 zwarich 2011-01-29 12:31:54 -0800 Fixed in r77067. 80556 2011-01-29 02:05:47 -0800 2011-01-29 12:23:25 -0800 Proposed patch unsafe.patch text/plain 1373 zwarich SW5kZXg6IHJ1bnRpbWUvUmVnRXhwLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBydW50aW1lL1JlZ0V4cC5j cHAJKHJldmlzaW9uIDc3MDQ4KQorKysgcnVudGltZS9SZWdFeHAuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0yMzAsMTEgKzIzMCwxMiBAQAogI2lmIEVOQUJMRShZQVJSX0pJVCkKICAgICAgICAgWWFy cjo6WWFyckNvZGVCbG9jayYgY29kZUJsb2NrID0gbV9yZXByZXNlbnRhdGlvbi0+bV9yZWdFeHBK SVRDb2RlOwogCi0gICAgICAgIGNoYXIgaml0QWRkclsyMF07CisgICAgICAgIGNvbnN0IHNpemVf dCBqaXRBZGRyU2l6ZSA9IDIwOworICAgICAgICBjaGFyIGppdEFkZHJbaml0QWRkclNpemVdOwog ICAgICAgICBpZiAobV9zdGF0ZSA9PSBKSVRDb2RlKQotICAgICAgICAgICAgc3ByaW50ZihqaXRB ZGRyLCAiZmFsbGJhY2siKTsKKyAgICAgICAgICAgIHNucHJpbnRmKGppdEFkZHIsIGppdEFkZHJT aXplLCAiZmFsbGJhY2siKTsKICAgICAgICAgZWxzZQotICAgICAgICAgICAgc3ByaW50ZihqaXRB ZGRyLCAiMHglMDE0bHgiLCByZWludGVycHJldF9jYXN0PHVuc2lnbmVkIGxvbmcgaW50Pihjb2Rl QmxvY2suZ2V0QWRkcigpKSk7CisgICAgICAgICAgICBzbnByaW50ZihqaXRBZGRyLCBqaXRBZGRy U2l6ZSwgIjB4JTAxNGx4IiwgcmVpbnRlcnByZXRfY2FzdDx1bnNpZ25lZCBsb25nIGludD4oY29k ZUJsb2NrLmdldEFkZHIoKSkpOwogI2Vsc2UKICAgICAgICAgY29uc3QgY2hhciogaml0QWRkciA9 ICJKSVQgT2ZmIjsKICNlbmRpZgpJbmRleDogQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIENoYW5n ZUxvZwkocmV2aXNpb24gNzcwNjApCisrKyBDaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEs MyArMSwxMyBAQAorMjAxMS0wMS0yOSAgQ2FtZXJvbiBad2FyaWNoICA8endhcmljaEBhcHBsZS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQnVn IDUzMzc0IC0gUmVtb3ZlIHVzZXMgb2YgdW5zYWZlIHN0cmluZyBmdW5jdGlvbnMgaW4gZGVidWdn aW5nIGNvZGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTUzMzc0CisKKyAgICAgICAgKiBydW50aW1lL1JlZ0V4cC5jcHA6CisgICAgICAgIChKU0M6OlJl Z0V4cDo6cHJpbnRUcmFjZURhdGEpOgorCiAyMDExLTAxLTI4ICBTaW1vbiBGcmFzZXIgIDxzaW1v bi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEdhdmluIEJhcnJhY2xv dWdoLgo=