<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>53368</bug_id>
          
          <creation_ts>2011-01-28 23:21:09 -0800</creation_ts>
          <short_desc>Fix XSSFilter crash when extracting the source for a token twice</short_desc>
          <delta_ts>2011-01-29 18:40:04 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>49845</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Adam Barth">abarth</reporter>
          <assigned_to name="Adam Barth">abarth</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>dbates</cc>
    
    <cc>eric</cc>
    
    <cc>sam</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>342011</commentid>
    <comment_count>0</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-01-28 23:21:09 -0800</bug_when>
    <thetext>Fix XSSFilter crash when extracting the source for a token twice</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>342014</commentid>
    <comment_count>1</comment_count>
      <attachid>80551</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-01-28 23:30:25 -0800</bug_when>
    <thetext>Created attachment 80551
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>342015</commentid>
    <comment_count>2</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-01-28 23:31:27 -0800</bug_when>
    <thetext>BTW, after this patch, we pass all the xssAuditor/script-tag* tests!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>342158</commentid>
    <comment_count>3</comment_count>
      <attachid>80551</attachid>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2011-01-29 15:27:12 -0800</bug_when>
    <thetext>Comment on attachment 80551
Patch

This looks sane to me.

r=me.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>342159</commentid>
    <comment_count>4</comment_count>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2011-01-29 15:27:31 -0800</bug_when>
    <thetext>(In reply to comment #2)
&gt; BTW, after this patch, we pass all the xssAuditor/script-tag* tests!

Awesome!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>342172</commentid>
    <comment_count>5</comment_count>
      <attachid>80551</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-01-29 17:21:27 -0800</bug_when>
    <thetext>Comment on attachment 80551
Patch

Thanks Dan!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>342185</commentid>
    <comment_count>6</comment_count>
      <attachid>80551</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-01-29 18:40:00 -0800</bug_when>
    <thetext>Comment on attachment 80551
Patch

Clearing flags on attachment: 80551

Committed r77076: &lt;http://trac.webkit.org/changeset/77076&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>342186</commentid>
    <comment_count>7</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-01-29 18:40:04 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>80551</attachid>
            <date>2011-01-28 23:30:25 -0800</date>
            <delta_ts>2011-01-29 18:40:00 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-53368-20110128233024.patch</filename>
            <type>text/plain</type>
            <size>3026</size>
            <attacher name="Adam Barth">abarth</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCBjZmI1NTQwODRmZWQyNDBkMWYyY2ZhMTAzZDlkZTUwNGQ1YmI3NjQyLi4x
OWRmYzhiNmZmNzUyYmMyOTE1ZWI1Nzk0MmQwMzUxN2Q1NDM3MjNhIDEwMDY0NAotLS0gYS9Tb3Vy
Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0y
LDYgKzIsMjMgQEAKIAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KIAorICAg
ICAgICBGaXggWFNTRmlsdGVyIGNyYXNoIHdoZW4gZXh0cmFjdGluZyB0aGUgc291cmNlIGZvciBh
IHRva2VuIHR3aWNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn
aT9pZD01MzM2OAorCisgICAgICAgIFByZXZpb3VzbHksIGl0IHdhcyB1bnNhZmUgdG8gZXh0cmFj
dCB0aGUgc291cmNlIGZvciB0aGUgc2FtZSB0b2tlbgorICAgICAgICB0d2ljZSBiZWNhdXNlIHRo
ZSBIVE1MU291cmNlVHJhY2tlciB3b3VsZCBhZHZhbmNlIGl0cyBpbnRlcm5hbAorICAgICAgICBy
ZXByZXNlbnRhdGlvbiBvZiB0aGUgU2VnbWVudGVkU3RyaW5nLiAgVGhpcyBwYXRjaCBpbnRyb2R1
Y2VzIGEgY2FjaGUKKyAgICAgICAgdG8gbWFrZSBjYWxsaW5nIEhUTUxTb3VyY2VUcmFja2VyOjpz
b3VyY2VGb3JUb2tlbiBtdWx0aXBsZSB0aW1lcyBzYWZlLgorCisgICAgICAgICogaHRtbC9wYXJz
ZXIvSFRNTFNvdXJjZVRyYWNrZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTFNvdXJjZVRy
YWNrZXI6OmVuZCk6CisgICAgICAgIChXZWJDb3JlOjpIVE1MU291cmNlVHJhY2tlcjo6c291cmNl
Rm9yVG9rZW4pOgorICAgICAgICAqIGh0bWwvcGFyc2VyL0hUTUxTb3VyY2VUcmFja2VyLmg6CisK
KzIwMTEtMDEtMjggIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBS
ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwogICAgICAgICBYU1NGaWx0ZXIgc2hvdWxkIHBh
c3MgeHNzQXVkaXRvci9zY3JpcHQtdGFnLWFkZHNsYXNoZXMqCiAgICAgICAgIGh0dHBzOi8vYnVn
cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MzM2NQogCmRpZmYgLS1naXQgYS9Tb3VyY2Uv
V2ViQ29yZS9odG1sL3BhcnNlci9IVE1MU291cmNlVHJhY2tlci5jcHAgYi9Tb3VyY2UvV2ViQ29y
ZS9odG1sL3BhcnNlci9IVE1MU291cmNlVHJhY2tlci5jcHAKaW5kZXggOWQ4MzI4ZjIzOWMxYjc5
NDg2YjY3MTI4Y2MxZGFhOGVmNTk0Y2I0Yy4uY2Y0MzEwNWQzOTIxYTYyMjY1ZDZhMmE5ZjdhN2Fm
MGVlNTFiNTVlYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTFNv
dXJjZVRyYWNrZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvcGFyc2VyL0hUTUxTb3Vy
Y2VUcmFja2VyLmNwcApAQCAtNDEsNiArNDEsNyBAQCB2b2lkIEhUTUxTb3VyY2VUcmFja2VyOjpz
dGFydChjb25zdCBIVE1MSW5wdXRTdHJlYW0mIGlucHV0LCBIVE1MVG9rZW4mIHRva2VuKQogCiB2
b2lkIEhUTUxTb3VyY2VUcmFja2VyOjplbmQoY29uc3QgSFRNTElucHV0U3RyZWFtJiBpbnB1dCwg
SFRNTFRva2VuJiB0b2tlbikKIHsKKyAgICBtX2NhY2hlZFNvdXJjZUZvclRva2VuID0gU3RyaW5n
KCk7CiAgICAgLy8gRklYTUU6IFRoaXMgd29yayBzaG91bGQgcmVhbGx5IGJlIGRvbmUgYnkgdGhl
IEhUTUxUb2tlbml6ZXIuCiAgICAgdG9rZW4uZW5kKGlucHV0LmN1cnJlbnQoKS5udW1iZXJPZkNo
YXJhY3RlcnNDb25zdW1lZCgpKTsKIH0KQEAgLTUwLDYgKzUxLDkgQEAgU3RyaW5nIEhUTUxTb3Vy
Y2VUcmFja2VyOjpzb3VyY2VGb3JUb2tlbihjb25zdCBIVE1MVG9rZW4mIHRva2VuKQogICAgIGlm
ICh0b2tlbi50eXBlKCkgPT0gSFRNTFRva2VuOjpFbmRPZkZpbGUpCiAgICAgICAgIHJldHVybiBT
dHJpbmcoKTsgLy8gSGlkZXMgdGhlIG51bGwgY2hhcmFjdGVyIHdlIHVzZSB0byBtYXJrIHRoZSBl
bmQgb2YgZmlsZS4KIAorICAgIGlmICghbV9jYWNoZWRTb3VyY2VGb3JUb2tlbi5pc0VtcHR5KCkp
CisgICAgICAgIHJldHVybiBtX2NhY2hlZFNvdXJjZUZvclRva2VuOworCiAgICAgQVNTRVJUKCF0
b2tlbi5zdGFydEluZGV4KCkpOwogICAgIFVDaGFyKiBkYXRhID0gMDsKICAgICBpbnQgbGVuZ3Ro
ID0gdG9rZW4uZW5kSW5kZXgoKSAtIHRva2VuLnN0YXJ0SW5kZXgoKSAtIG1fc291cmNlRnJvbVBy
ZXZpb3VzU2VnbWVudHMubGVuZ3RoKCk7CkBAIC01OCw3ICs2Miw4IEBAIFN0cmluZyBIVE1MU291
cmNlVHJhY2tlcjo6c291cmNlRm9yVG9rZW4oY29uc3QgSFRNTFRva2VuJiB0b2tlbikKICAgICAg
ICAgZGF0YVtpXSA9ICptX3NvdXJjZTsKICAgICAgICAgbV9zb3VyY2UuYWR2YW5jZSgpOwogICAg
IH0KLSAgICByZXR1cm4gbV9zb3VyY2VGcm9tUHJldmlvdXNTZWdtZW50cyArIHNvdXJjZTsKKyAg
ICBtX2NhY2hlZFNvdXJjZUZvclRva2VuID0gbV9zb3VyY2VGcm9tUHJldmlvdXNTZWdtZW50cyAr
IHNvdXJjZTsKKyAgICByZXR1cm4gbV9jYWNoZWRTb3VyY2VGb3JUb2tlbjsKIH0KIAogfQpkaWZm
IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTFNvdXJjZVRyYWNrZXIuaCBi
L1NvdXJjZS9XZWJDb3JlL2h0bWwvcGFyc2VyL0hUTUxTb3VyY2VUcmFja2VyLmgKaW5kZXggZGYz
MjJiOTg0YmU2ZDc5YTgwM2NhNDUyNWExYTYwNzczYjk3ZGJjMS4uMTdhZTE5MWU5NDc5ZGQ2NDQy
YWRjYWU5OWVlODI5MWNkMjMxNTdkOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9w
YXJzZXIvSFRNTFNvdXJjZVRyYWNrZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNl
ci9IVE1MU291cmNlVHJhY2tlci5oCkBAIC00Nyw2ICs0Nyw3IEBAIHB1YmxpYzoKIHByaXZhdGU6
CiAgICAgU3RyaW5nIG1fc291cmNlRnJvbVByZXZpb3VzU2VnbWVudHM7CiAgICAgU2VnbWVudGVk
U3RyaW5nIG1fc291cmNlOworICAgIFN0cmluZyBtX2NhY2hlZFNvdXJjZUZvclRva2VuOwogfTsK
IAogfQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>