53318 2011-01-28 11:58:11 -0800 Remove dead code that tried to map from CSS values to parser values 2011-01-28 12:48:05 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 koivisto webkit-unassigned abarth eric webkit.review.bot oldest_to_newest 341596 0 koivisto 2011-01-28 11:58:11 -0800 CSSValue::parserValue() and related are dead code. 341605 1 80476 koivisto 2011-01-28 12:02:29 -0800 Created attachment 80476 patch 341626 2 koivisto 2011-01-28 12:18:18 -0800 http://trac.webkit.org/changeset/76966 341660 3 webkit.review.bot 2011-01-28 12:48:05 -0800 http://trac.webkit.org/changeset/76966 might have broken Chromium Win Release 80476 2011-01-28 12:02:29 -0800 2011-01-28 12:10:51 -0800 patch parser-value-dead-code.patch text/plain 7254 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc2OTU0KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDEtMjggIEFudHRpIEtv aXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFJlbW92ZSBkZWFkIGNvZGUgdGhhdCB0cmllZCB0byBtYXAgZnJv bSBDU1MgdmFsdWVzIHRvIHBhcnNlciB2YWx1ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTUzMzE4CisKKyAgICAgICAgKiBjc3MvQ1NTRnVuY3Rpb25W YWx1ZS5jcHA6CisgICAgICAgICogY3NzL0NTU0Z1bmN0aW9uVmFsdWUuaDoKKyAgICAgICAgKiBj c3MvQ1NTUHJpbWl0aXZlVmFsdWUuY3BwOgorICAgICAgICAqIGNzcy9DU1NQcmltaXRpdmVWYWx1 ZS5oOgorICAgICAgICAqIGNzcy9DU1NWYWx1ZS5oOgorICAgICAgICAqIGNzcy9DU1NWYWx1ZUxp c3QuY3BwOgorICAgICAgICAqIGNzcy9DU1NWYWx1ZUxpc3QuaDoKKwogMjAxMS0wMS0yOCAgRGFu IEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFuZGVy cyBDYXJsc3Nvbi4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NGdW5jdGlvblZhbHVlLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9jc3MvQ1NTRnVuY3Rpb25WYWx1ZS5jcHAJ KHJldmlzaW9uIDc2OTU0KQorKysgU291cmNlL1dlYkNvcmUvY3NzL0NTU0Z1bmN0aW9uVmFsdWUu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNiw2ICsyNiw3IEBACiAjaW5jbHVkZSAiY29uZmlnLmgi CiAjaW5jbHVkZSAiQ1NTRnVuY3Rpb25WYWx1ZS5oIgogCisjaW5jbHVkZSAiQ1NTUGFyc2VyVmFs dWVzLmgiCiAjaW5jbHVkZSAiQ1NTVmFsdWVMaXN0LmgiCiAjaW5jbHVkZSA8d3RmL1Bhc3NPd25Q dHIuaD4KIApAQCAtNTEsMTggKzUyLDQgQEAgU3RyaW5nIENTU0Z1bmN0aW9uVmFsdWU6OmNzc1Rl eHQoKSBjb25zdAogICAgIHJldHVybiByZXN1bHQ7CiB9CiAKLUNTU1BhcnNlclZhbHVlIENTU0Z1 bmN0aW9uVmFsdWU6OnBhcnNlclZhbHVlKCkgY29uc3QKLXsKLSAgICBDU1NQYXJzZXJWYWx1ZSB2 YWw7Ci0gICAgdmFsLmlkID0gMDsKLSAgICB2YWwuaXNJbnQgPSBmYWxzZTsKLSAgICB2YWwudW5p dCA9IENTU1BhcnNlclZhbHVlOjpGdW5jdGlvbjsKLSAgICB2YWwuZnVuY3Rpb24gPSBuZXcgQ1NT UGFyc2VyRnVuY3Rpb247Ci0gICAgdmFsLmZ1bmN0aW9uLT5uYW1lLmNoYXJhY3RlcnMgPSBjb25z dF9jYXN0PFVDaGFyKj4obV9uYW1lLmNoYXJhY3RlcnMoKSk7Ci0gICAgdmFsLmZ1bmN0aW9uLT5u YW1lLmxlbmd0aCA9IG1fbmFtZS5sZW5ndGgoKTsKLSAgICBpZiAobV9hcmdzKQotICAgICAgICB2 YWwuZnVuY3Rpb24tPmFyZ3MgPSBtX2FyZ3MtPmNyZWF0ZVBhcnNlclZhbHVlTGlzdCgpOwotICAg IHJldHVybiB2YWw7Ci19Ci0KIH0KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NGdW5jdGlv blZhbHVlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvY3NzL0NTU0Z1bmN0aW9uVmFs dWUuaAkocmV2aXNpb24gNzY5NTQpCisrKyBTb3VyY2UvV2ViQ29yZS9jc3MvQ1NTRnVuY3Rpb25W YWx1ZS5oCSh3b3JraW5nIGNvcHkpCkBAIC00NCw4ICs0NCw2IEBAIHB1YmxpYzoKICAgICAKICAg ICB2aXJ0dWFsIFN0cmluZyBjc3NUZXh0KCkgY29uc3Q7CiAKLSAgICB2aXJ0dWFsIENTU1BhcnNl clZhbHVlIHBhcnNlclZhbHVlKCkgY29uc3Q7Ci0KIHByaXZhdGU6CiAgICAgZXhwbGljaXQgQ1NT RnVuY3Rpb25WYWx1ZShDU1NQYXJzZXJGdW5jdGlvbiopOwogICAgIApJbmRleDogU291cmNlL1dl YkNvcmUvY3NzL0NTU1ByaW1pdGl2ZVZhbHVlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9jc3MvQ1NTUHJpbWl0aXZlVmFsdWUuY3BwCShyZXZpc2lvbiA3Njk1NCkKKysrIFNvdXJj ZS9XZWJDb3JlL2Nzcy9DU1NQcmltaXRpdmVWYWx1ZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTkx NCw4MSArOTE0LDYgQEAgU3RyaW5nIENTU1ByaW1pdGl2ZVZhbHVlOjpjc3NUZXh0KCkgY29ucwog ICAgIHJldHVybiB0ZXh0OwogfQogCi1DU1NQYXJzZXJWYWx1ZSBDU1NQcmltaXRpdmVWYWx1ZTo6 cGFyc2VyVmFsdWUoKSBjb25zdAotewotICAgIC8vIFdlIG9ubHkgaGF2ZSB0byBoYW5kbGUgYSBz dWJzZXQgb2YgdHlwZXMuCi0gICAgQ1NTUGFyc2VyVmFsdWUgdmFsdWU7Ci0gICAgdmFsdWUuaWQg PSAwOwotICAgIHZhbHVlLmlzSW50ID0gZmFsc2U7Ci0gICAgdmFsdWUudW5pdCA9IENTU1ByaW1p dGl2ZVZhbHVlOjpDU1NfSURFTlQ7Ci0gICAgc3dpdGNoIChtX3R5cGUpIHsKLSAgICAgICAgY2Fz ZSBDU1NfTlVNQkVSOgotICAgICAgICBjYXNlIENTU19QRVJDRU5UQUdFOgotICAgICAgICBjYXNl IENTU19FTVM6Ci0gICAgICAgIGNhc2UgQ1NTX0VYUzoKLSAgICAgICAgY2FzZSBDU1NfUkVNUzoK LSAgICAgICAgY2FzZSBDU1NfUFg6Ci0gICAgICAgIGNhc2UgQ1NTX0NNOgotICAgICAgICBjYXNl IENTU19NTToKLSAgICAgICAgY2FzZSBDU1NfSU46Ci0gICAgICAgIGNhc2UgQ1NTX1BUOgotICAg ICAgICBjYXNlIENTU19QQzoKLSAgICAgICAgY2FzZSBDU1NfREVHOgotICAgICAgICBjYXNlIENT U19SQUQ6Ci0gICAgICAgIGNhc2UgQ1NTX0dSQUQ6Ci0gICAgICAgIGNhc2UgQ1NTX01TOgotICAg ICAgICBjYXNlIENTU19TOgotICAgICAgICBjYXNlIENTU19IWjoKLSAgICAgICAgY2FzZSBDU1Nf S0haOgotICAgICAgICBjYXNlIENTU19ESU1FTlNJT046Ci0gICAgICAgIGNhc2UgQ1NTX1RVUk46 Ci0gICAgICAgICAgICB2YWx1ZS5mVmFsdWUgPSBtX3ZhbHVlLm51bTsKLSAgICAgICAgICAgIHZh bHVlLnVuaXQgPSBtX3R5cGU7Ci0gICAgICAgICAgICBicmVhazsKLSAgICAgICAgY2FzZSBDU1Nf U1RSSU5HOgotICAgICAgICBjYXNlIENTU19VUkk6Ci0gICAgICAgIGNhc2UgQ1NTX1BBUlNFUl9I RVhDT0xPUjoKLSAgICAgICAgICAgIHZhbHVlLnN0cmluZy5jaGFyYWN0ZXJzID0gY29uc3RfY2Fz dDxVQ2hhcio+KG1fdmFsdWUuc3RyaW5nLT5jaGFyYWN0ZXJzKCkpOwotICAgICAgICAgICAgdmFs dWUuc3RyaW5nLmxlbmd0aCA9IG1fdmFsdWUuc3RyaW5nLT5sZW5ndGgoKTsKLSAgICAgICAgICAg IHZhbHVlLnVuaXQgPSBtX3R5cGU7Ci0gICAgICAgICAgICBicmVhazsKLSAgICAgICAgY2FzZSBD U1NfSURFTlQ6IHsKLSAgICAgICAgICAgIHZhbHVlLmlkID0gbV92YWx1ZS5pZGVudDsKLSAgICAg ICAgICAgIGNvbnN0IEF0b21pY1N0cmluZyYgbmFtZSA9IHZhbHVlT3JQcm9wZXJ0eU5hbWUobV92 YWx1ZS5pZGVudCk7Ci0gICAgICAgICAgICB2YWx1ZS5zdHJpbmcuY2hhcmFjdGVycyA9IGNvbnN0 X2Nhc3Q8VUNoYXIqPihuYW1lLmNoYXJhY3RlcnMoKSk7Ci0gICAgICAgICAgICB2YWx1ZS5zdHJp bmcubGVuZ3RoID0gbmFtZS5sZW5ndGgoKTsKLSAgICAgICAgICAgIGJyZWFrOwotICAgICAgICB9 Ci0gICAgICAgIGNhc2UgQ1NTX1BBUlNFUl9PUEVSQVRPUjoKLSAgICAgICAgICAgIHZhbHVlLmlW YWx1ZSA9IG1fdmFsdWUuaWRlbnQ7Ci0gICAgICAgICAgICB2YWx1ZS51bml0ID0gQ1NTUGFyc2Vy VmFsdWU6Ok9wZXJhdG9yOwotICAgICAgICAgICAgYnJlYWs7Ci0gICAgICAgIGNhc2UgQ1NTX1BB UlNFUl9JTlRFR0VSOgotICAgICAgICAgICAgdmFsdWUuZlZhbHVlID0gbV92YWx1ZS5udW07Ci0g ICAgICAgICAgICB2YWx1ZS51bml0ID0gQ1NTUHJpbWl0aXZlVmFsdWU6OkNTU19OVU1CRVI7Ci0g ICAgICAgICAgICB2YWx1ZS5pc0ludCA9IHRydWU7Ci0gICAgICAgICAgICBicmVhazsKLSAgICAg ICAgY2FzZSBDU1NfUEFSU0VSX0lERU5USUZJRVI6Ci0gICAgICAgICAgICB2YWx1ZS5zdHJpbmcu Y2hhcmFjdGVycyA9IGNvbnN0X2Nhc3Q8VUNoYXIqPihtX3ZhbHVlLnN0cmluZy0+Y2hhcmFjdGVy cygpKTsKLSAgICAgICAgICAgIHZhbHVlLnN0cmluZy5sZW5ndGggPSBtX3ZhbHVlLnN0cmluZy0+ bGVuZ3RoKCk7Ci0gICAgICAgICAgICB2YWx1ZS51bml0ID0gQ1NTUHJpbWl0aXZlVmFsdWU6OkNT U19JREVOVDsKLSAgICAgICAgICAgIGJyZWFrOwotICAgICAgICBjYXNlIENTU19VTktOT1dOOgot ICAgICAgICBjYXNlIENTU19BVFRSOgotICAgICAgICBjYXNlIENTU19DT1VOVEVSOgotICAgICAg ICBjYXNlIENTU19SRUNUOgotICAgICAgICBjYXNlIENTU19SR0JDT0xPUjoKLSAgICAgICAgY2Fz ZSBDU1NfUEFJUjoKLSNpZiBFTkFCTEUoREFTSEJPQVJEX1NVUFBPUlQpCi0gICAgICAgIGNhc2Ug Q1NTX0RBU0hCT0FSRF9SRUdJT046Ci0jZW5kaWYKLSAgICAgICAgICAgIEFTU0VSVF9OT1RfUkVB Q0hFRCgpOwotICAgICAgICAgICAgYnJlYWs7Ci0gICAgfQotICAgIAotICAgIHJldHVybiB2YWx1 ZTsKLX0KLQogdm9pZCBDU1NQcmltaXRpdmVWYWx1ZTo6YWRkU3VicmVzb3VyY2VTdHlsZVVSTHMo TGlzdEhhc2hTZXQ8S1VSTD4mIHVybHMsIGNvbnN0IENTU1N0eWxlU2hlZXQqIHN0eWxlU2hlZXQp CiB7CiAgICAgaWYgKG1fdHlwZSA9PSBDU1NfVVJJKQpJbmRleDogU291cmNlL1dlYkNvcmUvY3Nz L0NTU1ByaW1pdGl2ZVZhbHVlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvY3NzL0NT U1ByaW1pdGl2ZVZhbHVlLmgJKHJldmlzaW9uIDc2OTU0KQorKysgU291cmNlL1dlYkNvcmUvY3Nz L0NTU1ByaW1pdGl2ZVZhbHVlLmgJKHdvcmtpbmcgY29weSkKQEAgLTE4NSw4ICsxODUsNiBAQCBw dWJsaWM6CiAKICAgICB2aXJ0dWFsIGJvb2wgaXNRdWlya1ZhbHVlKCkgeyByZXR1cm4gZmFsc2U7 IH0KIAotICAgIHZpcnR1YWwgQ1NTUGFyc2VyVmFsdWUgcGFyc2VyVmFsdWUoKSBjb25zdDsKLQog ICAgIHZpcnR1YWwgdm9pZCBhZGRTdWJyZXNvdXJjZVN0eWxlVVJMcyhMaXN0SGFzaFNldDxLVVJM PiYsIGNvbnN0IENTU1N0eWxlU2hlZXQqKTsKIAogcHJvdGVjdGVkOgpJbmRleDogU291cmNlL1dl YkNvcmUvY3NzL0NTU1ZhbHVlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvY3NzL0NT U1ZhbHVlLmgJKHJldmlzaW9uIDc2OTU0KQorKysgU291cmNlL1dlYkNvcmUvY3NzL0NTU1ZhbHVl LmgJKHdvcmtpbmcgY29weSkKQEAgLTIxLDcgKzIxLDYgQEAKICNpZm5kZWYgQ1NTVmFsdWVfaAog I2RlZmluZSBDU1NWYWx1ZV9oCiAKLSNpbmNsdWRlICJDU1NQYXJzZXJWYWx1ZXMuaCIKICNpbmNs dWRlICJLVVJMSGFzaC5oIgogI2luY2x1ZGUgPHd0Zi9MaXN0SGFzaFNldC5oPgogI2luY2x1ZGUg PHd0Zi9SZWZQdHIuaD4KQEAgLTcwLDggKzY5LDYgQEAgcHVibGljOgogICAgIHZpcnR1YWwgYm9v bCBpc1NWR1BhaW50KCkgY29uc3QgeyByZXR1cm4gZmFsc2U7IH0KICNlbmRpZgogCi0gICAgdmly dHVhbCBDU1NQYXJzZXJWYWx1ZSBwYXJzZXJWYWx1ZSgpIGNvbnN0IHsgQVNTRVJUX05PVF9SRUFD SEVEKCk7IHJldHVybiBDU1NQYXJzZXJWYWx1ZSgpOyB9Ci0KICAgICB2aXJ0dWFsIHZvaWQgYWRk U3VicmVzb3VyY2VTdHlsZVVSTHMoTGlzdEhhc2hTZXQ8S1VSTD4mLCBjb25zdCBDU1NTdHlsZVNo ZWV0KikgeyB9CiB9OwogCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9jc3MvQ1NTVmFsdWVMaXN0LmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9jc3MvQ1NTVmFsdWVMaXN0LmNwcAkocmV2 aXNpb24gNzY5NTQpCisrKyBTb3VyY2UvV2ViQ29yZS9jc3MvQ1NTVmFsdWVMaXN0LmNwcAkod29y a2luZyBjb3B5KQpAQCAtMTIwLDE3ICsxMjAsNiBAQCBTdHJpbmcgQ1NTVmFsdWVMaXN0Ojpjc3NU ZXh0KCkgY29uc3QKICAgICByZXR1cm4gcmVzdWx0OwogfQogCi1QYXNzT3duUHRyPENTU1BhcnNl clZhbHVlTGlzdD4gQ1NTVmFsdWVMaXN0OjpjcmVhdGVQYXJzZXJWYWx1ZUxpc3QoKSBjb25zdAot ewotICAgIHNpemVfdCBzaXplID0gbV92YWx1ZXMuc2l6ZSgpOwotICAgIGlmICghc2l6ZSkKLSAg ICAgICAgcmV0dXJuIDA7Ci0gICAgT3duUHRyPENTU1BhcnNlclZhbHVlTGlzdD4gcmVzdWx0ID0g YWRvcHRQdHIobmV3IENTU1BhcnNlclZhbHVlTGlzdCk7Ci0gICAgZm9yIChzaXplX3QgaSA9IDA7 IGkgPCBzaXplOyArK2kpCi0gICAgICAgIHJlc3VsdC0+YWRkVmFsdWUobV92YWx1ZXNbaV0tPnBh cnNlclZhbHVlKCkpOwotICAgIHJldHVybiByZXN1bHQucmVsZWFzZSgpOwotfQotCiB2b2lkIENT U1ZhbHVlTGlzdDo6YWRkU3VicmVzb3VyY2VTdHlsZVVSTHMoTGlzdEhhc2hTZXQ8S1VSTD4mIHVy bHMsIGNvbnN0IENTU1N0eWxlU2hlZXQqIHN0eWxlU2hlZXQpCiB7CiAgICAgc2l6ZV90IHNpemUg PSBtX3ZhbHVlcy5zaXplKCk7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9jc3MvQ1NTVmFsdWVMaXN0 LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvY3NzL0NTU1ZhbHVlTGlzdC5oCShyZXZp c2lvbiA3Njk1NCkKKysrIFNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NWYWx1ZUxpc3QuaAkod29ya2lu ZyBjb3B5KQpAQCAtNTgsOCArNTgsNiBAQCBwdWJsaWM6CiAKICAgICB2aXJ0dWFsIFN0cmluZyBj c3NUZXh0KCkgY29uc3Q7CiAKLSAgICBQYXNzT3duUHRyPENTU1BhcnNlclZhbHVlTGlzdD4gY3Jl YXRlUGFyc2VyVmFsdWVMaXN0KCkgY29uc3Q7Ci0KICAgICB2aXJ0dWFsIHZvaWQgYWRkU3VicmVz b3VyY2VTdHlsZVVSTHMoTGlzdEhhc2hTZXQ8S1VSTD4mLCBjb25zdCBDU1NTdHlsZVNoZWV0Kik7 CiAKIHByb3RlY3RlZDoK