53309 2011-01-28 09:56:27 -0800 Web Inspector: "Clear CPU profiles" button title is too specific having multiple profile types. 2011-01-31 02:45:29 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 mnaganov webkit-unassigned apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 341493 0 mnaganov 2011-01-28 09:56:27 -0800 As besides CPU profiles there can be heap profiles, the name of the button: "Clear CPU profiles" is misleading. My proposal is to change the text to "Clear all profiles". 341495 1 80461 mnaganov 2011-01-28 10:01:07 -0800 Created attachment 80461 patch 341507 2 80461 yurys 2011-01-28 10:22:40 -0800 Comment on attachment 80461 patch View in context: https://bugs.webkit.org/attachment.cgi?id=80461&action=review > Source/WebCore/ChangeLog:10 > + * inspector/front-end/ProfilesPanel.js: You seem to have missed the changes. 341509 3 80463 mnaganov 2011-01-28 10:23:41 -0800 Created attachment 80463 now full diff 342512 4 mnaganov 2011-01-31 02:45:29 -0800 Manually committed http://trac.webkit.org/changeset/77116 2011-01-31 Mikhail Naganov <mnaganov@chromium.org> Reviewed by Yury Semikhatsky. WebInspector: Change button title from "Clear CPU profiles" to "Clear all profiles". https://bugs.webkit.org/show_bug.cgi?id=53309 * English.lproj/localizedStrings.js: * inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel): 80461 2011-01-28 10:01:07 -0800 2011-01-28 10:23:41 -0800 patch patch-53309 text/plain 648 mnaganov ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1NjNjOWM5Li5lYzY1M2JkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTEtMDEtMjggIE1pa2hhaWwgTmFnYW5vdiAgPG1uYWdhbm92QGNocm9taXVtLm9yZz4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWJJbnNw ZWN0b3I6IENoYW5nZSBidXR0b24gdGl0bGUgZnJvbSAiQ2xlYXIgQ1BVIHByb2ZpbGVzIiB0byAi Q2xlYXIgYWxsIHByb2ZpbGVzIi4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NTMzMDkKKworICAgICAgICAqIEVuZ2xpc2gubHByb2ovbG9jYWxpemVk U3RyaW5ncy5qczoKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL1Byb2ZpbGVzUGFuZWwu anM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuUHJvZmlsZXNQYW5lbCk6CisKIDIwMTEtMDEtMjcg IERpbWl0cmkgR2xhemtvdiAgPGRnbGF6a292QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZp ZXdlZCBieSBLZW50IFRhbXVyYS4K 80463 2011-01-28 10:23:41 -0800 2011-01-31 02:27:50 -0800 now full diff patch-53309 text/plain 1991 mnaganov ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1NjNjOWM5Li5lYzY1M2JkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTEtMDEtMjggIE1pa2hhaWwgTmFnYW5vdiAgPG1uYWdhbm92QGNocm9taXVtLm9yZz4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWJJbnNw ZWN0b3I6IENoYW5nZSBidXR0b24gdGl0bGUgZnJvbSAiQ2xlYXIgQ1BVIHByb2ZpbGVzIiB0byAi Q2xlYXIgYWxsIHByb2ZpbGVzIi4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NTMzMDkKKworICAgICAgICAqIEVuZ2xpc2gubHByb2ovbG9jYWxpemVk U3RyaW5ncy5qczoKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL1Byb2ZpbGVzUGFuZWwu anM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuUHJvZmlsZXNQYW5lbCk6CisKIDIwMTEtMDEtMjcg IERpbWl0cmkgR2xhemtvdiAgPGRnbGF6a292QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZp ZXdlZCBieSBLZW50IFRhbXVyYS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0VuZ2xpc2gu bHByb2ovbG9jYWxpemVkU3RyaW5ncy5qcyBiL1NvdXJjZS9XZWJDb3JlL0VuZ2xpc2gubHByb2ov bG9jYWxpemVkU3RyaW5ncy5qcwppbmRleCAwZDZiYzNjZTA3NDBkOWExZjE1MmQ3ZWZmYzNhNjQy NmZhMzQyY2VmLi43YWVjYmI2YjFlYjUzODM2YTE1NjIzOGZkNWRhYzQ2NWFjNDA1ODdhIDEwMDY0 NApHSVQgYmluYXJ5IHBhdGNoCmRlbHRhIDQwCnRjbWJRISZwZkF9ZDRyb09ZYSZBcUwoYiR7UnFA SFFyZ0JaKnJfUk4kenlLRThUJnBVLTJtbFlPNDh7TmUKCmRlbHRhIDQwCnRjbWJRISZwZkF9ZDRy b090MjA5WUwrSXBNUnFASFFyZ0JaKnJfUk4kenlLRThUJnBVLTJta350Mz91Km0KCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Byb2ZpbGVzUGFuZWwuanMg Yi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Byb2ZpbGVzUGFuZWwuanMKaW5k ZXggMTc2ZGRiMi4uNjUzNzYwYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y L2Zyb250LWVuZC9Qcm9maWxlc1BhbmVsLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvUHJvZmlsZXNQYW5lbC5qcwpAQCAtMTEyLDcgKzExMiw3IEBAIFdlYkluc3Bl Y3Rvci5Qcm9maWxlc1BhbmVsID0gZnVuY3Rpb24oKQogICAgIHRoaXMuZW5hYmxlVG9nZ2xlQnV0 dG9uID0gbmV3IFdlYkluc3BlY3Rvci5TdGF0dXNCYXJCdXR0b24oIiIsICJlbmFibGUtdG9nZ2xl LXN0YXR1cy1iYXItaXRlbSIpOwogICAgIHRoaXMuZW5hYmxlVG9nZ2xlQnV0dG9uLmFkZEV2ZW50 TGlzdGVuZXIoImNsaWNrIiwgdGhpcy5fdG9nZ2xlUHJvZmlsaW5nLmJpbmQodGhpcyksIGZhbHNl KTsKIAotICAgIHRoaXMuY2xlYXJSZXN1bHRzQnV0dG9uID0gbmV3IFdlYkluc3BlY3Rvci5TdGF0 dXNCYXJCdXR0b24oV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJDbGVhciBDUFUgcHJvZmlsZXMuIiks ICJjbGVhci1zdGF0dXMtYmFyLWl0ZW0iKTsKKyAgICB0aGlzLmNsZWFyUmVzdWx0c0J1dHRvbiA9 IG5ldyBXZWJJbnNwZWN0b3IuU3RhdHVzQmFyQnV0dG9uKFdlYkluc3BlY3Rvci5VSVN0cmluZygi Q2xlYXIgYWxsIHByb2ZpbGVzLiIpLCAiY2xlYXItc3RhdHVzLWJhci1pdGVtIik7CiAgICAgdGhp cy5jbGVhclJlc3VsdHNCdXR0b24uYWRkRXZlbnRMaXN0ZW5lcigiY2xpY2siLCB0aGlzLl9jbGVh clByb2ZpbGVzLmJpbmQodGhpcyksIGZhbHNlKTsKIAogICAgIHRoaXMucHJvZmlsZVZpZXdTdGF0 dXNCYXJJdGVtc0NvbnRhaW5lciA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImRpdiIpOwo=