53303 2011-01-28 08:30:31 -0800 Web Inspector: allow remote debugging with front-end served from the cloud. 2011-01-28 08:57:08 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pfeldman pfeldman apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 341449 0 pfeldman 2011-01-28 08:30:31 -0800 Sometimes we don't want to serve front-end from the browser. Make it possible. Patch to follow. 341458 1 80453 pfeldman 2011-01-28 08:36:32 -0800 Created attachment 80453 [PATCH] Proposed change. 341461 2 80453 yurys 2011-01-28 08:40:17 -0800 Comment on attachment 80453 [PATCH] Proposed change. View in context: https://bugs.webkit.org/attachment.cgi?id=80453&action=review > Source/WebCore/inspector/front-end/inspector.js:482 > + if (WebInspector.socket) { Did you mean !WebInspector.socket 341462 3 80454 pfeldman 2011-01-28 08:41:05 -0800 Created attachment 80454 [PATCH] A better patch. 341466 4 80454 yurys 2011-01-28 08:44:47 -0800 Comment on attachment 80454 [PATCH] A better patch. View in context: https://bugs.webkit.org/attachment.cgi?id=80454&action=review > Source/WebCore/inspector/front-end/inspector.js:479 > + else if ("page" in WebInspector.queryParamsObject) Could you factor out if ("page" in WebInspector.queryParamsObject) in an outer if block? 341471 5 pfeldman 2011-01-28 08:57:08 -0800 Ok, ok, no hurry anymore. Landed beautified. Committing to http://svn.webkit.org/repository/webkit/trunk ... M Source/WebCore/ChangeLog M Source/WebCore/inspector/front-end/inspector.js Committed r76947 80453 2011-01-28 08:36:32 -0800 2011-01-28 08:41:05 -0800 [PATCH] Proposed change. cloud_remote text/plain 1741 pfeldman ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBiNjU5MjcwLi5lNDI5YWFhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTEtMDEtMjggIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViIEluc3Bl Y3RvcjogYWxsb3cgcmVtb3RlIGRlYnVnZ2luZyB3aXRoIGZyb250LWVuZAorICAgICAgICBzZXJ2 ZWQgZnJvbSB0aGUgY2xvdWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD01MzMwMworCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0 b3IuanM6CisKIDIwMTEtMDEtMjYgIEFuZHJleSBLb3N5YWtvdiAgPGNhc2VxQGNocm9taXVtLm9y Zz4KIAogICAgICAgICBSZXZpZXdlZCBieSBQYXZlbCBGZWxkbWFuLgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0b3IuanMgYi9Tb3VyY2UvV2Vi Q29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5qcwppbmRleCAwZmE0MjA5Li5jOTA2 YjYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3Bl Y3Rvci5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rv ci5qcwpAQCAtNDc0LDcgKzQ3NCwxMiBAQCBXZWJJbnNwZWN0b3IuUGxhdGZvcm1GbGF2b3IgPSB7 CiAKIFdlYkluc3BlY3Rvci5sb2FkZWQgPSBmdW5jdGlvbigpCiB7Ci0gICAgaWYgKCJwYWdlIiBp biBXZWJJbnNwZWN0b3IucXVlcnlQYXJhbXNPYmplY3QpIHsKKyAgICBpZiAoImhvc3QiIGluIFdl Ykluc3BlY3Rvci5xdWVyeVBhcmFtc09iamVjdCAmJiAicGFnZSIgaW4gV2ViSW5zcGVjdG9yLnF1 ZXJ5UGFyYW1zT2JqZWN0KQorICAgICAgICBXZWJJbnNwZWN0b3Iuc29ja2V0ID0gbmV3IFdlYlNv Y2tldCgid3M6Ly8iICsgV2ViSW5zcGVjdG9yLnF1ZXJ5UGFyYW1zT2JqZWN0Lmhvc3QgKyAiL2Rl dnRvb2xzL3BhZ2UvIiArIFdlYkluc3BlY3Rvci5xdWVyeVBhcmFtc09iamVjdC5wYWdlKTsKKyAg ICBlbHNlIGlmICgicGFnZSIgaW4gV2ViSW5zcGVjdG9yLnF1ZXJ5UGFyYW1zT2JqZWN0KQorICAg ICAgICBXZWJJbnNwZWN0b3Iuc29ja2V0ID0gbmV3IFdlYlNvY2tldCgid3M6Ly8iICsgd2luZG93 LmxvY2F0aW9uLmhvc3QgKyAiL2RldnRvb2xzL3BhZ2UvIiArIFdlYkluc3BlY3Rvci5xdWVyeVBh cmFtc09iamVjdC5wYWdlKTsKKworICAgIGlmIChXZWJJbnNwZWN0b3Iuc29ja2V0KSB7CiAgICAg ICAgIFdlYkluc3BlY3Rvci5zb2NrZXQgPSBuZXcgV2ViU29ja2V0KCJ3czovLyIgKyB3aW5kb3cu bG9jYXRpb24uaG9zdCArICIvZGV2dG9vbHMvcGFnZS8iICsgV2ViSW5zcGVjdG9yLnF1ZXJ5UGFy YW1zT2JqZWN0LnBhZ2UpOwogICAgICAgICBXZWJJbnNwZWN0b3Iuc29ja2V0Lm9ubWVzc2FnZSA9 IGZ1bmN0aW9uKG1lc3NhZ2UpIHsgSW5zcGVjdG9yQmFja2VuZC5kaXNwYXRjaChtZXNzYWdlLmRh dGEpOyB9CiAgICAgICAgIFdlYkluc3BlY3Rvci5zb2NrZXQub25lcnJvciA9IGZ1bmN0aW9uKGVy cm9yKSB7IGNvbnNvbGUuZXJyb3IoZXJyb3IpOyB9Cg== 80454 2011-01-28 08:41:05 -0800 2011-01-28 08:44:47 -0800 [PATCH] A better patch. cloud_remote text/plain 1656 pfeldman ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBiNjU5MjcwLi5lNDI5YWFhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTEtMDEtMjggIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViIEluc3Bl Y3RvcjogYWxsb3cgcmVtb3RlIGRlYnVnZ2luZyB3aXRoIGZyb250LWVuZAorICAgICAgICBzZXJ2 ZWQgZnJvbSB0aGUgY2xvdWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD01MzMwMworCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0 b3IuanM6CisKIDIwMTEtMDEtMjYgIEFuZHJleSBLb3N5YWtvdiAgPGNhc2VxQGNocm9taXVtLm9y Zz4KIAogICAgICAgICBSZXZpZXdlZCBieSBQYXZlbCBGZWxkbWFuLgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0b3IuanMgYi9Tb3VyY2UvV2Vi Q29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5qcwppbmRleCAwZmE0MjA5Li45OWMx ZGQ2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3Bl Y3Rvci5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rv ci5qcwpAQCAtNDc0LDggKzQ3NCwxMiBAQCBXZWJJbnNwZWN0b3IuUGxhdGZvcm1GbGF2b3IgPSB7 CiAKIFdlYkluc3BlY3Rvci5sb2FkZWQgPSBmdW5jdGlvbigpCiB7Ci0gICAgaWYgKCJwYWdlIiBp biBXZWJJbnNwZWN0b3IucXVlcnlQYXJhbXNPYmplY3QpIHsKKyAgICBpZiAoImhvc3QiIGluIFdl Ykluc3BlY3Rvci5xdWVyeVBhcmFtc09iamVjdCAmJiAicGFnZSIgaW4gV2ViSW5zcGVjdG9yLnF1 ZXJ5UGFyYW1zT2JqZWN0KQorICAgICAgICBXZWJJbnNwZWN0b3Iuc29ja2V0ID0gbmV3IFdlYlNv Y2tldCgid3M6Ly8iICsgV2ViSW5zcGVjdG9yLnF1ZXJ5UGFyYW1zT2JqZWN0Lmhvc3QgKyAiL2Rl dnRvb2xzL3BhZ2UvIiArIFdlYkluc3BlY3Rvci5xdWVyeVBhcmFtc09iamVjdC5wYWdlKTsKKyAg ICBlbHNlIGlmICgicGFnZSIgaW4gV2ViSW5zcGVjdG9yLnF1ZXJ5UGFyYW1zT2JqZWN0KQogICAg ICAgICBXZWJJbnNwZWN0b3Iuc29ja2V0ID0gbmV3IFdlYlNvY2tldCgid3M6Ly8iICsgd2luZG93 LmxvY2F0aW9uLmhvc3QgKyAiL2RldnRvb2xzL3BhZ2UvIiArIFdlYkluc3BlY3Rvci5xdWVyeVBh cmFtc09iamVjdC5wYWdlKTsKKworICAgIGlmIChXZWJJbnNwZWN0b3Iuc29ja2V0KSB7CiAgICAg ICAgIFdlYkluc3BlY3Rvci5zb2NrZXQub25tZXNzYWdlID0gZnVuY3Rpb24obWVzc2FnZSkgeyBJ bnNwZWN0b3JCYWNrZW5kLmRpc3BhdGNoKG1lc3NhZ2UuZGF0YSk7IH0KICAgICAgICAgV2ViSW5z cGVjdG9yLnNvY2tldC5vbmVycm9yID0gZnVuY3Rpb24oZXJyb3IpIHsgY29uc29sZS5lcnJvcihl cnJvcik7IH0KICAgICAgICAgV2ViSW5zcGVjdG9yLnNvY2tldC5vbm9wZW4gPSBmdW5jdGlvbigp IHsK