53295 2011-01-28 04:15:03 -0800 Web Inspector: [STYLES] Up/Down-suggestion breaks an existing keyword 2011-01-28 07:08:03 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 apavlov apavlov apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 341396 0 apavlov 2011-01-28 04:15:03 -0800 1. Create a property, "border: 1px solid" 2. Start editing the value, place the caret after "s" (in "solid"). 3. Press Up You will see "saddlebrownolid", "addlebrown" selected. Instead, the suffix ("olid") should get removed. 341409 1 80440 apavlov 2011-01-28 05:14:20 -0800 Created attachment 80440 [PATCH] Suggested fix 341412 2 80440 yurys 2011-01-28 06:07:11 -0800 Comment on attachment 80440 [PATCH] Suggested fix View in context: https://bugs.webkit.org/attachment.cgi?id=80440&action=review > Source/WebCore/inspector/front-end/StylesSidebarPane.js:1944 > + if (!selection.isCollapsed || !selection.rangeCount) Let's ignore the selection and always change suffix of the current word. 341417 3 80442 apavlov 2011-01-28 06:33:07 -0800 Created attachment 80442 [PATCH] Comment addressed 341419 4 80442 yurys 2011-01-28 06:35:41 -0800 Comment on attachment 80442 [PATCH] Comment addressed View in context: https://bugs.webkit.org/attachment.cgi?id=80442&action=review > Source/WebCore/inspector/front-end/StylesSidebarPane.js:1941 > + _selectSuffix: function() I'd give this method a more specific name. 341427 5 apavlov 2011-01-28 07:08:03 -0800 Landed with the method renamed. Committing to http://svn.webkit.org/repository/webkit/trunk ... M Source/WebCore/ChangeLog M Source/WebCore/inspector/front-end/StylesSidebarPane.js Committed r76941 80440 2011-01-28 05:14:20 -0800 2011-01-28 06:33:07 -0800 [PATCH] Suggested fix suggestfix.patch text/plain 2469 apavlov Y29tbWl0IDliNDFjMTVhYjU3ZGJkNGUxNDE4MGNiMTBhZmYwZGE4MTg1NzJiMTAKQXV0aG9yOiBB bGV4YW5kZXIgUGF2bG92IDxhcGF2bG92QGNocm9taXVtLm9yZz4KRGF0ZTogICBGcmkgSmFuIDI4 IDE2OjA1OjU5IDIwMTEgKzAzMDAKCiAgICBGaXhTdWdnZXN0U2Nyb2xsCgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4 IDQwODQxNTEuLmE3Nzg3MzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwor KysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMS0wMS0y OCAgQWxleGFuZGVyIFBhdmxvdiAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFtTVFlM RVNdIFVwL0Rvd24tc3VnZ2VzdGlvbiBicmVha3MgYW4gZXhpc3Rpbmcga2V5d29yZAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTMyOTUKKworICAgICAg ICBTZWxlY3QgdGhlIGN1cnJlbnQgd29yZCBzdWZmaXggYmVmb3JlIHN3aXRjaGluZyB0byB0aGUg bmV4dCBzdWdnZXN0aW9uLgorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9TdHlsZXNT aWRlYmFyUGFuZS5qczoKKyAgICAgICAgKCk6CisKIDIwMTEtMDEtMjggIFNoZXJpZmYgQm90ICA8 d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxp bmcgb3V0IHI3Njg5My4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9u dC1lbmQvU3R5bGVzU2lkZWJhclBhbmUuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL1N0eWxlc1NpZGViYXJQYW5lLmpzCmluZGV4IDM3OGNmZDcuLjA4ZWI5NDIgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU3R5bGVzU2lkZWJhclBh bmUuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TdHlsZXNTaWRl YmFyUGFuZS5qcwpAQCAtMTkyOSwxMCArMTkyOSwzMSBAQCBXZWJJbnNwZWN0b3IuU3R5bGVzU2lk ZWJhclBhbmUuQ1NTUHJvcGVydHlQcm9tcHQucHJvdG90eXBlID0gewogICAgICAgICB2YXIgcmV2 ZXJzZSA9IGV2ZW50LmtleUlkZW50aWZpZXIgPT09ICJVcCI7CiAgICAgICAgIGlmICh0aGlzLmF1 dG9Db21wbGV0ZUVsZW1lbnQpCiAgICAgICAgICAgICB0aGlzLmNvbXBsZXRlKGZhbHNlLCByZXZl cnNlKTsgLy8gQWNjZXB0IHRoZSBjdXJyZW50IHN1Z2dlc3Rpb24sIGlmIGFueS4KKyAgICAgICAg ZWxzZSB7CisgICAgICAgICAgICAvLyBTZWxlY3QgdGhlIHdvcmQgc3VmZml4IHRvIGFmZmVjdCBp dCB3aGVuIGNvbXB1dGluZyB0aGUgc3Vic2VxdWVudCBzdWdnZXN0aW9uLgorICAgICAgICAgICAg dGhpcy5fc2VsZWN0U3VmZml4KCk7CisgICAgICAgIH0KKwogICAgICAgICB0aGlzLmNvbXBsZXRl KGZhbHNlLCByZXZlcnNlKTsgLy8gQWN0dWFsbHkgaW5jcmVtZW50L2RlY3JlbWVudCB0aGUgc3Vn Z2VzdGlvbi4KICAgICAgICAgZXZlbnQuaGFuZGxlZCA9IHRydWU7CiAgICAgfSwKIAorICAgIF9z ZWxlY3RTdWZmaXg6IGZ1bmN0aW9uKCkKKyAgICB7CisgICAgICAgIHZhciBzZWxlY3Rpb24gPSB3 aW5kb3cuZ2V0U2VsZWN0aW9uKCk7CisgICAgICAgIGlmICghc2VsZWN0aW9uLmlzQ29sbGFwc2Vk IHx8ICFzZWxlY3Rpb24ucmFuZ2VDb3VudCkKKyAgICAgICAgICAgIHJldHVybjsKKworICAgICAg ICB2YXIgc2VsZWN0aW9uUmFuZ2UgPSBzZWxlY3Rpb24uZ2V0UmFuZ2VBdCgwKTsKKyAgICAgICAg aWYgKCFzZWxlY3Rpb25SYW5nZS5jb21tb25BbmNlc3RvckNvbnRhaW5lci5pc0Rlc2NlbmRhbnQo dGhpcy5lbGVtZW50KSkKKyAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgdmFyIHdvcmRTdWZm aXhSYW5nZSA9IHNlbGVjdGlvblJhbmdlLnN0YXJ0Q29udGFpbmVyLnJhbmdlT2ZXb3JkKHNlbGVj dGlvblJhbmdlLnN0YXJ0T2Zmc2V0LCBXZWJJbnNwZWN0b3IuU3R5bGVzU2lkZWJhclBhbmUuU3R5 bGVWYWx1ZURlbGltaXRlcnMsIHRoaXMuZWxlbWVudCwgImZvcndhcmQiKTsKKyAgICAgICAgaWYg KCF3b3JkU3VmZml4UmFuZ2UudG9TdHJpbmcoKSkKKyAgICAgICAgICAgIHJldHVybjsKKyAgICAg ICAgc2VsZWN0aW9uLnJlbW92ZUFsbFJhbmdlcygpOworICAgICAgICBzZWxlY3Rpb24uYWRkUmFu Z2Uod29yZFN1ZmZpeFJhbmdlKTsKKyAgICB9LAorCiAgICAgX2J1aWxkUHJvcGVydHlDb21wbGV0 aW9uczogZnVuY3Rpb24od29yZFJhbmdlLCBiZXN0TWF0Y2hPbmx5LCBjb21wbGV0aW9uc1JlYWR5 Q2FsbGJhY2spCiAgICAgewogICAgICAgICB2YXIgcHJlZml4ID0gd29yZFJhbmdlLnRvU3RyaW5n KCkudG9Mb3dlckNhc2UoKTsK 80442 2011-01-28 06:33:07 -0800 2011-01-28 06:35:41 -0800 [PATCH] Comment addressed suggestfix.patch text/plain 2443 apavlov Y29tbWl0IGM3MTVkOGM5ZDNhOGUyYjRjMzdmYmY2NDJlZmQyZjliOWVjNGM4NGQKQXV0aG9yOiBB bGV4YW5kZXIgUGF2bG92IDxhcGF2bG92QGNocm9taXVtLm9yZz4KRGF0ZTogICBGcmkgSmFuIDI4 IDE2OjA1OjU5IDIwMTEgKzAzMDAKCiAgICBGaXhTdWdnZXN0U2Nyb2xsCgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4 IDQwODQxNTEuLmE3Nzg3MzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwor KysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMS0wMS0y OCAgQWxleGFuZGVyIFBhdmxvdiAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFtTVFlM RVNdIFVwL0Rvd24tc3VnZ2VzdGlvbiBicmVha3MgYW4gZXhpc3Rpbmcga2V5d29yZAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTMyOTUKKworICAgICAg ICBTZWxlY3QgdGhlIGN1cnJlbnQgd29yZCBzdWZmaXggYmVmb3JlIHN3aXRjaGluZyB0byB0aGUg bmV4dCBzdWdnZXN0aW9uLgorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9TdHlsZXNT aWRlYmFyUGFuZS5qczoKKyAgICAgICAgKCk6CisKIDIwMTEtMDEtMjggIFNoZXJpZmYgQm90ICA8 d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxp bmcgb3V0IHI3Njg5My4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9u dC1lbmQvU3R5bGVzU2lkZWJhclBhbmUuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL1N0eWxlc1NpZGViYXJQYW5lLmpzCmluZGV4IDM3OGNmZDcuLjlkNTI3MmEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU3R5bGVzU2lkZWJhclBh bmUuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TdHlsZXNTaWRl YmFyUGFuZS5qcwpAQCAtMTkyOSwxMCArMTkyOSwzMSBAQCBXZWJJbnNwZWN0b3IuU3R5bGVzU2lk ZWJhclBhbmUuQ1NTUHJvcGVydHlQcm9tcHQucHJvdG90eXBlID0gewogICAgICAgICB2YXIgcmV2 ZXJzZSA9IGV2ZW50LmtleUlkZW50aWZpZXIgPT09ICJVcCI7CiAgICAgICAgIGlmICh0aGlzLmF1 dG9Db21wbGV0ZUVsZW1lbnQpCiAgICAgICAgICAgICB0aGlzLmNvbXBsZXRlKGZhbHNlLCByZXZl cnNlKTsgLy8gQWNjZXB0IHRoZSBjdXJyZW50IHN1Z2dlc3Rpb24sIGlmIGFueS4KKyAgICAgICAg ZWxzZSB7CisgICAgICAgICAgICAvLyBTZWxlY3QgdGhlIHdvcmQgc3VmZml4IHRvIGFmZmVjdCBp dCB3aGVuIGNvbXB1dGluZyB0aGUgc3Vic2VxdWVudCBzdWdnZXN0aW9uLgorICAgICAgICAgICAg dGhpcy5fc2VsZWN0U3VmZml4KCk7CisgICAgICAgIH0KKwogICAgICAgICB0aGlzLmNvbXBsZXRl KGZhbHNlLCByZXZlcnNlKTsgLy8gQWN0dWFsbHkgaW5jcmVtZW50L2RlY3JlbWVudCB0aGUgc3Vn Z2VzdGlvbi4KICAgICAgICAgZXZlbnQuaGFuZGxlZCA9IHRydWU7CiAgICAgfSwKIAorICAgIF9z ZWxlY3RTdWZmaXg6IGZ1bmN0aW9uKCkKKyAgICB7CisgICAgICAgIHZhciBzZWxlY3Rpb24gPSB3 aW5kb3cuZ2V0U2VsZWN0aW9uKCk7CisgICAgICAgIGlmICghc2VsZWN0aW9uLnJhbmdlQ291bnQp CisgICAgICAgICAgICByZXR1cm47CisKKyAgICAgICAgdmFyIHNlbGVjdGlvblJhbmdlID0gc2Vs ZWN0aW9uLmdldFJhbmdlQXQoMCk7CisgICAgICAgIGlmICghc2VsZWN0aW9uUmFuZ2UuY29tbW9u QW5jZXN0b3JDb250YWluZXIuaXNEZXNjZW5kYW50KHRoaXMuZWxlbWVudCkpCisgICAgICAgICAg ICByZXR1cm47CisgICAgICAgIHZhciB3b3JkU3VmZml4UmFuZ2UgPSBzZWxlY3Rpb25SYW5nZS5z dGFydENvbnRhaW5lci5yYW5nZU9mV29yZChzZWxlY3Rpb25SYW5nZS5zdGFydE9mZnNldCwgV2Vi SW5zcGVjdG9yLlN0eWxlc1NpZGViYXJQYW5lLlN0eWxlVmFsdWVEZWxpbWl0ZXJzLCB0aGlzLmVs ZW1lbnQsICJmb3J3YXJkIik7CisgICAgICAgIGlmICghd29yZFN1ZmZpeFJhbmdlLnRvU3RyaW5n KCkpCisgICAgICAgICAgICByZXR1cm47CisgICAgICAgIHNlbGVjdGlvbi5yZW1vdmVBbGxSYW5n ZXMoKTsKKyAgICAgICAgc2VsZWN0aW9uLmFkZFJhbmdlKHdvcmRTdWZmaXhSYW5nZSk7CisgICAg fSwKKwogICAgIF9idWlsZFByb3BlcnR5Q29tcGxldGlvbnM6IGZ1bmN0aW9uKHdvcmRSYW5nZSwg YmVzdE1hdGNoT25seSwgY29tcGxldGlvbnNSZWFkeUNhbGxiYWNrKQogICAgIHsKICAgICAgICAg dmFyIHByZWZpeCA9IHdvcmRSYW5nZS50b1N0cmluZygpLnRvTG93ZXJDYXNlKCk7Cg==