53292 2011-01-28 02:39:48 -0800 [GTK] Fix compilation warning 2011-01-28 06:36:06 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 alex webkit-unassigned gustavo mrobinson webkit.review.bot xan.lopez oldest_to_newest 341376 0 alex 2011-01-28 02:39:48 -0800 After r75955 we need to cast the number of pages: ../../../Source/WebKit/gtk/webkit/webkitwebframe.cpp: En la función ‘void draw_page_callback(GtkPrintOperation*, GtkPrintContext*, gint, void*)’: ../../../Source/WebKit/gtk/webkit/webkitwebframe.cpp:771:44: aviso: comparación entre expresiones enteras signed y unsigned 341381 1 80434 alex 2011-01-28 02:55:06 -0800 Created attachment 80434 Proposed patch 341393 2 webkit.review.bot 2011-01-28 03:58:56 -0800 Attachment 80434 did not build on gtk: Build output: http://queues.webkit.org/results/7646102 341394 3 80434 xan.lopez 2011-01-28 04:08:50 -0800 Comment on attachment 80434 Proposed patch You are missing the opening '(' it seems. 341395 4 80437 alex 2011-01-28 04:14:55 -0800 Created attachment 80437 Proposed patch Uploaded the wrong patch sorry. 341398 5 80437 xan.lopez 2011-01-28 04:41:46 -0800 Comment on attachment 80437 Proposed patch r=me 341420 6 alex 2011-01-28 06:36:06 -0800 Landed http://trac.webkit.org/changeset/76940 80434 2011-01-28 02:55:06 -0800 2011-01-28 04:14:55 -0800 Proposed patch fix_warning.patch text/plain 1271 alex ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv Z3RrL0NoYW5nZUxvZwppbmRleCBhZmRjMzc1Li5iZWZiMTNkIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2d0ay9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTEtMDEtMjggIEFsZWphbmRybyBHLiBDYXN0cm8gIDxhbGV4QGln YWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgW0dUS10gRml4IGNvbXBpbGF0aW9uIHdhcm5pbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUzMjkyCisKKyAgICAgICAgKiB3ZWJraXQvd2Via2l0 d2ViZnJhbWUuY3BwOgorICAgICAgICAoZHJhd19wYWdlX2NhbGxiYWNrKTogQ2FzdCB0aGUgcGFn ZUNvdW50IGZyb20gc2l6ZV90IHRvIGludCwgaXQKKyAgICAgICAgc2hvdWxkIGJlIHNhZmUgY29u c2lkZXJpbmcgcGFnZV9uciBpdCBpcyB0aGUgbnVtYmVyIG9mIHBhZ2VzLAorICAgICAgICAwLWJh c2VkLgorCiAyMDExLTAxLTI3ICBOYXRlIENoYXBpbiAgPGphcGhldEBjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJmcmFtZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJr aXQvd2Via2l0d2ViZnJhbWUuY3BwCmluZGV4IGQwZWE4NzUuLjgxODBhODQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJmcmFtZS5jcHAKKysrIGIvU291cmNl L1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYmZyYW1lLmNwcApAQCAtNzY4LDcgKzc2OCw3IEBA IHN0YXRpYyB2b2lkIGRyYXdfcGFnZV9jYWxsYmFjayhHdGtQcmludE9wZXJhdGlvbiogb3AsIEd0 a1ByaW50Q29udGV4dCogY29udGV4dCwKIHsKICAgICBQcmludENvbnRleHQqIHByaW50Q29udGV4 dCA9IHJlaW50ZXJwcmV0X2Nhc3Q8UHJpbnRDb250ZXh0Kj4odXNlcl9kYXRhKTsKIAotICAgIGlm IChwYWdlX25yID49IHByaW50Q29udGV4dC0+cGFnZUNvdW50KCkpCisgICAgaWYgKHBhZ2VfbnIg Pj0gc3RhdGljX2Nhc3Q8Z2ludD5wcmludENvbnRleHQtPnBhZ2VDb3VudCgpKQogICAgICAgICBy ZXR1cm47CiAKICAgICBjYWlyb190KiBjciA9IGd0a19wcmludF9jb250ZXh0X2dldF9jYWlyb19j b250ZXh0KGNvbnRleHQpOwo= 80437 2011-01-28 04:14:55 -0800 2011-01-28 04:41:46 -0800 Proposed patch fix_warning.patch text/plain 1273 alex ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv Z3RrL0NoYW5nZUxvZwppbmRleCBhZmRjMzc1Li5iZWZiMTNkIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2d0ay9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTEtMDEtMjggIEFsZWphbmRybyBHLiBDYXN0cm8gIDxhbGV4QGln YWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgW0dUS10gRml4IGNvbXBpbGF0aW9uIHdhcm5pbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUzMjkyCisKKyAgICAgICAgKiB3ZWJraXQvd2Via2l0 d2ViZnJhbWUuY3BwOgorICAgICAgICAoZHJhd19wYWdlX2NhbGxiYWNrKTogQ2FzdCB0aGUgcGFn ZUNvdW50IGZyb20gc2l6ZV90IHRvIGludCwgaXQKKyAgICAgICAgc2hvdWxkIGJlIHNhZmUgY29u c2lkZXJpbmcgcGFnZV9uciBpdCBpcyB0aGUgbnVtYmVyIG9mIHBhZ2VzLAorICAgICAgICAwLWJh c2VkLgorCiAyMDExLTAxLTI3ICBOYXRlIENoYXBpbiAgPGphcGhldEBjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJmcmFtZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJr aXQvd2Via2l0d2ViZnJhbWUuY3BwCmluZGV4IGQwZWE4NzUuLjVhYjI2NTQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJmcmFtZS5jcHAKKysrIGIvU291cmNl L1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYmZyYW1lLmNwcApAQCAtNzY4LDcgKzc2OCw3IEBA IHN0YXRpYyB2b2lkIGRyYXdfcGFnZV9jYWxsYmFjayhHdGtQcmludE9wZXJhdGlvbiogb3AsIEd0 a1ByaW50Q29udGV4dCogY29udGV4dCwKIHsKICAgICBQcmludENvbnRleHQqIHByaW50Q29udGV4 dCA9IHJlaW50ZXJwcmV0X2Nhc3Q8UHJpbnRDb250ZXh0Kj4odXNlcl9kYXRhKTsKIAotICAgIGlm IChwYWdlX25yID49IHByaW50Q29udGV4dC0+cGFnZUNvdW50KCkpCisgICAgaWYgKHBhZ2VfbnIg Pj0gc3RhdGljX2Nhc3Q8Z2ludD4ocHJpbnRDb250ZXh0LT5wYWdlQ291bnQoKSkpCiAgICAgICAg IHJldHVybjsKIAogICAgIGNhaXJvX3QqIGNyID0gZ3RrX3ByaW50X2NvbnRleHRfZ2V0X2NhaXJv X2NvbnRleHQoY29udGV4dCk7Cg==