53284 2011-01-27 23:11:52 -0800 Build fix for Mac Intel Debug after r76916 2011-01-28 00:05:19 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 laszlo.gombos webkit-unassigned buildbot webkit.review.bot oldest_to_newest 341325 0 laszlo.gombos 2011-01-27 23:11:52 -0800 Macro redefinition In file included from /Volumes/Data/WebKit-BuildSlave/snowleopard-intel-leaks/build/WebKitBuild/Debug/DerivedSources/WebKit2/WebPageMessages.h:25, from /Volumes/Data/WebKit-BuildSlave/snowleopard-intel-leaks/build/Source/WebKit2/UIProcess/cf/WebPageProxyCF.cpp:33: /Volumes/Data/WebKit-BuildSlave/snowleopard-intel-leaks/build/Source/WebKit2/config.h:38:1: error: "EXTERN_C_BEGIN" redefined /usr/include/c++/4.2.1/i686-apple-darwin10/x86_64/bits/c++config.h:320:99: error: this is the location of the previous definition 341328 1 80422 laszlo.gombos 2011-01-27 23:14:43 -0800 Created attachment 80422 buildfix 341332 2 80423 laszlo.gombos 2011-01-27 23:42:21 -0800 Created attachment 80423 2nd try 341333 3 webkit.review.bot 2011-01-27 23:43:41 -0800 Attachment 80423 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/config.h:38: #ifndef header guard has wrong style, please use: WTF_config_h [build/header_guard] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 341334 4 80423 mjs 2011-01-27 23:44:42 -0800 Comment on attachment 80423 2nd try r=me 341337 5 buildbot 2011-01-27 23:48:19 -0800 Attachment 80422 did not build on win: Build output: http://queues.webkit.org/results/7640137 341339 6 80423 laszlo.gombos 2011-01-28 00:04:54 -0800 Comment on attachment 80423 2nd try Landed as http://trac.webkit.org/changeset/76922. Clearing flags. 80422 2011-01-27 23:14:43 -0800 2011-01-27 23:42:21 -0800 buildfix 53284.patch text/plain 1118 laszlo.gombos SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDc2OTE5KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDEtMjcgIExhc3psbyBH b21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1aWxkIGZpeCBmb3IgTWFjIEludGVsIERlYnVn IGFmdGVyIHI3NjkxNgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NTMyODQKKworICAgICAgICBGaXggbWFjcm8gcmVkZWZpbml0aW9uIGJ5IGd1YXJkaW5n IHRoZSByZWRlZmluZWQgbWFjcm9zLgorICAgICAgICBDaGVjayBpZiB0aGUgbWFjcm8gaXMgYWxy ZWFkeSBkZWZpbmVkIGJlZm9yZSBkZWZpbmluaWcgaXQgYXMKKyAgICAgICAgYysrY29uZmlnLmgg aGFzIHRoZSBzYW1lIG1hY3JvcworCisgICAgICAgICogY29uZmlnLmg6CisKIDIwMTEtMDEtMjcg IExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IEFkYW0gQmFydGguCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9jb25maWcuaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9jb25maWcuaAkocmV2aXNpb24gNzY5MTYpCisrKyBT b3VyY2UvV2ViS2l0Mi9jb25maWcuaAkod29ya2luZyBjb3B5KQpAQCAtMzQsNyArMzQsNyBAQAog I2luY2x1ZGUgPHd0Zi9GYXN0TWFsbG9jLmg+CiAjZW5kaWYKIAotI2lmZGVmIF9fY3BsdXNwbHVz CisjaWYgZGVmaW5lZChfX2NwbHVzcGx1cykgJiYgIWRlZmluZWQoRVhURVJOX0NfQkVHSU4pICYm ICFkZWZpbmVkKEVYVEVSTl9DX0VORCkKICNkZWZpbmUgRVhURVJOX0NfQkVHSU4gZXh0ZXJuICJD IiB7CiAjZGVmaW5lIEVYVEVSTl9DX0VORCB9CiAjZWxzZQo= 80423 2011-01-27 23:42:21 -0800 2011-01-28 00:04:54 -0800 2nd try 53284.patch text/plain 1147 laszlo.gombos SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDc2OTIxKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDEtMjcgIExhc3psbyBH b21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1aWxkIGZpeCBmb3IgTWFjIEludGVsIERlYnVn IGFmdGVyIHI3NjkxNgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NTMyODQKKworICAgICAgICBGaXggbWFjcm8gcmVkZWZpbml0aW9uIGJ5IGd1YXJkaW5n IHRoZSByZWRlZmluZWQgbWFjcm9zLgorCisgICAgICAgICogY29uZmlnLmg6CisKIDIwMTEtMDEt MjcgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgogCiAgICAgICAg IFVucmV2aWV3ZWQgYnVpbGQgZml4IGZvciBNYWMgSW50ZWwgRGVidWcgYWZ0ZXIgcjc2OTE2LgpJ bmRleDogU291cmNlL1dlYktpdDIvY29uZmlnLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktp dDIvY29uZmlnLmgJKHJldmlzaW9uIDc2OTIxKQorKysgU291cmNlL1dlYktpdDIvY29uZmlnLmgJ KHdvcmtpbmcgY29weSkKQEAgLTM0LDkgKzM0LDEzIEBACiAjaW5jbHVkZSA8d3RmL0Zhc3RNYWxs b2MuaD4KICNlbmRpZgogCi0jaWYgZGVmaW5lZChfX2NwbHVzcGx1cykgJiYgIWRlZmluZWQoRVhU RVJOX0NfQkVHSU4pICYmICFkZWZpbmVkKEVYVEVSTl9DX0VORCkKKyNpZmRlZiBfX2NwbHVzcGx1 cworI2lmbmRlZiBFWFRFUk5fQ19CRUdJTgogI2RlZmluZSBFWFRFUk5fQ19CRUdJTiBleHRlcm4g IkMiIHsKKyNlbmRpZgorI2lmbmRlZiBFWFRFUk5fQ19FTkQKICNkZWZpbmUgRVhURVJOX0NfRU5E IH0KKyNlbmRpZgogI2Vsc2UKICNkZWZpbmUgRVhURVJOX0NfQkVHSU4KICNkZWZpbmUgRVhURVJO X0NfRU5ECg==