53274 2011-01-27 17:43:01 -0800 WebKit2: Page flashes just before accelerated compositing animation 2011-01-28 11:49:12 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED http://www.apple.com/startpage InRadar P2 Normal --- 1 cmarrin cmarrin andersca simon.fraser oldest_to_newest 341178 0 cmarrin 2011-01-27 17:43:01 -0800 When you reload this page in a WebKit2 window, the page will flash to white after to top button bar finishes it's roll down animation The problem is that after that animation, the page switches out of compositing mode momentarily and the change in renderers causes a flash When switching out of compositing mode, the new ChunkedUpdateDrawingAreaProxy is getting created with the current page size. When the setSize() call is subsequently made, the sizeDidChange() call is not made (which does the initial render of the page) because the old size and new size are the same. The solution is to skip the setting of the size in the ctor and let it go through a size change sequence. 341179 1 cmarrin 2011-01-27 17:43:22 -0800 rdar://problem/8711567 341191 2 80389 cmarrin 2011-01-27 17:52:03 -0800 Created attachment 80389 Patch 341497 3 80389 andersca 2011-01-28 10:11:35 -0800 Comment on attachment 80389 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=80389&action=review > Source/WebKit2/ChangeLog:12 > + is to skip the setting of the size in the ctor and let it go through a size Extra space. 341584 4 cmarrin 2011-01-28 11:49:12 -0800 Committed r76962: <http://trac.webkit.org/changeset/76962> 80389 2011-01-27 17:52:03 -0800 2011-01-28 10:11:35 -0800 Patch bug-53274-20110127175203.patch text/plain 1583 cmarrin SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDc2ODgwKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDEtMjcgIENocmlzIE1h cnJpbiAgPGNtYXJyaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFdlYktpdDI6IFBhZ2UgZmxhc2hlcyBqdXN0IGJlZm9yZSBhY2Nl bGVyYXRlZCBjb21wb3NpdGluZyBhbmltYXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTUzMjc0CisKKyAgICAgICAgV2hlbiBzd2l0Y2hpbmcgb3V0 IG9mIGNvbXBvc2l0aW5nIG1vZGUsIHRoZSBuZXcgQ2h1bmtlZFVwZGF0ZURyYXdpbmdBcmVhUHJv eHkgCisgICAgICAgIGlzIGdldHRpbmcgY3JlYXRlZCB3aXRoIHRoZSBjdXJyZW50IHBhZ2Ugc2l6 ZS4gV2hlbiB0aGUgc2V0U2l6ZSgpIGNhbGwgaXMgCisgICAgICAgIHN1YnNlcXVlbnRseSBtYWRl LCB0aGUgc2l6ZURpZENoYW5nZSgpIGNhbGwgaXMgbm90IG1hZGUgKHdoaWNoIGRvZXMgdGhlIGlu aXRpYWwgCisgICAgICAgIHJlbmRlciBvZiB0aGUgcGFnZSkgYmVjYXVzZSB0aGUgb2xkIHNpemUg YW5kIG5ldyBzaXplIGFyZSB0aGUgc2FtZS4gVGhlIHNvbHV0aW9uCisgICAgICAgIGlzIHRvIHNr aXAgdGhlIHNldHRpbmcgb2YgdGhlIHNpemUgaW4gdGhlIGN0b3IgYW5kIGxldCBpdCBnbyAgdGhy b3VnaCBhIHNpemUgCisgICAgICAgIGNoYW5nZSBzZXF1ZW5jZS4KKworICAgICAgICAqIFVJUHJv Y2Vzcy9EcmF3aW5nQXJlYVByb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6RHJhd2luZ0FyZWFQ cm94eTo6RHJhd2luZ0FyZWFQcm94eSk6CisKIDIwMTEtMDEtMjcgIE5hdGUgQ2hhcGluICA8amFw aGV0QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgpJbmRl eDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0RyYXdpbmdBcmVhUHJveHkuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9EcmF3aW5nQXJlYVByb3h5LmNwcAkocmV2 aXNpb24gNzY4NzUpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvRHJhd2luZ0FyZWFQcm94 eS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM0LDcgKzM0LDYgQEAgbmFtZXNwYWNlIFdlYktpdCB7 CiBEcmF3aW5nQXJlYVByb3h5OjpEcmF3aW5nQXJlYVByb3h5KERyYXdpbmdBcmVhSW5mbzo6VHlw ZSB0eXBlLCBXZWJQYWdlUHJveHkqIHdlYlBhZ2VQcm94eSkKICAgICA6IG1faW5mbyh0eXBlLCBu ZXh0SWRlbnRpZmllcigpKQogICAgICwgbV93ZWJQYWdlUHJveHkod2ViUGFnZVByb3h5KQotICAg ICwgbV9zaXplKHdlYlBhZ2VQcm94eS0+dmlld1NpemUoKSkKIHsKIH0KIAo=