53242 2011-01-27 08:45:57 -0800 Web Inspector: [STYLES] Cancelled suggestion of a property name results in a visual artifact 2011-01-27 22:01:36 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 apavlov apavlov abarth apavlov bweinstein commit-queue eric joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 340884 0 apavlov 2011-01-27 08:45:57 -0800 1. Double-click a property name (e.g. "color") and type in some other name prefix, e.g. "bo". "border" is suggested 2. Press Esc to cancel the property rename. As a result, "bocolor" remains in place of the property name ("bo" in black color). Another double-click + Esc fixes the display (the actual property name is not affected by the issue). 340886 1 80335 apavlov 2011-01-27 08:54:36 -0800 Created attachment 80335 [PATCH] Suggested fix 340896 2 80335 yurys 2011-01-27 09:17:25 -0800 Comment on attachment 80335 [PATCH] Suggested fix View in context: https://bugs.webkit.org/attachment.cgi?id=80335&action=review > Source/WebCore/inspector/front-end/StylesSidebarPane.js:1727 > + this._prompt.removeFromElement(); I don't quite understand why we detach the prompt from its parent here and don't do this on commit, can you explain this? 340901 3 80341 apavlov 2011-01-27 09:32:11 -0800 Created attachment 80341 [PATCH] Comment addressed You are correct, this removal should be invoked in all cases. Fixed. 341273 4 80341 commit-queue 2011-01-27 20:14:50 -0800 Comment on attachment 80341 [PATCH] Comment addressed Clearing flags on attachment: 80341 Committed r76913: <http://trac.webkit.org/changeset/76913> 341274 5 commit-queue 2011-01-27 20:14:54 -0800 All reviewed patches have been landed. Closing bug. 341315 6 webkit.review.bot 2011-01-27 22:01:36 -0800 http://trac.webkit.org/changeset/76913 might have broken Leopard Intel Release (Tests) 80335 2011-01-27 08:54:36 -0800 2011-01-27 09:32:11 -0800 [PATCH] Suggested fix nameartifact.patch text/plain 1802 apavlov Y29tbWl0IDQwZGVlN2FjZmQ5MzYxNGY2ZTA5MzI5YTJlYzJjYWM5NTM3YTM2NjkKQXV0aG9yOiBB bGV4YW5kZXIgUGF2bG92IDxhcGF2bG92QGNocm9taXVtLm9yZz4KRGF0ZTogICBUaHUgSmFuIDI3 IDE5OjUxOjEzIDIwMTEgKzAzMDAKCiAgICBGaXhBcnRpZmFjdAoKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBlMTdk MDAyLi5kM2RmNGNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIv U291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDEtMjcgIEFs ZXhhbmRlciBQYXZsb3YgIDxhcGF2bG92QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBbU1RZTEVTXSBD YW5jZWxsZWQgc3VnZ2VzdGlvbiBvZiBhIHByb3BlcnR5IG5hbWUgcmVzdWx0cyBpbiBhIHZpc3Vh bCBhcnRpZmFjdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NTMyNDIKKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvU3R5bGVzU2lkZWJhclBh bmUuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU3R5bGVQcm9wZXJ0eVRyZWVFbGVtZW50LnBy b3RvdHlwZSk6CisKIDIwMTEtMDEtMjcgIFl1cnkgU2VtaWtoYXRza3kgIDx5dXJ5c0BjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgUGF2ZWwgRmVsZG1hbi4KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU3R5bGVzU2lkZWJhclBhbmUuanMg Yi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1N0eWxlc1NpZGViYXJQYW5lLmpz CmluZGV4IDk4ODBhZGMuLjc3ODlmNjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3Bl Y3Rvci9mcm9udC1lbmQvU3R5bGVzU2lkZWJhclBhbmUuanMKKysrIGIvU291cmNlL1dlYkNvcmUv aW5zcGVjdG9yL2Zyb250LWVuZC9TdHlsZXNTaWRlYmFyUGFuZS5qcwpAQCAtMTcwOSwxMCArMTcw OSw2IEBAIFdlYkluc3BlY3Rvci5TdHlsZVByb3BlcnR5VHJlZUVsZW1lbnQucHJvdG90eXBlID0g ewogCiAgICAgZWRpdGluZ0VuZGVkOiBmdW5jdGlvbihjb250ZXh0KQogICAgIHsKLSAgICAgICAg aWYgKHRoaXMuX3Byb21wdCkgewotICAgICAgICAgICAgdGhpcy5fcHJvbXB0LnJlbW92ZUZyb21F bGVtZW50KCk7Ci0gICAgICAgICAgICBkZWxldGUgdGhpcy5fcHJvbXB0OwotICAgICAgICB9CiAg ICAgICAgIHRoaXMuaGFzQ2hpbGRyZW4gPSBjb250ZXh0Lmhhc0NoaWxkcmVuOwogICAgICAgICBp ZiAoY29udGV4dC5leHBhbmRlZCkKICAgICAgICAgICAgIHRoaXMuZXhwYW5kKCk7CkBAIC0xNzI3 LDYgKzE3MjMsMTEgQEAgV2ViSW5zcGVjdG9yLlN0eWxlUHJvcGVydHlUcmVlRWxlbWVudC5wcm90 b3R5cGUgPSB7CiAKICAgICBlZGl0aW5nQ2FuY2VsbGVkOiBmdW5jdGlvbihlbGVtZW50LCBjb250 ZXh0KQogICAgIHsKKyAgICAgICAgaWYgKHRoaXMuX3Byb21wdCkgeworICAgICAgICAgICAgdGhp cy5fcHJvbXB0LnJlbW92ZUZyb21FbGVtZW50KCk7CisgICAgICAgICAgICBkZWxldGUgdGhpcy5f cHJvbXB0OworICAgICAgICB9CisKICAgICAgICAgaWYgKCJvcmlnaW5hbFByb3BlcnR5VGV4dCIg aW4gdGhpcykKICAgICAgICAgICAgIHRoaXMuYXBwbHlTdHlsZVRleHQodGhpcy5vcmlnaW5hbFBy b3BlcnR5VGV4dCwgdHJ1ZSk7CiAgICAgICAgIGVsc2Ugewo= 80341 2011-01-27 09:32:11 -0800 2011-01-27 20:14:50 -0800 [PATCH] Comment addressed nameartifact.patch text/plain 2546 apavlov Y29tbWl0IDUyNmZiOWZhMTM0ODQ3YmNhNzNhN2Y4ODAyNGFhOTQzYzEzZmViYzcKQXV0aG9yOiBB bGV4YW5kZXIgUGF2bG92IDxhcGF2bG92QGNocm9taXVtLm9yZz4KRGF0ZTogICBUaHUgSmFuIDI3 IDE5OjUxOjEzIDIwMTEgKzAzMDAKCiAgICBGaXhBcnRpZmFjdAoKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBlMTdk MDAyLi5kM2RmNGNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIv U291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDEtMjcgIEFs ZXhhbmRlciBQYXZsb3YgIDxhcGF2bG92QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBbU1RZTEVTXSBD YW5jZWxsZWQgc3VnZ2VzdGlvbiBvZiBhIHByb3BlcnR5IG5hbWUgcmVzdWx0cyBpbiBhIHZpc3Vh bCBhcnRpZmFjdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NTMyNDIKKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvU3R5bGVzU2lkZWJhclBh bmUuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU3R5bGVQcm9wZXJ0eVRyZWVFbGVtZW50LnBy b3RvdHlwZSk6CisKIDIwMTEtMDEtMjcgIFl1cnkgU2VtaWtoYXRza3kgIDx5dXJ5c0BjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgUGF2ZWwgRmVsZG1hbi4KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU3R5bGVzU2lkZWJhclBhbmUuanMg Yi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1N0eWxlc1NpZGViYXJQYW5lLmpz CmluZGV4IDk4ODBhZGMuLjM3OGNmZDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3Bl Y3Rvci9mcm9udC1lbmQvU3R5bGVzU2lkZWJhclBhbmUuanMKKysrIGIvU291cmNlL1dlYkNvcmUv aW5zcGVjdG9yL2Zyb250LWVuZC9TdHlsZXNTaWRlYmFyUGFuZS5qcwpAQCAtMTcwOSwxMCArMTcw OSw2IEBAIFdlYkluc3BlY3Rvci5TdHlsZVByb3BlcnR5VHJlZUVsZW1lbnQucHJvdG90eXBlID0g ewogCiAgICAgZWRpdGluZ0VuZGVkOiBmdW5jdGlvbihjb250ZXh0KQogICAgIHsKLSAgICAgICAg aWYgKHRoaXMuX3Byb21wdCkgewotICAgICAgICAgICAgdGhpcy5fcHJvbXB0LnJlbW92ZUZyb21F bGVtZW50KCk7Ci0gICAgICAgICAgICBkZWxldGUgdGhpcy5fcHJvbXB0OwotICAgICAgICB9CiAg ICAgICAgIHRoaXMuaGFzQ2hpbGRyZW4gPSBjb250ZXh0Lmhhc0NoaWxkcmVuOwogICAgICAgICBp ZiAoY29udGV4dC5leHBhbmRlZCkKICAgICAgICAgICAgIHRoaXMuZXhwYW5kKCk7CkBAIC0xNzI3 LDYgKzE3MjMsNyBAQCBXZWJJbnNwZWN0b3IuU3R5bGVQcm9wZXJ0eVRyZWVFbGVtZW50LnByb3Rv dHlwZSA9IHsKIAogICAgIGVkaXRpbmdDYW5jZWxsZWQ6IGZ1bmN0aW9uKGVsZW1lbnQsIGNvbnRl eHQpCiAgICAgeworICAgICAgICB0aGlzLl9yZW1vdmVQcm9tcHQoKTsKICAgICAgICAgaWYgKCJv cmlnaW5hbFByb3BlcnR5VGV4dCIgaW4gdGhpcykKICAgICAgICAgICAgIHRoaXMuYXBwbHlTdHls ZVRleHQodGhpcy5vcmlnaW5hbFByb3BlcnR5VGV4dCwgdHJ1ZSk7CiAgICAgICAgIGVsc2UgewpA QCAtMTc0Miw2ICsxNzM5LDcgQEAgV2ViSW5zcGVjdG9yLlN0eWxlUHJvcGVydHlUcmVlRWxlbWVu dC5wcm90b3R5cGUgPSB7CiAKICAgICBlZGl0aW5nQ29tbWl0dGVkOiBmdW5jdGlvbihlbGVtZW50 LCB1c2VySW5wdXQsIHByZXZpb3VzQ29udGVudCwgY29udGV4dCwgbW92ZURpcmVjdGlvbikKICAg ICB7CisgICAgICAgIHRoaXMuX3JlbW92ZVByb21wdCgpOwogICAgICAgICB0aGlzLmVkaXRpbmdF bmRlZChjb250ZXh0KTsKICAgICAgICAgdmFyIGlzRWRpdGluZ05hbWUgPSBjb250ZXh0LmlzRWRp dGluZ05hbWU7CiAKQEAgLTE4MzksNiArMTgzNywxNSBAQCBXZWJJbnNwZWN0b3IuU3R5bGVQcm9w ZXJ0eVRyZWVFbGVtZW50LnByb3RvdHlwZSA9IHsKICAgICAgICAgfQogICAgIH0sCiAKKyAgICBf cmVtb3ZlUHJvbXB0OiBmdW5jdGlvbigpCisgICAgeworICAgICAgICAvLyBCVUcgNTMyNDIuIFRo aXMgY2Fubm90IGdvIGludG8gZWRpdGluZ0VuZGVkKCksIGFzIGl0IHNob3VsZCBhbHdheXMgaGFw cGVuIGZpcnN0IGZvciBhbnkgZWRpdGluZyBvdXRjb21lLgorICAgICAgICBpZiAodGhpcy5fcHJv bXB0KSB7CisgICAgICAgICAgICB0aGlzLl9wcm9tcHQucmVtb3ZlRnJvbUVsZW1lbnQoKTsKKyAg ICAgICAgICAgIGRlbGV0ZSB0aGlzLl9wcm9tcHQ7CisgICAgICAgIH0KKyAgICB9LAorCiAgICAg X2hhc0JlZW5BcHBsaWVkVG9QYWdlVmlhVXBEb3duOiBmdW5jdGlvbigpCiAgICAgewogICAgICAg ICAvLyBOZXcgcHJvcGVydGllcyBhcHBsaWVkIHZpYSB1cC9kb3duIGhhdmUgYW4gb3JpZ2luYWxQ cm9wZXJ0eVRleHQgYW5kIHdpbGwgYmUgZGVsZXRlZCBsYXRlcgo=