53233 2011-01-27 02:35:42 -0800 [Qt][WK2] Lots of layout test failures due to wrong font type 2011-01-27 06:56:30 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 kbalazs webkit-unassigned oldest_to_newest 340803 0 kbalazs 2011-01-27 02:35:42 -0800 A bunch of layout tests failing in WTR because the default font types are differ in WK2 from WK1 and DRT. The most frequent error is using Courier instead of Courier new as fixed font type. The default values are being set in WebPreferencesStore.h. We should specialize them for Qt. 340823 1 80317 kbalazs 2011-01-27 04:11:26 -0800 Created attachment 80317 Patch 340825 2 kbalazs 2011-01-27 04:13:13 -0800 The patch fixes 70 tests (tested on our wk2 bot: http://webkit.sed.hu/buildbot/waterfall?show=x86-32%20Linux%20Qt%20Release%20WebKit2) 340826 3 kbalazs 2011-01-27 04:15:08 -0800 (In reply to comment #2) > The patch fixes 70 tests (tested on our wk2 bot: > http://webkit.sed.hu/buildbot/waterfall?show=x86-32%20Linux%20Qt%20Release%20WebKit2) Ahm, this is not exactly true. The patch was tested on the same machine that runs this bot. 340830 4 80317 kling 2011-01-27 04:30:31 -0800 Comment on attachment 80317 Patch Delightful! r=me 340862 5 80317 kbalazs 2011-01-27 06:56:24 -0800 Comment on attachment 80317 Patch Clearing flags on attachment: 80317 Committed r76797: <http://trac.webkit.org/changeset/76797> 340863 6 kbalazs 2011-01-27 06:56:30 -0800 All reviewed patches have been landed. Closing bug. 80317 2011-01-27 04:11:26 -0800 2011-01-27 06:56:24 -0800 Patch bug-53233-20110127121124.patch text/plain 1975 kbalazs ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBjNzMyM2JiMWM3NmM3ZmJkNzRhOWYxMjc5OTM1MjA2YWYxYTNhOTU4Li43 YWQ1ZThmOTlmYzE5NThmNzU5ZGUwMGQ0ZGEyNzBlNDc1ZmMwMDkyIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTMgQEAKKzIwMTEtMDEtMjcgIEJhbGF6cyBLZWxlbWVuICA8a2JhbGF6c0B3ZWJraXQu b3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtR dF1bV0syXSBMb3RzIG9mIGxheW91dCB0ZXN0IGZhaWx1cmVzIGR1ZSB0byB3cm9uZyBmb250IHR5 cGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUzMjMz CisKKyAgICAgICAgKiBTaGFyZWQvV2ViUHJlZmVyZW5jZXNTdG9yZS5oOgorICAgICAgICBTcGVj aWFsaXplIGRlZmF1bHQgZm9udCBmYW1pbGllcyBmb3IgUXQuCisKIDIwMTEtMDEtMjUgIENocmlz IEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBE YXJpbiBBZGxlci4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9XZWJQcmVmZXJl bmNlc1N0b3JlLmggYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvV2ViUHJlZmVyZW5jZXNTdG9yZS5o CmluZGV4IDE4MjZkODg3OTkxNDI1ODczMGI5OWM5YzczNTk0ZjFlNmVmNDRkMmMuLmExZTlmMTU3 YzI5OTNiMGZjMjBkZjg1MDcxM2E0NjVkOWQ2ODBhYWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQyL1NoYXJlZC9XZWJQcmVmZXJlbmNlc1N0b3JlLmgKKysrIGIvU291cmNlL1dlYktpdDIvU2hh cmVkL1dlYlByZWZlcmVuY2VzU3RvcmUuaApAQCAtOTIsNyArOTIsNyBAQCBuYW1lc3BhY2UgV2Vi S2l0IHsKICAgICBtYWNybyhTZXJpZkZvbnRGYW1pbHksIHNlcmlmRm9udEZhbWlseSwgU3RyaW5n LCBTdHJpbmcsICJUaW1lcyBOZXcgUm9tYW4iKSBcCiAgICAgXAogCi0jZWxzZQorI2VsaWYgUExB VEZPUk0oTUFDKQogCiAjZGVmaW5lIEZPUl9FQUNIX1dFQktJVF9GT05UX0ZBTUlMWV9QUkVGRVJF TkNFKG1hY3JvKSBcCiAgICAgbWFjcm8oU3RhbmRhcmRGb250RmFtaWx5LCBzdGFuZGFyZEZvbnRG YW1pbHksIFN0cmluZywgU3RyaW5nLCAiVGltZXMiKSBcCkBAIC0xMDMsNiArMTAzLDE3IEBAIG5h bWVzcGFjZSBXZWJLaXQgewogICAgIG1hY3JvKFNlcmlmRm9udEZhbWlseSwgc2VyaWZGb250RmFt aWx5LCBTdHJpbmcsIFN0cmluZywgIlRpbWVzIikgXAogICAgIFwKIAorI2VsaWYgUExBVEZPUk0o UVQpCisKKyNkZWZpbmUgRk9SX0VBQ0hfV0VCS0lUX0ZPTlRfRkFNSUxZX1BSRUZFUkVOQ0UobWFj cm8pIFwKKyAgICBtYWNybyhTdGFuZGFyZEZvbnRGYW1pbHksIHN0YW5kYXJkRm9udEZhbWlseSwg U3RyaW5nLCBTdHJpbmcsICJUaW1lcyIpIFwKKyAgICBtYWNybyhDdXJzaXZlRm9udEZhbWlseSwg Y3Vyc2l2ZUZvbnRGYW1pbHksIFN0cmluZywgU3RyaW5nLCAiQ29taWMgU2FucyBNUyIpIFwKKyAg ICBtYWNybyhGYW50YXN5Rm9udEZhbWlseSwgZmFudGFzeUZvbnRGYW1pbHksIFN0cmluZywgU3Ry aW5nLCAiSW1wYWN0IikgXAorICAgIG1hY3JvKEZpeGVkRm9udEZhbWlseSwgZml4ZWRGb250RmFt aWx5LCBTdHJpbmcsIFN0cmluZywgIkNvdXJpZXIgTmV3IikgXAorICAgIG1hY3JvKFNhbnNTZXJp ZkZvbnRGYW1pbHksIHNhbnNTZXJpZkZvbnRGYW1pbHksIFN0cmluZywgU3RyaW5nLCAiSGVsdmV0 aWNhIikgXAorICAgIG1hY3JvKFNlcmlmRm9udEZhbWlseSwgc2VyaWZGb250RmFtaWx5LCBTdHJp bmcsIFN0cmluZywgIlRpbWVzIikgXAorICAgIFwKKwogI2VuZGlmCiAKICNkZWZpbmUgRk9SX0VB Q0hfV0VCS0lUX1NUUklOR19QUkVGRVJFTkNFKG1hY3JvKSBcCg==