53220 2011-01-26 19:49:06 -0800 back-during-onload-hung-page.php causes Chromium WebKit bot to fail 2011-01-27 11:54:31 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 0 creis webkit-unassigned eric mihaip ojan rniwa tony oldest_to_newest 340701 0 creis 2011-01-26 19:49:06 -0800 One of the Chromium WebKit bots is frequently failing because the PHP process for back-during-onload-hung-page.php doesn't exit for over 600 seconds. The tests that rely on this file are passing, but they just need it not to respond during the test. They would still pass if we reduced the timeout from 1000 seconds to something more reasonable, like 60. URL to the bot: http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Win%20(deps) 340702 1 80290 creis 2011-01-26 19:51:24 -0800 Created attachment 80290 Patch 340722 2 eric 2011-01-26 22:33:53 -0800 I take it we don't have code in run-webkit-tests/new-run-webkit-tests to kill run-away http servers (or in this case php processes?) Should we? 340904 3 creis 2011-01-27 09:57:59 -0800 (In reply to comment #2) > I take it we don't have code in run-webkit-tests/new-run-webkit-tests to kill run-away http servers (or in this case php processes?) Should we? I don't know much about those scripts, but they appear to try to kill the process but fail in this case. Here's one of the error messages from the bot, which looks like it tried and failed to kill the PHP process (according to Nicolas, who found out which process it was after the fact): command timed out: 600 seconds without output, killing pid 19192 SIGKILL failed to kill process using fake rc=-1 program finished with exit code -1 remoteFailed: [Failure instance: Traceback from remote host -- Traceback (most recent call last): Failure: buildbot.slave.commands.TimeoutError: SIGKILL failed to kill process ] (From: http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Win%20(deps)/builds/334/steps/webkit_tests/logs/stdio) Maybe we just need a more effective approach for killing such processes? We only see the problem on one of the bots, so it might be specific to something in the config. 340961 4 80290 rniwa 2011-01-27 11:12:02 -0800 Comment on attachment 80290 Patch Clearing flags on attachment: 80290 Committed r76816: <http://trac.webkit.org/changeset/76816> 340962 5 rniwa 2011-01-27 11:12:07 -0800 All reviewed patches have been landed. Closing bug. 340978 6 tony 2011-01-27 11:54:31 -0800 (In reply to comment #3) > (In reply to comment #2) > > I take it we don't have code in run-webkit-tests/new-run-webkit-tests to kill run-away http servers (or in this case php processes?) Should we? > > I don't know much about those scripts, but they appear to try to kill the process but fail in this case. Here's one of the error messages from the bot, which looks like it tried and failed to kill the PHP process (according to Nicolas, who found out which process it was after the fact): > > command timed out: 600 seconds without output, killing pid 19192 > SIGKILL failed to kill process > using fake rc=-1 > program finished with exit code -1 Maybe I misunderstand, but it looks like the buildbot process is trying to kill the NRWT process. Maybe it's failing to kill the NRWT because it's holding on to the lighttpd process which holds on to the php process? I bet it wouldn't be too hard to add a "kill all php.exe processes" when stopping the httpd, but it might cause collateral damage. I bet apache handles this better. Another reason to try and switch to apache (although I'm not volunteering). Nice detective work! 80290 2011-01-26 19:51:24 -0800 2011-01-27 11:12:02 -0800 Patch bug-53220-20110126195123.patch text/plain 1223 creis SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDc2NjQwKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDEtMjYgIENoYXJsaWUgUmVpcyAgPGNy ZWlzQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBiYWNrLWR1cmluZy1vbmxvYWQtaHVuZy1wYWdlLnBocCBjYXVzZXMgQ2hyb21p dW0gV2ViS2l0IGJvdCB0byBmYWlsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD01MzIyMAorCisgICAgICAgIFJlZHVjZXMgdGhlIHRpbWVvdXQgb24gYSBz Y3JpcHQgdGhhdCBzaG91bGRuJ3QgZmluaXNoIGR1cmluZyBhIHRlc3QuCisgICAgICAgIFRoaXMg YXZvaWRzIHByb2JsZW1zIGluIG9uZSBvZiB0aGUgQ2hyb21pdW0gV2ViS2l0IGJ1aWxkZXJzLgor CisgICAgICAgICogaHR0cC90ZXN0cy9oaXN0b3J5L3Jlc291cmNlcy9iYWNrLWR1cmluZy1vbmxv YWQtaHVuZy1wYWdlLnBocDogUmVkdWNlIHRpbWVvdXQuCisKIDIwMTEtMDEtMjUgIEplciBOb2Js ZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCBidWlsZCBmaXg6 IGFkZCBmYWlsaW5nIHRlc3QgdG8gZ3RrL1NraXBwZWQuCkluZGV4OiBMYXlvdXRUZXN0cy9odHRw L3Rlc3RzL2hpc3RvcnkvcmVzb3VyY2VzL2JhY2stZHVyaW5nLW9ubG9hZC1odW5nLXBhZ2UucGhw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2h0dHAvdGVzdHMvaGlzdG9yeS9yZXNvdXJjZXMv YmFjay1kdXJpbmctb25sb2FkLWh1bmctcGFnZS5waHAJKHJldmlzaW9uIDc2NjQwKQorKysgTGF5 b3V0VGVzdHMvaHR0cC90ZXN0cy9oaXN0b3J5L3Jlc291cmNlcy9iYWNrLWR1cmluZy1vbmxvYWQt aHVuZy1wYWdlLnBocAkod29ya2luZyBjb3B5KQpAQCAtMSwyICsxLDIgQEAKLTw/IHNsZWVwKDEw MDApOyA/PgorPD8gc2xlZXAoNjApOyA/PgogRkFJTDogU2hvdWxkIG5ldmVyIHNlZSB0aGlzClwg Tm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQo=